191716 2018-11-15 14:28:15 -0800 ASSERTION FAILED: m_outOfLineJumpTargets.contains(bytecodeOffset) 2018-11-26 10:15:28 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tzagallo tzagallo commit-queue ews-watchlist keith_miller mark.lam msaboff saam oldest_to_newest 1479123 0 tzagallo 2018-11-15 14:28:15 -0800 After https://bugs.webkit.org/show_bug.cgi?id=187373, when updating jump targets during generatorification, we only stored the new jump target when it changed. However, the out-of-line jump targets are cleared at the beginning of the pass, so we need to store it unconditionally. 1479128 1 tzagallo 2018-11-15 14:32:44 -0800 <rdar://problem/45723878> 1479130 2 354990 tzagallo 2018-11-15 14:33:42 -0800 Created attachment 354990 Patch 1481563 3 354990 commit-queue 2018-11-26 10:15:27 -0800 Comment on attachment 354990 Patch Clearing flags on attachment: 354990 Committed r238499: <https://trac.webkit.org/changeset/238499> 1481564 4 commit-queue 2018-11-26 10:15:28 -0800 All reviewed patches have been landed. Closing bug. 354990 2018-11-15 14:33:42 -0800 2018-11-26 10:15:27 -0800 Patch bug-191716-20181115233315.patch text/plain 5516 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4MjM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw YjU4OGIwMDU2ODg2OTcwZDU5NDk2MTZiOWRiMTg2Nzk5NzgyMjY3Li5jMWJmNTIxNThhZjUwNDA5 NTE3OGZmYzU0YTIwN2EwYmQ3YzZkM2FkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxOC0xMS0xNSAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBBU1NFUlRJT04gRkFJTEVEOiBtX291dE9mTGluZUp1bXBUYXJnZXRzLmNv bnRhaW5zKGJ5dGVjb2RlT2Zmc2V0KQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTkxNzE2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NTcyMzg3OD4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZnRlciBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg3MzczLCB3aGVuIHVwZGF0 aW5nCisgICAgICAgIGp1bXAgdGFyZ2V0cyBkdXJpbmcgZ2VuZXJhdG9yaWZpY2F0aW9uLCB3ZSBv bmx5IHN0b3JlZCB0aGUgbmV3IGp1bXAKKyAgICAgICAgdGFyZ2V0IHdoZW4gaXQgY2hhbmdlZC4g SG93ZXZlciwgdGhlIG91dC1vZi1saW5lIGp1bXAgdGFyZ2V0cyBhcmUKKyAgICAgICAgY2xlYXJl ZCBhdCB0aGUgYmVnaW5uaW5nIG9mIHRoZSBwYXNzLCBzbyB3ZSBuZWVkIHRvIHN0b3JlIGl0Cisg ICAgICAgIHVuY29uZGl0aW9uYWxseS4KKworICAgICAgICAqIGJ5dGVjb2RlL1ByZWNpc2VKdW1w VGFyZ2V0c0lubGluZXMuaDoKKyAgICAgICAgKEpTQzo6ZXh0cmFjdFN0b3JlZEp1bXBUYXJnZXRz Rm9ySW5zdHJ1Y3Rpb24pOgorICAgICAgICAoSlNDOjp1cGRhdGVTdG9yZWRKdW1wVGFyZ2V0c0Zv ckluc3RydWN0aW9uKToKKwogMjAxOC0xMS0xNSAgS2VpdGggUm9sbGluICA8a3JvbGxpbkBhcHBs ZS5jb20+CiAKICAgICAgICAgRGVsZXRlIG9sZCAueGNmaWxlbGlzdCBmaWxlcwpkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1ByZWNpc2VKdW1wVGFyZ2V0c0lubGlu ZXMuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9QcmVjaXNlSnVtcFRhcmdldHNJ bmxpbmVzLmgKaW5kZXggNjJhOWU3MTE3NWFiZGE0YmI4NjFjNTQ0OTEwNTc2OTM3NDRjZTlmZC4u MWYzMGQ0MzhiN2JiMjk0NTA1ZjRhZGUxZWI4OTNmZGE2MzE1NWY0ZiAxMDA2NDQKLS0tIGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1ByZWNpc2VKdW1wVGFyZ2V0c0lubGluZXMuaAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvUHJlY2lzZUp1bXBUYXJnZXRzSW5s aW5lcy5oCkBAIC0xMTIsNyArMTEyLDcgQEAgaW5saW5lIGludCBqdW1wVGFyZ2V0Rm9ySW5zdHJ1 Y3Rpb24oQmxvY2smJiBjb2RlQmxvY2ssIGNvbnN0IEluc3RydWN0aW9uU3RyZWFtOjoKIH0KIAog dGVtcGxhdGU8dHlwZW5hbWUgQmxvY2ssIHR5cGVuYW1lIEZ1bmN0aW9uPgotaW5saW5lIHZvaWQg ZXh0cmFjdFN0b3JlZEp1bXBUYXJnZXRzRm9ySW5zdHJ1Y3Rpb24oQmxvY2smJiBjb2RlQmxvY2ss IGNvbnN0IEluc3RydWN0aW9uU3RyZWFtOjpSZWYmIGluc3RydWN0aW9uLCBGdW5jdGlvbiBmdW5j dGlvbikKK2lubGluZSB2b2lkIGV4dHJhY3RTdG9yZWRKdW1wVGFyZ2V0c0Zvckluc3RydWN0aW9u KEJsb2NrJiYgY29kZUJsb2NrLCBjb25zdCBJbnN0cnVjdGlvblN0cmVhbTo6UmVmJiBpbnN0cnVj dGlvbiwgY29uc3QgRnVuY3Rpb24mIGZ1bmN0aW9uKQogewogI2RlZmluZSBDQVNFX09QKF9fb3Ap IFwKICAgICBjYXNlIF9fb3A6Om9wY29kZUlEOiBcCkBAIC0xMzMsMzkgKzEzMywzMyBAQCBTV0lU Q0hfSk1QKENBU0VfT1AsIFNXSVRDSF9DQVNFLCBTV0lUQ0hfREVGQVVMVF9PRkZTRVQpCiB9CiAK IHRlbXBsYXRlPHR5cGVuYW1lIEJsb2NrLCB0eXBlbmFtZSBGdW5jdGlvbiwgdHlwZW5hbWUgQ29k ZUJsb2NrT3JIYXNoTWFwPgotaW5saW5lIHZvaWQgdXBkYXRlU3RvcmVkSnVtcFRhcmdldHNGb3JJ bnN0cnVjdGlvbihCbG9jayYmIGNvZGVCbG9jaywgdW5zaWduZWQgZmluYWxPZmZzZXQsIEluc3Ry dWN0aW9uU3RyZWFtOjpNdXRhYmxlUmVmIGluc3RydWN0aW9uLCBGdW5jdGlvbiBmdW5jdGlvbiwg Q29kZUJsb2NrT3JIYXNoTWFwIGNvZGVCbG9ja09ySGFzaE1hcCkKK2lubGluZSB2b2lkIHVwZGF0 ZVN0b3JlZEp1bXBUYXJnZXRzRm9ySW5zdHJ1Y3Rpb24oQmxvY2smJiBjb2RlQmxvY2ssIHVuc2ln bmVkIGZpbmFsT2Zmc2V0LCBJbnN0cnVjdGlvblN0cmVhbTo6TXV0YWJsZVJlZiBpbnN0cnVjdGlv biwgY29uc3QgRnVuY3Rpb24mIGZ1bmN0aW9uLCBDb2RlQmxvY2tPckhhc2hNYXAmIGNvZGVCbG9j a09ySGFzaE1hcCkKIHsKICNkZWZpbmUgQ0FTRV9PUChfX29wKSBcCiAgICAgY2FzZSBfX29wOjpv cGNvZGVJRDogeyBcCiAgICAgICAgIGludDMyX3QgdGFyZ2V0ID0ganVtcFRhcmdldEZvckluc3Ry dWN0aW9uPF9fb3A+KGNvZGVCbG9ja09ySGFzaE1hcCwgaW5zdHJ1Y3Rpb24pOyBcCiAgICAgICAg IGludDMyX3QgbmV3VGFyZ2V0ID0gZnVuY3Rpb24odGFyZ2V0KTsgXAotICAgICAgICBpZiAobmV3 VGFyZ2V0ICE9IHRhcmdldCB8fCBmaW5hbE9mZnNldCkgeyBcCi0gICAgICAgICAgICBpbnN0cnVj dGlvbi0+Y2FzdDxfX29wPigpLT5zZXRUYXJnZXQoQm91bmRMYWJlbChuZXdUYXJnZXQpLCBbJl0o KSB7IFwKLSAgICAgICAgICAgICAgICBjb2RlQmxvY2stPmFkZE91dE9mTGluZUp1bXBUYXJnZXQo ZmluYWxPZmZzZXQgKyBpbnN0cnVjdGlvbi5vZmZzZXQoKSwgbmV3VGFyZ2V0KTsgXAotICAgICAg ICAgICAgICAgIHJldHVybiBCb3VuZExhYmVsKCk7IFwKLSAgICAgICAgICAgIH0pOyBcCi0gICAg ICAgIH0gXAorICAgICAgICBpbnN0cnVjdGlvbi0+Y2FzdDxfX29wPigpLT5zZXRUYXJnZXQoQm91 bmRMYWJlbChuZXdUYXJnZXQpLCBbJl0oKSB7IFwKKyAgICAgICAgICAgIGNvZGVCbG9jay0+YWRk T3V0T2ZMaW5lSnVtcFRhcmdldChmaW5hbE9mZnNldCArIGluc3RydWN0aW9uLm9mZnNldCgpLCBu ZXdUYXJnZXQpOyBcCisgICAgICAgICAgICByZXR1cm4gQm91bmRMYWJlbCgpOyBcCisgICAgICAg IH0pOyBcCiAgICAgICAgIGJyZWFrOyBcCiAgICAgfQogCiAjZGVmaW5lIFNXSVRDSF9DQVNFKF9f dGFyZ2V0KSBcCiAgICAgZG8geyBcCiAgICAgICAgIGludDMyX3QgdGFyZ2V0ID0gX190YXJnZXQ7 IFwKLSAgICAgICAgaW50MzJfdCBuZXdUYXJnZXQgPSBmdW5jdGlvbih0YXJnZXQpOyBcCi0gICAg ICAgIGlmIChuZXdUYXJnZXQgIT0gdGFyZ2V0KSBcCi0gICAgICAgICAgICBfX3RhcmdldCA9IG5l d1RhcmdldDsgXAorICAgICAgICBfX3RhcmdldCA9IGZ1bmN0aW9uKHRhcmdldCk7IFwKICAgICB9 IHdoaWxlIChmYWxzZSkKIAogI2RlZmluZSBTV0lUQ0hfREVGQVVMVF9PRkZTRVQoX19vcCkgXAog ICAgIGRvIHsgXAogICAgICAgICBpbnQzMl90IHRhcmdldCA9IGp1bXBUYXJnZXRGb3JJbnN0cnVj dGlvbihjb2RlQmxvY2tPckhhc2hNYXAsIGluc3RydWN0aW9uLCBieXRlY29kZS5kZWZhdWx0T2Zm c2V0KTsgXAogICAgICAgICBpbnQzMl90IG5ld1RhcmdldCA9IGZ1bmN0aW9uKHRhcmdldCk7IFwK LSAgICAgICAgaWYgKG5ld1RhcmdldCAhPSB0YXJnZXQgfHwgZmluYWxPZmZzZXQpIHsgXAotICAg ICAgICAgICAgaW5zdHJ1Y3Rpb24tPmNhc3Q8X19vcD4oKS0+c2V0RGVmYXVsdE9mZnNldChCb3Vu ZExhYmVsKG5ld1RhcmdldCksIFsmXSgpIHsgXAotICAgICAgICAgICAgICAgIGNvZGVCbG9jay0+ YWRkT3V0T2ZMaW5lSnVtcFRhcmdldChmaW5hbE9mZnNldCArIGluc3RydWN0aW9uLm9mZnNldCgp LCBuZXdUYXJnZXQpOyBcCi0gICAgICAgICAgICAgICAgcmV0dXJuIEJvdW5kTGFiZWwoKTsgXAot ICAgICAgICAgICAgfSk7IFwKLSAgICAgICAgfSBcCisgICAgICAgIGluc3RydWN0aW9uLT5jYXN0 PF9fb3A+KCktPnNldERlZmF1bHRPZmZzZXQoQm91bmRMYWJlbChuZXdUYXJnZXQpLCBbJl0oKSB7 IFwKKyAgICAgICAgICAgIGNvZGVCbG9jay0+YWRkT3V0T2ZMaW5lSnVtcFRhcmdldChmaW5hbE9m ZnNldCArIGluc3RydWN0aW9uLm9mZnNldCgpLCBuZXdUYXJnZXQpOyBcCisgICAgICAgICAgICBy ZXR1cm4gQm91bmRMYWJlbCgpOyBcCisgICAgICAgIH0pOyBcCiAgICAgfSB3aGlsZSAoZmFsc2Up CiAKIFNXSVRDSF9KTVAoQ0FTRV9PUCwgU1dJVENIX0NBU0UsIFNXSVRDSF9ERUZBVUxUX09GRlNF VCkKZGlmZiAtLWdpdCBhL0pTVGVzdHMvQ2hhbmdlTG9nIGIvSlNUZXN0cy9DaGFuZ2VMb2cKaW5k ZXggNzY4YzEwMGM0MzQwNjBjZTllMWI2OThkZTYzNmZhM2ZhMWU0ZDFlNy4uYjJiYTBmOTRmODQ5 ZDU3MmRhNTExYjkxNGM2YzBmYjQxZmU0NTUxZiAxMDA2NDQKLS0tIGEvSlNUZXN0cy9DaGFuZ2VM b2cKKysrIGIvSlNUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxOC0xMS0xNSAg VGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNvbT4KKworICAgICAgICBBU1NFUlRJT04g RkFJTEVEOiBtX291dE9mTGluZUp1bXBUYXJnZXRzLmNvbnRhaW5zKGJ5dGVjb2RlT2Zmc2V0KQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkxNzE2Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NTcyMzg3OD4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0cmVzcy9yZWdyZXNzLTE4NzM3My5qczogQWRk ZWQuCisgICAgICAgIChhc3luYy5mbik6CisKIDIwMTgtMTEtMTMgIFNhYW0gQmFyYXRpICA8c2Jh cmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgVHlwZVByb2ZpbGVMb2c6OnByb2Nlc3NMb2dFbnRy aWVzIHNob3VsZCBzdGFzaCBhd2F5IGFueSBwZW5kaW5nIGV4Y2VwdGlvbnMgYW5kIHJlLWFwcGx5 IHRoZW0gdG8gdGhlIFZNCmRpZmYgLS1naXQgYS9KU1Rlc3RzL3N0cmVzcy9yZWdyZXNzLTE4NzM3 My5qcyBiL0pTVGVzdHMvc3RyZXNzL3JlZ3Jlc3MtMTg3MzczLmpzCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmZlODE5 ZjliYjk5MTYzZTA2NzY5MGQ3ZmY3NWJmYmVhZmYxNDM3M2MKLS0tIC9kZXYvbnVsbAorKysgYi9K U1Rlc3RzL3N0cmVzcy9yZWdyZXNzLTE4NzM3My5qcwpAQCAtMCwwICsxLDEyIEBACithc3luYyBm dW5jdGlvbiogZm4oKSB7CisgIHJldHVybiBwCisgIHJldHVybiBxCisgIHN3aXRjaCAoMCkgewor ICAgIGNhc2UgMToKKyAgICAgIGkrKzsKKyAgICAgIGkrKzsKKyAgICAgIGZvbyh4LCBhcmd1bWVu dHNbel0pOworICAgICAgYnJlYWs7CisgIH0KK30KK2ZuKCkubmV4dCgpOwo=