191712 2018-11-15 14:04:34 -0800 [iOS] 2 subsequent taps are required to trigger certain tasks on the desktop version of YouTube.com 2018-11-16 07:07:22 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham simon.fraser zalan oldest_to_newest 1479100 0 zalan 2018-11-15 14:04:34 -0800 Settings, subtitles, full screen etc. Let's try to reduce them to a single tap. 1479110 1 zalan 2018-11-15 14:14:51 -0800 <rdar://problem/45612900> 1479111 2 354985 zalan 2018-11-15 14:16:50 -0800 Created attachment 354985 Patch 1479120 3 354985 simon.fraser 2018-11-15 14:24:27 -0800 Comment on attachment 354985 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354985&action=review > Source/WebCore/ChangeLog:3 > + [iOS] 2 subsequent taps are required to trigger certain tasks on the desktop version of YouTube.com Maybe talk about :hover > Source/WebCore/ChangeLog:10 > + The idea here is that if the new content (result of dispatching mouseMoved) does not respond to mouse click events, it is most likely only for tooltip-like reasons. > + Hover-like drop down menus tend to respond to mouse click events. I think this should mention "content observation" or WKContentObservation 1479399 4 zalan 2018-11-16 07:07:22 -0800 Committed r238280: <https://trac.webkit.org/changeset/238280> 354985 2018-11-15 14:16:50 -0800 2018-11-15 14:24:27 -0800 Patch bug-191712-20181115141650.patch text/plain 5076 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4MjQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzlkY2RjMmY3OTBhNTdj YjdjYWZlNTdlZDA3NTViNmU3YjUwOTZjMS4uZDViNDMwN2I4YzZlZDE3NGJiY2ZkYWY1ZDlhY2Rk ZGE3NGVhZjY4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTExLTE1ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gMiBzdWJzZXF1ZW50 IHRhcHMgYXJlIHJlcXVpcmVkIHRvIHRyaWdnZXIgY2VydGFpbiB0YXNrcyBvbiB0aGUgZGVza3Rv cCB2ZXJzaW9uIG9mIFlvdVR1YmUuY29tCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTE3MTIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ1NjEyOTAw PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBp ZGVhIGhlcmUgaXMgdGhhdCBpZiB0aGUgbmV3IGNvbnRlbnQgKHJlc3VsdCBvZiBkaXNwYXRjaGlu ZyBtb3VzZU1vdmVkKSBkb2VzIG5vdCByZXNwb25kIHRvIG1vdXNlIGNsaWNrIGV2ZW50cywgaXQg aXMgbW9zdCBsaWtlbHkgb25seSBmb3IgdG9vbHRpcC1saWtlIHJlYXNvbnMuCisgICAgICAgIEhv dmVyLWxpa2UgZHJvcCBkb3duIG1lbnVzIHRlbmQgdG8gcmVzcG9uZCB0byBtb3VzZSBjbGljayBl dmVudHMuCisKKyAgICAgICAgVGVzdDogZmFzdC9ldmVudHMvdG91Y2gvaW9zL2NsaWNrLWluc3Rl YWQtb2YtaG92ZXItc2ltcGxlLmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy91cGRhdGluZy9S ZW5kZXJUcmVlVXBkYXRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDaGVja0ZvclZpc2liaWxp dHlDaGFuZ2U6On5DaGVja0ZvclZpc2liaWxpdHlDaGFuZ2UpOgorCiAyMDE4LTExLTE1ICBKdXN0 aW4gRmFuICA8anVzdGluX2ZhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW1dlYkdQVV0gV2ViR1BV Q29tbWFuZEJ1ZmZlciBwcm90b3R5cGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy91cGRhdGluZy9SZW5kZXJUcmVlVXBkYXRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvdXBkYXRpbmcvUmVuZGVyVHJlZVVwZGF0ZXIuY3BwCmluZGV4IDZkZDBiODc3YjU5OWE1 MGE2NGU4MWIzNWU0YWY5Y2IwM2Y4ZGY1MjMuLmQzYTZmOGNiNjMwYzdjZGYyM2NjYzhlMGNmMDEy MDE5NWU0MGIxNTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy91cGRhdGlu Zy9SZW5kZXJUcmVlVXBkYXRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3Vw ZGF0aW5nL1JlbmRlclRyZWVVcGRhdGVyLmNwcApAQCAtNjc5LDEwICs2NzksMjAgQEAgQ2hlY2tG b3JWaXNpYmlsaXR5Q2hhbmdlOjp+Q2hlY2tGb3JWaXNpYmlsaXR5Q2hhbmdlKCkKIHsKICAgICBp ZiAoIVdLT2JzZXJ2aW5nQ29udGVudENoYW5nZXMoKSkKICAgICAgICAgcmV0dXJuOwotICAgIGlm IChtX2VsZW1lbnQuaXNJblVzZXJBZ2VudFNoYWRvd1RyZWUoKSkKLSAgICAgICAgcmV0dXJuOwor CiAgICAgYXV0byogc3R5bGUgPSBtX2VsZW1lbnQucmVuZGVyU3R5bGUoKTsKLSAgICBpZiAoIXN0 eWxlKQorCisgICAgYXV0byBxdWFsaWZpZXNGb3JWaXNpYmlsaXR5Q2hlY2sgPSBbJl0geworICAg ICAgICBpZiAoIXN0eWxlKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICBpZiAo bV9lbGVtZW50LmlzSW5Vc2VyQWdlbnRTaGFkb3dUcmVlKCkpCisgICAgICAgICAgICByZXR1cm4g ZmFsc2U7CisgICAgICAgIGlmICghY29uc3RfY2FzdDxFbGVtZW50Jj4obV9lbGVtZW50KS53aWxs UmVzcG9uZFRvTW91c2VDbGlja0V2ZW50cygpKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwor ICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICB9OworCisgICAgaWYgKCFxdWFsaWZpZXNGb3JWaXNp YmlsaXR5Q2hlY2soKSkKICAgICAgICAgcmV0dXJuOwogICAgIGlmICgobV9wcmV2aW91c0Rpc3Bs YXkgPT0gRGlzcGxheVR5cGU6Ok5vbmUgJiYgc3R5bGUtPmRpc3BsYXkoKSAhPSBEaXNwbGF5VHlw ZTo6Tm9uZSkgfHwgKG1fcHJldmlvdXNWaXNpYmlsaXR5ID09IFZpc2liaWxpdHk6OkhpZGRlbiAm JiBzdHlsZS0+dmlzaWJpbGl0eSgpICE9IFZpc2liaWxpdHk6OkhpZGRlbikKICAgICAgICAgfHwg KG1fcHJldmlvdXNJbXBsaWNpdFZpc2liaWxpdHkgPT0gVmlzaWJpbGl0eTo6SGlkZGVuICYmIGVs ZW1lbnRJbXBsaWNpdFZpc2liaWxpdHkobV9lbGVtZW50KSA9PSBWaXNpYmlsaXR5OjpWaXNpYmxl KSkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwppbmRleCBkZDA4OGIxOGI0MzE1MGUwZGY2NDdhMmQ2MGU2YTIxM2Y3YmI5OWNmLi4yNmQw YTk1ZDkzMTIxNTI2ZmMyYjJjYjk1NjgxZGE1MmZkYTdlZDY2IDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTgtMTEtMTUgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKworICAgICAg ICBbaU9TXSAyIHN1YnNlcXVlbnQgdGFwcyBhcmUgcmVxdWlyZWQgdG8gdHJpZ2dlciBjZXJ0YWlu IHRhc2tzIG9uIHRoZSBkZXNrdG9wIHZlcnNpb24gb2YgWW91VHViZS5jb20KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTcxMgorICAgICAgICA8cmRh cjovL3Byb2JsZW0vNDU2MTI5MDA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBmYXN0L2V2ZW50cy90b3VjaC9pb3MvY2xpY2staW5zdGVhZC1vZi1o b3Zlci1zaW1wbGUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2V2ZW50cy90 b3VjaC9pb3MvY2xpY2staW5zdGVhZC1vZi1ob3Zlci1zaW1wbGUuaHRtbDogQWRkZWQuCisKIDIw MTgtMTEtMTUgIEp1c3RpbiBGYW4gIDxqdXN0aW5fZmFuQGFwcGxlLmNvbT4KIAogICAgICAgICBb V2ViR1BVXSBXZWJHUFVDb21tYW5kQnVmZmVyIHByb3RvdHlwZQpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvZmFzdC9ldmVudHMvdG91Y2gvaW9zL2NsaWNrLWluc3RlYWQtb2YtaG92ZXItc2ltcGxl LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3RvdWNoL2lvcy9jbGljay1p bnN0ZWFkLW9mLWhvdmVyLXNpbXBsZS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uOTZhMzJkYmJi OTk1ODdmOWViM2MwODNhZGZiOTI5MzQ5MmZlOGE0YgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91 dFRlc3RzL2Zhc3QvZXZlbnRzL3RvdWNoL2lvcy9jbGljay1pbnN0ZWFkLW9mLWhvdmVyLXNpbXBs ZS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwzIEBACitQQVNTIGlmIGNsaWNrZWQuCitjbGlja2Vk Cit0b29sdGlwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy90b3VjaC9pb3Mv Y2xpY2staW5zdGVhZC1vZi1ob3Zlci1zaW1wbGUuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZXZl bnRzL3RvdWNoL2lvcy9jbGljay1pbnN0ZWFkLW9mLWhvdmVyLXNpbXBsZS5odG1sCm5ldyBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAuLjJiNDIzOGU0MGZmMjkzZjFmNTlmNTBlODMyNjg3NmRkNmFhOWY4YmEKLS0tIC9kZXYvbnVs bAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy90b3VjaC9pb3MvY2xpY2staW5zdGVhZC1v Zi1ob3Zlci1zaW1wbGUuaHRtbApAQCAtMCwwICsxLDQ1IEBACis8aHRtbD4KKzxoZWFkPgorPHRp dGxlPlRoaXMgdGVzdCB0aGF0IHdlIHRyaWdnZXIgY2xpY2sgd2hlbiBob3ZlciB3b3VsZCBub3Qg ZGlzcGxheSBub24tY2xpY2thYmxlIGNvbnRlbnQuPC90aXRsZT4KKzxzY3JpcHQgc3JjPSIuLi8u Li8uLi8uLi9yZXNvdXJjZXMvYmFzaWMtZ2VzdHVyZXMuanMiPjwvc2NyaXB0PgorPHN0eWxlPgor I3RhcHRoaXMgeworICAgIHdpZHRoOiA0MDBweDsKKyAgICBoZWlnaHQ6IDQwMHB4OworICAgIGJv cmRlcjogMXB4IHNvbGlkIGdyZWVuOworfQorPC9zdHlsZT4KKzxzY3JpcHQ+Cithc3luYyBmdW5j dGlvbiB0ZXN0KCkgeworICAgIGlmICghd2luZG93LnRlc3RSdW5uZXIgfHwgIXRlc3RSdW5uZXIu cnVuVUlTY3JpcHQpCisgICAgICAgIHJldHVybjsKKworICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4 dCgpOworICAgIHRlc3RSdW5uZXIud2FpdFVudGlsRG9uZSgpOworCisgICAgbGV0IHJlY3QgPSB0 YXB0aGlzLmdldEJvdW5kaW5nQ2xpZW50UmVjdCgpOworICAgIGxldCB4ID0gcmVjdC5sZWZ0ICsg cmVjdC53aWR0aCAvIDI7CisgICAgbGV0IHkgPSByZWN0LnRvcCArIHJlY3QuaGVpZ2h0IC8gMjsK KworCWF3YWl0IHRhcEF0UG9pbnQoeCwgeSk7CisKKyAgICB0ZXN0UnVubmVyLm5vdGlmeURvbmUo KTsKK30KKzwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkgb25sb2FkPSJ0ZXN0KCkiPgorPGRpdiBp ZD10YXB0aGlzPlBBU1MgaWYgY2xpY2tlZC48L2Rpdj4KKzxwcmUgaWQ9cmVzdWx0PjwvcHJlPgor PHNjcmlwdD4KK3RhcHRoaXMuYWRkRXZlbnRMaXN0ZW5lcigibW91c2VvdmVyIiwgZnVuY3Rpb24o IGV2ZW50ICkgeyAgIAorCWxldCBuZXdDb250ZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgi ZGl2Iik7CisJbmV3Q29udGVudC5pbm5lckhUTUwgPSAidG9vbHRpcCI7CisJZG9jdW1lbnQuYm9k eS5hcHBlbmRDaGlsZChuZXdDb250ZW50KTsJCQorfSwgZmFsc2UpOworCit0YXB0aGlzLmFkZEV2 ZW50TGlzdGVuZXIoImNsaWNrIiwgZnVuY3Rpb24oIGV2ZW50ICkgeyAgIAorCXJlc3VsdC5pbm5l ckhUTUwgPSAiY2xpY2tlZCI7Cit9LCBmYWxzZSk7Cis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRt bD4K