191705 2018-11-15 13:17:31 -0800 Increase EWS lock timeout to 3 hours 2018-11-16 14:20:35 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue lforschler ryanhaddad webkit-bug-importer oldest_to_newest 1479064 0 aakash_jain 2018-11-15 13:17:31 -0800 We should increase the EWS lock timeout for a patch from 2 hours to 3 hours. Many times 2 hours is not enough for the patch to be completely processed, especially in case of test failure and retries. e.g.: In https://webkit-queues.webkit.org/patch/354938/ios-sim-ews ews121 was still processing the patch for 2+ hours, when EWS unlocked the patch, and ews125 also started processing same patch. 1479066 1 354977 aakash_jain 2018-11-15 13:20:02 -0800 Created attachment 354977 Proposed patch 1479071 2 354979 aakash_jain 2018-11-15 13:22:06 -0800 Created attachment 354979 Proposed patch 1479102 3 354979 commit-queue 2018-11-15 14:05:35 -0800 Comment on attachment 354979 Proposed patch Clearing flags on attachment: 354979 Committed r238251: <https://trac.webkit.org/changeset/238251> 1479103 4 commit-queue 2018-11-15 14:05:37 -0800 All reviewed patches have been landed. Closing bug. 1479104 5 webkit-bug-importer 2018-11-15 14:06:34 -0800 <rdar://problem/46107448> 1479105 6 aakash_jain 2018-11-15 14:06:49 -0800 Will deploy to webkit-queues soon. 1479616 7 aakash_jain 2018-11-16 14:20:35 -0800 This change has been deployed to webkit-quues. 354977 2018-11-15 13:20:02 -0800 2018-11-15 13:22:06 -0800 Proposed patch ews-timeout-3hours.patch text/plain 1182 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzODI0NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE4LTExLTE1ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBJbmNyZWFzZSBFV1MgbG9jayB0aW1lb3V0IGZyb20gdG8gMyBob3Vycwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkxNzA1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBRdWV1ZVN0 YXR1c1NlcnZlci9jb25maWcvcXVldWVzLnB5OiBJbmNyZWFzZWQgRVdTIGxvY2sgdGltZW91dCB0 byAzIGhvdXJzLgorCiAyMDE4LTExLTE1ICBPcmlvbCBCcnVmYXUgIDxvYnJ1ZmF1QGlnYWxpYS5j b20+CiAKICAgICAgICAgW2Nzcy1sb2dpY2FsXSBJbXBsZW1lbnQgZmxvdy1yZWxhdGl2ZSBtYXJn aW4sIHBhZGRpbmcgYW5kIGJvcmRlciBzaG9ydGhhbmRzCkluZGV4OiBUb29scy9RdWV1ZVN0YXR1 c1NlcnZlci9jb25maWcvcXVldWVzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1F1ZXVlU3RhdHVz U2VydmVyL2NvbmZpZy9xdWV1ZXMucHkJKHJldmlzaW9uIDIzODI0NCkKKysrIFRvb2xzL1F1ZXVl U3RhdHVzU2VydmVyL2NvbmZpZy9xdWV1ZXMucHkJKHdvcmtpbmcgY29weSkKQEAgLTUyLDQgKzUy LDQgQEAgYWxsX3F1ZXVlX25hbWVzID0gWwogCiAjIElmIHRoZSBwYXRjaCBpcyBzdGlsbCBhY3Rp dmUgYWZ0ZXIgdGhpcyBtdWNoIHRpbWUsIHRoZW4gYSBib3QgbXVzdCBoYXZlIGZyb3plbiBvciBy ZWJvb3RlZCwKICMgYW5kIGRyb3BwZWQgdGhlIHBhdGNoIG9uIHRoZSBmbG9vci4gV2Ugd2lsbCBp Z25vcmUgdGhlIGxvY2sgaW4gdGhpcyBjYXNlLCBhbmQgbGV0IGFub3RoZXIgYm90IHBpY2sgdXAu Ci13b3JrX2l0ZW1fbG9ja190aW1lb3V0ID0gdGltZWRlbHRhKG1pbnV0ZXM9MTIwKQord29ya19p dGVtX2xvY2tfdGltZW91dCA9IHRpbWVkZWx0YShtaW51dGVzPTE4MCkK 354979 2018-11-15 13:22:06 -0800 2018-11-15 14:05:35 -0800 Proposed patch ews-timeout-3hours.patch text/plain 1177 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzODI0NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE4LTExLTE1ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBJbmNyZWFzZSBFV1MgbG9jayB0aW1lb3V0IHRvIDMgaG91cnMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTcwNQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogUXVldWVTdGF0dXNT ZXJ2ZXIvY29uZmlnL3F1ZXVlcy5weTogSW5jcmVhc2VkIEVXUyBsb2NrIHRpbWVvdXQgdG8gMyBo b3Vycy4KKwogMjAxOC0xMS0xNSAgT3Jpb2wgQnJ1ZmF1ICA8b2JydWZhdUBpZ2FsaWEuY29tPgog CiAgICAgICAgIFtjc3MtbG9naWNhbF0gSW1wbGVtZW50IGZsb3ctcmVsYXRpdmUgbWFyZ2luLCBw YWRkaW5nIGFuZCBib3JkZXIgc2hvcnRoYW5kcwpJbmRleDogVG9vbHMvUXVldWVTdGF0dXNTZXJ2 ZXIvY29uZmlnL3F1ZXVlcy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9RdWV1ZVN0YXR1c1NlcnZl ci9jb25maWcvcXVldWVzLnB5CShyZXZpc2lvbiAyMzgyNDQpCisrKyBUb29scy9RdWV1ZVN0YXR1 c1NlcnZlci9jb25maWcvcXVldWVzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC01Miw0ICs1Miw0IEBA IGFsbF9xdWV1ZV9uYW1lcyA9IFsKIAogIyBJZiB0aGUgcGF0Y2ggaXMgc3RpbGwgYWN0aXZlIGFm dGVyIHRoaXMgbXVjaCB0aW1lLCB0aGVuIGEgYm90IG11c3QgaGF2ZSBmcm96ZW4gb3IgcmVib290 ZWQsCiAjIGFuZCBkcm9wcGVkIHRoZSBwYXRjaCBvbiB0aGUgZmxvb3IuIFdlIHdpbGwgaWdub3Jl IHRoZSBsb2NrIGluIHRoaXMgY2FzZSwgYW5kIGxldCBhbm90aGVyIGJvdCBwaWNrIHVwLgotd29y a19pdGVtX2xvY2tfdGltZW91dCA9IHRpbWVkZWx0YShtaW51dGVzPTEyMCkKK3dvcmtfaXRlbV9s b2NrX3RpbWVvdXQgPSB0aW1lZGVsdGEobWludXRlcz0xODApCg==