191700 2018-11-15 12:15:03 -0800 Regression: Layer doesn't move when transform updated after a transition 2019-12-17 13:32:22 -0800 1 1 1 Unclassified WebKit Animations WebKit Nightly Build Unspecified Unspecified RESOLVED CONFIGURATION CHANGED InRadar P2 Normal --- 1 ajuma graouts dino fred.wang graouts simon.fraser webkit-bug-importer oldest_to_newest 1479020 0 354968 ajuma 2018-11-15 12:15:03 -0800 Created attachment 354968 Test case See attached test case: the blue box is animated using a CSS transition, and then its transform is updated again after the transition finishes. But the layer doesn't move for the latter update, until an update is forced by resizing the window and/or minimizing and restoring it. This works in STP 69 but is broken on trunk. Trying to debug this a bit, we do get as far as setting the new transform on CALayer, but the CALayer still has an animation on it (even though the transition is finished) and ignores the new transform. If that animation is removed before setting the transform, the layer does move to the right place. 1479037 1 simon.fraser 2018-11-15 12:36:06 -0800 Almost certainly a regression from my compositing changes. 1479252 2 simon.fraser 2018-11-15 21:08:46 -0800 I can't reproduce. Are you sure this wasn't fixed by r238170? 1479284 3 fred.wang 2018-11-15 23:15:02 -0800 I can only reproduce this issue on the iOS simulator, not macOS safari/minibrowser. I'm at r238191 1479407 4 ajuma 2018-11-16 07:34:00 -0800 I tried again at r238277, and this still reproduces for me on macOS MiniBrowser and Safari. 1479447 5 simon.fraser 2018-11-16 09:44:48 -0800 I can reproduce in the simulator. 1479469 6 simon.fraser 2018-11-16 10:06:14 -0800 It seems like we're failing to remove the transforms from the GraphicsLayer. 1479471 7 simon.fraser 2018-11-16 10:10:55 -0800 I think this is an animations bug. We don't hit KeyframeEffect::applyPendingAcceleratedActions() when the transition ends. 1479478 8 simon.fraser 2018-11-16 10:20:38 -0800 https://trac.webkit.org/changeset/238128/webkit may be related. 1479480 9 webkit-bug-importer 2018-11-16 10:21:38 -0800 <rdar://problem/46130742> 1599543 10 graouts 2019-12-17 13:32:22 -0800 Does not reproduce with ToT for me. 354968 2018-11-15 12:15:03 -0800 2018-11-15 12:15:03 -0800 Test case animation-stops.html text/html 723 ajuma PCFET0NUWVBFIGh0bWw+CjxoZWFkPgo8c3R5bGU+CiNib3ggewogIGRpc3BsYXk6IGJsb2NrOwog IHdpZHRoOiAxMDBweDsKICBoZWlnaHQ6IDEwMHB4OwogIGJhY2tncm91bmQtY29sb3I6IGJsdWU7 CiAgdHJhbnNmb3JtOiB0cmFuc2xhdGUzZCgxNTBweCwgMCwgMCk7Cn0KPC9zdHlsZT4KPC9oZWFk PgoKPGJvZHk+CiAgPGRpdiBpZD0iYm94Ij48L2Rpdj4KICBUaGUgYm94IHNob3VsZCBmaXJzdCBt b3ZlIGxlZnQsIGFuZCB0aGVuIG1vdmUgcmlnaHQuCjwvYm9keT4KICAKPHNjcmlwdCA+CmNvbnN0 IGJveCA9IGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJyNib3gnKTsKCmZ1bmN0aW9uIHNsaWRlKCkg ewogIGJveC5zdHlsZS50cmFuc2Zvcm0gPSBgdHJhbnNsYXRlM2QoMzAwcHgsIDAsIDApYDsKICBi b3guc3R5bGUuYmFja2dyb3VuZENvbG9yID0gJ2JsdWUnOwogIGJveC5zdHlsZS50cmFuc2l0aW9u ID0gJ2luaXRpYWwnOwp9CgpmdW5jdGlvbiBhbmltYXRlKCkgewogICAgYm94LnN0eWxlLnRyYW5z Zm9ybSA9IGB0cmFuc2xhdGUzZCgwcHgsIDAsIDApYDsKICAgIGJveC5zdHlsZS5iYWNrZ3JvdW5k Q29sb3IgPSAncmVkJzsKICAgIGJveC5zdHlsZS50cmFuc2l0aW9uID0gJ3RyYW5zZm9ybSAwLjJz JzsKICAgIAogICAgd2luZG93LnNldFRpbWVvdXQoKCkgPT4gc2xpZGUoKSwgMzAwKTsKfQoKcmVx dWVzdEFuaW1hdGlvbkZyYW1lKGFuaW1hdGUpOwo8L3NjcmlwdD4K