191698 2018-11-15 11:05:10 -0800 Safari throws error when changing transceiver.direction 2018-12-06 03:40:57 -0800 1 1 1 Unclassified WebKit WebRTC Safari Technology Preview Unspecified macOS 10.14 RESOLVED DUPLICATE 191202 P2 Normal --- 1 ibc webkit-unassigned youennf oldest_to_newest 1478981 0 354958 ibc 2018-11-15 11:05:10 -0800 Created attachment 354958 Script that reproduces the issue. Just run it in Safari 12.1 console with "Unified-Plan" enabled. * Latest Safari Tech Preview 12.1 (15-Nov-2018) * "WebRTC Unified-Plan" enabled in menu "Develop / Experimental Features". Scenario: - Add a mic transceiver with "sendonly" direction. Create offer and apply it. - Remove the mic track using pc.removeTrack(transceiver.sender). Create offer and apply it. - Add again the mic track using transceiver.replaceTrack(track) and changing transceiver.direction = "sendonly". It throws "InvalidStateError: The object is in an invalid state." This should not happen. The app should be able to change transceiver.direction at any time. And in this case, the app does need to set transceiver.direction="sendonly" since it's not supposed to be automatically changed after replacing the sending track. This works in Chrome and Firefox. 1479166 1 ibc 2018-11-15 16:11:18 -0800 UPDATE: The error does not happen when setting transceiver.direction = "sendonly" (my fault) but when calling transceiver.sender.replaceTrack(track). So it seems that, after calling pc.removeTrack(micTransceiver.sender), the transceiver or its sender component becomes unusable for handling new tracks later. 1479214 2 youennf 2018-11-15 18:18:21 -0800 Thanks for the report Inaki. It does not repro on WebKit Tot. I believe this is a dupe of bug 191202. *** This bug has been marked as a duplicate of bug 191202 *** 1479324 3 ibc 2018-11-16 02:56:55 -0800 Hi Youenn, yes, it is the same issue. My fault. However, according to the latest release notes[*] the issue 191202 is supposed to be fixed in latest Safari Tech Preview, but I can perfectly reproduce the bug by running the attached script. [*] https://webkit.org/blog/8496/release-notes-for-safari-technology-preview-70/ 1485674 4 ibc 2018-12-06 03:40:57 -0800 Confirmed that it's fixed in latest Safari 12.1, WebKit 14607.1.15. 354958 2018-11-15 11:05:10 -0800 2018-11-15 11:05:10 -0800 Script that reproduces the issue. Just run it in Safari 12.1 console with "Unified-Plan" enabled. safari-throws-when-changing-transceiver-direction.js text/javascript 1241 ibc bGV0IG1pY1RyYWNrOwpsZXQgbWljVHJhbnNjZWl2ZXI7CmNvbnN0IHBjID0gbmV3IFJUQ1BlZXJD b25uZWN0aW9uKAogIHsKICAgIGljZVNlcnZlcnMgICAgOiBbXSwKICAgIGJ1bmRsZVBvbGljeSAg OiAnbWF4LWJ1bmRsZScsCiAgICBydGNwTXV4UG9saWN5IDogJ3JlcXVpcmUnLAogICAgc2RwU2Vt YW50aWNzICA6ICd1bmlmaWVkLXBsYW4nCiAgfSk7CgpuYXZpZ2F0b3IubWVkaWFEZXZpY2VzLmdl dFVzZXJNZWRpYSh7IGF1ZGlvOiB0cnVlIH0pCiAgLnRoZW4oKHN0cmVhbSkgPT4KICB7CiAgICBt aWNUcmFjayA9IHN0cmVhbS5nZXRBdWRpb1RyYWNrcygpWzBdOwogIH0pCiAgLnRoZW4oKCkgPT4K ICB7CiAgICBjb25zb2xlLndhcm4oJ2FkZGluZyBtaWMgdHJhY2snKTsKCiAgICBtaWNUcmFuc2Nl aXZlciA9CiAgICAgIHBjLmFkZFRyYW5zY2VpdmVyKG1pY1RyYWNrLCB7IGRpcmVjdGlvbjogJ3Nl bmRvbmx5JyB9KTsKICB9KQogIC50aGVuKCgpID0+IGRvU2RwU3R1ZmYoKSkKICAudGhlbigoKSA9 PgogIHsKICAgIGNvbnNvbGUud2FybigncmVtb3ZpbmcgbWljIHRyYWNrIHVzaW5nIHBjLnJlbW92 ZVRyYWNrKHNlbmRlciknKTsKCiAgICBwYy5yZW1vdmVUcmFjayhtaWNUcmFuc2NlaXZlci5zZW5k ZXIpOwogIH0pCiAgLnRoZW4oKCkgPT4gZG9TZHBTdHVmZigpKQogIC50aGVuKCgpID0+CiAgewog ICAgY29uc29sZS53YXJuKCdhZGRpbmcgbWljIHRyYWNrIGFnYWluJyk7CgogICAgLy8gU2FmYXJp IHRocm93cyBoZXJlLiBJdCBzaG91bGQgbm90LgogICAgbWljVHJhbnNjZWl2ZXIuZGlyZWN0aW9u ID0gJ3NlbmRvbmx5JzsKCiAgICByZXR1cm4gbWljVHJhbnNjZWl2ZXIuc2VuZGVyLnJlcGxhY2VU cmFjayhtaWNUcmFjayk7CiAgfSkKICAudGhlbigoKSA9PiBkb1NkcFN0dWZmKCkpCiAgLmNhdGNo KChlcnJvcikgPT4KICB7CiAgICBjb25zb2xlLmVycm9yKGVycm9yKTsKICB9KTsKCmZ1bmN0aW9u IGRvU2RwU3R1ZmYoKQp7CiAgbGV0IGVycm9yZWQgPSBmYWxzZTsKCiAgcmV0dXJuIHBjLmNyZWF0 ZU9mZmVyKCkKICAgIC50aGVuKChvZmZlcikgPT4KICAgIHsKICAgICAgY29uc29sZS53YXJuKCdw Yy5jcmVhdGVPZmZlcigpIHN1Y2NlZWRlZDpcbiVzJywgb2ZmZXIuc2RwKTsKICAgIH0pCiAgICAu Y2F0Y2goKGVycm9yKSA9PgogICAgewogICAgICBjb25zb2xlLmVycm9yKCdwYy5jcmVhdGVPZmZl cigpIGZhaWxlZCcpOwoKICAgICAgdGhyb3cgZXJyb3I7CiAgICB9KTsKfQo=