191674 2018-11-14 23:44:53 -0800 Web Inspector: Remove unused WebInspectorProxy code 2018-11-15 14:44:23 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue dino inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1478785 0 joepeck 2018-11-14 23:44:53 -0800 Remove unused WebInspectorProxy code 1478786 1 354893 joepeck 2018-11-14 23:45:26 -0800 Created attachment 354893 [PATCH] Proposed Fix 1479137 2 354893 commit-queue 2018-11-15 14:43:06 -0800 Comment on attachment 354893 [PATCH] Proposed Fix Clearing flags on attachment: 354893 Committed r238254: <https://trac.webkit.org/changeset/238254> 1479138 3 commit-queue 2018-11-15 14:43:07 -0800 All reviewed patches have been landed. Closing bug. 1479139 4 webkit-bug-importer 2018-11-15 14:44:23 -0800 <rdar://problem/46108909> 354893 2018-11-14 23:45:26 -0800 2018-11-15 14:43:06 -0800 [PATCH] Proposed Fix unused-1.patch text/plain 4495 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNDYwMmI5MGJjYzkuLmJiNTFjZmRmYjAzIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE5IEBACisyMDE4LTExLTE0ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVtb3ZlIHVudXNlZCBXZWJJbnNwZWN0b3JQcm94 eSBjb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x OTE2NzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFVJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYklu c3BlY3RvclByb3h5OjpjcmVhdGVJbnNwZWN0b3JQYWdlKToKKyAgICAgICAgKFdlYktpdDo6V2Vi SW5zcGVjdG9yUHJveHk6OmNsb3NlRnJvbnRlbmRQYWdlQW5kV2luZG93KToKKyAgICAgICAgKiBV SVByb2Nlc3MvV2ViSW5zcGVjdG9yUHJveHkuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvbWFjL1dl Ykluc3BlY3RvclByb3h5TWFjLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJJbnNwZWN0b3JQcm94 eTo6c2V0SW5zcGVjdG9yV2luZG93RnJhbWUpOiBEZWxldGVkLgorICAgICAgICAoV2ViS2l0OjpX ZWJJbnNwZWN0b3JQcm94eTo6aW5zcGVjdG9yV2luZG93RnJhbWUpOiBEZWxldGVkLgorICAgICAg ICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJJbnNwZWN0b3IuaDoKKwogMjAxOC0xMS0xNCAgS2Vp dGggUm9sbGluICA8a3JvbGxpbkBhcHBsZS5jb20+CiAKICAgICAgICAgTW92ZSBzY3JpcHRzIGZv ciBEZXJpdmVkIGFuZCBVbmlmaWVkIFNvdXJjZXMgdG8gZXh0ZXJuYWwgZmlsZXMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYkluc3BlY3RvclByb3h5LmNwcCBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL1dlYkluc3BlY3RvclByb3h5LmNwcAppbmRleCA2MzVjM2Q2NmZm MS4uOGNkNjIxMzYxNzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYklu c3BlY3RvclByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJJbnNwZWN0 b3JQcm94eS5jcHAKQEAgLTM1Myw5ICszNTMsNyBAQCB2b2lkIFdlYkluc3BlY3RvclByb3h5Ojpj cmVhdGVJbnNwZWN0b3JQYWdlKElQQzo6QXR0YWNobWVudCBjb25uZWN0aW9uSWRlbnRpZmllcgog ICAgIGlmICghbV9pbnNwZWN0b3JQYWdlKQogICAgICAgICByZXR1cm47CiAKLSAgICBtX2Nvbm5l Y3Rpb25JZGVudGlmaWVyID0gV1RGTW92ZShjb25uZWN0aW9uSWRlbnRpZmllcik7Ci0KLSAgICBt X2luc3BlY3RvclBhZ2UtPnByb2Nlc3MoKS5zZW5kKE1lc3NhZ2VzOjpXZWJJbnNwZWN0b3JVSTo6 RXN0YWJsaXNoQ29ubmVjdGlvbihtX2Nvbm5lY3Rpb25JZGVudGlmaWVyLCBtX2luc3BlY3RlZFBh Z2UtPnBhZ2VJRCgpLCBtX3VuZGVyVGVzdCwgaW5zcGVjdGlvbkxldmVsKCkpLCBtX2luc3BlY3Rv clBhZ2UtPnBhZ2VJRCgpKTsKKyAgICBtX2luc3BlY3RvclBhZ2UtPnByb2Nlc3MoKS5zZW5kKE1l c3NhZ2VzOjpXZWJJbnNwZWN0b3JVSTo6RXN0YWJsaXNoQ29ubmVjdGlvbihXVEZNb3ZlKGNvbm5l Y3Rpb25JZGVudGlmaWVyKSwgbV9pbnNwZWN0ZWRQYWdlLT5wYWdlSUQoKSwgbV91bmRlclRlc3Qs IGluc3BlY3Rpb25MZXZlbCgpKSwgbV9pbnNwZWN0b3JQYWdlLT5wYWdlSUQoKSk7CiAKICAgICBp ZiAoIW1fdW5kZXJUZXN0KSB7CiAgICAgICAgIG1fY2FuQXR0YWNoID0gcGxhdGZvcm1DYW5BdHRh Y2goY2FuQXR0YWNoKTsKQEAgLTQzNyw4ICs0MzUsNiBAQCB2b2lkIFdlYkluc3BlY3RvclByb3h5 OjpjbG9zZUZyb250ZW5kUGFnZUFuZFdpbmRvdygpCiAgICAgbV9jYW5BdHRhY2ggPSBmYWxzZTsK ICAgICBtX3VuZGVyVGVzdCA9IGZhbHNlOwogCi0gICAgbV9jb25uZWN0aW9uSWRlbnRpZmllciA9 IElQQzo6QXR0YWNobWVudCgpOwotCiAgICAgcGxhdGZvcm1DbG9zZUZyb250ZW5kUGFnZUFuZFdp bmRvdygpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJJbnNw ZWN0b3JQcm94eS5oIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViSW5zcGVjdG9yUHJveHku aAppbmRleCA2NzgyZGU5NDg5OS4uZDRlNjA2OTMzZTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL1dlYkluc3BlY3RvclByb3h5LmgKKysrIGIvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvV2ViSW5zcGVjdG9yUHJveHkuaApAQCAtMTA3LDkgKzEwNyw2IEBAIHB1YmxpYzoKICAg ICB2b2lkIHdpbmRvd0Z1bGxTY3JlZW5EaWRDaGFuZ2UoKTsKICAgICBOU1dpbmRvdyogaW5zcGVj dG9yV2luZG93KCkgY29uc3QgeyByZXR1cm4gbV9pbnNwZWN0b3JXaW5kb3cuZ2V0KCk7IH0KIAot ICAgIHZvaWQgc2V0SW5zcGVjdG9yV2luZG93RnJhbWUoV0tSZWN0Jik7Ci0gICAgV0tSZWN0IGlu c3BlY3RvcldpbmRvd0ZyYW1lKCk7Ci0KICAgICB2b2lkIGNsb3NlRnJvbnRlbmRQYWdlKCk7CiAg ICAgdm9pZCBjbG9zZUZyb250ZW5kQWZ0ZXJJbmFjdGl2aXR5VGltZXJGaXJlZCgpOwogCkBAIC0y NDMsOCArMjQwLDYgQEAgcHJpdmF0ZToKICAgICBib29sIG1faWdub3JlRWxlbWVudFNlbGVjdGlv bkNoYW5nZSB7IGZhbHNlIH07CiAgICAgYm9vbCBtX2lzT3BlbmluZyB7IGZhbHNlIH07CiAKLSAg ICBJUEM6OkF0dGFjaG1lbnQgbV9jb25uZWN0aW9uSWRlbnRpZmllcjsKLQogICAgIEF0dGFjaG1l bnRTaWRlIG1fYXR0YWNobWVudFNpZGUge0F0dGFjaG1lbnRTaWRlOjpCb3R0b219OwogCiAjaWYg UExBVEZPUk0oTUFDKSAmJiBXS19BUElfRU5BQkxFRApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvbWFjL1dlYkluc3BlY3RvclByb3h5TWFjLm1tIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvbWFjL1dlYkluc3BlY3RvclByb3h5TWFjLm1tCmluZGV4IDcwZTEzNDBiNWZhLi45 ODMyNjMyM2Y2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvbWFjL1dlYklu c3BlY3RvclByb3h5TWFjLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL21hYy9XZWJJ bnNwZWN0b3JQcm94eU1hYy5tbQpAQCAtMjEwLDIzICsyMTAsNiBAQCB2b2lkIFdlYkluc3BlY3Rv clByb3h5OjphdHRhY2htZW50RGlkTW92ZVRvV2luZG93KE5TV2luZG93ICpuZXdXaW5kb3cpCiAg ICAgfQogfQogCi12b2lkIFdlYkluc3BlY3RvclByb3h5OjpzZXRJbnNwZWN0b3JXaW5kb3dGcmFt ZShXS1JlY3QmIGZyYW1lKQotewotICAgIGlmIChtX2lzQXR0YWNoZWQpCi0gICAgICAgIHJldHVy bjsKLQotICAgIFttX2luc3BlY3RvcldpbmRvdyBzZXRGcmFtZTpOU01ha2VSZWN0KGZyYW1lLm9y aWdpbi54LCBmcmFtZS5vcmlnaW4ueSwgZnJhbWUuc2l6ZS53aWR0aCwgZnJhbWUuc2l6ZS5oZWln aHQpIGRpc3BsYXk6WUVTXTsKLX0KLQotV0tSZWN0IFdlYkluc3BlY3RvclByb3h5OjppbnNwZWN0 b3JXaW5kb3dGcmFtZSgpCi17Ci0gICAgaWYgKG1faXNBdHRhY2hlZCkKLSAgICAgICAgcmV0dXJu IFdLUmVjdE1ha2UoMCwgMCwgMCwgMCk7Ci0KLSAgICBOU1JlY3QgZnJhbWUgPSBtX2luc3BlY3Rv cldpbmRvdy5nZXQoKS5mcmFtZTsKLSAgICByZXR1cm4gV0tSZWN0TWFrZShmcmFtZS5vcmlnaW4u eCwgZnJhbWUub3JpZ2luLnksIGZyYW1lLnNpemUud2lkdGgsIGZyYW1lLnNpemUuaGVpZ2h0KTsK LX0KLQogdm9pZCBXZWJJbnNwZWN0b3JQcm94eTo6dXBkYXRlSW5zcGVjdG9yV2luZG93VGl0bGUo KSBjb25zdAogewogICAgIGlmICghbV9pbnNwZWN0b3JXaW5kb3cpCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJJbnNwZWN0b3IuaCBiL1NvdXJjZS9XZWJL aXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkluc3BlY3Rvci5oCmluZGV4IGUwYzUxMjQ3NDU0Li41 YzExZGYzZTc3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2Uv V2ViSW5zcGVjdG9yLmgKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2Vi SW5zcGVjdG9yLmgKQEAgLTU0LDkgKzU0LDYgQEAgcHVibGljOgogICAgIHZvaWQgZGlkQ2xvc2Uo SVBDOjpDb25uZWN0aW9uJikgb3ZlcnJpZGUgeyBjbG9zZSgpOyB9CiAgICAgdm9pZCBkaWRSZWNl aXZlSW52YWxpZE1lc3NhZ2UoSVBDOjpDb25uZWN0aW9uJiwgSVBDOjpTdHJpbmdSZWZlcmVuY2Us IElQQzo6U3RyaW5nUmVmZXJlbmNlKSBvdmVycmlkZSB7IGNsb3NlKCk7IH0KIAotICAgIC8vIENh bGxlZCBieSBXZWJJbnNwZWN0b3IgbWVzc2FnZXMKLSAgICB2b2lkIGNvbm5lY3Rpb25Fc3RhYmxp c2hlZCgpOwotCiAgICAgdm9pZCBzaG93KCk7CiAgICAgdm9pZCBjbG9zZSgpOwogCg==