191660 2018-11-14 15:02:41 -0800 REGRESSION (r238115): [iOS] TestWebKitAPI.ProcessSwap.NavigateToInvalidURL is failing 2018-11-14 19:33:36 -0800 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad cdumez achristensen beidson cdumez commit-queue ggaren jlewis3 rniwa tsavell webkit-bug-importer oldest_to_newest 1478646 0 ryanhaddad 2018-11-14 15:02:41 -0800 Failed TestWebKitAPI.ProcessSwap.NavigateToInvalidURL Received data during response processing, queuing it. /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:2382 Expected equality of these values: 2 numberOfDecidePolicyCalls Which is: 1 https://build.webkit.org/builders/Apple%20iOS%2012%20Simulator%20Release%20WK2%20%28Tests%29/builds/959/steps/run-api-tests/logs/stdio 1478649 1 ryanhaddad 2018-11-14 15:06:37 -0800 I think this regressed with https://trac.webkit.org/changeset/238115 1478656 2 cdumez 2018-11-14 15:15:08 -0800 TEST(ProcessSwap, NavigateToInvalidURL) { auto processPoolConfiguration = adoptNS([[_WKProcessPoolConfiguration alloc] init]); processPoolConfiguration.get().processSwapsOnNavigation = YES; auto processPool = adoptNS([[WKProcessPool alloc] _initWithConfiguration:processPoolConfiguration.get()]); auto webViewConfiguration = adoptNS([[WKWebViewConfiguration alloc] init]); [webViewConfiguration setProcessPool:processPool.get()]; auto handler = adoptNS([[PSONScheme alloc] initWithBytes:navigateToInvalidURLTestBytes]); [webViewConfiguration setURLSchemeHandler:handler.get() forURLScheme:@"PSON"]; auto webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:webViewConfiguration.get()]); auto navigationDelegate = adoptNS([[PSONNavigationDelegate alloc] init]); [webView setNavigationDelegate:navigationDelegate.get()]; auto uiDelegate = adoptNS([[PSONUIDelegate alloc] initWithNavigationDelegate:navigationDelegate.get()]); [webView setUIDelegate:uiDelegate.get()]; numberOfDecidePolicyCalls = 0; [webView loadRequest:[NSURLRequest requestWithURL:[NSURL URLWithString:@"pson://www.webkit.org/main.html"]]]; TestWebKitAPI::Util::run(&done); done = false; auto pid1 = [webView _webProcessIdentifier]; EXPECT_TRUE(!!pid1); TestWebKitAPI::Util::run(&didReceiveAlert); didReceiveAlert = false; auto pid2 = [webView _webProcessIdentifier]; EXPECT_TRUE(!!pid2); EXPECT_EQ(2, numberOfDecidePolicyCalls); EXPECT_EQ(pid1, pid2); } Since the safe browsing check, we're getting one decidePolicyForNavigationAction call instead of 2. Previously there would be one for "pson://www.webkit.org/main.html" and presumably another one for the invalid URL load 'http://A=a%B=b'. Alex? 1478667 3 cdumez 2018-11-14 15:53:21 -0800 (In reply to Chris Dumez from comment #2) > TEST(ProcessSwap, NavigateToInvalidURL) > { > auto processPoolConfiguration = adoptNS([[_WKProcessPoolConfiguration > alloc] init]); > processPoolConfiguration.get().processSwapsOnNavigation = YES; > auto processPool = adoptNS([[WKProcessPool alloc] > _initWithConfiguration:processPoolConfiguration.get()]); > > auto webViewConfiguration = adoptNS([[WKWebViewConfiguration alloc] > init]); > [webViewConfiguration setProcessPool:processPool.get()]; > auto handler = adoptNS([[PSONScheme alloc] > initWithBytes:navigateToInvalidURLTestBytes]); > [webViewConfiguration setURLSchemeHandler:handler.get() > forURLScheme:@"PSON"]; > > auto webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, > 800, 600) configuration:webViewConfiguration.get()]); > auto navigationDelegate = adoptNS([[PSONNavigationDelegate alloc] init]); > [webView setNavigationDelegate:navigationDelegate.get()]; > auto uiDelegate = adoptNS([[PSONUIDelegate alloc] > initWithNavigationDelegate:navigationDelegate.get()]); > [webView setUIDelegate:uiDelegate.get()]; > > numberOfDecidePolicyCalls = 0; > [webView loadRequest:[NSURLRequest requestWithURL:[NSURL > URLWithString:@"pson://www.webkit.org/main.html"]]]; > TestWebKitAPI::Util::run(&done); > done = false; > auto pid1 = [webView _webProcessIdentifier]; > EXPECT_TRUE(!!pid1); > > TestWebKitAPI::Util::run(&didReceiveAlert); > didReceiveAlert = false; > auto pid2 = [webView _webProcessIdentifier]; > EXPECT_TRUE(!!pid2); > > EXPECT_EQ(2, numberOfDecidePolicyCalls); > EXPECT_EQ(pid1, pid2); > } > > Since the safe browsing check, we're getting one > decidePolicyForNavigationAction call instead of 2. Previously there would be > one for "pson://www.webkit.org/main.html" and presumably another one for the > invalid URL load 'http://A=a%B=b'. > > Alex? Oh, I think this is just a timing issue and the safe browsing check merely delayed things by a bit. I am investigate. Likely, I just need to write the test in a better way. 1478684 4 354868 cdumez 2018-11-14 16:24:51 -0800 Created attachment 354868 Patch 1478752 5 354868 commit-queue 2018-11-14 19:32:39 -0800 Comment on attachment 354868 Patch Clearing flags on attachment: 354868 Committed r238216: <https://trac.webkit.org/changeset/238216> 1478753 6 commit-queue 2018-11-14 19:32:41 -0800 All reviewed patches have been landed. Closing bug. 1478755 7 webkit-bug-importer 2018-11-14 19:33:36 -0800 <rdar://problem/46084621> 354868 2018-11-14 16:24:51 -0800 2018-11-14 19:32:39 -0800 Patch bug-191660-20181114162450.patch text/plain 4266 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4MjA1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOGM1MzVjN2ZmNjMwN2M5NTVmYTk3NzEyMTMwNDg4ZTRh YTg4Y2U5Ni4uMDkyMTZkYzc3MWE1NjA2NDVmZGJlYTczZTE5NGQ4YjcwNDQ3Mjc2ZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2 IEBACisyMDE4LTExLTE0ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAg ICAgUkVHUkVTU0lPTiAocjIzODExNSk6IFtpT1NdIFRlc3RXZWJLaXRBUEkuUHJvY2Vzc1N3YXAu TmF2aWdhdGVUb0ludmFsaWRVUkwgaXMgZmFpbGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkxNjYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHRlc3QgdHJpZXMgdG8gbmF2aWdhdGUgdG8gYW4g aW52YWxpZCBVUkwgYW5kIG1ha2VzIHN1cmUgdGhhdCB3ZSBkbyBub3QgcHJvY2VzcyBzd2FwCisg ICAgICAgIGZvciBzdWNoIGxvYWQuIFRoZSB0ZXN0IHdhcyBpbmhlcmVudGx5IHJhY2luZyBiZWNh dXNlIGl0IHdhcyBkb2luZzoKKyAgICAgICAgPGJvZHkgb25sb2FkPSJzZXRUaW1lb3V0KCgpID0+ IGFsZXJ0KCdET05FJyksIDApOyBsb2NhdGlvbi5ocmVmID0gJ2h0dHA6Ly9BPWElQj1iJyI+CisK KyAgICAgICAgSXRzIGxvYWQgZXZlbnQgaGFuZGxlciB0cmllcyB0byBuYXZpZ2F0ZSB0byAnaHR0 cDovL0E9YSVCPWInIGFuZCBzZXRzIGEgMCB0aW1lciB0bworICAgICAgICBsb2cgYW4gYWxlcnQs IHdoaWNoIGNhdXNlcyB0aGUgQVBJIHRlc3QgdG8ga2VlcCBnb2luZyBhbmQgY2hlY2sgdGhhdCB3 ZSBkaWQgbm90IHN3YXAKKyAgICAgICAgcHJvY2Vzcy4gVGhlIGlzc3VlIGlzIHRoYXQgYSAwIHRp bWVyIG1heSBub3QgYmUgc3VmZmljaWVudCB0byB0cmlnZ2VyIHRoZSBsb2FkLCBhcworICAgICAg ICB0aGUgcG9saWN5IGRlY2lzaW9uIGlzIGFzeW5jaHJvbm91cyBhbmQgcmVsaWVzIG9uIHRoZSBV SVByb2Nlc3MgcmVzcG9uZGluZyB0byBpdC4KKworICAgICAgICBUbyBhZGRyZXNzIHRoZSBpc3N1 ZSwgdGhlIHRlc3Qgbm93IHdhaXRzIGZvciB0aGUgbmV4dCBwb2xpY3kgZGVjaXNpb24sIHNwaW5z IHRoZQorICAgICAgICBydW4gbG9vcCBhbmQgdGhlbiBtYWtlcyBzdXJlIHdlIGRpZCBub3Qgc3dh cCBwcm9jZXNzLiBJdCBubyBsb25nZXIgcmVsaWVzIG9uIGEgbWVzc2FnZQorICAgICAgICBmcm9t IHRoZSBwYWdlLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9Q cm9jZXNzU3dhcE9uTmF2aWdhdGlvbi5tbToKKyAgICAgICAgKC1bUFNPTk5hdmlnYXRpb25EZWxl Z2F0ZSB3ZWJWaWV3OmRlY2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb246ZGVjaXNpb25IYW5k bGVyOl0pOgorCiAyMDE4LTExLTE0ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdl YmtpdC5vcmc+CiAKICAgICAgICAgQWRkIFNQSSB0byBzaG93IGEgc2FmZSBicm93c2luZyB3YXJu aW5nCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1By b2Nlc3NTd2FwT25OYXZpZ2F0aW9uLm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJL aXRDb2NvYS9Qcm9jZXNzU3dhcE9uTmF2aWdhdGlvbi5tbQppbmRleCA4Y2IxMzAzZWFmMjdlMzli YzIzNjZkMzdmMGNhMjUwZThlOTA4NmQ5Li5hODNmYjAzYzEzMzE4M2U2ZjFmZDBjMDYzOGU5ZmE0 MWZhMDFiOWVhIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENv Y29hL1Byb2Nlc3NTd2FwT25OYXZpZ2F0aW9uLm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkv VGVzdHMvV2ViS2l0Q29jb2EvUHJvY2Vzc1N3YXBPbk5hdmlnYXRpb24ubW0KQEAgLTYyLDYgKzYy LDcgQEAgc3RhdGljIGJvb2wgZG9uZTsKIHN0YXRpYyBib29sIGZhaWxlZDsKIHN0YXRpYyBib29s IGRpZENyZWF0ZVdlYlZpZXc7CiBzdGF0aWMgaW50IG51bWJlck9mRGVjaWRlUG9saWN5Q2FsbHM7 CitzdGF0aWMgYm9vbCBkaWRSZXBvbmRUb1BvbGljeURlY2lzaW9uQ2FsbDsKIAogc3RhdGljIFJl dGFpblB0cjxOU011dGFibGVBcnJheT4gcmVjZWl2ZWRNZXNzYWdlcyA9IGFkb3B0TlMoW0BbXSBt dXRhYmxlQ29weV0pOwogYm9vbCBkaWRSZWNlaXZlQWxlcnQ7CkBAIC0xMjMsNiArMTI0LDcgQEAg LSAodm9pZCl3ZWJWaWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3IGRlY2lkZVBvbGljeUZvck5hdmln YXRpb25BY3Rpb246KFdLTmF2aWdhdGkKICAgICAgICAgZGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlv bkFjdGlvbihuYXZpZ2F0aW9uQWN0aW9uLCBkZWNpc2lvbkhhbmRsZXIpOwogICAgIGVsc2UKICAg ICAgICAgZGVjaXNpb25IYW5kbGVyKFdLTmF2aWdhdGlvbkFjdGlvblBvbGljeUFsbG93KTsKKyAg ICBkaWRSZXBvbmRUb1BvbGljeURlY2lzaW9uQ2FsbCA9IHRydWU7CiB9CiAKIC0gKHZvaWQpd2Vi VmlldzooV0tXZWJWaWV3ICopd2ViVmlldyBkaWRSZWNlaXZlU2VydmVyUmVkaXJlY3RGb3JQcm92 aXNpb25hbE5hdmlnYXRpb246KFdLTmF2aWdhdGlvbiAqKW5hdmlnYXRpb24KQEAgLTIzNDQsMTIg KzIzNDYsNiBAQCBURVNUKFByb2Nlc3NTd2FwLCBQcm9jZXNzUmV1c2VlVExEUGx1czIpCiAgICAg RVhQRUNUX0VRKHBpZDEsIHBpZDMpOwogfQogCi1zdGF0aWMgY29uc3QgY2hhciogbmF2aWdhdGVU b0ludmFsaWRVUkxUZXN0Qnl0ZXMgPSBSIlBTT05SRVNPVVJDRSgKLTwhRE9DVFlQRSBodG1sPgot PGh0bWw+Ci08Ym9keSBvbmxvYWQ9InNldFRpbWVvdXQoKCkgPT4gYWxlcnQoJ0RPTkUnKSwgMCk7 IGxvY2F0aW9uLmhyZWYgPSAnaHR0cDovL0E9YSVCPWInIj4KLSlQU09OUkVTT1VSQ0UiOwotCiBU RVNUKFByb2Nlc3NTd2FwLCBOYXZpZ2F0ZVRvSW52YWxpZFVSTCkKIHsKICAgICBhdXRvIHByb2Nl c3NQb29sQ29uZmlndXJhdGlvbiA9IGFkb3B0TlMoW1tfV0tQcm9jZXNzUG9vbENvbmZpZ3VyYXRp b24gYWxsb2NdIGluaXRdKTsKQEAgLTIzNTgsNyArMjM1NCw3IEBAIFRFU1QoUHJvY2Vzc1N3YXAs IE5hdmlnYXRlVG9JbnZhbGlkVVJMKQogCiAgICAgYXV0byB3ZWJWaWV3Q29uZmlndXJhdGlvbiA9 IGFkb3B0TlMoW1tXS1dlYlZpZXdDb25maWd1cmF0aW9uIGFsbG9jXSBpbml0XSk7CiAgICAgW3dl YlZpZXdDb25maWd1cmF0aW9uIHNldFByb2Nlc3NQb29sOnByb2Nlc3NQb29sLmdldCgpXTsKLSAg ICBhdXRvIGhhbmRsZXIgPSBhZG9wdE5TKFtbUFNPTlNjaGVtZSBhbGxvY10gaW5pdFdpdGhCeXRl czpuYXZpZ2F0ZVRvSW52YWxpZFVSTFRlc3RCeXRlc10pOworICAgIGF1dG8gaGFuZGxlciA9IGFk b3B0TlMoW1tQU09OU2NoZW1lIGFsbG9jXSBpbml0XSk7CiAgICAgW3dlYlZpZXdDb25maWd1cmF0 aW9uIHNldFVSTFNjaGVtZUhhbmRsZXI6aGFuZGxlci5nZXQoKSBmb3JVUkxTY2hlbWU6QCJQU09O Il07CiAKICAgICBhdXRvIHdlYlZpZXcgPSBhZG9wdE5TKFtbV0tXZWJWaWV3IGFsbG9jXSBpbml0 V2l0aEZyYW1lOk5TTWFrZVJlY3QoMCwgMCwgODAwLCA2MDApIGNvbmZpZ3VyYXRpb246d2ViVmll d0NvbmZpZ3VyYXRpb24uZ2V0KCldKTsKQEAgLTIzNzQsOCArMjM3MCwxNSBAQCBURVNUKFByb2Nl c3NTd2FwLCBOYXZpZ2F0ZVRvSW52YWxpZFVSTCkKICAgICBhdXRvIHBpZDEgPSBbd2ViVmlldyBf d2ViUHJvY2Vzc0lkZW50aWZpZXJdOwogICAgIEVYUEVDVF9UUlVFKCEhcGlkMSk7CiAKLSAgICBU ZXN0V2ViS2l0QVBJOjpVdGlsOjpydW4oJmRpZFJlY2VpdmVBbGVydCk7Ci0gICAgZGlkUmVjZWl2 ZUFsZXJ0ID0gZmFsc2U7CisgICAgRVhQRUNUX0VRKDEsIG51bWJlck9mRGVjaWRlUG9saWN5Q2Fs bHMpOworCisgICAgW3dlYlZpZXcgZXZhbHVhdGVKYXZhU2NyaXB0OkAibG9jYXRpb24uaHJlZiA9 ICdodHRwOi8vQT1hJUI9YiciIGNvbXBsZXRpb25IYW5kbGVyOm5pbF07CisKKyAgICBkaWRSZXBv bmRUb1BvbGljeURlY2lzaW9uQ2FsbCA9IGZhbHNlOworICAgIFRlc3RXZWJLaXRBUEk6OlV0aWw6 OnJ1bigmZGlkUmVwb25kVG9Qb2xpY3lEZWNpc2lvbkNhbGwpOworCisgICAgVGVzdFdlYktpdEFQ STo6VXRpbDo6c3BpblJ1bkxvb3AoMSk7CisKICAgICBhdXRvIHBpZDIgPSBbd2ViVmlldyBfd2Vi UHJvY2Vzc0lkZW50aWZpZXJdOwogICAgIEVYUEVDVF9UUlVFKCEhcGlkMik7CiAK