191654 2018-11-14 13:56:24 -0800 Update prefers-color-scheme media query matching based on GitHub issue #3278 2018-11-14 14:24:19 -0800 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy commit-queue dino simon.fraser webkit-bug-importer oldest_to_newest 1478605 0 timothy 2018-11-14 13:56:24 -0800 Fix some issues raised by Firefox devs on prefers-color-scheme in WebKit. https://github.com/w3c/csswg-drafts/issues/3278 1478606 1 webkit-bug-importer 2018-11-14 13:56:46 -0800 <rdar://problem/46074307> 1478608 2 354849 timothy 2018-11-14 14:00:18 -0800 Created attachment 354849 Patch 1478624 3 354849 commit-queue 2018-11-14 14:24:18 -0800 Comment on attachment 354849 Patch Clearing flags on attachment: 354849 Committed r238200: <https://trac.webkit.org/changeset/238200> 1478625 4 commit-queue 2018-11-14 14:24:19 -0800 All reviewed patches have been landed. Closing bug. 354849 2018-11-14 14:00:18 -0800 2018-11-14 14:24:18 -0800 Patch bug-191654-20181114140017.patch text/plain 6792 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4MDAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2RiMTZiMmQxZWZmMGQ1 YmFlYTdhZTIwYjJmZDhmYTVkZTc1ZTUyNi4uMWNkMGM1NjQ2NjkxNzc1MjlkNDYxMjUzYjQxMWMy NGQzYzRhNmMwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTExLTE0ICBUaW1v dGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICBVcGRhdGUgcHJlZmVy cy1jb2xvci1zY2hlbWUgbWVkaWEgcXVlcnkgbWF0Y2hpbmcgYmFzZWQgb24gR2l0SHViIGlzc3Vl ICMzMjc4LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTkxNjU0CisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzQ2MDc0MzA3CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogY3NzLWRhcmstbW9kZS9wcmVm ZXJzLWNvbG9yLXNjaGVtZS5odG1sCisKKyAgICAgICAgKiBjc3MvTWVkaWFRdWVyeUV2YWx1YXRv ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpwcmVmZXJzQ29sb3JTY2hlbWVFdmFsdWF0ZSk6IFJl dHVybiB0cnVlIHdoZW4gdGhlcmUgaXMgbm8gdmFsdWUuIFJldHVybiBmYWxzZQorICAgICAgICBm b3IgYG5vLXByZWZlcmVuY2VgIHNpbmNlIHRoZXJlIGlzIG5vIG1hY09TIG9wdGlvbiBmb3Igbm8g dXNlciBwcmVmZXJlbmNlLgorICAgICAgICAqIGNzcy9NZWRpYVF1ZXJ5RXhwcmVzc2lvbi5jcHA6 CisgICAgICAgIChXZWJDb3JlOjppc0ZlYXR1cmVWYWxpZFdpdGhvdXRWYWx1ZSk6IEFkZGVkIHBy ZWZlcnMtY29sb3Itc2NoZW1lLgorCiAyMDE4LTExLTEzICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1v dGh5QGFwcGxlLmNvbT4KIAogICAgICAgICBFbmFibGVkIGRhcmsgbW9kZSBDU1Mgc3VwcG9ydCBi eSBkZWZhdWx0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL01lZGlhUXVlcnlFdmFs dWF0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL01lZGlhUXVlcnlFdmFsdWF0b3IuY3BwCmlu ZGV4IDI5ZjUwNDZiNzU4NWJlNTE4NTg5ZjIxYjU2ZjcyZjc2NDA1MzJmMjQuLmU5NTlhZTYwY2Zh Njc0NGE3OGFiODBhM2MzYjYzNmIwMGU5Zjg4ODQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2Nzcy9NZWRpYVF1ZXJ5RXZhbHVhdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvTWVk aWFRdWVyeUV2YWx1YXRvci5jcHAKQEAgLTc0NSw2ICs3NDUsOSBAQCBzdGF0aWMgYm9vbCBwcmVm ZXJzQ29sb3JTY2hlbWVFdmFsdWF0ZShDU1NWYWx1ZSogdmFsdWUsIGNvbnN0IENTU1RvTGVuZ3Ro Q29udmVycwogewogICAgIEFTU0VSVChSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpzaGFyZWRGZWF0 dXJlcygpLmRhcmtNb2RlQ1NTRW5hYmxlZCgpKTsKIAorICAgIGlmICghdmFsdWUpCisgICAgICAg IHJldHVybiB0cnVlOworCiAgICAgaWYgKCFpczxDU1NQcmltaXRpdmVWYWx1ZT4odmFsdWUpKQog ICAgICAgICByZXR1cm4gZmFsc2U7CiAKQEAgLTc1Myw3ICs3NTYsNyBAQCBzdGF0aWMgYm9vbCBw cmVmZXJzQ29sb3JTY2hlbWVFdmFsdWF0ZShDU1NWYWx1ZSogdmFsdWUsIGNvbnN0IENTU1RvTGVu Z3RoQ29udmVycwogCiAgICAgc3dpdGNoIChrZXl3b3JkKSB7CiAgICAgY2FzZSBDU1NWYWx1ZU5v UHJlZmVyZW5jZToKLSAgICAgICAgcmV0dXJuIHRydWU7CisgICAgICAgIHJldHVybiBmYWxzZTsK ICAgICBjYXNlIENTU1ZhbHVlRGFyazoKICAgICAgICAgcmV0dXJuIHVzZURhcmtBcHBlYXJhbmNl OwogICAgIGNhc2UgQ1NTVmFsdWVMaWdodDoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nz cy9NZWRpYVF1ZXJ5RXhwcmVzc2lvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvTWVkaWFRdWVy eUV4cHJlc3Npb24uY3BwCmluZGV4IDkyMDg3ZTRkODJiOGM1YWE4ZjE4MzJmM2EwM2U3MGRjMDAx NzVhZmQuLjA4YmUwNTUyNjA1N2ZjOTVkNTk4ZGE4YjhkN2FkNWVkOTkzYzRjNmYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9NZWRpYVF1ZXJ5RXhwcmVzc2lvbi5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvY3NzL01lZGlhUXVlcnlFeHByZXNzaW9uLmNwcApAQCAtMTY3LDYgKzE2Nyw5 IEBAIHN0YXRpYyBpbmxpbmUgYm9vbCBpc0ZlYXR1cmVWYWxpZFdpdGhvdXRWYWx1ZShjb25zdCBB dG9taWNTdHJpbmcmIG1lZGlhRmVhdHVyZSwKICAgICAgICAgfHwgbWVkaWFGZWF0dXJlID09IE1l ZGlhRmVhdHVyZU5hbWVzOjpwb2ludGVyCiAgICAgICAgIHx8IG1lZGlhRmVhdHVyZSA9PSBNZWRp YUZlYXR1cmVOYW1lczo6cHJlZmVyc1JlZHVjZWRNb3Rpb24KICAgICAgICAgfHwgKG1lZGlhRmVh dHVyZSA9PSBNZWRpYUZlYXR1cmVOYW1lczo6cHJlZmVyc0RhcmtJbnRlcmZhY2UgJiYgKGNvbnRl eHQudXNlU3lzdGVtQXBwZWFyYW5jZSB8fCBpc1VBU2hlZXRCZWhhdmlvcihjb250ZXh0Lm1vZGUp KSkKKyNpZiBFTkFCTEUoREFSS19NT0RFX0NTUykKKyAgICAgICAgfHwgKG1lZGlhRmVhdHVyZSA9 PSBNZWRpYUZlYXR1cmVOYW1lczo6cHJlZmVyc0NvbG9yU2NoZW1lICYmIFJ1bnRpbWVFbmFibGVk RmVhdHVyZXM6OnNoYXJlZEZlYXR1cmVzKCkuZGFya01vZGVDU1NFbmFibGVkKCkpCisjZW5kaWYK ICAgICAgICAgfHwgbWVkaWFGZWF0dXJlID09IE1lZGlhRmVhdHVyZU5hbWVzOjpkZXZpY2VQaXhl bFJhdGlvCiAgICAgICAgIHx8IG1lZGlhRmVhdHVyZSA9PSBNZWRpYUZlYXR1cmVOYW1lczo6cmVz b2x1dGlvbgogI2lmIEVOQUJMRShBUFBMSUNBVElPTl9NQU5JRkVTVCkKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBhZmU2ZWYy MjUwNTZlZmU5NGFiNDEzMWJmN2EzYjgxYmFkMWFhODUyLi5lYjk3ZTI0OGEzMTk1ZDVjMmVkOWM0 MTAyMmExNmM3ZDFhNzUwNzM1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysr IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMTEtMTQgIFRp bW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCisgICAgICAgIFVwZGF0ZSBwcmVm ZXJzLWNvbG9yLXNjaGVtZSBtZWRpYSBxdWVyeSBtYXRjaGluZyBiYXNlZCBvbiBHaXRIdWIgaXNz dWUgIzMyNzguCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTE2NTQKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vNDYwNzQzMDcKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGNzcy1kYXJrLW1vZGUvcHJlZmVy cy1jb2xvci1zY2hlbWUtZXhwZWN0ZWQudHh0OiBSZWJhc2VsaW5lLgorICAgICAgICAqIGNzcy1k YXJrLW1vZGUvcHJlZmVycy1jb2xvci1zY2hlbWUuaHRtbDogVXBkYXRlcyB0byBiZXR0ZXIgbWF0 Y2ggdGhlIHNwZWMuCisKIDIwMTgtMTEtMTMgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBw bGUuY29tPgogCiAgICAgICAgIERlZmF1bHQgdGhlIHZpZXcgYmFja2dyb3VuZCBjb2xvciBhbmQg dGV4dCBjb2xvciB0byBkaWZmZXJlbnQgdmFsdWVzIHdoZW4gaW4gZGFyayBtb2RlLgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvY3NzLWRhcmstbW9kZS9wcmVmZXJzLWNvbG9yLXNjaGVtZS1leHBl Y3RlZC50eHQgYi9MYXlvdXRUZXN0cy9jc3MtZGFyay1tb2RlL3ByZWZlcnMtY29sb3Itc2NoZW1l LWV4cGVjdGVkLnR4dAppbmRleCA3NWMyMTc0MWJlOWY2NGE1MGEyZjZkZDM5OTY0ODAwZmYwN2Ri ZmFjLi4wMmQwMGJlZWE5NTM4ZjVjZmJmM2FiYmIzOWE4NmM3NjFiOTIyMWQ3IDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9jc3MtZGFyay1tb2RlL3ByZWZlcnMtY29sb3Itc2NoZW1lLWV4cGVjdGVk LnR4dAorKysgYi9MYXlvdXRUZXN0cy9jc3MtZGFyay1tb2RlL3ByZWZlcnMtY29sb3Itc2NoZW1l LWV4cGVjdGVkLnR4dApAQCAtMSw1ICsxLDcgQEAKIAogUEFTUyBFbGVtZW50IGNvbG9ycyBhcmUg Y29ycmVjdCBpbiBsaWdodCBjb2xvciBzY2hlbWUgCitQQVNTIEVsZW1lbnQgY29sb3JzIGFyZSBj b3JyZWN0IGluIGxpZ2h0IGNvbG9yIHNjaGVtZSB3aXRoIGJvb2xlYW4gY29udGV4dCBxdWVyeSAK IFBBU1MgRGFyayBjb2xvciBzY2hlbWUgZW5hYmxlZCAKIFBBU1MgRWxlbWVudCBjb2xvcnMgYXJl IGNvcnJlY3QgaW4gZGFyayBjb2xvciBzY2hlbWUgCitQQVNTIEVsZW1lbnQgY29sb3JzIGFyZSBj b3JyZWN0IGluIGRhcmsgY29sb3Igc2NoZW1lIHdpdGggYm9vbGVhbiBjb250ZXh0IHF1ZXJ5IAog CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jc3MtZGFyay1tb2RlL3ByZWZlcnMtY29sb3Itc2No ZW1lLmh0bWwgYi9MYXlvdXRUZXN0cy9jc3MtZGFyay1tb2RlL3ByZWZlcnMtY29sb3Itc2NoZW1l Lmh0bWwKaW5kZXggNTQyY2Y1ZTQwZDI2ODM1MmI4MzNmNzJkZjI1YzQzNjc4MTM5NDUwYy4uYzJj YmU3N2MzZWQzZTg4ZGMwODNlMTRmNWE4YWExYmFkOTNkMDBmYyAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvY3NzLWRhcmstbW9kZS9wcmVmZXJzLWNvbG9yLXNjaGVtZS5odG1sCisrKyBiL0xheW91 dFRlc3RzL2Nzcy1kYXJrLW1vZGUvcHJlZmVycy1jb2xvci1zY2hlbWUuaHRtbApAQCAtNiw3ICs2 LDcgQEAKIDxzY3JpcHQgc3JjPSIuLi9yZXNvdXJjZXMvdGVzdGhhcm5lc3NyZXBvcnQuanMiPjwv c2NyaXB0PgogCiA8c3R5bGU+Ci0jdGVzdDEgeworZGl2IHsKICAgICBiYWNrZ3JvdW5kLWNvbG9y OiByZWQ7CiAgICAgY29sb3I6IHRleHQ7CiB9CkBAIC0yMyw2ICsyMywxMyBAQAogICAgIH0KIH0K IAorQG1lZGlhIChwcmVmZXJzLWNvbG9yLXNjaGVtZTogbm8tcHJlZmVyZW5jZSkgeworICAgIC8q IFRoaXMgaXMgdmFsaWQsIGJ1dCBzaG91bGQgbm90IGFwcGx5IGZvciB1cyBzaW5jZSB0aGVyZSBp cyBubyBvcHRpb24gZm9yIG5vIHVzZXIgcHJlZmVyZW5jZS4gKi8KKyAgICAjdGVzdDEgeworICAg ICAgICBiYWNrZ3JvdW5kLWNvbG9yOiBjeWFuOworICAgIH0KK30KKwogQG1lZGlhIChwcmVmZXJz LWNvbG9yLXNjaGVtZTogZm9vKSB7CiAgICAgLyogVGhpcyBpcyBpbnZhbGlkIGFuZCBzaG91bGQg bm90IGFwcGx5LiAqLwogICAgICN0ZXN0MSB7CkBAIC0zMSwxNCArMzgsMTUgQEAKIH0KIAogQG1l ZGlhIChwcmVmZXJzLWNvbG9yLXNjaGVtZSkgewotICAgIC8qIFRoaXMgaXMgaW52YWxpZCBhbmQg c2hvdWxkIG5vdCBhcHBseS4gKi8KLSAgICAjdGVzdDEgewotICAgICAgICBiYWNrZ3JvdW5kLWNv bG9yOiBvcmFuZ2U7CisgICAgLyogVGhpcyBpcyB2YWxpZCBhbmQgc2hvdWxkIGFsd2F5cyBhcHBs eSBmb3IgdXMsIHNpbmNlIHRoZXJlIGlzIGFsd2F5cyBhIHVzZXIgcHJlZmVyZW5jZSBjdXJyZW50 bHkuICovCisgICAgI3Rlc3QyIHsKKyAgICAgICAgYmFja2dyb3VuZC1jb2xvcjogbGltZTsKICAg ICB9CiB9CiA8L3N0eWxlPgogCiA8ZGl2IGlkPSJ0ZXN0MSI+PC9kaXY+Cis8ZGl2IGlkPSJ0ZXN0 MiI+PC9kaXY+CiAKIDxzY3JpcHQ+CiBmdW5jdGlvbiB0ZXN0X3Byb3AoaWQsIHByb3AsIGV4cGVj dGVkKSB7CkBAIC01Myw2ICs2MSwxNCBAQCB0ZXN0KGZ1bmN0aW9uKCkgewogICAgIHRlc3RfcHJv cCgidGVzdDEiLCAiY29sb3IiLCAicmdiKDAsIDAsIDApIik7CiB9LCAiRWxlbWVudCBjb2xvcnMg YXJlIGNvcnJlY3QgaW4gbGlnaHQgY29sb3Igc2NoZW1lIik7CiAKK3Rlc3QoZnVuY3Rpb24oKSB7 CisgICAgLy8gU3R5bGVkIGJhY2tncm91bmQtY29sb3IgaW4gbWVkaWEgcXVlcnkgc2hvdWxkIGJl IGxpbWUgZ3JlZW4uCisgICAgdGVzdF9wcm9wKCJ0ZXN0MiIsICJiYWNrZ3JvdW5kLWNvbG9yIiwg InJnYigwLCAyNTUsIDApIik7CisKKyAgICAvLyBUaGUgc2VtYW50aWMgdGV4dCBjb2xvciBzaG91 bGQgYmUgYmxhY2suCisgICAgdGVzdF9wcm9wKCJ0ZXN0MiIsICJjb2xvciIsICJyZ2IoMCwgMCwg MCkiKTsKK30sICJFbGVtZW50IGNvbG9ycyBhcmUgY29ycmVjdCBpbiBsaWdodCBjb2xvciBzY2hl bWUgd2l0aCBib29sZWFuIGNvbnRleHQgcXVlcnkiKTsKKwogdGVzdChmdW5jdGlvbigpIHsKICAg ICBpZiAod2luZG93LmludGVybmFscykKICAgICAgICAgaW50ZXJuYWxzLnNldHRpbmdzLnNldFVz ZURhcmtBcHBlYXJhbmNlKHRydWUpOwpAQCAtNjUsNCArODEsMTIgQEAgdGVzdChmdW5jdGlvbigp IHsKICAgICAvLyBUaGUgc2VtYW50aWMgdGV4dCBjb2xvciBzaG91bGQgYmUgYmxhY2ssIGFuZCBu b3QgY2hhbmdlLgogICAgIHRlc3RfcHJvcCgidGVzdDEiLCAiY29sb3IiLCAicmdiKDAsIDAsIDAp Iik7CiB9LCAiRWxlbWVudCBjb2xvcnMgYXJlIGNvcnJlY3QgaW4gZGFyayBjb2xvciBzY2hlbWUi KTsKKwordGVzdChmdW5jdGlvbigpIHsKKyAgICAvLyBTdHlsZWQgYmFja2dyb3VuZC1jb2xvciBp biBtZWRpYSBxdWVyeSBzaG91bGQgYmUgbGltZSBncmVlbi4KKyAgICB0ZXN0X3Byb3AoInRlc3Qy IiwgImJhY2tncm91bmQtY29sb3IiLCAicmdiKDAsIDI1NSwgMCkiKTsKKworICAgIC8vIFRoZSBz ZW1hbnRpYyB0ZXh0IGNvbG9yIHNob3VsZCBiZSBibGFjay4KKyAgICB0ZXN0X3Byb3AoInRlc3Qy IiwgImNvbG9yIiwgInJnYigwLCAwLCAwKSIpOworfSwgIkVsZW1lbnQgY29sb3JzIGFyZSBjb3Jy ZWN0IGluIGRhcmsgY29sb3Igc2NoZW1lIHdpdGggYm9vbGVhbiBjb250ZXh0IHF1ZXJ5Iik7CiA8 L3NjcmlwdD4K