191642 2018-11-14 11:11:11 -0800 REGRESSION(r238178): fast/forms/access-key-mutated.html and fast/forms/access-key-case-insensitive.html are timing out 2018-11-15 09:47:42 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 191632 1 koivisto webkit-unassigned aboxhall apinheiro ap bfulgham cdumez cfleizach commit-queue dbates dmazzoni esprehn+autocc ews-watchlist jcraig jdiggs kangil.han ryanhaddad samuel_white simon.fraser tsavell webkit-bug-importer zalan oldest_to_newest 1478534 0 koivisto 2018-11-14 11:11:11 -0800 The changes in https://trac.webkit.org/changeset/238178/webkit has caused these two tests to begin timing out on MacOS Release WK2: fast/forms/access-key-mutated.html fast/forms/access-key-case-insensitive.html Repro Command: run-webkit-tests --root testbuild-238178 fast/forms/access-key-mutated.html fast/forms/access-key-case-insensitive.html --iterations 5 -f 1478553 1 tsavell 2018-11-14 11:39:48 -0800 additionally accessibility/mac/selection-notification-focus-change.html is also failing constantly now in those same configurations History https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=accessibility%2Fmac%2Fselection-notification-focus-change.html Diff: --- /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/accessibility/mac/selection-notification-focus-change-expected.txt +++ /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/accessibility/mac/selection-notification-focus-change-actual.txt @@ -7,9 +7,9 @@ eventSender.keyDown(tabCharacter); Received AXSelectedTextChanged PASS userInfo["AXTextSelectionChangedFocus"] is true +Received AXFocusChanged Received AXSelectedTextChanged PASS userInfo["AXTextSelectionChangedFocus"] is true -Received AXFocusChanged PASS accessibilityController.accessibleElementById("1").isFocusable is true accessibilityController.accessibleElementById("1").takeFocus() 1478556 2 koivisto 2018-11-14 11:47:25 -0800 Skipped that too in https://trac.webkit.org/r238189 1478559 3 tsavell 2018-11-14 11:49:00 -0800 Looks like this is going to effect debug too. fast/forms/access-key-case-insensitive.html and fast/forms/access-key-mutated.html shows a timeout on Sierra Debug WK2 1478564 4 koivisto 2018-11-14 11:53:41 -0800 The tests are skipped on all platforms 1478595 5 ryanhaddad 2018-11-14 13:38:59 -0800 (In reply to Antti Koivisto from comment #2) > Skipped that too in https://trac.webkit.org/r238189 Moved the skip to mac-wk2 in https://trac.webkit.org/r238194 (since accessibility/mac is marked as pass in platform/mac, r238189 didn't do anything). 1478800 6 354902 koivisto 2018-11-15 01:20:34 -0800 Created attachment 354902 patch 1478841 7 354902 commit-queue 2018-11-15 05:32:44 -0800 Comment on attachment 354902 patch Rejecting attachment 354902 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 354902, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: https://webkit-queues.webkit.org/results/10002856 1478849 8 koivisto 2018-11-15 05:58:18 -0800 https://trac.webkit.org/r238223 1478850 9 webkit-bug-importer 2018-11-15 05:59:29 -0800 <rdar://problem/46093834> 1478948 10 354902 simon.fraser 2018-11-15 09:47:42 -0800 Comment on attachment 354902 patch View in context: https://bugs.webkit.org/attachment.cgi?id=354902&action=review > Source/WebCore/dom/Document.cpp:1808 > + // FIXME: Why on earth is this here? This is clearly misplaced. > + invalidateAccessKeyMap(); Hahahah 354902 2018-11-15 01:20:34 -0800 2018-11-15 05:32:44 -0800 patch access-key-test-timeout-2.patch text/plain 4689 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzODIxOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE4LTExLTE1ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyMzgxNzgp OiBmYXN0L2Zvcm1zL2FjY2Vzcy1rZXktbXV0YXRlZC5odG1sIGFuZCBmYXN0L2Zvcm1zL2FjY2Vz cy1rZXktY2FzZS1pbnNlbnNpdGl2ZS5odG1sIGFyZSB0aW1pbmcgb3V0CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTE2NDIKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbnZhbGlkYXRlIGFjY2VzcyBrZXkg bWFwIGV2ZW4gd2hlbiB0aG9ydHRsaW5nIHN0eWxlIHJlY2FsY3MuCisKKyAgICAgICAgKiBkb20v RG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OnNjaGVkdWxlU3R5bGVS ZWNhbGMpOgorCiAyMDE4LTExLTE0ICBLZWl0aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4K IAogICAgICAgICBNb3ZlIHNjcmlwdHMgZm9yIERlcml2ZWQgYW5kIFVuaWZpZWQgU291cmNlcyB0 byBleHRlcm5hbCBmaWxlcwpJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCShyZXZpc2lvbiAy MzgyMTkpCisrKyBTb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0xODA0LDYgKzE4MDQsOSBAQCB2b2lkIERvY3VtZW50OjpzY2hlZHVsZVN0eWxlUmVjYWxj KCkKIAogICAgIEFTU0VSVChjaGlsZE5lZWRzU3R5bGVSZWNhbGMoKSB8fCBtX3BlbmRpbmdTdHls ZVJlY2FsY1Nob3VsZEZvcmNlKTsKIAorICAgIC8vIEZJWE1FOiBXaHkgb24gZWFydGggaXMgdGhp cyBoZXJlPyBUaGlzIGlzIGNsZWFybHkgbWlzcGxhY2VkLgorICAgIGludmFsaWRhdGVBY2Nlc3NL ZXlNYXAoKTsKKwogICAgIGF1dG8gc2hvdWxkVGhyb3R0bGVTdHlsZVJlY2FsYyA9IFsmXSB7CiAg ICAgICAgIGlmIChtX3BlbmRpbmdTdHlsZVJlY2FsY1Nob3VsZEZvcmNlKQogICAgICAgICAgICAg cmV0dXJuIGZhbHNlOwpAQCAtMTgxNyw5ICsxODIwLDYgQEAgdm9pZCBEb2N1bWVudDo6c2NoZWR1 bGVTdHlsZVJlY2FsYygpCiAgICAgaWYgKHNob3VsZFRocm90dGxlU3R5bGVSZWNhbGMoKSkKICAg ICAgICAgcmV0dXJuOwogCi0gICAgLy8gRklYTUU6IFdoeSBvbiBlYXJ0aCBpcyB0aGlzIGhlcmU/ IFRoaXMgaXMgY2xlYXJseSBtaXNwbGFjZWQuCi0gICAgaW52YWxpZGF0ZUFjY2Vzc0tleU1hcCgp OwotICAgIAogICAgIG1fc3R5bGVSZWNhbGNUaW1lci5zdGFydE9uZVNob3QoMF9zKTsKIAogICAg IEluc3BlY3Rvckluc3RydW1lbnRhdGlvbjo6ZGlkU2NoZWR1bGVTdHlsZVJlY2FsY3VsYXRpb24o KnRoaXMpOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMjM4MjE5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMTEtMTUgIEFudHRpIEtv aXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjIzODE3OCk6 IGZhc3QvZm9ybXMvYWNjZXNzLWtleS1tdXRhdGVkLmh0bWwgYW5kIGZhc3QvZm9ybXMvYWNjZXNz LWtleS1jYXNlLWluc2Vuc2l0aXZlLmh0bWwgYXJlIHRpbWluZyBvdXQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTY0MgorCisgICAgICAgICogVGVz dEV4cGVjdGF0aW9uczogVW5za2lwCisgICAgICAgICogcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhw ZWN0YXRpb25zOiBVbnNraXAKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMtd2syL2FjY2Vzc2liaWxp dHkvbWFjL3NlbGVjdGlvbi1ub3RpZmljYXRpb24tZm9jdXMtY2hhbmdlLWV4cGVjdGVkLnR4dDoK KworICAgICAgICBSZWJhc2UuIEZvY3VzIHRpbWluZ3MgZGVwZW5kcyBvbiBsYXlvdXQgdGltaW5n cy4KKwogMjAxOC0xMS0xNCAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+CiAK ICAgICAgICAgRGVmYXVsdCB0aGUgdmlldyBiYWNrZ3JvdW5kIGNvbG9yIGFuZCB0ZXh0IGNvbG9y IHRvIGRpZmZlcmVudCB2YWx1ZXMgd2hlbiBpbiBkYXJrIG1vZGUuCkluZGV4OiBMYXlvdXRUZXN0 cy9UZXN0RXhwZWN0YXRpb25zCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL1Rlc3RFeHBlY3Rh dGlvbnMJKHJldmlzaW9uIDIzODIxOSkKKysrIExheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMJ KHdvcmtpbmcgY29weSkKQEAgLTI5NTAsNiArMjk1MCwzIEBAIHdlYmtpdC5vcmcvYi8xOTAwMzIg aW1wb3J0ZWQvdzNjL3dlYi1wbGEKIGZhc3QvbWVkaWFjYXB0dXJlZnJvbWVsZW1lbnQvQ2FudmFz Q2FwdHVyZU1lZGlhU3RyZWFtLWltYWdlYml0bWFwcmVuZGVyaW5nY29udGV4dC5odG1sIFsgU2tp cCBdCiBmYXN0L21lZGlhY2FwdHVyZWZyb21lbGVtZW50L0NhbnZhc0NhcHR1cmVNZWRpYVN0cmVh bS1mcmFtZXJhdGUtMC5odG1sIFsgU2tpcCBdCiBmYXN0L21lZGlhY2FwdHVyZWZyb21lbGVtZW50 L0NhbnZhc0NhcHR1cmVNZWRpYVN0cmVhbS1jYXB0dXJlLW91dC1vZi1ET00tZWxlbWVudC5odG1s IFsgU2tpcCBdCi0KLXdlYmtpdC5vcmcvYi8xOTE2NDIgZmFzdC9mb3Jtcy9hY2Nlc3Mta2V5LWNh c2UtaW5zZW5zaXRpdmUuaHRtbCBbIFNraXAgXQotd2Via2l0Lm9yZy9iLzE5MTY0MiBmYXN0L2Zv cm1zL2FjY2Vzcy1rZXktbXV0YXRlZC5odG1sIFsgU2tpcCBdClwgTm8gbmV3bGluZSBhdCBlbmQg b2YgZmlsZQpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRp b25zCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvVGVzdEV4cGVj dGF0aW9ucwkocmV2aXNpb24gMjM4MjE5KQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdr Mi9UZXN0RXhwZWN0YXRpb25zCSh3b3JraW5nIGNvcHkpCkBAIC05MDcsNiArOTA3LDQgQEAgd2Vi a2l0Lm9yZy9iLzE4Mzg3OCBtZWRpYS9tb2Rlcm4tbWVkaWEtYwogCiB3ZWJraXQub3JnL2IvMTkx NjQ0IFsgU2llcnJhIF0gZmFzdC93b3JrZXJzL3dvcmtlci1jbG9uZXBvcnQuaHRtbCBbIFBhc3Mg RmFpbHVyZSBdCiAKLXdlYmtpdC5vcmcvYi8xOTE2NDIgYWNjZXNzaWJpbGl0eS9tYWMvc2VsZWN0 aW9uLW5vdGlmaWNhdGlvbi1mb2N1cy1jaGFuZ2UuaHRtbCBbIFNraXAgXQotCiB3ZWJraXQub3Jn L2IvMTkxNjU4IFsgU2llcnJhIFJlbGVhc2UgXSBmYXN0L2xheWVycy9uby1jbGlwcGluZy1vdmVy Zmxvdy1oaWRkZW4tYWRkZWQtYWZ0ZXItdHJhbnNmb3JtLmh0bWwgWyBQYXNzIEltYWdlT25seUZh aWx1cmUgXQpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9hY2Nlc3NpYmlsaXR5 L21hYy9zZWxlY3Rpb24tbm90aWZpY2F0aW9uLWZvY3VzLWNoYW5nZS1leHBlY3RlZC50eHQKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9hY2Nlc3NpYmlsaXR5L21h Yy9zZWxlY3Rpb24tbm90aWZpY2F0aW9uLWZvY3VzLWNoYW5nZS1leHBlY3RlZC50eHQJKHJldmlz aW9uIDIzODIxOSkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvYWNjZXNzaWJpbGl0 eS9tYWMvc2VsZWN0aW9uLW5vdGlmaWNhdGlvbi1mb2N1cy1jaGFuZ2UtZXhwZWN0ZWQudHh0CSh3 b3JraW5nIGNvcHkpCkBAIC03LDkgKzcsOSBAQCBQQVNTIHdlYkFyZWEuYWRkTm90aWZpY2F0aW9u TGlzdGVuZXIobm90CiBldmVudFNlbmRlci5rZXlEb3duKHRhYkNoYXJhY3Rlcik7CiBSZWNlaXZl ZCBBWFNlbGVjdGVkVGV4dENoYW5nZWQKIFBBU1MgdXNlckluZm9bIkFYVGV4dFNlbGVjdGlvbkNo YW5nZWRGb2N1cyJdIGlzIHRydWUKK1JlY2VpdmVkIEFYRm9jdXNDaGFuZ2VkCiBSZWNlaXZlZCBB WFNlbGVjdGVkVGV4dENoYW5nZWQKIFBBU1MgdXNlckluZm9bIkFYVGV4dFNlbGVjdGlvbkNoYW5n ZWRGb2N1cyJdIGlzIHRydWUKLVJlY2VpdmVkIEFYRm9jdXNDaGFuZ2VkCiAKIFBBU1MgYWNjZXNz aWJpbGl0eUNvbnRyb2xsZXIuYWNjZXNzaWJsZUVsZW1lbnRCeUlkKCIxIikuaXNGb2N1c2FibGUg aXMgdHJ1ZQogYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIuYWNjZXNzaWJsZUVsZW1lbnRCeUlkKCIx IikudGFrZUZvY3VzKCkK