191614 2018-11-13 17:32:42 -0800 [SOUP] Make Accept-Languages header look more like other browsers 2018-11-15 11:44:08 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro berto bugs-noreply cgarcia commit-queue ews-watchlist gustavo mcatanzaro oldest_to_newest 1478239 0 mcatanzaro 2018-11-13 17:32:42 -0800 Remove extra spaces from Accept-Languages header Firefox header: Accept-Language: en-US,en;q=0.7,es-ES;q=0.3 Chrome header: Accept-Language: en-US,en;q=0.9,es;q=0.8 Epiphany before: Accept-Language: en-us, en;q=0.90, es-es;q=0.80, es;q=0.70 Epiphany after: Accept-Language: en-us,en;q=0.90,es-es;q=0.80,es;q=0.70 (Probably should stop lowercasing it too, but that's Epiphany, not WebKit, doing that.) 1478248 1 354738 mcatanzaro 2018-11-13 17:42:59 -0800 Created attachment 354738 Patch 1478254 2 mcatanzaro 2018-11-13 17:54:06 -0800 (In reply to Michael Catanzaro from comment #0) > (Probably should stop lowercasing it too, but that's Epiphany, not WebKit, > doing that.) Actually we have redundant code in both Epiphany and WebKit to do this. I'm not sure why. Clearly other browsers do not downcase the languages. 1478271 3 354748 mcatanzaro 2018-11-13 18:26:06 -0800 Created attachment 354748 Patch 1478272 4 ews-watchlist 2018-11-13 18:29:50 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1478995 5 354748 commit-queue 2018-11-15 11:44:06 -0800 Comment on attachment 354748 Patch Clearing flags on attachment: 354748 Committed r238236: <https://trac.webkit.org/changeset/238236> 1478996 6 commit-queue 2018-11-15 11:44:08 -0800 All reviewed patches have been landed. Closing bug. 354738 2018-11-13 17:42:59 -0800 2018-11-13 18:26:04 -0800 Patch bug-191614-20181113194258.patch text/plain 1950 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4MTE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGJiMjhkNDFlNjAyMWNkYWI5 ZDlmMjM4ODE0MTIyZGM3NjYyNDEzZWEuLjcxODRjODgyM2U0YmQxZWM0MWE2YTQ1OWFjZTc0ZTA5 MWRmZTk0N2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjggQEAKKzIwMTgtMTEtMTMgIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtTT1VQXSBSZW1v dmUgZXh0cmEgc3BhY2VzIGZyb20gQWNjZXB0LUxhbmd1YWdlcyBoZWFkZXIKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTYxNAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgY2hhbmdlcyBvdXIgQWNj ZXB0LUxhbmd1YWdlIGhlYWRlciB0byBtYXRjaCBvdGhlciBicm93c2VycywgZnJvbSBzb21ldGhp bmcgbGlrZSB0aGlzOgorCisgICAgICAgIEFjY2VwdC1MYW5ndWFnZTogZW4tdXMsIGVuO3E9MC45 MCwgZXMtZXM7cT0wLjgwLCBlcztxPTAuNzAKKworICAgICAgICB0byBzb21ldGhpbmcgbGlrZSB0 aGlzOgorCisgICAgICAgIEFjY2VwdC1MYW5ndWFnZTogZW4tdXMsZW47cT0wLjkwLGVzLWVzO3E9 MC44MCxlcztxPTAuNzAKKworICAgICAgICBUaGVyZSdzIG5vIHBhcnRpY3VsYXIgbW90aXZhdGlv biBmb3IgdGhpcyBjaGFuZ2UuIEkganVzdCBub3RpY2VkIHdlIHdlcmUgZGlmZmVyZW50IGZvciBu bworICAgICAgICBwYXJ0aWN1bGFyIHJlYXNvbi4KKworICAgICAgICBJIHNlcmlvdXNseSBob3Bl IHRoaXMgY2hhbmdlIGJyZWFrcyBzb21lIGxheW91dCB0ZXN0cywgYXMgb3RoZXJ3aXNlIHRoYXQg aW5kaWNhdGVzCisgICAgICAgIGluYWRlcXVhdGUgdGVzdCBjb3ZlcmFnZS4gU2luY2UgcnVubmlu ZyB0ZXN0cyBsb2NhbGx5IGlzIHVuZm9ydHVuYXRlbHkgbm90IHlldCByZWFsaXN0aWMsCisgICAg ICAgIEknbGwganVzdCBoYXZlIHRvIHdhdGNoIHRoZSBib3RzIHdoZW4gdGhpcyBsYW5kcy4KKwor ICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL3NvdXAvTmV0d29ya1Byb2Nlc3NTb3VwLmNwcDoKKyAg ICAgICAgKFdlYktpdDo6YnVpbGRBY2NlcHRMYW5ndWFnZXMpOgorCiAyMDE4LTExLTEyICBBbGV4 IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW2lPU10g SW1wbGVtZW50IHNhZmUgYnJvd3NpbmcgaW4gV2ViS2l0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L05ldHdvcmtQcm9jZXNzL3NvdXAvTmV0d29ya1Byb2Nlc3NTb3VwLmNwcCBiL1NvdXJjZS9X ZWJLaXQvTmV0d29ya1Byb2Nlc3Mvc291cC9OZXR3b3JrUHJvY2Vzc1NvdXAuY3BwCmluZGV4IDU5 YmZlMjg1NzRkYmQxNjJlODkwMWM0ZTQ1MmMwNTE2YWViOWFjOWQuLmQ5MGM3M2ViZjZhNmNmMjA1 ZWUxNzM2ZTBiMDAyZTJlMjE4NzhhM2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29y a1Byb2Nlc3Mvc291cC9OZXR3b3JrUHJvY2Vzc1NvdXAuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQv TmV0d29ya1Byb2Nlc3Mvc291cC9OZXR3b3JrUHJvY2Vzc1NvdXAuY3BwCkBAIC03Niw3ICs3Niw3 IEBAIHN0YXRpYyBDU3RyaW5nIGJ1aWxkQWNjZXB0TGFuZ3VhZ2VzKGNvbnN0IFZlY3RvcjxTdHJp bmc+JiBsYW5ndWFnZXMpCiAgICAgICAgICAgICBjb250aW51ZTsKIAogICAgICAgICBpZiAoaSkK LSAgICAgICAgICAgIGJ1aWxkZXIuYXBwZW5kTGl0ZXJhbCgiLCAiKTsKKyAgICAgICAgICAgIGJ1 aWxkZXIuYXBwZW5kTGl0ZXJhbCgiLCIpOwogCiAgICAgICAgIGJ1aWxkZXIuYXBwZW5kKGxhbmd1 YWdlc1tpXSk7CiAK 354748 2018-11-13 18:26:06 -0800 2018-11-15 11:44:06 -0800 Patch bug-191614-20181113202605.patch text/plain 2825 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4MTE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGJiMjhkNDFlNjAyMWNkYWI5 ZDlmMjM4ODE0MTIyZGM3NjYyNDEzZWEuLmM1NWQyMDY1ZTBiYWY2NDBjY2Y0NmY0YjlmOGFhYjIz ZTcxNDQ2ZDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcgQEAKKzIwMTgtMTEtMTMgIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtTT1VQXSBNYWtl IEFjY2VwdC1MYW5ndWFnZXMgaGVhZGVyIGxvb2sgbW9yZSBsaWtlIG90aGVyIGJyb3dzZXJzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTE2MTQKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGNoYW5n ZXMgb3VyIEFjY2VwdC1MYW5ndWFnZSBoZWFkZXIgdG8gYmV0dGVyIG1hdGNoIG90aGVyIGJyb3dz ZXJzLCBmcm9tIHNvbWV0aGluZworICAgICAgICBsaWtlIHRoaXM6CisKKyAgICAgICAgQWNjZXB0 LUxhbmd1YWdlOiBlbi11cywgZW47cT0wLjkwLCBlcy1lcztxPTAuODAsIGVzO3E9MC43MAorCisg ICAgICAgIHRvIHNvbWV0aGluZyBsaWtlIHRoaXM6CisKKyAgICAgICAgQWNjZXB0LUxhbmd1YWdl OiBlbi1VUyxlbjtxPTAuOTAsZXMtRVM7cT0wLjgwLGVzO3E9MC43MAorCisgICAgICAgIFRoZXJl J3Mgbm8gcGFydGljdWxhciBtb3RpdmF0aW9uIGZvciB0aGlzIGNoYW5nZS4gSSBqdXN0IG5vdGlj ZWQgd2Ugd2VyZSBkaWZmZXJlbnQgZm9yIG5vCisgICAgICAgIGNsZWFyIHJlYXNvbi4KKworICAg ICAgICAqIE5ldHdvcmtQcm9jZXNzL3NvdXAvTmV0d29ya1Byb2Nlc3NTb3VwLmNwcDoKKyAgICAg ICAgKFdlYktpdDo6YnVpbGRBY2NlcHRMYW5ndWFnZXMpOgorICAgICAgICAqIFVJUHJvY2Vzcy9B UEkvZ2xpYi9XZWJLaXRXZWJDb250ZXh0LmNwcDoKKyAgICAgICAgKHdlYmtpdF93ZWJfY29udGV4 dF9zZXRfcHJlZmVycmVkX2xhbmd1YWdlcyk6CisKIDIwMTgtMTEtMTIgIEFsZXggQ2hyaXN0ZW5z ZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBbaU9TXSBJbXBsZW1lbnQg c2FmZSBicm93c2luZyBpbiBXZWJLaXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29y a1Byb2Nlc3Mvc291cC9OZXR3b3JrUHJvY2Vzc1NvdXAuY3BwIGIvU291cmNlL1dlYktpdC9OZXR3 b3JrUHJvY2Vzcy9zb3VwL05ldHdvcmtQcm9jZXNzU291cC5jcHAKaW5kZXggNTliZmUyODU3NGRi ZDE2MmU4OTAxYzRlNDUyYzA1MTZhZWI5YWM5ZC4uZDkwYzczZWJmNmE2Y2YyMDVlZTE3MzZlMGIw MDJlMmUyMTg3OGEzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9z b3VwL05ldHdvcmtQcm9jZXNzU291cC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJv Y2Vzcy9zb3VwL05ldHdvcmtQcm9jZXNzU291cC5jcHAKQEAgLTc2LDcgKzc2LDcgQEAgc3RhdGlj IENTdHJpbmcgYnVpbGRBY2NlcHRMYW5ndWFnZXMoY29uc3QgVmVjdG9yPFN0cmluZz4mIGxhbmd1 YWdlcykKICAgICAgICAgICAgIGNvbnRpbnVlOwogCiAgICAgICAgIGlmIChpKQotICAgICAgICAg ICAgYnVpbGRlci5hcHBlbmRMaXRlcmFsKCIsICIpOworICAgICAgICAgICAgYnVpbGRlci5hcHBl bmRMaXRlcmFsKCIsIik7CiAKICAgICAgICAgYnVpbGRlci5hcHBlbmQobGFuZ3VhZ2VzW2ldKTsK IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0V2Vi Q29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRXZWJD b250ZXh0LmNwcAppbmRleCAzMmNlMDZjODM0Njg2YzViYmM2NTE4MTcyMGM5MzM1NWYwMTYxM2Ey Li4zOWYzYzA4NTIzN2I1MDkwMzNlOTFlZTE1NDdjYmI0YzMwZGMwZDU0IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRXZWJDb250ZXh0LmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRXZWJDb250ZXh0LmNwcApA QCAtMTMxMiw5ICsxMzEyLDkgQEAgdm9pZCB3ZWJraXRfd2ViX2NvbnRleHRfc2V0X3ByZWZlcnJl ZF9sYW5ndWFnZXMoV2ViS2l0V2ViQ29udGV4dCogY29udGV4dCwgY29uc3QKICAgICBmb3IgKHNp emVfdCBpID0gMDsgbGFuZ3VhZ2VMaXN0W2ldOyArK2kpIHsKICAgICAgICAgLy8gRG8gbm90IHBy b3BhZ2F0ZSB0aGUgQyBsb2NhbGUgdG8gV2ViQ29yZS4KICAgICAgICAgaWYgKCFnX2FzY2lpX3N0 cmNhc2VjbXAobGFuZ3VhZ2VMaXN0W2ldLCAiQyIpIHx8ICFnX2FzY2lpX3N0cmNhc2VjbXAobGFu Z3VhZ2VMaXN0W2ldLCAiUE9TSVgiKSkKLSAgICAgICAgICAgIGxhbmd1YWdlcy5hcHBlbmQoImVu LXVzIl9zKTsKKyAgICAgICAgICAgIGxhbmd1YWdlcy5hcHBlbmQoImVuLVVTIl9zKTsKICAgICAg ICAgZWxzZQotICAgICAgICAgICAgbGFuZ3VhZ2VzLmFwcGVuZChTdHJpbmc6OmZyb21VVEY4KGxh bmd1YWdlTGlzdFtpXSkuY29udmVydFRvQVNDSUlMb3dlcmNhc2UoKS5yZXBsYWNlKCJfIiwgIi0i KSk7CisgICAgICAgICAgICBsYW5ndWFnZXMuYXBwZW5kKFN0cmluZzo6ZnJvbVVURjgobGFuZ3Vh Z2VMaXN0W2ldKS5yZXBsYWNlKCJfIiwgIi0iKSk7CiAgICAgfQogICAgIG92ZXJyaWRlVXNlclBy ZWZlcnJlZExhbmd1YWdlcyhsYW5ndWFnZXMpOwogfQo=