<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>191613</bug_id>
          
          <creation_ts>2018-11-13 17:17:27 -0800</creation_ts>
          <short_desc>Create feature flag (HTTPS_UPGRADE)</short_desc>
          <delta_ts>2018-11-15 15:17:31 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Page Loading</component>
          <version>Other</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Vivek Seth">v_seth</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>beidson</cc>
    
    <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dino</cc>
    
    <cc>don.olmstead</cc>
    
    <cc>ggaren</cc>
    
    <cc>jberlin</cc>
    
    <cc>v_seth</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1478232</commentid>
    <comment_count>0</comment_count>
    <who name="Vivek Seth">v_seth</who>
    <bug_when>2018-11-13 17:17:27 -0800</bug_when>
    <thetext>Create feature flag (HTTPS_UPGRADE)

rdar://45851068</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1478704</commentid>
    <comment_count>1</comment_count>
      <attachid>354874</attachid>
    <who name="Vivek Seth">v_seth</who>
    <bug_when>2018-11-14 17:00:21 -0800</bug_when>
    <thetext>Created attachment 354874
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1479003</commentid>
    <comment_count>2</comment_count>
      <attachid>354874</attachid>
    <who name="Dean Jackson">dino</who>
    <bug_when>2018-11-15 11:55:52 -0800</bug_when>
    <thetext>Comment on attachment 354874
Patch

rs=me, but we usually do this when we start to use the flag somewhere.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1479092</commentid>
    <comment_count>3</comment_count>
      <attachid>354874</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-11-15 13:58:22 -0800</bug_when>
    <thetext>Comment on attachment 354874
Patch

Clearing flags on attachment: 354874

Committed r238249: &lt;https://trac.webkit.org/changeset/238249&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1479093</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-11-15 13:58:24 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1479095</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-11-15 13:59:32 -0800</bug_when>
    <thetext>&lt;rdar://problem/46107188&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1479146</commentid>
    <comment_count>6</comment_count>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2018-11-15 15:17:31 -0800</bug_when>
    <thetext>(In reply to Dean Jackson from comment #2)
&gt; Comment on attachment 354874 [details]
&gt; Patch
&gt; 
&gt; rs=me, but we usually do this when we start to use the flag somewhere.

We&apos;ve been really bad about keeping feature flags up to date with CMake and this patch doesn&apos;t include anything. Just noting for a followup when things actually do start appearing.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>354874</attachid>
            <date>2018-11-14 17:00:21 -0800</date>
            <delta_ts>2018-11-15 13:58:22 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-191613-20181114170020.patch</filename>
            <type>text/plain</type>
            <size>1001</size>
            <attacher name="Vivek Seth">v_seth</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4MTUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGI3MzRmOTVhMjNiMDkzOTRj
MDA0YzBmNTVkN2QyYzM4NmI5ZTg4ZGIuLmU5MDZiNThjMGI1NWM1MjAwNGNiMWRjNjliZGJiNmE4
NmUxNDE1N2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMTEtMTQgIFZpdmVrIFNl
dGggIDx2X3NldGhAYXBwbGUuY29tPgorCisgICAgICAgIENyZWF0ZSBmZWF0dXJlIGZsYWcgKEhU
VFBTX1VQR1JBREUpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn
aT9pZD0xOTE2MTMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ1ODUxMDY4PgorCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogY29uZmlnLmg6CisKIDIw
MTgtMTEtMTMgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAg
ICAgW2lPU10gRG8gbm90IHNob3cgc2VsZWN0aW9uIFVJIGZvciBlZGl0YWJsZSBlbGVtZW50cyB3
aXRoIG9wYWNpdHkgbmVhciB6ZXJvCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2NvbmZpZy5o
IGIvU291cmNlL1dlYktpdC9jb25maWcuaAppbmRleCBkYTJmMGQwMWM4ZDA4M2FkNGQxZmY1ZGIy
ZDY2ZDE5MzhjOWNjNjc1Li4zODMzMWM2ODZjNDBlMGVjNzY2M2Y2ZWI3MzM0NTEzMzNjYmUwZmI5
IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2NvbmZpZy5oCisrKyBiL1NvdXJjZS9XZWJLaXQv
Y29uZmlnLmgKQEAgLTEyNCwzICsxMjQsNyBAQAogI2Vsc2UKICNkZWZpbmUgSEFWRV9TQUZFX0JS
T1dTSU5HIDAKICNlbmRpZgorCisjaWZuZGVmIEVOQUJMRV9IVFRQU19VUEdSQURFCisjZGVmaW5l
IEVOQUJMRV9IVFRQU19VUEdSQURFIDAKKyNlbmRpZgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>