191593 2018-11-13 12:21:51 -0800 [WinCairo][WebKitTestRunner] Test contents window is displayed while testing. 2018-11-19 17:58:41 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Windows 10 RESOLVED FIXED InRadar P2 Normal --- 1 basuke webkit-unassigned achristensen basuke bfulgham commit-queue fujii lforschler pvollan takashi.komori oldest_to_newest 1478094 0 basuke 2018-11-13 12:21:51 -0800 It doesn't displayed on DumpRenderTree. 1478095 1 basuke 2018-11-13 12:25:46 -0800 I don't know Windows detail, but also process is visible in task bar. 1479322 2 355037 takashi.komori 2018-11-16 02:49:08 -0800 Created attachment 355037 Patch 1479323 3 takashi.komori 2018-11-16 02:54:14 -0800 DumpRenderTree displays test window in out of display area. (x<0, y<0) This patch does same thing. 1479328 4 takashi.komori 2018-11-16 03:24:34 -0800 We can hide taskbar button by specifying WS_EX_TOOLWINDOW as argument of CreateWindowEX. 1479461 5 355037 basuke 2018-11-16 09:57:08 -0800 Comment on attachment 355037 Patch LGTM 1479554 6 355037 commit-queue 2018-11-16 12:18:57 -0800 Comment on attachment 355037 Patch Clearing flags on attachment: 355037 Committed r238296: <https://trac.webkit.org/changeset/238296> 1479555 7 commit-queue 2018-11-16 12:18:58 -0800 All reviewed patches have been landed. Closing bug. 1479631 8 webkit-bug-importer 2018-11-16 14:36:44 -0800 <rdar://problem/46140101> 1479648 9 fujii 2018-11-16 14:45:55 -0800 This isn’t right fix. I’ll fix the next week. 1479783 10 basuke 2018-11-16 18:07:46 -0800 (In reply to Fujii Hironori from comment #9) > This isn’t right fix. I’ll fix the next week. Komori-san said this is what DumpRenderTree does, please fix that also if this isn't the right fix. 1480128 11 fujii 2018-11-18 21:58:47 -0800 (In reply to Basuke Suzuki from comment #10) > Komori-san said this is what DumpRenderTree does, please fix that also if > this isn't the right fix. I didn't know that. I wanted to hide the window by not calling ShowWindow. I will do it another bug. 1480346 12 355303 takashi.komori 2018-11-19 17:56:35 -0800 Created attachment 355303 Patch If we don't want to call ShowWindow, we have to send WM_PAINT message to webview because BitBlt doesn't work to hidden window. 1480347 13 takashi.komori 2018-11-19 17:58:41 -0800 WM_PAINT is wrong. WM_PRINT 355037 2018-11-16 02:49:08 -0800 2018-11-16 12:18:57 -0800 Patch bug-191593-20181116194714.patch text/plain 1818 takashi.komori U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4MjYxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWRkYTMzNzg1M2M0ODE5ZmMzMWRiOTQwMjM2MTZjZWEy NzM0OTBmMC4uNjUyNDIwNWYxODhmZjAxMTI2NzM2MWZlNmFkODA0OWJhYzBjNDhlMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE4LTExLTE2ICBUYWthc2hpIEtvbW9yaSAgPFRha2FzaGkuS29tb3JpQHNvbnkuY29t PgorCisgICAgICAgIFtXaW5DYWlyb11bV2ViS2l0VGVzdFJ1bm5lcl0gVGVzdCBjb250ZW50cyB3 aW5kb3cgaXMgZGlzcGxheWVkIHdoaWxlIHRlc3RpbmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTE1OTMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBIaWRlIFRlc3RSdW5uZXIgd2luZG93IGFuZCB0YXNr YmFyIGJ1dHRvbi4KKworICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvd2luL1BsYXRmb3JtV2Vi Vmlld1dpbi5jcHA6CisgICAgICAgIChXVFI6OlBsYXRmb3JtV2ViVmlldzo6UGxhdGZvcm1XZWJW aWV3KToKKyAgICAgICAgKFdUUjo6UGxhdGZvcm1XZWJWaWV3Ojp3aW5kb3dTbmFwc2hvdEltYWdl KToKKwogMjAxOC0xMS0xNSAgQWFrYXNoIEphaW4gIDxhYWthc2hfamFpbkBhcHBsZS5jb20+CiAK ICAgICAgICAgSW5jcmVhc2UgRVdTIGxvY2sgdGltZW91dCB0byAzIGhvdXJzCmRpZmYgLS1naXQg YS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL3dpbi9QbGF0Zm9ybVdlYlZpZXdXaW4uY3BwIGIvVG9v bHMvV2ViS2l0VGVzdFJ1bm5lci93aW4vUGxhdGZvcm1XZWJWaWV3V2luLmNwcAppbmRleCA0Zjkz YjNiMmViZTQyNTIwZWEwYTg1Y2ZjZTI5MmI2MDdlNTJmM2RlLi5mZGM1MDQ5ODFjMjgyZDRjOTYx OTVlNTM4NTNkMDgyZDI3NTJkNmE4IDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVy L3dpbi9QbGF0Zm9ybVdlYlZpZXdXaW4uY3BwCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIv d2luL1BsYXRmb3JtV2ViVmlld1dpbi5jcHAKQEAgLTY5LDEyICs2OSwxMiBAQCBQbGF0Zm9ybVdl YlZpZXc6OlBsYXRmb3JtV2ViVmlldyhXS1BhZ2VDb25maWd1cmF0aW9uUmVmIGNvbmZpZ3VyYXRp b24sIGNvbnN0IFRlcwogCiAgICAgUkVDVCB2aWV3UmVjdCA9IHswLCAwLCA4MDAsIDYwMH07CiAg ICAgbV93aW5kb3cgPSA6OkNyZWF0ZVdpbmRvd0V4KAotICAgICAgICAwLAorICAgICAgICBXU19F WF9UT09MV0lORE9XLAogICAgICAgICBob3N0V2luZG93Q2xhc3NOYW1lLAogICAgICAgICB0ZXN0 UnVubmVyV2luZG93TmFtZSwKICAgICAgICAgV1NfT1ZFUkxBUFBFRFdJTkRPVywKLSAgICAgICAg MCwKLSAgICAgICAgMCwKKyAgICAgICAgLXZpZXdSZWN0LnJpZ2h0LAorICAgICAgICAtdmlld1Jl Y3QuYm90dG9tLAogICAgICAgICB2aWV3UmVjdC5yaWdodCwKICAgICAgICAgdmlld1JlY3QuYm90 dG9tLAogICAgICAgICAwLApAQCAtMjE4LDYgKzIxOCw3IEBAIGNhaXJvX3N1cmZhY2VfdCogUGxh dGZvcm1XZWJWaWV3Ojp3aW5kb3dTbmFwc2hvdEltYWdlKCkKICAgICBpZiAoIWJpdG1hcCkKICAg ICAgICAgcmV0dXJuIG51bGxwdHI7CiAKKyAgICA6OkludmFsaWRhdGVSZWN0KG1fd2luZG93LCBu dWxscHRyLCB0cnVlKTsKICAgICA6OlNlbGVjdE9iamVjdChtZW1vcnlEQy5nZXQoKSwgYml0bWFw LmdldCgpKTsKICAgICA6OkJpdEJsdChtZW1vcnlEQy5nZXQoKSwKICAgICAgICAgMCwK 355303 2018-11-19 17:56:35 -0800 2018-11-19 17:56:35 -0800 Patch not-to-call-showwindow.path text/plain 1115 takashi.komori ZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvd2luL1BsYXRmb3JtV2ViVmlld1dp bi5jcHAgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL3dpbi9QbGF0Zm9ybVdlYlZpZXdXaW4uY3Bw CmluZGV4IGZkYzUwNDk4MWMyLi4wNDIzYWY1NzZkNCAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0 VGVzdFJ1bm5lci93aW4vUGxhdGZvcm1XZWJWaWV3V2luLmNwcAorKysgYi9Ub29scy9XZWJLaXRU ZXN0UnVubmVyL3dpbi9QbGF0Zm9ybVdlYlZpZXdXaW4uY3BwCkBAIC04Myw4ICs4Myw2IEBAIFBs YXRmb3JtV2ViVmlldzo6UGxhdGZvcm1XZWJWaWV3KFdLUGFnZUNvbmZpZ3VyYXRpb25SZWYgY29u ZmlndXJhdGlvbiwgY29uc3QgVGVzCiAgICAgICAgIDApOwogICAgIG1fdmlldyA9IFdLVmlld0Ny ZWF0ZSh2aWV3UmVjdCwgY29uZmlndXJhdGlvbiwgbV93aW5kb3cpOwogICAgIFdLVmlld1NldElz SW5XaW5kb3cobV92aWV3LCB0cnVlKTsKLQotICAgIFNob3dXaW5kb3cobV93aW5kb3csIFNXX1NI T1cpOwogfQogCiBQbGF0Zm9ybVdlYlZpZXc6On5QbGF0Zm9ybVdlYlZpZXcoKQpAQCAtMjIwLDE1 ICsyMTgsNyBAQCBjYWlyb19zdXJmYWNlX3QqIFBsYXRmb3JtV2ViVmlldzo6d2luZG93U25hcHNo b3RJbWFnZSgpCiAKICAgICA6OkludmFsaWRhdGVSZWN0KG1fd2luZG93LCBudWxscHRyLCB0cnVl KTsKICAgICA6OlNlbGVjdE9iamVjdChtZW1vcnlEQy5nZXQoKSwgYml0bWFwLmdldCgpKTsKLSAg ICA6OkJpdEJsdChtZW1vcnlEQy5nZXQoKSwKLSAgICAgICAgMCwKLSAgICAgICAgMCwKLSAgICAg ICAgd2lkdGgsCi0gICAgICAgIGhlaWdodCwKLSAgICAgICAgd2luZG93REMsCi0gICAgICAgIDAs Ci0gICAgICAgIDAsCi0gICAgICAgIFNSQ0NPUFkpOworICAgIDo6U2VuZE1lc3NhZ2UoV0tWaWV3 R2V0V2luZG93KG1fdmlldyksIFdNX1BSSU5ULCByZWludGVycHJldF9jYXN0PFdQQVJBTT4obWVt b3J5REMuZ2V0KCkpLCBQUkZfQ0xJRU5UIHwgUFJGX0NISUxEUkVOIHwgUFJGX09XTkVEKTsKIAog ICAgIEJJVE1BUCBiaXRtYXBUYWcgPSB7MH07CiAgICAgR2V0T2JqZWN0KGJpdG1hcC5nZXQoKSwg c2l6ZW9mKGJpdG1hcFRhZyksICZiaXRtYXBUYWcpOwo=