191582 2018-11-13 01:36:32 -0800 [curl] warning: delete called on non-final 'WebCore::CurlDownload' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] 2018-11-15 17:38:36 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii achristensen basuke commit-queue don.olmstead ews-watchlist galpeter webkit-bug-importer oldest_to_newest 1477944 0 fujii 2018-11-13 01:36:32 -0800 clang-cl reports following compilation warnings while building WinCairo port. > [5002/6237] Building CXX object Source\WebCore\CMakeFiles\WebCore.dir\platform\network\curl\CurlDownload.cpp.obj > In file included from ..\..\Source\WebCore\platform\network\curl\CurlDownload.cpp:29: > In file included from ..\..\Source\WebCore\platform\network\curl/CurlDownload.h:32: > In file included from ..\..\Source\WebCore\platform\network\curl/CurlRequest.h:32: > In file included from ..\..\Source\WebCore\platform\network\curl/CurlRequestSchedulerClient.h:17: > In file included from ..\..\Source\WebCore\platform\network\curl/CurlContext.h:30: > In file included from ..\..\Source\WebCore\platform\network\curl/CurlSSLHandle.h:30: > In file included from ..\..\WebKitLibraries\win\include\openssl/crypto.h:129: > ..\..\WebKitLibraries\win\include\openssl/ossl_typ.h(86,9): warning: Warning, overriding WinCrypt defines [-W#pragma-messages] > #pragma message("Warning, overriding WinCrypt defines") > ^ > In file included from ..\..\Source\WebCore\platform\network\curl\CurlDownload.cpp:29: > In file included from ..\..\Source\WebCore\platform\network\curl/CurlDownload.h:32: > In file included from ..\..\Source\WebCore\platform\network\curl/CurlRequest.h:29: > In file included from ..\..\Source\WebCore\platform\network\curl/CurlFormDataStream.h:30: > In file included from ..\..\Source\WebCore\platform\network/FormData.h:22: > In file included from ..\..\Source\WebCore\platform\network/BlobData.h:35: > In file included from ..\..\Source\WebCore\platform\ThreadSafeDataBuffer.h:28: > DerivedSources\ForwardingHeaders\wtf/ThreadSafeRefCounted.h(76,13): warning: delete called on non-final 'WebCore::CurlDownload' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] > delete static_cast<const T*>(this); > ^ > ..\..\Source\WebCore\platform\network\curl/CurlDownload.h(56,65): note: in instantiation of member function 'WTF::ThreadSafeRefCounted<WebCore::CurlDownload, WTF::DestructionThread::Any>::deref' requested here > void deref() override { ThreadSafeRefCounted<CurlDownload>::deref(); } > ^ > In file included from ..\..\Source\WebCore\platform\network\curl\CurlDownload.cpp:29: > In file included from ..\..\Source\WebCore\platform\network\curl/CurlDownload.h:32: > In file included from ..\..\Source\WebCore\platform\network\curl/CurlRequest.h:29: > In file included from ..\..\Source\WebCore\platform\network\curl/CurlFormDataStream.h:30: > In file included from ..\..\Source\WebCore\platform\network/FormData.h:22: > In file included from ..\..\Source\WebCore\platform\network/BlobData.h:35: > In file included from ..\..\Source\WebCore\platform\ThreadSafeDataBuffer.h:28: > DerivedSources\ForwardingHeaders\wtf/ThreadSafeRefCounted.h(80,13): warning: delete called on non-final 'WebCore::CurlDownload' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] > delete static_cast<const T*>(this); > ^ > 3 warnings generated. > [5019/6237] Building CXX object Source\WebCore\CMakeFiles\WebCore.dir\platform\network\curl\NetworkStorageSessionCurl.cpp.obj > In file included from ..\..\Source\WebCore\platform\network\curl\NetworkStorageSessionCurl.cpp:35: > In file included from ..\..\Source\WebCore\platform\network\curl/CurlContext.h:30: > In file included from ..\..\Source\WebCore\platform\network\curl/CurlSSLHandle.h:30: > In file included from ..\..\WebKitLibraries\win\include\openssl/crypto.h:129: > ..\..\WebKitLibraries\win\include\openssl/ossl_typ.h(86,9): warning: Warning, overriding WinCrypt defines [-W#pragma-messages] > #pragma message("Warning, overriding WinCrypt defines") > ^ > In file included from ..\..\Source\WebCore\platform\network\curl\NetworkStorageSessionCurl.cpp:26: > In file included from ..\..\Source\WebCore\config.h:51: > In file included from DerivedSources\ForwardingHeaders\wtf/FastMalloc.h:25: > In file included from DerivedSources\ForwardingHeaders\wtf/StdLibExtras.h:30: > C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.14.26428\include\memory(2055,3): warning: delete called on non-final 'WebCore::CookieJarCurlDatabase' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] > delete _Ptr; > ^ > C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.14.26428\include\memory(2267,4): note: in instantiation of member function 'std::default_delete<WebCore::CookieJarCurlDatabase>::operator()' requested here > this->get_deleter()(get()); > ^ > DerivedSources\ForwardingHeaders\wtf/UniqueRef.h(33,28): note: in instantiation of member function 'std::unique_ptr<WebCore::CookieJarCurlDatabase, std::default_delete<WebCore::CookieJarCurlDatabase> >::~unique_ptr' requested here > template<typename T> class UniqueRef; > ^ > In file included from ..\..\Source\WebCore\platform\network\curl\NetworkStorageSessionCurl.cpp:26: > In file included from ..\..\Source\WebCore\config.h:51: > In file included from DerivedSources\ForwardingHeaders\wtf/FastMalloc.h:25: > In file included from DerivedSources\ForwardingHeaders\wtf/StdLibExtras.h:30: > C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.14.26428\include\memory(2055,3): warning: delete called on 'WebCore::CookieJarCurl' that is abstract but has non-virtual destructor [-Wdelete-non-virtual-dtor] > delete _Ptr; > ^ > C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.14.26428\include\memory(2267,4): note: in instantiation of member function 'std::default_delete<WebCore::CookieJarCurl>::operator()' requested here > this->get_deleter()(get()); > ^ > DerivedSources\ForwardingHeaders\wtf/UniqueRef.h(42,7): note: in instantiation of member function 'std::unique_ptr<WebCore::CookieJarCurl, std::default_delete<WebCore::CookieJarCurl> >::~unique_ptr' requested here > class UniqueRef { > ^ > 3 warnings generated. 1477945 1 354660 fujii 2018-11-13 01:43:54 -0800 Created attachment 354660 Patch 1478038 2 354660 don.olmstead 2018-11-13 09:57:20 -0800 Comment on attachment 354660 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354660&action=review I'm honestly wondering why there's a CookieJarCurl at all. There's no cpp file and I just see an implementation in CookieJarCurlDatabase. Maybe this should just be collapsed? > Source/WebCore/platform/network/curl/CookieJarCurl.h:39 > + virtual ~CookieJarCurl() { } = default 1478068 3 basuke 2018-11-13 10:56:07 -0800 (In reply to Don Olmstead from comment #2) > Comment on attachment 354660 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=354660&action=review > > I'm honestly wondering why there's a CookieJarCurl at all. There's no cpp > file and I just see an implementation in CookieJarCurlDatabase. Maybe this > should just be collapsed? This must be the left over of cookie backend abstraction. It had been a file based storage and when the introduction of sqlite based backend, the clients, such as NetworkStorageSession, just used interface to communicate with backend. I agree with removing this abstraction because we already took out the file based backend. 1478801 4 fujii 2018-11-15 01:25:38 -0800 (In reply to Basuke Suzuki from comment #3) > I agree with removing this abstraction because we already took out the file > based backend. I did it. Bug 191620 – [curl] Unify CookieJarCurlDatabase and the abstract class CookieJarCurl 1478802 5 354903 fujii 2018-11-15 01:33:49 -0800 Created attachment 354903 Patch 1479198 6 354903 commit-queue 2018-11-15 17:37:47 -0800 Comment on attachment 354903 Patch Clearing flags on attachment: 354903 Committed r238263: <https://trac.webkit.org/changeset/238263> 1479199 7 commit-queue 2018-11-15 17:37:49 -0800 All reviewed patches have been landed. Closing bug. 1479200 8 webkit-bug-importer 2018-11-15 17:38:36 -0800 <rdar://problem/46114410> 354660 2018-11-13 01:43:54 -0800 2018-11-15 01:33:13 -0800 Patch bug-191582-20181113184353.patch text/plain 2652 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4MTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWUyZjMxMDM0NDA2MDkz YTEzYWY0MjdkOTY0ODMwOTc4ZDZmNTJmNy4uZTdiMGRmZDY5ZmRkY2E3NzExM2U1MjY2NWM5ZDUx YTE1NzgzY2ZjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTExLTEzICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtjdXJsXSBD dXJsRG93bmxvYWQgYW5kIENvb2tpZUphckN1cmw6IHdhcm5pbmc6IGRlbGV0ZSBjYWxsZWQgb24g bm9uLWZpbmFsIHRoYXQgaGFzIHZpcnR1YWwgZnVuY3Rpb25zIGJ1dCBub24tdmlydHVhbCBkZXN0 cnVjdG9yIFstV2RlbGV0ZS1ub24tdmlydHVhbC1kdG9yXQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkxNTgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1c2UgdGhlcmUncyBu byBiZWhhdmlvdXIgY2hhbmdlLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jdXJsL0Nv b2tpZUphckN1cmwuaDoKKyAgICAgICAgKFdlYkNvcmU6OkNvb2tpZUphckN1cmw6On5Db29raWVK YXJDdXJsKTogQWRkZWQgYSBkZWZhdWx0IHZpcnR1YWwgZHRvci4KKyAgICAgICAgKiBwbGF0Zm9y bS9uZXR3b3JrL2N1cmwvQ3VybERvd25sb2FkLmg6IE1hcmtlZCBDdXJsRG93bmxvYWQgZmluYWwu CisKIDIwMTgtMTEtMTIgIENocmlzdG9waGVyIFJlaWQgIDxjaHJpcy5yZWlkQHNvbnkuY29tPgog CiAgICAgICAgIFtDdXJsXSBSZWplY3QgZW50aXJlIGNvb2tpZSBpZiB0aGUgZG9tYWluIGZhaWxz IGEgdGFpbG1hdGNoLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9jdXJsL0Nvb2tpZUphckN1cmwuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv Y3VybC9Db29raWVKYXJDdXJsLmgKaW5kZXggZWQ2ZDhiNjliMjkxZmNhNmIxNzJkNjM4MDViOTNh YjdiZjMzZmJlZi4uZjg0MjFkMTY4NDZlYzdlYWE4YzI3ZjNjYTNkYjc2YTM3MjQxNjZlZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0Nvb2tpZUphckN1 cmwuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ29va2llSmFy Q3VybC5oCkBAIC0zNiw2ICszNiw3IEBAIGVudW0gY2xhc3MgSW5jbHVkZVNlY3VyZUNvb2tpZXMg OiBib29sOwogCiBjbGFzcyBDb29raWVKYXJDdXJsIHsKIHB1YmxpYzoKKyAgICB2aXJ0dWFsIH5D b29raWVKYXJDdXJsKCkgeyB9CiAgICAgdmlydHVhbCBzdGQ6OnBhaXI8U3RyaW5nLCBib29sPiBj b29raWVzRm9yRE9NKGNvbnN0IE5ldHdvcmtTdG9yYWdlU2Vzc2lvbiYsIGNvbnN0IFVSTCYgZmly c3RQYXJ0eSwgY29uc3QgU2FtZVNpdGVJbmZvJiwgY29uc3QgVVJMJiwgc3RkOjpvcHRpb25hbDx1 aW50NjRfdD4gZnJhbWVJRCwgc3RkOjpvcHRpb25hbDx1aW50NjRfdD4gcGFnZUlELCBJbmNsdWRl U2VjdXJlQ29va2llcykgY29uc3QgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBzZXRDb29raWVzRnJv bURPTShjb25zdCBOZXR3b3JrU3RvcmFnZVNlc3Npb24mLCBjb25zdCBVUkwmIGZpcnN0UGFydHks IGNvbnN0IFNhbWVTaXRlSW5mbyYsIGNvbnN0IFVSTCYsIHN0ZDo6b3B0aW9uYWw8dWludDY0X3Q+ IGZyYW1lSUQsIHN0ZDo6b3B0aW9uYWw8dWludDY0X3Q+IHBhZ2VJRCwgY29uc3QgU3RyaW5nJikg Y29uc3QgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBzZXRDb29raWVzRnJvbUhUVFBSZXNwb25zZShj b25zdCBOZXR3b3JrU3RvcmFnZVNlc3Npb24mLCBjb25zdCBVUkwmLCBjb25zdCBTdHJpbmcmKSBj b25zdCA9IDA7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1 cmwvQ3VybERvd25sb2FkLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwv Q3VybERvd25sb2FkLmgKaW5kZXggYzZmNWM1OTZmMjQzZGZjZDRjZGVlMGExYjU1NzVhNDEwYTU0 NjRiNC4uYTczOWRmYWM5NWViMzA0ZjM1ZDA0NjgzNWM2ZDQ3YWMxZjFmMDZjZCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxEb3dubG9hZC5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsRG93bmxvYWQuaApA QCAtNDcsNyArNDcsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIGRpZEZhaWwoKSB7IH0K IH07CiAKLWNsYXNzIEN1cmxEb3dubG9hZCA6IHB1YmxpYyBUaHJlYWRTYWZlUmVmQ291bnRlZDxD dXJsRG93bmxvYWQ+LCBwdWJsaWMgQ3VybFJlcXVlc3RDbGllbnQgeworY2xhc3MgQ3VybERvd25s b2FkIGZpbmFsIDogcHVibGljIFRocmVhZFNhZmVSZWZDb3VudGVkPEN1cmxEb3dubG9hZD4sIHB1 YmxpYyBDdXJsUmVxdWVzdENsaWVudCB7CiBwdWJsaWM6CiAgICAgQ3VybERvd25sb2FkKCkgPSBk ZWZhdWx0OwogICAgIH5DdXJsRG93bmxvYWQoKTsK 354903 2018-11-15 01:33:49 -0800 2018-11-15 17:37:47 -0800 Patch bug-191582-20181115183348.patch text/plain 1487 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4MjE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWI5ODhiMjRkMWM5NzM4 OGE0N2YyNzdkYjkzMjgwNmQ0MGJiNWY5MC4uZWU5N2EwMzI4ODE2ZWNiZDNjNGVkOTAwNGI3NmNk ODk0ZmI0OTAwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTExLTE1ICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtjdXJsXSB3 YXJuaW5nOiBkZWxldGUgY2FsbGVkIG9uIG5vbi1maW5hbCAnV2ViQ29yZTo6Q3VybERvd25sb2Fk JyB0aGF0IGhhcyB2aXJ0dWFsIGZ1bmN0aW9ucyBidXQgbm9uLXZpcnR1YWwgZGVzdHJ1Y3RvciBb LVdkZWxldGUtbm9uLXZpcnR1YWwtZHRvcl0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE5MTU4MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBiZWNhdXNlIHRoZXJlJ3Mgbm8gYmVoYXZp b3VyIGNoYW5nZS4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsRG93bmxv YWQuaDogTWFya2VkIEN1cmxEb3dubG9hZCBmaW5hbC4KKwogMjAxOC0xMS0xNCAgS2VpdGggUm9s bGluICA8a3JvbGxpbkBhcHBsZS5jb20+CiAKICAgICAgICAgTW92ZSBzY3JpcHRzIGZvciBEZXJp dmVkIGFuZCBVbmlmaWVkIFNvdXJjZXMgdG8gZXh0ZXJuYWwgZmlsZXMKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsRG93bmxvYWQuaCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsRG93bmxvYWQuaAppbmRleCBjNmY1 YzU5NmYyNDNkZmNkNGNkZWUwYTFiNTU3NWE0MTBhNTQ2NGI0Li5hNzM5ZGZhYzk1ZWIzMDRmMzVk MDQ2ODM1YzZkNDdhYzFmMWYwNmNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL2N1cmwvQ3VybERvd25sb2FkLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9jdXJsL0N1cmxEb3dubG9hZC5oCkBAIC00Nyw3ICs0Nyw3IEBAIHB1YmxpYzoK ICAgICB2aXJ0dWFsIHZvaWQgZGlkRmFpbCgpIHsgfQogfTsKIAotY2xhc3MgQ3VybERvd25sb2Fk IDogcHVibGljIFRocmVhZFNhZmVSZWZDb3VudGVkPEN1cmxEb3dubG9hZD4sIHB1YmxpYyBDdXJs UmVxdWVzdENsaWVudCB7CitjbGFzcyBDdXJsRG93bmxvYWQgZmluYWwgOiBwdWJsaWMgVGhyZWFk U2FmZVJlZkNvdW50ZWQ8Q3VybERvd25sb2FkPiwgcHVibGljIEN1cmxSZXF1ZXN0Q2xpZW50IHsK IHB1YmxpYzoKICAgICBDdXJsRG93bmxvYWQoKSA9IGRlZmF1bHQ7CiAgICAgfkN1cmxEb3dubG9h ZCgpOwo=