191581 2018-11-13 00:49:42 -0800 Hidden attribute does not apply to optgroup and option 2020-12-06 10:59:44 -0800 1 1 1 Unclassified WebKit Layout and Rendering Safari 12 Mac macOS 10.13 RESOLVED DUPLICATE 69014 https://bugs.webkit.org/show_bug.cgi?id=169039 https://html.spec.whatwg.org/multipage/rendering.html#the-select-element-2 InRadar P2 Normal --- 1 develop webkit-unassigned bfulgham cdumez koivisto rniwa simon.fraser webkit-bug-importer wenson_hsieh zalan oldest_to_newest 1477939 0 develop 2018-11-13 00:49:42 -0800 The spec defines[0] on all HTML elements (subclasses of HTMLElement), including optgroup (HTMLOptGroupElement) and option (HTMLOptionElement) a hidden attribute. Unlike Firefox, Edge, and Chrome, Safari does not (visually) reflect the semantics of setting this attribute: "User agents should not render elements that have the hidden attribute specified." In the following demo, optgroup and option are visible in Safari: http://jsfiddle.net/c1nzxm8e/ [0] https://html.spec.whatwg.org/multipage/interaction.html#the-hidden-attribute 1478004 1 cdumez 2018-11-13 08:57:32 -0800 Web Inspector properly reports that both the <option> and <optgroup> have "display: none" computed style, yet they are indeed visible :/ If I add "hidden" attribute the the <select> element then the <select> also becomes "display: none", and then it becomes indeed hidden. The issue is therefore specific to <option> and <optgroup> elements somehow. Also, I do not believe this is actually a DOM/HTML issue since the CSS style was properly set. This is more likely a CSS or rendering issue. 1478006 2 cdumez 2018-11-13 08:59:56 -0800 Both HTMLOptionElement and HTMLOptGroupElement have the following override: bool rendererIsNeeded(const RenderStyle&) final { return false; } Not sure why they do not need a renderer. 1478007 3 cdumez 2018-11-13 09:04:38 -0800 The default definition of rendererIsNeeded is: bool Element::rendererIsNeeded(const RenderStyle& style) { return style.display() != DisplayType::None && style.display() != DisplayType::Contents; } 1478010 4 cdumez 2018-11-13 09:09:10 -0800 This may also be relevant: bool HTMLSelectElement::childShouldCreateRenderer(const Node& child) const { if (!HTMLFormControlElementWithState::childShouldCreateRenderer(child)) return false; #if !PLATFORM(IOS_FAMILY) if (!usesMenuList()) return is<HTMLOptionElement>(child) || is<HTMLOptGroupElement>(child) || validationMessageShadowTreeContains(child); #endif return validationMessageShadowTreeContains(child); } 1478018 5 simon.fraser 2018-11-13 09:18:16 -0800 See also bug 169039. Our <option> rendering seems wonky. 1478021 6 cdumez 2018-11-13 09:22:34 -0800 Relevant rendering code seems to be in void RenderListBox::updateFromElement(). It grabs text from options and optgroup elements without taking into consideration their visibility. 1478024 7 cdumez 2018-11-13 09:25:08 -0800 Moving to Layout & Rendering. I do not think I am the right assignee. 1555441 8 webkit-bug-importer 2019-07-24 11:36:42 -0700 <rdar://problem/53505809> 1712334 9 ap 2020-12-06 10:59:44 -0800 *** This bug has been marked as a duplicate of bug 69014 ***