<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>191580</bug_id>
          
          <creation_ts>2018-11-13 00:45:59 -0800</creation_ts>
          <short_desc>Remove WebKitTestRunnerLib&apos;s build warnings.</short_desc>
          <delta_ts>2018-11-13 02:06:25 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Takashi Komori">takashi.komori</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>fujii</cc>
    
    <cc>lforschler</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1477937</commentid>
    <comment_count>0</comment_count>
    <who name="Takashi Komori">takashi.komori</who>
    <bug_when>2018-11-13 00:45:59 -0800</bug_when>
    <thetext>Remove WebKitTestRunnerLib&apos;s build warnings.

Building WebKitTestRunnerLib for WinCairo produces many redefinition warnings.
This is because wtf/Platform.h is included ahead cmakeconfig.h, through precompiled header (WebKitTestRunnerPrefix.h)

To remove these warnings we should include cmakeconfig.h in WebKitTestRunnerPrefix.h</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1477941</commentid>
    <comment_count>1</comment_count>
      <attachid>354659</attachid>
    <who name="Takashi Komori">takashi.komori</who>
    <bug_when>2018-11-13 00:56:30 -0800</bug_when>
    <thetext>Created attachment 354659
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1477946</commentid>
    <comment_count>2</comment_count>
      <attachid>354659</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-11-13 02:05:24 -0800</bug_when>
    <thetext>Comment on attachment 354659
Patch

Clearing flags on attachment: 354659

Committed r238127: &lt;https://trac.webkit.org/changeset/238127&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1477947</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-11-13 02:05:25 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1477948</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-11-13 02:06:25 -0800</bug_when>
    <thetext>&lt;rdar://problem/46022189&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>354659</attachid>
            <date>2018-11-13 00:56:30 -0800</date>
            <delta_ts>2018-11-13 02:05:24 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-191580-20181113175435.patch</filename>
            <type>text/plain</type>
            <size>1211</size>
            <attacher name="Takashi Komori">takashi.komori</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4MTEzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjI1Mjg0MjUyN2Y5NjdkOTkyMThiMWMwMWVmNDdhYWJk
YjZlZWFmZi4uZTZlYzdhYjE3N2ZjODEyYjhkMmRmNzE4YTgxNTAyMTgxODQyMmM0OSAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0
IEBACisyMDE4LTExLTEzICBUYWthc2hpIEtvbW9yaSAgPFRha2FzaGkuS29tb3JpQHNvbnkuY29t
PgorCisgICAgICAgIFJlbW92ZSBXZWJLaXRUZXN0UnVubmVyTGliJ3MgYnVpbGQgd2FybmluZ3Mu
CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTE1ODAK
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbmNsdWRl
IGNtYWtlY29uZmlnLmggaW4gcHJlY29tcGlsZWQgaGVhZGVyLgorCisgICAgICAgICogV2ViS2l0
VGVzdFJ1bm5lci9XZWJLaXRUZXN0UnVubmVyUHJlZml4Lmg6CisKIDIwMTgtMTEtMTIgIEJhc3Vr
ZSBTdXp1a2kgIDxiYXN1a2Uuc3V6dWtpQHNvbnkuY29tPgogCiAgICAgICAgIFtDdXJsXSBBZGQg
QVBJIFRlc3QgZm9yIEN1cmwgY29va2llIGJhY2tlbmQuCmRpZmYgLS1naXQgYS9Ub29scy9XZWJL
aXRUZXN0UnVubmVyL1dlYktpdFRlc3RSdW5uZXJQcmVmaXguaCBiL1Rvb2xzL1dlYktpdFRlc3RS
dW5uZXIvV2ViS2l0VGVzdFJ1bm5lclByZWZpeC5oCmluZGV4IGYyMDAxMTk4NmMxZGViNjYzOTc5
NzkxMjZlODBmZmVmYWQyMjk4MDIuLjc4ZWU3NjVjZmJmNGMyMWQ1YTNlMGMxMDhmZTRmODEyNWRj
YmNiNDEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvV2ViS2l0VGVzdFJ1bm5l
clByZWZpeC5oCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvV2ViS2l0VGVzdFJ1bm5lclBy
ZWZpeC5oCkBAIC0yMyw2ICsyMywxMCBAQAogICogVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFN
QUdFLgogICovCiAKKyNpZiBkZWZpbmVkKEhBVkVfQ09ORklHX0gpICYmIEhBVkVfQ09ORklHX0gg
JiYgZGVmaW5lZChCVUlMRElOR19XSVRIX0NNQUtFKQorI2luY2x1ZGUgImNtYWtlY29uZmlnLmgi
CisjZW5kaWYKKwogI2lmZGVmIF9fT0JKQ19fCiAjaW1wb3J0IDxGb3VuZGF0aW9uL0ZvdW5kYXRp
b24uaD4KICNlbmRpZgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>