191578 2018-11-12 22:40:36 -0800 [GStreamer][MSE][Debug] Several debug tests are crashing after r238084 2018-11-16 10:15:29 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 calvaris aboya aboya calvaris commit-queue webkit-bug-importer oldest_to_newest 1477915 0 calvaris 2018-11-12 22:40:36 -0800 Examples at https://build.webkit.org/results/GTK%20Linux%2064-bit%20Debug%20(Tests)/r238109%20(3932)/results.html. 1477916 1 calvaris 2018-11-12 22:41:24 -0800 Both GTK and WPE Debug testing bots are unhappy. 1478051 2 aboya 2018-11-13 10:36:56 -0800 Caps notifications are being emitted from the main thread when setting the pipeline to NULL state, unexpectedly (therefore the failed assertion). The weird part is that so far this is only happening in the bots, even though we I am running supposedly the same GStreamer version from the jhbuild, with the same WebKit commit and the same test. It may be worth it to investigate why it only fails in the bots. As for actually fixing the assertion error, all event handlers should be disconnected before tearing down the pipeline. 1479347 3 aboya 2018-11-16 05:02:48 -0800 I've been able to reproduce the issue reliably after updating my system to F29... or maybe just the moons moved to the correct place. Either way, the error makes sense, here is a patch: 1479351 4 355044 aboya 2018-11-16 05:09:37 -0800 Created attachment 355044 Patch 1479439 5 355044 calvaris 2018-11-16 09:17:45 -0800 Comment on attachment 355044 Patch We are assuming that isMainThread() => !caps, which I think is dangerous. We should at least ASSERT on that 1479442 6 355065 aboya 2018-11-16 09:24:53 -0800 Created attachment 355065 Patch 1479472 7 355065 commit-queue 2018-11-16 10:14:52 -0800 Comment on attachment 355065 Patch Clearing flags on attachment: 355065 Committed r238287: <https://trac.webkit.org/changeset/238287> 1479473 8 commit-queue 2018-11-16 10:14:54 -0800 All reviewed patches have been landed. Closing bug. 1479475 9 webkit-bug-importer 2018-11-16 10:15:29 -0800 <rdar://problem/46130553> 355044 2018-11-16 05:09:37 -0800 2018-11-16 09:24:49 -0800 Patch bug-191578-20181116140935.patch text/plain 2411 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4Mjc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWFhMjNiMDU4YTBkZDcw NGY2Y2RlMDg1NzJkNzIxY2VhMTUwNmVhOC4uZTM1MTljOGVhYzlmN2Q4ZmVhMjQ3Y2VmMDU2MDgy Y2E3ZWE4Yzc5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE4LTExLTE2ICBBbGlj aWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbTVNFXVtHU3Ry ZWFtZXJdIElnbm9yZSBjYXBzIG5vdGlmaWNhdGlvbnMgd2hlbiB0ZWFyaW5nIGRvd24gdGhlIHBp cGVsaW5lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x OTE1NzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBD aGFuZ2luZyB0aGUgZGVtdXhlciB0byBSRUFEWSBzdGF0ZSAod2hpY2ggaXMgZG9uZSBvbmx5IGlu IHRoZSBtYWluCisgICAgICAgIHRocmVhZCkgdHJpZ2dlcnMgdGhlIHVubGlua2luZyBvZiBpdHMg c3JjcGFkcywgd2hpY2ggaW4gdHVybnMgZW1pdHMgYQorICAgICAgICBjYXBzIGNoYW5nZSBub3Rp ZmljYXRpb24gaW4gdGhlIHByZXZpb3VzbHkgbGlua2VkIGVsZW1lbnQgc2luY2UgdGhleQorICAg ICAgICBiZWNvbWUgdW5uZWdvdGlhdGVkIGFnYWluLgorCisgICAgICAgIFdlIGFyZSBub3QgaW50 ZXJlc3RlZCBpbiBjYXBzIG5vdGlmaWNhdGlvbnMgaW4gdGhlc2UgY2FzZXMsIHNvIGxldCdzCisg ICAgICAgIGp1c3QgaWdub3JlIGNhcHMgbm90aWZpY2F0aW9ucyBlbWl0dGVkIGZyb20gdGhlIG1h aW4gdGhyZWFkLgorCisgICAgICAgIFRoaXMgZml4ZXMgYW4gYXNzZXJ0aW9uIGZhaWx1cmUgaW4g dGhlIGRlYnVnIGJ1aWxkcy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1l ci9tc2UvQXBwZW5kUGlwZWxpbmUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QXBwZW5kUGlwZWxp bmU6OkFwcGVuZFBpcGVsaW5lKToKKwogMjAxOC0xMS0xNiAgWmFuIERvYmVyc2VrICA8emRvYmVy c2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAgU2NhbGFibGVJbWFnZURlY29kZXI6IGRvbid0IGZv cmNlZnVsbHkgZGVjb2RlIGltYWdlIGRhdGEgd2hlbiBxdWVyeWluZyBmcmFtZSBjb21wbGV0ZW5l c3MsIGR1cmF0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9nc3RyZWFtZXIvbXNlL0FwcGVuZFBpcGVsaW5lLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvQXBwZW5kUGlwZWxpbmUuY3BwCmluZGV4IDFiN2I0 YTIxNDI3Zjk1ZmFmZmM0YmI1NDg5MmNlZmQ1Yjc4NGIzNGMuLmU3NGY5Njk1NGFhMGY5MGY5Zjgx ODJhNDY4OGJkZjMwYzhhYTEzZjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvQXBwZW5kUGlwZWxpbmUuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvQXBwZW5kUGlwZWxpbmUuY3Bw CkBAIC0xNTksNiArMTU5LDExIEBAIEFwcGVuZFBpcGVsaW5lOjpBcHBlbmRQaXBlbGluZShSZWY8 TWVkaWFTb3VyY2VDbGllbnRHU3RyZWFtZXJNU0U+IG1lZGlhU291cmNlQ2xpCiAKICAgICBHUmVm UHRyPEdzdFBhZD4gYXBwc2lua1BhZCA9IGFkb3B0R1JlZihnc3RfZWxlbWVudF9nZXRfc3RhdGlj X3BhZChtX2FwcHNpbmsuZ2V0KCksICJzaW5rIikpOwogICAgIGdfc2lnbmFsX2Nvbm5lY3QoYXBw c2lua1BhZC5nZXQoKSwgIm5vdGlmeTo6Y2FwcyIsIEdfQ0FMTEJBQ0soK1tdKEdPYmplY3QqLCBH UGFyYW1TcGVjKiwgQXBwZW5kUGlwZWxpbmUqIGFwcGVuZFBpcGVsaW5lKSB7CisgICAgICAgIC8v IFdoZW4gY2hhbmdpbmcgdGhlIHBpcGVsaW5lIHN0YXRlIGRvd24gdG8gUkVBRFkgdGhlIGRlbXV4 ZXIgaXMgdW5saW5rZWQgYW5kIHRoaXMgdHJpZ2dlcnMgYSBjYXBzIG5vdGlmaWNhdGlvbgorICAg ICAgICAvLyBiZWNhdXNlIHRoZSBhcHBzaW5rIGxvc2VzIGl0cyBwcmV2aW91c2x5IG5lZ290aWF0 ZWQgY2Fwcy4gV2UgYXJlIG5vdCBpbnRlcmVzdGVkIGluIHRoZXNlIHVubmVnb3RpYXRlZCBjYXBz LgorICAgICAgICBpZiAoaXNNYWluVGhyZWFkKCkpCisgICAgICAgICAgICByZXR1cm47CisKICAg ICAgICAgYXBwZW5kUGlwZWxpbmUtPm1fdGFza1F1ZXVlLmVucXVldWVUYXNrKFthcHBlbmRQaXBl bGluZV0oKSB7CiAgICAgICAgICAgICBhcHBlbmRQaXBlbGluZS0+YXBwc2lua0NhcHNDaGFuZ2Vk KCk7CiAgICAgICAgIH0pOwo= 355065 2018-11-16 09:24:53 -0800 2018-11-16 10:14:52 -0800 Patch bug-191578-20181116182452.patch text/plain 2684 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4Mjc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWFhMjNiMDU4YTBkZDcw NGY2Y2RlMDg1NzJkNzIxY2VhMTUwNmVhOC4uZTM1MTljOGVhYzlmN2Q4ZmVhMjQ3Y2VmMDU2MDgy Y2E3ZWE4Yzc5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE4LTExLTE2ICBBbGlj aWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbTVNFXVtHU3Ry ZWFtZXJdIElnbm9yZSBjYXBzIG5vdGlmaWNhdGlvbnMgd2hlbiB0ZWFyaW5nIGRvd24gdGhlIHBp cGVsaW5lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x OTE1NzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBD aGFuZ2luZyB0aGUgZGVtdXhlciB0byBSRUFEWSBzdGF0ZSAod2hpY2ggaXMgZG9uZSBvbmx5IGlu IHRoZSBtYWluCisgICAgICAgIHRocmVhZCkgdHJpZ2dlcnMgdGhlIHVubGlua2luZyBvZiBpdHMg c3JjcGFkcywgd2hpY2ggaW4gdHVybnMgZW1pdHMgYQorICAgICAgICBjYXBzIGNoYW5nZSBub3Rp ZmljYXRpb24gaW4gdGhlIHByZXZpb3VzbHkgbGlua2VkIGVsZW1lbnQgc2luY2UgdGhleQorICAg ICAgICBiZWNvbWUgdW5uZWdvdGlhdGVkIGFnYWluLgorCisgICAgICAgIFdlIGFyZSBub3QgaW50 ZXJlc3RlZCBpbiBjYXBzIG5vdGlmaWNhdGlvbnMgaW4gdGhlc2UgY2FzZXMsIHNvIGxldCdzCisg ICAgICAgIGp1c3QgaWdub3JlIGNhcHMgbm90aWZpY2F0aW9ucyBlbWl0dGVkIGZyb20gdGhlIG1h aW4gdGhyZWFkLgorCisgICAgICAgIFRoaXMgZml4ZXMgYW4gYXNzZXJ0aW9uIGZhaWx1cmUgaW4g dGhlIGRlYnVnIGJ1aWxkcy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1l ci9tc2UvQXBwZW5kUGlwZWxpbmUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QXBwZW5kUGlwZWxp bmU6OkFwcGVuZFBpcGVsaW5lKToKKwogMjAxOC0xMS0xNiAgWmFuIERvYmVyc2VrICA8emRvYmVy c2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAgU2NhbGFibGVJbWFnZURlY29kZXI6IGRvbid0IGZv cmNlZnVsbHkgZGVjb2RlIGltYWdlIGRhdGEgd2hlbiBxdWVyeWluZyBmcmFtZSBjb21wbGV0ZW5l c3MsIGR1cmF0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9nc3RyZWFtZXIvbXNlL0FwcGVuZFBpcGVsaW5lLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvQXBwZW5kUGlwZWxpbmUuY3BwCmluZGV4IDFiN2I0 YTIxNDI3Zjk1ZmFmZmM0YmI1NDg5MmNlZmQ1Yjc4NGIzNGMuLmY1NWUwMGU4YTY1OGFlY2VjOWNj ZGEyYzY4YmQwZjQxZDVlNzVjZmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvQXBwZW5kUGlwZWxpbmUuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvQXBwZW5kUGlwZWxpbmUuY3Bw CkBAIC0xNTksNiArMTU5LDE3IEBAIEFwcGVuZFBpcGVsaW5lOjpBcHBlbmRQaXBlbGluZShSZWY8 TWVkaWFTb3VyY2VDbGllbnRHU3RyZWFtZXJNU0U+IG1lZGlhU291cmNlQ2xpCiAKICAgICBHUmVm UHRyPEdzdFBhZD4gYXBwc2lua1BhZCA9IGFkb3B0R1JlZihnc3RfZWxlbWVudF9nZXRfc3RhdGlj X3BhZChtX2FwcHNpbmsuZ2V0KCksICJzaW5rIikpOwogICAgIGdfc2lnbmFsX2Nvbm5lY3QoYXBw c2lua1BhZC5nZXQoKSwgIm5vdGlmeTo6Y2FwcyIsIEdfQ0FMTEJBQ0soK1tdKEdPYmplY3QqLCBH UGFyYW1TcGVjKiwgQXBwZW5kUGlwZWxpbmUqIGFwcGVuZFBpcGVsaW5lKSB7CisgICAgICAgIGlm IChpc01haW5UaHJlYWQoKSkgeworICAgICAgICAgICAgLy8gV2hlbiBjaGFuZ2luZyB0aGUgcGlw ZWxpbmUgc3RhdGUgZG93biB0byBSRUFEWSB0aGUgZGVtdXhlciBpcyB1bmxpbmtlZCBhbmQgdGhp cyB0cmlnZ2VycyBhIGNhcHMgbm90aWZpY2F0aW9uCisgICAgICAgICAgICAvLyBiZWNhdXNlIHRo ZSBhcHBzaW5rIGxvc2VzIGl0cyBwcmV2aW91c2x5IG5lZ290aWF0ZWQgY2Fwcy4gV2UgYXJlIG5v dCBpbnRlcmVzdGVkIGluIHRoZXNlIHVubmVnb3RpYXRlZCBjYXBzLgorI2lmbmRlZiBOREVCVUcK KyAgICAgICAgICAgIEdSZWZQdHI8R3N0UGFkPiBwYWQgPSBhZG9wdEdSZWYoZ3N0X2VsZW1lbnRf Z2V0X3N0YXRpY19wYWQoYXBwZW5kUGlwZWxpbmUtPm1fYXBwc2luay5nZXQoKSwgInNpbmsiKSk7 CisgICAgICAgICAgICBHUmVmUHRyPEdzdENhcHM+IGNhcHMgPSBhZG9wdEdSZWYoZ3N0X3BhZF9n ZXRfY3VycmVudF9jYXBzKHBhZC5nZXQoKSkpOworICAgICAgICAgICAgQVNTRVJUKCFjYXBzKTsK KyNlbmRpZgorICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CisKICAgICAgICAgYXBwZW5k UGlwZWxpbmUtPm1fdGFza1F1ZXVlLmVucXVldWVUYXNrKFthcHBlbmRQaXBlbGluZV0oKSB7CiAg ICAgICAgICAgICBhcHBlbmRQaXBlbGluZS0+YXBwc2lua0NhcHNDaGFuZ2VkKCk7CiAgICAgICAg IH0pOwo=