<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>191572</bug_id>
          
          <creation_ts>2018-11-12 16:55:21 -0800</creation_ts>
          <short_desc>Enable process swap on cross-site navigation by default on macOS</short_desc>
          <delta_ts>2018-11-15 14:07:14 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>191602</dependson>
    
    <dependson>191616</dependson>
    
    <dependson>191618</dependson>
    
    <dependson>191619</dependson>
    
    <dependson>191624</dependson>
    
    <dependson>191634</dependson>
    
    <dependson>191638</dependson>
    
    <dependson>191640</dependson>
    
    <dependson>191671</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ryosuke Niwa">rniwa</reporter>
          <assigned_to name="Ryosuke Niwa">rniwa</assigned_to>
          <cc>beidson</cc>
    
    <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>ggaren</cc>
    
    <cc>jlewis3</cc>
    
    <cc>ryanhaddad</cc>
    
    <cc>tsavell</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1477801</commentid>
    <comment_count>0</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2018-11-12 16:55:21 -0800</bug_when>
    <thetext>Do that.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1477803</commentid>
    <comment_count>1</comment_count>
      <attachid>354611</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2018-11-12 16:56:45 -0800</bug_when>
    <thetext>Created attachment 354611
Enables the feature</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1478000</commentid>
    <comment_count>2</comment_count>
      <attachid>354611</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2018-11-13 08:45:50 -0800</bug_when>
    <thetext>Comment on attachment 354611
Enables the feature

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1478060</commentid>
    <comment_count>3</comment_count>
      <attachid>354611</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-11-13 10:43:28 -0800</bug_when>
    <thetext>Comment on attachment 354611
Enables the feature

Clearing flags on attachment: 354611

Committed r238137: &lt;https://trac.webkit.org/changeset/238137&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1478061</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-11-13 10:43:30 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1478064</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-11-13 10:44:27 -0800</bug_when>
    <thetext>&lt;rdar://problem/46033843&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1478090</commentid>
    <comment_count>6</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2018-11-13 11:59:07 -0800</bug_when>
    <thetext>Enabling this introduced API test failures on macOS: 
https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK1%20%28Tests%29/builds/9226/steps/run-api-tests/logs/stdio</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1478093</commentid>
    <comment_count>7</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2018-11-13 12:18:24 -0800</bug_when>
    <thetext>The ProcessSwapOnNavigation API test failures are likely due to PSON getting forced to true now in cases where the tests are trying to test when PSON is disabled. Those are not too worrisome and can probably easily be fixed.

However, I am concerned about the other API test failures. We may want to roll out and investigate offline.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1478105</commentid>
    <comment_count>8</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2018-11-13 12:56:12 -0800</bug_when>
    <thetext>------------------------------
Test suite failed

Failed

    TestWebKitAPI.WebKit.ApplicationManifestBasic
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm:98
        Value of: [manifest.name isEqualToString:@&quot;A Web Application&quot;]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm:99
        Value of: [manifest.shortName isEqualToString:@&quot;WebApp&quot;]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm:100
        Value of: [manifest.applicationDescription isEqualToString:@&quot;Hello.&quot;]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm:101
        Value of: [manifest.startURL isEqual:[NSURL URLWithString:@&quot;http://example.com/app/start&quot;]]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm:102
        Value of: [manifest.scope isEqual:[NSURL URLWithString:@&quot;http://example.com/app&quot;]]
          Actual: false
        Expected: true
        

    TestWebKitAPI.WebKit.DecidePolicyForNavigationActionForPOSTFormSubmissionThatRedirectsToGET
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:517
        Expected equality of these values:
          WKNavigationTypeFormSubmitted
            Which is: 1
          [action navigationType]
            Which is: -1
        
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:522
        Expected equality of these values:
          &quot;http&quot;
          [[[action sourceFrame] securityOrigin] protocol]
            Which is: &quot;&quot;
        
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:523
        Expected equality of these values:
          &quot;webkit.org&quot;
          [[[action sourceFrame] securityOrigin] host]
            Which is: &quot;&quot;
        

    TestWebKitAPI.ProcessSwap.NavigationWithLockedHistoryWithoutPSON
        Received data during response processing, queuing it.
        Received data during response processing, queuing it.
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:1493
        Expected equality of these values:
          webkitPID
            Which is: 65707
          applePID
            Which is: 65709
        

    TestWebKitAPI.WebKit.WKHTTPCookieStoreWithoutProcessPool
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:473
        Expected equality of these values:
          &quot;PersistentCookieName=CookieValue; SessionCookieName=CookieValue&quot;
          message.UTF8String
            Which is: &quot;PersistentCookieName=CookieValue&quot;
        

    TestWebKitAPI.ServiceWorkers.HasServiceWorkerRegistrationBit
        Received data during response processing, queuing it.
        Received data during response processing, queuing it.
        Received data during response processing, queuing it.
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:1144
        Expected equality of these values:
          1u
            Which is: 1
          webView.get().configuration.processPool._webProcessCount
            Which is: 2
        

    TestWebKitAPI.WebKit.DecidePolicyForNavigationActionForHyperlinkThatRedirects
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:470
        Expected equality of these values:
          WKNavigationTypeLinkActivated
            Which is: 0
          [action navigationType]
            Which is: -1
        
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:475
        Expected equality of these values:
          &quot;http&quot;
          [[[action sourceFrame] securityOrigin] protocol]
            Which is: &quot;&quot;
        
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:476
        Expected equality of these values:
          &quot;webkit.org&quot;
          [[[action sourceFrame] securityOrigin] host]
            Which is: &quot;&quot;
        

    TestWebKitAPI.ServiceWorkers.ServiceWorkerProcessCreation
        Received data during response processing, queuing it.
        Received data during response processing, queuing it.
        Received data during response processing, queuing it.
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:1060
        Expected equality of these values:
          3u
            Which is: 3
          webView.get().configuration.processPool._webProcessCount
            Which is: 4
        

    TestWebKitAPI.WKProcessPool.InitialWarmedProcessUsed
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:74
        Value of: [pool _hasPrewarmedWebProcess]
          Actual: true
        Expected: false
        
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:75
        Expected equality of these values:
          1U
            Which is: 1
          [pool _webPageContentProcessCount]
            Which is: 2
        

    TestWebKitAPI.WebKit.DecidePolicyForNavigationActionForPOSTFormSubmissionThatRedirectsToPOST
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:564
        Expected equality of these values:
          WKNavigationTypeFormSubmitted
            Which is: 1
          [action navigationType]
            Which is: -1
        
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:569
        Expected equality of these values:
          &quot;http&quot;
          [[[action sourceFrame] securityOrigin] protocol]
            Which is: &quot;&quot;
        
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:570
        Expected equality of these values:
          &quot;webkit.org&quot;
          [[[action sourceFrame] securityOrigin] host]
            Which is: &quot;&quot;
        

    TestWebKitAPI.WebKit.WebsiteDataStoreCustomPaths
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:262
        Value of: [WKWebsiteDataStore _defaultDataStoreExists]
          Actual: true
        Expected: false
        

    TestWebKitAPI.ProcessSwap.CrossSiteClientSideRedirectWithoutPSON
        Received data during response processing, queuing it.
        Received data during response processing, queuing it.
        Received data during response processing, queuing it.
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:1358
        Expected equality of these values:
          webkitPID
            Which is: 65640
          googlePID
            Which is: 65642
        
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:1370
        Expected equality of these values:
          webkitPID
            Which is: 65640
          applePID
            Which is: 65643
        
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:1371
        Expected equality of these values:
          webkitPID
            Which is: 65640
          googlePID
            Which is: 65642
        

Crashed

    TestWebKitAPI.WebKit.GeolocationTransitionToLowAccuracy
        2018-11-13 11:29:39.907 com.apple.WebKit.WebContent.Development[63324:18897420] Application does not have the &apos;com.apple.security.network.client&apos; entitlement.

Timeout

    TestWebKitAPI.IndexedDB.IndexedDBTempFileSize
        Attempted to create a NetworkLoad with a session (id=2) that does not exist.

    TestWebKitAPI.WebKit.GeolocationPermission
    TestWebKitAPI.WebKit.NotificationPermission
    TestWebKitAPI.WebKit.GeolocationTransitionToHighAccuracy</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1478106</commentid>
    <comment_count>9</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2018-11-13 12:59:35 -0800</bug_when>
    <thetext>Okay, let&apos;s rollout the change and investigate this offline.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1478107</commentid>
    <comment_count>10</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2018-11-13 13:04:51 -0800</bug_when>
    <thetext>Reverted r238137 for reason:

Introduced API test failures on macOS.

Committed r238142: &lt;https://trac.webkit.org/changeset/238142&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1478123</commentid>
    <comment_count>11</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2018-11-13 13:33:00 -0800</bug_when>
    <thetext>I am investigating the API test failures. Will fix them via dependency bugs.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1478152</commentid>
    <comment_count>12</comment_count>
      <attachid>354705</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2018-11-13 14:49:48 -0800</bug_when>
    <thetext>Created attachment 354705
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1478643</commentid>
    <comment_count>13</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2018-11-14 14:59:34 -0800</bug_when>
    <thetext>I believe all API tests will be passing on macOS once Bug 191638 and Bug 191640 are fixed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1478742</commentid>
    <comment_count>14</comment_count>
      <attachid>354611</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2018-11-14 19:05:53 -0800</bug_when>
    <thetext>Comment on attachment 354611
Enables the feature

All dependencies are in the commit queue. We can land this again once they have landed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1478760</commentid>
    <comment_count>15</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2018-11-14 19:37:20 -0800</bug_when>
    <thetext>Oops, I think TestWebKitAPI.IndexedDB.IndexedDBTempFileSize may still be timing out.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1478792</commentid>
    <comment_count>16</comment_count>
      <attachid>354896</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2018-11-14 23:50:50 -0800</bug_when>
    <thetext>Created attachment 354896
Enables PSON by default on macOS</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1478879</commentid>
    <comment_count>17</comment_count>
      <attachid>354896</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2018-11-15 06:59:06 -0800</bug_when>
    <thetext>Comment on attachment 354896
Enables PSON by default on macOS

I preferred the other patch now that I separated from client and experimental states. The reason is that the other patch allowed the user to disable PSON via the experimental features. This new patch does not.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1478987</commentid>
    <comment_count>18</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2018-11-15 11:35:55 -0800</bug_when>
    <thetext>(In reply to Chris Dumez from comment #17)
&gt; Comment on attachment 354896 [details]
&gt; Enables PSON by default on macOS
&gt; 
&gt; I preferred the other patch now that I separated from client and
&gt; experimental states. The reason is that the other patch allowed the user to
&gt; disable PSON via the experimental features. This new patch does not.

Okay, let&apos;s re-land the old patch then once the bug 191671 is fixed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1479098</commentid>
    <comment_count>19</comment_count>
      <attachid>354611</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2018-11-15 14:02:24 -0800</bug_when>
    <thetext>Comment on attachment 354611
Enables the feature

Let&apos;s do this!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1479106</commentid>
    <comment_count>20</comment_count>
      <attachid>354611</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-11-15 14:07:12 -0800</bug_when>
    <thetext>Comment on attachment 354611
Enables the feature

Clearing flags on attachment: 354611

Committed r238252: &lt;https://trac.webkit.org/changeset/238252&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1479107</commentid>
    <comment_count>21</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-11-15 14:07:14 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>354611</attachid>
            <date>2018-11-12 16:56:45 -0800</date>
            <delta_ts>2018-11-15 14:07:12 -0800</delta_ts>
            <desc>Enables the feature</desc>
            <filename>bug-191572-20181112165644.patch</filename>
            <type>text/plain</type>
            <size>2166</size>
            <attacher name="Ryosuke Niwa">rniwa</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4MTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDhmMzc3MGNlN2ViN2Y3YzQ1
ZGNkODZiYmM2NzQ4M2Q2NjczZDZlYzUuLjUxMmM2MGU4N2IwMGQzMzc5MWZmOTQzNGJkYWFhNDc1
YzMwNDViODIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTgtMTEtMTIgIFJ5b3N1a2Ug
Tml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRW5hYmxlIHByb2Nlc3Mgc3dhcCBv
biBjcm9zcy1zaXRlIG5hdmlnYXRpb24gYnkgZGVmYXVsdCBvbiBtYWNPUworICAgICAgICBodHRw
czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkxNTcyCisKKyAgICAgICAgUmV2
aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRW5hYmxlZCB0aGUgZmVhdHVyZSBi
eSBkZWZhdWx0IG9uIG1hY09TLgorCisgICAgICAgICogU2hhcmVkL1dlYlByZWZlcmVuY2VzLnlh
bWw6CisgICAgICAgICogU2hhcmVkL1dlYlByZWZlcmVuY2VzRGVmYXVsdFZhbHVlcy5oOgorCiAy
MDE4LTExLTEyICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAg
ICAgIE1ha2UgaXQgcG9zc2libGUgdG8gZWRpdCBpbWFnZXMgaW5saW5lCmRpZmYgLS1naXQgYS9T
b3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlcy55YW1sIGIvU291cmNlL1dlYktpdC9T
aGFyZWQvV2ViUHJlZmVyZW5jZXMueWFtbAppbmRleCA1Njc5ZmU2ZTNiYzhlZmNhOWJjNzk2OTEz
MWIwM2E3OWM3ZTQ0MDFjLi4zMzExZWE5NGI1OTFjMDk5MjM0N2ZkYTVmMjkyM2M3M2JkYmMxZDhh
IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlcy55YW1sCisr
KyBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzLnlhbWwKQEAgLTEzNDksNyAr
MTM0OSw3IEBAIFdlYlNRTERpc2FibGVkOgogCiBQcm9jZXNzU3dhcE9uQ3Jvc3NTaXRlTmF2aWdh
dGlvbkVuYWJsZWQ6CiAgIHR5cGU6IGJvb2wKLSAgZGVmYXVsdFZhbHVlOiBmYWxzZQorICBkZWZh
dWx0VmFsdWU6IERFRkFVTFRfUFJPQ0VTU19TV0FQX09OX0NST1NTX1NJVEVfTkFWSUdBVElPTl9F
TkFCTEVECiAgIGh1bWFuUmVhZGFibGVOYW1lOiAiU3dhcCBQcm9jZXNzZXMgb24gQ3Jvc3MtU2l0
ZSBOYXZpZ2F0aW9uIgogICBodW1hblJlYWRhYmxlRGVzY3JpcHRpb246ICJTd2FwIFdlYkNvbnRl
bnQgcHJvY2Vzc2VzIG9uIGNyb3NzLXNpdGUgbmF2aWdhdGlvbnMiCiAgIGNhdGVnb3J5OiBleHBl
cmltZW50YWwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2Vz
RGVmYXVsdFZhbHVlcy5oIGIvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXNEZWZh
dWx0VmFsdWVzLmgKaW5kZXggMWFjZmQyOWQ2OWU2ZmNjZjhiZjAzM2MyMjU5MjVjYzFkNmU4NzQ2
Ni4uMGY5MTIzNmZmMGUzYTgyZDFhODlmNTE1ZDk3OTJiMDdlMTcwMDZjMCAxMDA2NDQKLS0tIGEv
U291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXNEZWZhdWx0VmFsdWVzLmgKKysrIGIv
U291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXNEZWZhdWx0VmFsdWVzLmgKQEAgLTIx
MCw2ICsyMTAsMTIgQEAKICNkZWZpbmUgREVGQVVMVF9TRVJWSUNFX1dPUktFUlNfRU5BQkxFRCBm
YWxzZQogI2VuZGlmCiAKKyNpZiBQTEFURk9STShNQUMpCisjZGVmaW5lIERFRkFVTFRfUFJPQ0VT
U19TV0FQX09OX0NST1NTX1NJVEVfTkFWSUdBVElPTl9FTkFCTEVEIHRydWUKKyNlbHNlCisjZGVm
aW5lIERFRkFVTFRfUFJPQ0VTU19TV0FQX09OX0NST1NTX1NJVEVfTkFWSUdBVElPTl9FTkFCTEVE
IGZhbHNlCisjZW5kaWYKKwogI2lmIChQTEFURk9STShJT1NfRkFNSUxZKSAmJiBfX0lQSE9ORV9P
U19WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMjAwMDApIHx8IChQTEFURk9STShNQUMpICYmIF9f
TUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxNDAwKSB8fCBQTEFURk9STShXQVRD
SE9TKQogI2RlZmluZSBERUZBVUxUX0NPTklDX0dSQURJRU5UX0VOQUJMRUQgdHJ1ZQogI2Vsc2UK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>354705</attachid>
            <date>2018-11-13 14:49:48 -0800</date>
            <delta_ts>2018-11-14 09:09:39 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-191572-20181113144947.patch</filename>
            <type>text/plain</type>
            <size>1763</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4MTQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDA2Njk5MDQwMTBlM2EyYmRj
M2JiNzc3YTk2MGU2MDZhMmFiOGI1YzIuLmMxYzc0MTZkNGIwYTYzMjFjMGRjZmNmODQ1ZGE2Mzk2
MDk3YmNmMzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMTEtMTMgIENocmlzIER1
bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBFbmFibGUgcHJvY2VzcyBzd2FwIG9u
IGNyb3NzLXNpdGUgbmF2aWdhdGlvbiBieSBkZWZhdWx0IG9uIG1hY09TCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTE1NzIKKyAgICAgICAgPHJkYXI6
Ly9wcm9ibGVtLzQ2MDMzODQzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp
LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9BUElQcm9jZXNzUG9vbENvbmZpZ3VyYXRpb24u
aDoKKwogMjAxOC0xMS0xMyAgUnlhbiBIYWRkYWQgIDxyeWFuaGFkZGFkQGFwcGxlLmNvbT4KIAog
ICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjM4MTM3LgpkaWZmIC0tZ2l0IGEvU291
cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0FQSVByb2Nlc3NQb29sQ29uZmlndXJhdGlvbi5oIGIv
U291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0FQSVByb2Nlc3NQb29sQ29uZmlndXJhdGlvbi5o
CmluZGV4IGUyMmZmYjQ3ZGU0NmRkNDhkYTA0MjRjMDQzYjU5NWQzN2FiMTA2MGQuLjBkYjdiYzc1
ZWFkMmYyMGQ1NzA3MmU4MDAzMWQ5MmU1ODVjODNjNWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL
aXQvVUlQcm9jZXNzL0FQSS9BUElQcm9jZXNzUG9vbENvbmZpZ3VyYXRpb24uaAorKysgYi9Tb3Vy
Y2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQVBJUHJvY2Vzc1Bvb2xDb25maWd1cmF0aW9uLmgKQEAg
LTIwNSwxMCArMjA1LDE1IEBAIHByaXZhdGU6CiAgICAgYm9vbCBtX3Nob3VsZENhcHR1cmVBdWRp
b0luVUlQcm9jZXNzIHsgZmFsc2UgfTsKICAgICBib29sIG1fc2hvdWxkQ2FwdHVyZURpc3BsYXlJ
blVJUHJvY2VzcyB7IERFRkFVTFRfQ0FQVFVSRV9ESVNQTEFZX0lOX1VJX1BST0NFU1MgfTsKICAg
ICBQcm9jZXNzSUQgbV9wcmVzZW50aW5nQXBwbGljYXRpb25QSUQgeyBnZXRDdXJyZW50UHJvY2Vz
c0lEKCkgfTsKKyNpZiBQTEFURk9STShNQUMpCisgICAgYm9vbCBtX3Byb2Nlc3NTd2Fwc09uTmF2
aWdhdGlvbiB7IHRydWUgfTsKKyAgICBib29sIG1faXNBdXRvbWF0aWNQcm9jZXNzV2FybWluZ0Vu
YWJsZWQgeyB0cnVlIH07CisjZWxzZQogICAgIGJvb2wgbV9wcm9jZXNzU3dhcHNPbk5hdmlnYXRp
b24geyBmYWxzZSB9OworICAgIGJvb2wgbV9pc0F1dG9tYXRpY1Byb2Nlc3NXYXJtaW5nRW5hYmxl
ZCB7IGZhbHNlIH07CisjZW5kaWYKICAgICBib29sIG1fYWx3YXlzS2VlcEFuZFJldXNlU3dhcHBl
ZFByb2Nlc3NlcyB7IGZhbHNlIH07CiAgICAgYm9vbCBtX3Byb2Nlc3NTd2Fwc09uV2luZG93T3Bl
bldpdGhPcGVuZXIgeyBmYWxzZSB9OwotICAgIGJvb2wgbV9pc0F1dG9tYXRpY1Byb2Nlc3NXYXJt
aW5nRW5hYmxlZCB7IGZhbHNlIH07CiAgICAgV1RGOjpTdHJpbmcgbV9jdXN0b21XZWJDb250ZW50
U2VydmljZUJ1bmRsZUlkZW50aWZpZXI7CiAKICNpZiBQTEFURk9STShJT1NfRkFNSUxZKQo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>354896</attachid>
            <date>2018-11-14 23:50:50 -0800</date>
            <delta_ts>2018-11-15 11:36:15 -0800</delta_ts>
            <desc>Enables PSON by default on macOS</desc>
            <filename>bug-191572-20181114235049.patch</filename>
            <type>text/plain</type>
            <size>1969</size>
            <attacher name="Ryosuke Niwa">rniwa</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL
aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzgyMTkpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv
Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE4LTExLTE0ICBSeW9zdWtlIE5p
d2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEVuYWJsZSBwcm9jZXNzIHN3YXAgb24g
Y3Jvc3Mtc2l0ZSBuYXZpZ2F0aW9uIGJ5IGRlZmF1bHQgb24gbWFjT1MKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTU3MgorICAgICAgICA8cmRhcjov
L3Byb2JsZW0vNDYwMzM4NDM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgRW5hYmxlcyB0aGUgZmVhdHVyZSBieSBkZWZhdWx0LgorCisgICAgICAgICog
VUlQcm9jZXNzL0FQSS9BUElQcm9jZXNzUG9vbENvbmZpZ3VyYXRpb24uaDoKKwogMjAxOC0xMS0x
NCAgS2VpdGggUm9sbGluICA8a3JvbGxpbkBhcHBsZS5jb20+CiAKICAgICAgICAgTW92ZSBzY3Jp
cHRzIGZvciBEZXJpdmVkIGFuZCBVbmlmaWVkIFNvdXJjZXMgdG8gZXh0ZXJuYWwgZmlsZXMKSW5k
ZXg6IFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9BUElQcm9jZXNzUG9vbENvbmZpZ3VyYXRp
b24uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQVBJUHJvY2Vz
c1Bvb2xDb25maWd1cmF0aW9uLmgJKHJldmlzaW9uIDIzODIxOCkKKysrIFNvdXJjZS9XZWJLaXQv
VUlQcm9jZXNzL0FQSS9BUElQcm9jZXNzUG9vbENvbmZpZ3VyYXRpb24uaAkod29ya2luZyBjb3B5
KQpAQCAtMjE0LDExICsyMTQsMTggQEAgcHJpdmF0ZToKICAgICBib29sIG1fc2hvdWxkQ2FwdHVy
ZUF1ZGlvSW5VSVByb2Nlc3MgeyBmYWxzZSB9OwogICAgIGJvb2wgbV9zaG91bGRDYXB0dXJlRGlz
cGxheUluVUlQcm9jZXNzIHsgREVGQVVMVF9DQVBUVVJFX0RJU1BMQVlfSU5fVUlfUFJPQ0VTUyB9
OwogICAgIFByb2Nlc3NJRCBtX3ByZXNlbnRpbmdBcHBsaWNhdGlvblBJRCB7IGdldEN1cnJlbnRQ
cm9jZXNzSUQoKSB9OwotICAgIHN0ZDo6b3B0aW9uYWw8Ym9vbD4gbV9wcm9jZXNzU3dhcHNPbk5h
dmlnYXRpb25Gcm9tQ2xpZW50OworCisjaWYgUExBVEZPUk0oTUFDKQorICAgIHN0ZDo6b3B0aW9u
YWw8Ym9vbD4gbV9wcm9jZXNzU3dhcHNPbk5hdmlnYXRpb25Gcm9tQ2xpZW50IHsgdHJ1ZSB9Owor
ICAgIHN0ZDo6b3B0aW9uYWw8Ym9vbD4gbV9pc0F1dG9tYXRpY1Byb2Nlc3NXYXJtaW5nRW5hYmxl
ZEJ5Q2xpZW50IHsgdHJ1ZSB9OworI2Vsc2UKKyAgICBzdGQ6Om9wdGlvbmFsPGJvb2w+IG1fcHJv
Y2Vzc1N3YXBzT25OYXZpZ2F0aW9uRnJvbUNsaWVudCB7IGZhbHNlIH07CisgICAgc3RkOjpvcHRp
b25hbDxib29sPiBtX2lzQXV0b21hdGljUHJvY2Vzc1dhcm1pbmdFbmFibGVkQnlDbGllbnQgeyBm
YWxzZSB9OworI2VuZGlmCisKICAgICBib29sIG1fcHJvY2Vzc1N3YXBzT25OYXZpZ2F0aW9uRnJv
bUV4cGVyaW1lbnRhbEZlYXR1cmVzIHsgZmFsc2UgfTsKICAgICBib29sIG1fYWx3YXlzS2VlcEFu
ZFJldXNlU3dhcHBlZFByb2Nlc3NlcyB7IGZhbHNlIH07CiAgICAgYm9vbCBtX3Byb2Nlc3NTd2Fw
c09uV2luZG93T3BlbldpdGhPcGVuZXIgeyBmYWxzZSB9OwotICAgIHN0ZDo6b3B0aW9uYWw8Ym9v
bD4gbV9pc0F1dG9tYXRpY1Byb2Nlc3NXYXJtaW5nRW5hYmxlZEJ5Q2xpZW50IHsgZmFsc2UgfTsK
ICAgICBXVEY6OlN0cmluZyBtX2N1c3RvbVdlYkNvbnRlbnRTZXJ2aWNlQnVuZGxlSWRlbnRpZmll
cjsKIAogI2lmIFBMQVRGT1JNKElPU19GQU1JTFkpCg==
</data>
<flag name="review"
          id="372061"
          type_id="1"
          status="-"
          setter="cdumez"
    />
          </attachment>
      

    </bug>

</bugzilla>