191556 2018-11-12 12:46:47 -0800 Treat supported-color-schemes as the second highest priority property 2018-11-13 10:44:34 -0800 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 191559 1 timothy timothy bdakin commit-queue dino megan_gardner simon.fraser webkit-bug-importer oldest_to_newest 1477670 0 timothy 2018-11-12 12:46:47 -0800 supported-color-schemes should be the second highest priority property, to ensure that its value can be checked when resolving colors. 1477671 1 webkit-bug-importer 2018-11-12 12:47:27 -0800 <rdar://problem/46000076> 1477679 2 354577 timothy 2018-11-12 13:01:11 -0800 Created attachment 354577 Patch 1478066 3 354577 commit-queue 2018-11-13 10:44:32 -0800 Comment on attachment 354577 Patch Clearing flags on attachment: 354577 Committed r238138: <https://trac.webkit.org/changeset/238138> 1478067 4 commit-queue 2018-11-13 10:44:34 -0800 All reviewed patches have been landed. Closing bug. 354577 2018-11-12 13:01:11 -0800 2018-11-13 10:44:32 -0800 Patch bug-191556-20181112130111.patch text/plain 6815 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4MDAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmNiMTVmZTAyNDkzNDkw ZWFlYzQyYTgyNTdkZDM2NTUyZTQ2YWNiMS4uYzQxZDg2YTAyZTk1ZDE5Nzc0NWVkYmU5NGEwMzhm ZGUxZWM4OTZiMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTExLTEyICBUaW1v dGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICBUcmVhdCBzdXBwb3J0 ZWQtY29sb3Itc2NoZW1lcyBhcyB0aGUgc2Vjb25kIGhpZ2hlc3QgcHJpb3JpdHkgcHJvcGVydHku CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTE1NTYK KyAgICAgICAgcmRhcjovL3Byb2JsZW0vNDYwMDAwNzYKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBjc3MtZGFyay1tb2RlL3N1cHBvcnRlZC1j b2xvci1zY2hlbWVzLXByaW9yaXR5Lmh0bWwKKworICAgICAgICAqIGNzcy9DU1NQcm9wZXJ0aWVz Lmpzb246IE1ha2Ugc3VwcG9ydGVkLWNvbG9yLXNjaGVtZXMgaGlnaC1wcmlvcml0eSBhbmQgYWRk IGEgY29tbWVudC4KKyAgICAgICAgKiBjc3MvU3R5bGVSZXNvbHZlci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpTdHlsZVJlc29sdmVyOjphcHBseU1hdGNoZWRQcm9wZXJ0aWVzKTogTWFudWFsbHkg aGFuZGxlIHN1cHBvcnRlZC1jb2xvci1zY2hlbWVzCisgICAgICAgIGFmdGVyIC13ZWJraXQtcnVi eS1wb3NpdGlvbiwgYmVmb3JlIG90aGVyIHByb3BlcnRpZXMsIHNvIGl0IGNhbiBhZmZlY3QgcmVz b2x2ZWQgY29sb3JzLgorCiAyMDE4LTExLTA4ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFw cGxlLmNvbT4KIAogICAgICAgICBBZGQgZXhwZXJpbWVudGFsIHN1cHBvcnQgZm9yIGEgYHN1cHBv cnRlZC1jb2xvci1zY2hlbWVzYCBDU1MgcHJvcGVydHkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9jc3MvQ1NTUHJvcGVydGllcy5qc29uIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1Byb3Bl cnRpZXMuanNvbgppbmRleCBhMTU0ZWIwM2ExMDE2ZjM5Y2QyMzhiMGVlNWEyY2FjNWY3MmY4Y2Zh Li5kYmQ0YTI3NTdiZDJhZTM2NWFjMjc1YjliMmU3ZDU1ODRkZTcxZDVhIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJvcGVydGllcy5qc29uCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2Nzcy9DU1NQcm9wZXJ0aWVzLmpzb24KQEAgLTU3MjIsNyArNTcyMiw5IEBACiAgICAgICAgICAg ICBdLAogICAgICAgICAgICAgImNvZGVnZW4tcHJvcGVydGllcyI6IHsKICAgICAgICAgICAgICAg ICAiY29udmVydGVyIjogIlN1cHBvcnRlZENvbG9yU2NoZW1lcyIsCi0gICAgICAgICAgICAgICAg ImVuYWJsZS1pZiI6ICJFTkFCTEVfREFSS19NT0RFX0NTUyIKKyAgICAgICAgICAgICAgICAiY29t bWVudCI6ICJUaGlzIGlzIHRoZSBzZWNvbmQgaGlnaGVzdCBwcmlvcml0eSBwcm9wZXJ0eSwgdG8g ZW5zdXJlIHRoYXQgaXRzIHZhbHVlIGNhbiBiZSBjaGVja2VkIHdoZW4gcmVzb2x2aW5nIGNvbG9y cy4iLAorICAgICAgICAgICAgICAgICJlbmFibGUtaWYiOiAiRU5BQkxFX0RBUktfTU9ERV9DU1Mi LAorICAgICAgICAgICAgICAgICJoaWdoLXByaW9yaXR5IjogdHJ1ZQogICAgICAgICAgICAgfSwK ICAgICAgICAgICAgICJzdGF0dXMiOiB7CiAgICAgICAgICAgICAgICAgInN0YXR1cyI6ICJub24t c3RhbmRhcmQiCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAKaW5kZXggMjRiMDZiZWM5 MzM3ZTE2YmI4YWI3ZjI0ZGVmOTA5YTc4YTUyODNiZS4uNGVlMWE3NzZmZGM1YTRmNzU1NjE5YmU4 YjdjODc5ZDY5ZDIzN2Q1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVz b2x2ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcApAQCAt MTM3OSw2ICsxMzc5LDExIEBAIHZvaWQgU3R5bGVSZXNvbHZlcjo6YXBwbHlNYXRjaGVkUHJvcGVy dGllcyhjb25zdCBNYXRjaFJlc3VsdCYgbWF0Y2hSZXN1bHQsIGNvbnN0CiAgICAgICAgIGFwcGx5 Q2FzY2FkZWRQcm9wZXJ0aWVzKENTU1Byb3BlcnR5V2Via2l0UnVieVBvc2l0aW9uLCBDU1NQcm9w ZXJ0eVdlYmtpdFJ1YnlQb3NpdGlvbiwgYXBwbHlTdGF0ZSk7CiAgICAgICAgIGFkanVzdFN0eWxl Rm9ySW50ZXJDaGFyYWN0ZXJSdWJ5KCk7CiAKKyNpZiBFTkFCTEUoREFSS19NT0RFX0NTUykKKyAg ICAgICAgLy8gU3VwcG9ydGVkIGNvbG9yIHNjaGVtZXMgY2FuIGFmZmVjdCByZXNvbHZlZCBjb2xv cnMsIHNvIHdlIG5lZWQgdG8gYXBwbHkgdGhhdCBwcm9wZXJ0eSBiZWZvcmUgYW55IGNvbG9yIHBy b3BlcnRpZXMuCisgICAgICAgIGFwcGx5Q2FzY2FkZWRQcm9wZXJ0aWVzKENTU1Byb3BlcnR5U3Vw cG9ydGVkQ29sb3JTY2hlbWVzLCBDU1NQcm9wZXJ0eVN1cHBvcnRlZENvbG9yU2NoZW1lcywgYXBw bHlTdGF0ZSk7CisjZW5kaWYKKwogICAgICAgICBhcHBseUNhc2NhZGVkUHJvcGVydGllcyhmaXJz dENTU1Byb3BlcnR5LCBsYXN0SGlnaFByaW9yaXR5UHJvcGVydHksIGFwcGx5U3RhdGUpOwogCiAg ICAgICAgIC8vIElmIG91ciBmb250IGdvdCBkaXJ0aWVkLCB1cGRhdGUgaXQgbm93LgpAQCAtMTM5 OCwxMiArMTQwMywxNiBAQCB2b2lkIFN0eWxlUmVzb2x2ZXI6OmFwcGx5TWF0Y2hlZFByb3BlcnRp ZXMoY29uc3QgTWF0Y2hSZXN1bHQmIG1hdGNoUmVzdWx0LCBjb25zdAogICAgIGNhc2NhZGUuYWRk SW1wb3J0YW50TWF0Y2hlcyhtYXRjaFJlc3VsdCwgbWF0Y2hSZXN1bHQucmFuZ2VzLmZpcnN0VXNl clJ1bGUsIG1hdGNoUmVzdWx0LnJhbmdlcy5sYXN0VXNlclJ1bGUsIGFwcGx5SW5oZXJpdGVkT25s eSk7CiAgICAgY2FzY2FkZS5hZGRJbXBvcnRhbnRNYXRjaGVzKG1hdGNoUmVzdWx0LCBtYXRjaFJl c3VsdC5yYW5nZXMuZmlyc3RVQVJ1bGUsIG1hdGNoUmVzdWx0LnJhbmdlcy5sYXN0VUFSdWxlLCBh cHBseUluaGVyaXRlZE9ubHkpOwogCi0KICAgICBBcHBseUNhc2NhZGVkUHJvcGVydHlTdGF0ZSBh cHBseVN0YXRlIHsgdGhpcywgJmNhc2NhZGUsICZtYXRjaFJlc3VsdCB9OwogCiAgICAgYXBwbHlD YXNjYWRlZFByb3BlcnRpZXMoQ1NTUHJvcGVydHlXZWJraXRSdWJ5UG9zaXRpb24sIENTU1Byb3Bl cnR5V2Via2l0UnVieVBvc2l0aW9uLCBhcHBseVN0YXRlKTsKICAgICBhZGp1c3RTdHlsZUZvcklu dGVyQ2hhcmFjdGVyUnVieSgpOwogCisjaWYgRU5BQkxFKERBUktfTU9ERV9DU1MpCisgICAgLy8g U3VwcG9ydGVkIGNvbG9yIHNjaGVtZXMgY2FuIGFmZmVjdCByZXNvbHZlZCBjb2xvcnMsIHNvIHdl IG5lZWQgdG8gYXBwbHkgdGhhdCBwcm9wZXJ0eSBiZWZvcmUgYW55IGNvbG9yIHByb3BlcnRpZXMu CisgICAgYXBwbHlDYXNjYWRlZFByb3BlcnRpZXMoQ1NTUHJvcGVydHlTdXBwb3J0ZWRDb2xvclNj aGVtZXMsIENTU1Byb3BlcnR5U3VwcG9ydGVkQ29sb3JTY2hlbWVzLCBhcHBseVN0YXRlKTsKKyNl bmRpZgorCiAgICAgYXBwbHlDYXNjYWRlZFByb3BlcnRpZXMoZmlyc3RDU1NQcm9wZXJ0eSwgbGFz dEhpZ2hQcmlvcml0eVByb3BlcnR5LCBhcHBseVN0YXRlKTsKIAogICAgIC8vIElmIHRoZSBlZmZl Y3RpdmUgem9vbSB2YWx1ZSBjaGFuZ2VzLCB3ZSBjYW4ndCB1c2UgdGhlIG1hdGNoZWQgcHJvcGVy dGllcyBjYWNoZS4gU3RhcnQgb3Zlci4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxv ZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA5YmNlNGJmZDE4NTRkZTU3ZjhiMGIzMDYy OTlkMDQ3ZTE4ZmFmYzBhLi44OGVmY2M5YmU4ZmE2MjRlY2JmYjJkMmU0ZTFhMzNhZTE4YjJmZmY4 IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMTEtMTIgIFRpbW90aHkgSGF0Y2hlciAgPHRp bW90aHlAYXBwbGUuY29tPgorCisgICAgICAgIFRyZWF0IHN1cHBvcnRlZC1jb2xvci1zY2hlbWVz IGFzIHRoZSBzZWNvbmQgaGlnaGVzdCBwcmlvcml0eSBwcm9wZXJ0eS4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTU1NgorICAgICAgICByZGFyOi8v cHJvYmxlbS80NjAwMDA3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogY3NzLWRhcmstbW9kZS9zdXBwb3J0ZWQtY29sb3Itc2NoZW1lcy1wcmlvcml0 eS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGNzcy1kYXJrLW1vZGUvc3VwcG9ydGVk LWNvbG9yLXNjaGVtZXMtcHJpb3JpdHkuaHRtbDogQWRkZWQuCisKIDIwMTgtMTEtMDggIFRpbW90 aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBleHBlcmltZW50 YWwgc3VwcG9ydCBmb3IgYSBgc3VwcG9ydGVkLWNvbG9yLXNjaGVtZXNgIENTUyBwcm9wZXJ0eS4K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Nzcy1kYXJrLW1vZGUvc3VwcG9ydGVkLWNvbG9yLXNj aGVtZXMtcHJpb3JpdHktZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvY3NzLWRhcmstbW9kZS9z dXBwb3J0ZWQtY29sb3Itc2NoZW1lcy1wcmlvcml0eS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4u ZmQ3NzJiOTY0MTQzNTIwNWI1ZTgwOGVkY2MxMGYwYWZkYWVjYjFmMwotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL2Nzcy1kYXJrLW1vZGUvc3VwcG9ydGVkLWNvbG9yLXNjaGVtZXMtcHJp b3JpdHktZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNSBAQAorCitQQVNTIEVsZW1lbnQgY29sb3Jz IGFyZSBjb3JyZWN0IGluIGxpZ2h0IGNvbG9yIHNjaGVtZSB3aXRoIGxpZ2h0IGFuZCBkYXJrIHN1 cHBvcnRlZCBjb2xvciBzY2hlbWUgCitQQVNTIERhcmsgY29sb3Igc2NoZW1lIGVuYWJsZWQgCitQ QVNTIEVsZW1lbnQgY29sb3JzIGFyZSBjb3JyZWN0IGluIGRhcmsgY29sb3Igc2NoZW1lIHdpdGgg bGlnaHQgYW5kIGRhcmsgc3VwcG9ydGVkIGNvbG9yIHNjaGVtZSAKKwpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvY3NzLWRhcmstbW9kZS9zdXBwb3J0ZWQtY29sb3Itc2NoZW1lcy1wcmlvcml0eS5o dG1sIGIvTGF5b3V0VGVzdHMvY3NzLWRhcmstbW9kZS9zdXBwb3J0ZWQtY29sb3Itc2NoZW1lcy1w cmlvcml0eS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmIwNDQxZDg0YmIyMDZjODI1YzMxMzE5YmExYzVkYzFk N2ZiNDM0OTcKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9jc3MtZGFyay1tb2RlL3N1 cHBvcnRlZC1jb2xvci1zY2hlbWVzLXByaW9yaXR5Lmh0bWwKQEAgLTAsMCArMSw0NCBAQAorPCFE T0NUWVBFIGh0bWw+CisKKzwhLS0gd2Via2l0LXRlc3QtcnVubmVyIFsgZXhwZXJpbWVudGFsOkRh cmtNb2RlQ1NTRW5hYmxlZD10cnVlIF0gLS0+CisKKzxzY3JpcHQgc3JjPSIuLi9yZXNvdXJjZXMv dGVzdGhhcm5lc3MuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uL3Jlc291cmNlcy90ZXN0 aGFybmVzc3JlcG9ydC5qcyI+PC9zY3JpcHQ+CisKKzxzdHlsZT4KKyN0ZXN0MSB7CisgICAgc3Vw cG9ydGVkLWNvbG9yLXNjaGVtZXM6IGxpZ2h0IGRhcms7CisgICAgY29sb3I6IHRleHQ7Cit9Cis8 L3N0eWxlPgorCis8ZGl2IGlkPSJ0ZXN0MSI+PC9kaXY+CisKKzxzY3JpcHQ+CitmdW5jdGlvbiB0 ZXN0X3Byb3AoaWQsIHByb3AsIGV4cGVjdGVkKSB7CisgICAgYXNzZXJ0X2VxdWFscyh3aW5kb3cu Z2V0Q29tcHV0ZWRTdHlsZShkb2N1bWVudC5nZXRFbGVtZW50QnlJZChpZCkpLmdldFByb3BlcnR5 VmFsdWUocHJvcCksIGV4cGVjdGVkKTsKK30KKworZnVuY3Rpb24gdGVzdF9jb2xvcl9pc193aGl0 ZShpZCkgeworICAgIHRlc3RfcHJvcCgidGVzdDEiLCAiY29sb3IiLCAicmdiKDI1NSwgMjU1LCAy NTUpIik7Cit9CisKK2Z1bmN0aW9uIHRlc3RfY29sb3JfaXNfYmxhY2soaWQpIHsKKyAgICB0ZXN0 X3Byb3AoInRlc3QxIiwgImNvbG9yIiwgInJnYigwLCAwLCAwKSIpOworfQorCit0ZXN0KGZ1bmN0 aW9uKCkgeworICAgIC8vIFRoZSBzZW1hbnRpYyB0ZXh0IGNvbG9yIHNob3VsZCBiZSBibGFjay4K KyAgICB0ZXN0X2NvbG9yX2lzX2JsYWNrKCJ0ZXN0MSIpOworfSwgIkVsZW1lbnQgY29sb3JzIGFy ZSBjb3JyZWN0IGluIGxpZ2h0IGNvbG9yIHNjaGVtZSB3aXRoIGxpZ2h0IGFuZCBkYXJrIHN1cHBv cnRlZCBjb2xvciBzY2hlbWUiKTsKKwordGVzdChmdW5jdGlvbigpIHsKKyAgICBpZiAod2luZG93 LmludGVybmFscykKKyAgICAgICAgaW50ZXJuYWxzLnNldHRpbmdzLnNldFVzZURhcmtBcHBlYXJh bmNlKHRydWUpOworfSwgIkRhcmsgY29sb3Igc2NoZW1lIGVuYWJsZWQiKTsKKwordGVzdChmdW5j dGlvbigpIHsKKyAgICAvLyBUaGUgc2VtYW50aWMgdGV4dCBjb2xvciBzaG91bGQgYmUgd2hpdGUu CisgICAgdGVzdF9jb2xvcl9pc193aGl0ZSgidGVzdDEiKTsKK30sICJFbGVtZW50IGNvbG9ycyBh cmUgY29ycmVjdCBpbiBkYXJrIGNvbG9yIHNjaGVtZSB3aXRoIGxpZ2h0IGFuZCBkYXJrIHN1cHBv cnRlZCBjb2xvciBzY2hlbWUiKTsKKzwvc2NyaXB0Pgo=