191551 2018-11-12 10:00:24 -0800 webkitpy: Check for specific process instead of using data migrator 2018-11-15 11:48:47 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain commit-queue ews-watchlist glenn lforschler ryanhaddad webkit-bug-importer oldest_to_newest 1477607 0 jbedard 2018-11-12 10:00:24 -0800 Previously, we used data migrator as a proxy for simulated devices being booted. This is imperfect because it's possible that the data migrator gets stuck but the device is still usable. Instead, there are specific processes that can be checked to determine if a device is booted or not. 1477609 1 webkit-bug-importer 2018-11-12 10:01:20 -0800 <rdar://problem/45993156> 1477611 2 354565 jbedard 2018-11-12 10:08:42 -0800 Created attachment 354565 Patch 1477629 3 354565 aakash_jain 2018-11-12 10:34:06 -0800 Comment on attachment 354565 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354565&action=review rs=me > Tools/Scripts/webkitpy/xcode/simulated_device.py:497 > + def is_usable(self, force_update=False): no caller of this method seems to be using force_update. Do we need this parameter? > Tools/Scripts/webkitpy/xcode/simulated_device.py:506 > + return True Nit: might consider adding a log statement here. 1477641 4 354570 jbedard 2018-11-12 10:58:04 -0800 Created attachment 354570 Patch 1477664 5 354570 commit-queue 2018-11-12 11:59:44 -0800 Comment on attachment 354570 Patch Clearing flags on attachment: 354570 Committed r238103: <https://trac.webkit.org/changeset/238103> 1477665 6 commit-queue 2018-11-12 11:59:45 -0800 All reviewed patches have been landed. Closing bug. 1478988 7 jbedard 2018-11-15 11:37:28 -0800 Reopening to attach new patch. 1478989 8 354960 jbedard 2018-11-15 11:37:28 -0800 Created attachment 354960 Patch 1479001 9 jbedard 2018-11-15 11:48:47 -0800 Committed r238237: <https://trac.webkit.org/changeset/238237> 354565 2018-11-12 10:08:42 -0800 2018-11-12 10:58:03 -0800 Patch bug-191551-20181112100841.patch text/plain 5588 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzODA5NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDI2IEBACisyMDE4LTExLTEyICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogQ2hlY2sgZm9yIHNwZWNpZmljIHByb2Nlc3MgaW5zdGVh ZCBvZiB1c2luZyBkYXRhIG1pZ3JhdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTE1NTEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ1OTkzMTU2 PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEl0J3Mg cG9zc2libGUgZm9yIHRoZSBkYXRhIG1pZ3JhdG9yIHByb2Nlc3MgdG8gYmUgc3R1Y2ssIGJ1dCBm b3IgYSBzaW11bGF0b3IgdG8gYmUKKyAgICAgICAgdXNhYmxlLiBVc2UgZGV2aWNlLXNwZWNpZmlj IHByb2Nlc3NlcyB0byBkZXRlY3Qgd2hlbiBhIGRldmljZSBpcyB1c2FibGUuCisKKyAgICAgICAg KiBTY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRlZF9kZXZpY2UucHk6CisgICAgICAgIChT aW11bGF0ZWREZXZpY2VNYW5hZ2VyLl93YWl0X3VudGlsX2RldmljZV9pc191c2FibGUpOgorICAg ICAgICAoU2ltdWxhdGVkRGV2aWNlTWFuYWdlcik6CisgICAgICAgIChTaW11bGF0ZWREZXZpY2VN YW5hZ2VyLmluaXRpYWxpemVfZGV2aWNlcyk6IEV4cGxpY2l0bHkgd2FpdCB1bnRpbCBhIGRldmlj ZSBpcyB1c2FibGUKKyAgICAgICAgc2luY2UgdGhpcyBpbXBsaWVzIHRoYXQgYSBkZXZpY2UgaXMg Ym9vdGVkLgorICAgICAgICAoU2ltdWxhdGVkRGV2aWNlTWFuYWdlci5zd2FwKTogRGl0dG8uCisg ICAgICAgIChTaW11bGF0ZWREZXZpY2UuaXNfdXNhYmxlKTogQ2hlY2sgdGhhdCBhIGRldmljZSBp cyBib290ZWQgYW5kIHRoYXQgYSBkZXZpY2Utc3BlY2lmaWMKKyAgICAgICAgcHJvY2VzcyBpbmRp Y2F0aW5nIHRoZSBkZXZpY2UgaXMgdXNhYmxlIGNhbiBiZSBmb3VuZC4KKyAgICAgICAgKFNpbXVs YXRlZERldmljZU1hbmFnZXIud2FpdF91bnRpbF9kYXRhX21pZ3JhdGlvbl9pc19kb25lKTogRGVs ZXRlZC4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRlZF9kZXZpY2Vf dW5pdHRlc3QucHk6IFVwZGF0ZSBzaW1jdGxfanNvbiBzbyB0aGF0CisgICAgICAgIGl0IHRyaWdn ZXJzIHRoZSBsb2dpYyBpbiBpc191c2FibGUoKQorCiAyMDE4LTExLTEyICBBbGljaWEgQm95YSBH YXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbTVNFXVtHU3RyZWFtZXJdIElu dHJvZHVjZSBBYm9ydGFibGVUYXNrUXVldWUKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv eGNvZGUvc2ltdWxhdGVkX2RldmljZS5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dl YmtpdHB5L3hjb2RlL3NpbXVsYXRlZF9kZXZpY2UucHkJKHJldmlzaW9uIDIzODA4NykKKysrIFRv b2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdGVkX2RldmljZS5weQkod29ya2luZyBj b3B5KQpAQCAtMzA5LDYgKzMwOSwxNCBAQCBjbGFzcyBTaW11bGF0ZWREZXZpY2VNYW5hZ2VyKG9i amVjdCk6CiAgICAgICAgICAgICAgICAgcmFpc2UgUnVudGltZUVycm9yKCdUaW1lZCBvdXQgd2hp bGUgd2FpdGluZyBmb3IgYWxsIGRldmljZXMgdG8gYm9vdCcpCiAKICAgICBAc3RhdGljbWV0aG9k CisgICAgZGVmIF93YWl0X3VudGlsX2RldmljZV9pc191c2FibGUoZGV2aWNlLCBkZWFkbGluZSk6 CisgICAgICAgIF9sb2cuZGVidWcoJ1dhaXRpbmcgdW50aWwge30gaXMgdXNhYmxlJy5mb3JtYXQo ZGV2aWNlKSkKKyAgICAgICAgd2hpbGUgbm90IGRldmljZS5wbGF0Zm9ybV9kZXZpY2UuaXNfdXNh YmxlKCk6CisgICAgICAgICAgICBpZiB0aW1lLnRpbWUoKSA+IGRlYWRsaW5lOgorICAgICAgICAg ICAgICAgIHJhaXNlIFJ1bnRpbWVFcnJvcignVGltZWQgb3V0IHdoaWxlIHdhaXRpbmcgZm9yIHt9 IHRvIGJlY29tZSB1c2FibGUnLmZvcm1hdChkZXZpY2UpKQorICAgICAgICAgICAgdGltZS5zbGVl cCgxKQorCisgICAgQHN0YXRpY21ldGhvZAogICAgIGRlZiBfYm9vdF9kZXZpY2UoZGV2aWNlLCBo b3N0PVN5c3RlbUhvc3QoKSk6CiAgICAgICAgIF9sb2cuZGVidWcoIkJvb3RpbmcgZGV2aWNlICd7 fSciLmZvcm1hdChkZXZpY2UudWRpZCkpCiAgICAgICAgIGRldmljZS5wbGF0Zm9ybV9kZXZpY2Uu Ym9vdGVkX2J5X3NjcmlwdCA9IFRydWUKQEAgLTM2Niw4ICszNzQsNyBAQCBjbGFzcyBTaW11bGF0 ZWREZXZpY2VNYW5hZ2VyKG9iamVjdCk6CiAKICAgICAgICAgZGVhZGxpbmUgPSB0aW1lLnRpbWUo KSArIHRpbWVvdXQKICAgICAgICAgZm9yIGRldmljZSBpbiBTaW11bGF0ZWREZXZpY2VNYW5hZ2Vy LklOSVRJQUxJWkVEX0RFVklDRVM6Ci0gICAgICAgICAgICBTaW11bGF0ZWREZXZpY2VNYW5hZ2Vy Ll93YWl0X3VudGlsX2RldmljZV9pbl9zdGF0ZShkZXZpY2UsIFNpbXVsYXRlZERldmljZS5EZXZp Y2VTdGF0ZS5CT09URUQsIGRlYWRsaW5lKQotICAgICAgICBTaW11bGF0ZWREZXZpY2VNYW5hZ2Vy LndhaXRfdW50aWxfZGF0YV9taWdyYXRpb25faXNfZG9uZShob3N0LCBtYXgoMCwgZGVhZGxpbmUg LSB0aW1lLnRpbWUoKSkpCisgICAgICAgICAgICBTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLl93YWl0 X3VudGlsX2RldmljZV9pc191c2FibGUoZGV2aWNlLCBkZWFkbGluZSkKIAogICAgICAgICByZXR1 cm4gU2ltdWxhdGVkRGV2aWNlTWFuYWdlci5JTklUSUFMSVpFRF9ERVZJQ0VTCiAKQEAgLTQxNywx OCArNDI0LDcgQEAgY2xhc3MgU2ltdWxhdGVkRGV2aWNlTWFuYWdlcihvYmplY3QpOgogICAgICAg ICBTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLklOSVRJQUxJWkVEX0RFVklDRVNbaW5kZXhdID0gZGV2 aWNlCiAKICAgICAgICAgZGVhZGxpbmUgPSB0aW1lLnRpbWUoKSArIHRpbWVvdXQKLSAgICAgICAg U2ltdWxhdGVkRGV2aWNlTWFuYWdlci5fd2FpdF91bnRpbF9kZXZpY2VfaW5fc3RhdGUoZGV2aWNl LCBTaW11bGF0ZWREZXZpY2UuRGV2aWNlU3RhdGUuQk9PVEVELCBkZWFkbGluZSkKLSAgICAgICAg U2ltdWxhdGVkRGV2aWNlTWFuYWdlci53YWl0X3VudGlsX2RhdGFfbWlncmF0aW9uX2lzX2RvbmUo aG9zdCwgbWF4KDAsIGRlYWRsaW5lIC0gdGltZS50aW1lKCkpKQotCi0gICAgQHN0YXRpY21ldGhv ZAotICAgIGRlZiB3YWl0X3VudGlsX2RhdGFfbWlncmF0aW9uX2lzX2RvbmUoaG9zdCwgdGltZW91 dD1TSU1VTEFUT1JfQk9PVF9USU1FT1VUKToKLSAgICAgICAgIyBUaGUgZXhpc3RlbmNlIG9mIGEg ZGF0YW1pZ3JhdG9yIHByb2Nlc3MgbWVhbnMgdGhhdCBzaW11bGF0b3JzIGFyZSBzdGlsbCBib290 aW5nLgotICAgICAgICBkZWFkbGluZSA9IHRpbWUudGltZSgpICsgdGltZW91dAotICAgICAgICBf bG9nLmRlYnVnKCdXYWl0aW5nIHVudGlsIG5vIGNvbS5hcHBsZS5kYXRhbWlncmF0b3IgcHJvY2Vz c2VzIGFyZSBmb3VuZCcpCi0gICAgICAgIHdoaWxlIGhvc3QuZXhlY3V0aXZlLnJ1bm5pbmdfcGlk cyhsYW1iZGEgcHJvY2Vzc19uYW1lOiAnY29tLmFwcGxlLmRhdGFtaWdyYXRvcicgaW4gcHJvY2Vz c19uYW1lKToKLSAgICAgICAgICAgIGlmIHRpbWUudGltZSgpID4gZGVhZGxpbmU6Ci0gICAgICAg ICAgICAgICAgcmFpc2UgUnVudGltZUVycm9yKCdUaW1lZCBvdXQgd2hpbGUgd2FpdGluZyBmb3Ig ZGF0YSBtaWdyYXRpb24nKQotICAgICAgICAgICAgdGltZS5zbGVlcCgxKQorICAgICAgICBTaW11 bGF0ZWREZXZpY2VNYW5hZ2VyLl93YWl0X3VudGlsX2RldmljZV9pc191c2FibGUoZGV2aWNlLCBt YXgoMCwgZGVhZGxpbmUgLSB0aW1lLnRpbWUoKSkpCiAKICAgICBAc3RhdGljbWV0aG9kCiAgICAg ZGVmIHRlYXJfZG93bihob3N0PVN5c3RlbUhvc3QoKSwgdGltZW91dD02MCk6CkBAIC00OTgsNiAr NDk0LDIyIEBAIGNsYXNzIFNpbXVsYXRlZERldmljZShvYmplY3QpOgogICAgICAgICAgICAgcmV0 dXJuIFRydWUKICAgICAgICAgcmV0dXJuIEZhbHNlCiAKKyAgICBkZWYgaXNfdXNhYmxlKHNlbGYs IGZvcmNlX3VwZGF0ZT1GYWxzZSk6CisgICAgICAgIGlmIHNlbGYuc3RhdGUoZm9yY2VfdXBkYXRl PWZvcmNlX3VwZGF0ZSkgIT0gU2ltdWxhdGVkRGV2aWNlLkRldmljZVN0YXRlLkJPT1RFRDoKKyAg ICAgICAgICAgIHJldHVybiBGYWxzZQorCisgICAgICAgIGlmIHNlbGYuZGV2aWNlX3R5cGUuc29m dHdhcmVfdmFyaWFudCA9PSAnaU9TJzoKKyAgICAgICAgICAgIGhvbWVfc2NyZWVuX3NlcnZpY2Ug PSAnY29tLmFwcGxlLnNwcmluZ2JvYXJkLnNlcnZpY2VzJworICAgICAgICBlbGlmIHNlbGYuZGV2 aWNlX3R5cGUuc29mdHdhcmVfdmVyc2lvbiA9PSAnd2F0Y2hPUyc6CisgICAgICAgICAgICBob21l X3NjcmVlbl9zZXJ2aWNlID0gJ2NvbS5hcHBsZS5jYXJvdXNlbC5zZXNzaW9uc2VydmljZScKKyAg ICAgICAgZWxzZToKKyAgICAgICAgICAgIHJldHVybiBUcnVlCisKKyAgICAgICAgZm9yIGxpbmUg aW4gc2VsZi5leGVjdXRpdmUucnVuX2NvbW1hbmQoW1NpbXVsYXRlZERldmljZU1hbmFnZXIueGNy dW4sICdzaW1jdGwnLCAnc3Bhd24nLCBzZWxmLnVkaWQsICdsYXVuY2hjdGwnLCAncHJpbnQnLCAn c3lzdGVtJ10pLnNwbGl0bGluZXMoKToKKyAgICAgICAgICAgIGlmIGhvbWVfc2NyZWVuX3NlcnZp Y2UgaW4gbGluZToKKyAgICAgICAgICAgICAgICByZXR1cm4gVHJ1ZQorICAgICAgICByZXR1cm4g RmFsc2UKKwogICAgIGRlZiBfc2h1dF9kb3duKHNlbGYsIHRpbWVvdXQ9MTAuMCk6CiAgICAgICAg IGRlYWRsaW5lID0gdGltZS50aW1lKCkgKyB0aW1lb3V0CiAKSW5kZXg6IFRvb2xzL1NjcmlwdHMv d2Via2l0cHkveGNvZGUvc2ltdWxhdGVkX2RldmljZV91bml0dGVzdC5weQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRlZF9kZXZpY2VfdW5pdHRlc3Qu cHkJKHJldmlzaW9uIDIzODA4NykKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUvc2lt dWxhdGVkX2RldmljZV91bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtNDg3LDcgKzQ4Nywx MiBAQCBzaW1jdGxfanNvbl9vdXRwdXQgPSAiIiJ7CiAgICAgIH0sCiAgICAgICJzdGF0ZSIgOiAi KGFjdGl2ZSwgZGlzY29ubmVjdGVkKSIKICAgIH0KLSB9CisgfSwKKyAic2VydmljZXMiIDogWwor ICAgIlRoaXMgdHJpZ2dlcnMgdGhlIGJhaWwtb3V0IGxvZ2ljIGluIFNpbXVsYXRlZERldmljZS5p c191c2FibGUoKSIsCisgICAiY29tLmFwcGxlLnNwcmluZ2JvYXJkLnNlcnZpY2VzIiwKKyAgICJj b20uYXBwbGUuY2Fyb3VzZWwuc2Vzc2lvbnNlcnZpY2UiCisgXQogfSIiIgogCiBpbXBvcnQganNv bgo= 354570 2018-11-12 10:58:04 -0800 2018-11-15 11:37:26 -0800 Patch bug-191551-20181112105802.patch text/plain 5728 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzODA5NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDI2IEBACisyMDE4LTExLTEyICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogQ2hlY2sgZm9yIHNwZWNpZmljIHByb2Nlc3MgaW5zdGVh ZCBvZiB1c2luZyBkYXRhIG1pZ3JhdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTE1NTEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ1OTkzMTU2 PgorCisgICAgICAgIFJ1YmJlci1zdGFtcGVkIGJ5IEFha2FzaCBKYWluLgorCisgICAgICAgIEl0 J3MgcG9zc2libGUgZm9yIHRoZSBkYXRhIG1pZ3JhdG9yIHByb2Nlc3MgdG8gYmUgc3R1Y2ssIGJ1 dCBmb3IgYSBzaW11bGF0b3IgdG8gYmUKKyAgICAgICAgdXNhYmxlLiBVc2UgZGV2aWNlLXNwZWNp ZmljIHByb2Nlc3NlcyB0byBkZXRlY3Qgd2hlbiBhIGRldmljZSBpcyB1c2FibGUuCisKKyAgICAg ICAgKiBTY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRlZF9kZXZpY2UucHk6CisgICAgICAg IChTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLl93YWl0X3VudGlsX2RldmljZV9pc191c2FibGUpOgor ICAgICAgICAoU2ltdWxhdGVkRGV2aWNlTWFuYWdlcik6CisgICAgICAgIChTaW11bGF0ZWREZXZp Y2VNYW5hZ2VyLmluaXRpYWxpemVfZGV2aWNlcyk6IEV4cGxpY2l0bHkgd2FpdCB1bnRpbCBhIGRl dmljZSBpcyB1c2FibGUKKyAgICAgICAgc2luY2UgdGhpcyBpbXBsaWVzIHRoYXQgYSBkZXZpY2Ug aXMgYm9vdGVkLgorICAgICAgICAoU2ltdWxhdGVkRGV2aWNlTWFuYWdlci5zd2FwKTogRGl0dG8u CisgICAgICAgIChTaW11bGF0ZWREZXZpY2UuaXNfdXNhYmxlKTogQ2hlY2sgdGhhdCBhIGRldmlj ZSBpcyBib290ZWQgYW5kIHRoYXQgYSBkZXZpY2Utc3BlY2lmaWMKKyAgICAgICAgcHJvY2VzcyBp bmRpY2F0aW5nIHRoZSBkZXZpY2UgaXMgdXNhYmxlIGNhbiBiZSBmb3VuZC4KKyAgICAgICAgKFNp bXVsYXRlZERldmljZU1hbmFnZXIud2FpdF91bnRpbF9kYXRhX21pZ3JhdGlvbl9pc19kb25lKTog RGVsZXRlZC4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRlZF9kZXZp Y2VfdW5pdHRlc3QucHk6IFVwZGF0ZSBzaW1jdGxfanNvbiBzbyB0aGF0CisgICAgICAgIGl0IHRy aWdnZXJzIHRoZSBsb2dpYyBpbiBpc191c2FibGUoKQorCiAyMDE4LTExLTEyICBBbGljaWEgQm95 YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbTVNFXVtHU3RyZWFtZXJd IEludHJvZHVjZSBBYm9ydGFibGVUYXNrUXVldWUKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkveGNvZGUvc2ltdWxhdGVkX2RldmljZS5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRz L3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRlZF9kZXZpY2UucHkJKHJldmlzaW9uIDIzODA4NykKKysr IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdGVkX2RldmljZS5weQkod29ya2lu ZyBjb3B5KQpAQCAtMzA5LDYgKzMwOSwxNCBAQCBjbGFzcyBTaW11bGF0ZWREZXZpY2VNYW5hZ2Vy KG9iamVjdCk6CiAgICAgICAgICAgICAgICAgcmFpc2UgUnVudGltZUVycm9yKCdUaW1lZCBvdXQg d2hpbGUgd2FpdGluZyBmb3IgYWxsIGRldmljZXMgdG8gYm9vdCcpCiAKICAgICBAc3RhdGljbWV0 aG9kCisgICAgZGVmIF93YWl0X3VudGlsX2RldmljZV9pc191c2FibGUoZGV2aWNlLCBkZWFkbGlu ZSk6CisgICAgICAgIF9sb2cuZGVidWcoJ1dhaXRpbmcgdW50aWwge30gaXMgdXNhYmxlJy5mb3Jt YXQoZGV2aWNlKSkKKyAgICAgICAgd2hpbGUgbm90IGRldmljZS5wbGF0Zm9ybV9kZXZpY2UuaXNf dXNhYmxlKGZvcmNlX3VwZGF0ZT1UcnVlKToKKyAgICAgICAgICAgIGlmIHRpbWUudGltZSgpID4g ZGVhZGxpbmU6CisgICAgICAgICAgICAgICAgcmFpc2UgUnVudGltZUVycm9yKCdUaW1lZCBvdXQg d2hpbGUgd2FpdGluZyBmb3Ige30gdG8gYmVjb21lIHVzYWJsZScuZm9ybWF0KGRldmljZSkpCisg ICAgICAgICAgICB0aW1lLnNsZWVwKDEpCisKKyAgICBAc3RhdGljbWV0aG9kCiAgICAgZGVmIF9i b290X2RldmljZShkZXZpY2UsIGhvc3Q9U3lzdGVtSG9zdCgpKToKICAgICAgICAgX2xvZy5kZWJ1 ZygiQm9vdGluZyBkZXZpY2UgJ3t9JyIuZm9ybWF0KGRldmljZS51ZGlkKSkKICAgICAgICAgZGV2 aWNlLnBsYXRmb3JtX2RldmljZS5ib290ZWRfYnlfc2NyaXB0ID0gVHJ1ZQpAQCAtMzY2LDggKzM3 NCw3IEBAIGNsYXNzIFNpbXVsYXRlZERldmljZU1hbmFnZXIob2JqZWN0KToKIAogICAgICAgICBk ZWFkbGluZSA9IHRpbWUudGltZSgpICsgdGltZW91dAogICAgICAgICBmb3IgZGV2aWNlIGluIFNp bXVsYXRlZERldmljZU1hbmFnZXIuSU5JVElBTElaRURfREVWSUNFUzoKLSAgICAgICAgICAgIFNp bXVsYXRlZERldmljZU1hbmFnZXIuX3dhaXRfdW50aWxfZGV2aWNlX2luX3N0YXRlKGRldmljZSwg U2ltdWxhdGVkRGV2aWNlLkRldmljZVN0YXRlLkJPT1RFRCwgZGVhZGxpbmUpCi0gICAgICAgIFNp bXVsYXRlZERldmljZU1hbmFnZXIud2FpdF91bnRpbF9kYXRhX21pZ3JhdGlvbl9pc19kb25lKGhv c3QsIG1heCgwLCBkZWFkbGluZSAtIHRpbWUudGltZSgpKSkKKyAgICAgICAgICAgIFNpbXVsYXRl ZERldmljZU1hbmFnZXIuX3dhaXRfdW50aWxfZGV2aWNlX2lzX3VzYWJsZShkZXZpY2UsIGRlYWRs aW5lKQogCiAgICAgICAgIHJldHVybiBTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLklOSVRJQUxJWkVE X0RFVklDRVMKIApAQCAtNDE3LDE4ICs0MjQsNyBAQCBjbGFzcyBTaW11bGF0ZWREZXZpY2VNYW5h Z2VyKG9iamVjdCk6CiAgICAgICAgIFNpbXVsYXRlZERldmljZU1hbmFnZXIuSU5JVElBTElaRURf REVWSUNFU1tpbmRleF0gPSBkZXZpY2UKIAogICAgICAgICBkZWFkbGluZSA9IHRpbWUudGltZSgp ICsgdGltZW91dAotICAgICAgICBTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLl93YWl0X3VudGlsX2Rl dmljZV9pbl9zdGF0ZShkZXZpY2UsIFNpbXVsYXRlZERldmljZS5EZXZpY2VTdGF0ZS5CT09URUQs IGRlYWRsaW5lKQotICAgICAgICBTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLndhaXRfdW50aWxfZGF0 YV9taWdyYXRpb25faXNfZG9uZShob3N0LCBtYXgoMCwgZGVhZGxpbmUgLSB0aW1lLnRpbWUoKSkp Ci0KLSAgICBAc3RhdGljbWV0aG9kCi0gICAgZGVmIHdhaXRfdW50aWxfZGF0YV9taWdyYXRpb25f aXNfZG9uZShob3N0LCB0aW1lb3V0PVNJTVVMQVRPUl9CT09UX1RJTUVPVVQpOgotICAgICAgICAj IFRoZSBleGlzdGVuY2Ugb2YgYSBkYXRhbWlncmF0b3IgcHJvY2VzcyBtZWFucyB0aGF0IHNpbXVs YXRvcnMgYXJlIHN0aWxsIGJvb3RpbmcuCi0gICAgICAgIGRlYWRsaW5lID0gdGltZS50aW1lKCkg KyB0aW1lb3V0Ci0gICAgICAgIF9sb2cuZGVidWcoJ1dhaXRpbmcgdW50aWwgbm8gY29tLmFwcGxl LmRhdGFtaWdyYXRvciBwcm9jZXNzZXMgYXJlIGZvdW5kJykKLSAgICAgICAgd2hpbGUgaG9zdC5l eGVjdXRpdmUucnVubmluZ19waWRzKGxhbWJkYSBwcm9jZXNzX25hbWU6ICdjb20uYXBwbGUuZGF0 YW1pZ3JhdG9yJyBpbiBwcm9jZXNzX25hbWUpOgotICAgICAgICAgICAgaWYgdGltZS50aW1lKCkg PiBkZWFkbGluZToKLSAgICAgICAgICAgICAgICByYWlzZSBSdW50aW1lRXJyb3IoJ1RpbWVkIG91 dCB3aGlsZSB3YWl0aW5nIGZvciBkYXRhIG1pZ3JhdGlvbicpCi0gICAgICAgICAgICB0aW1lLnNs ZWVwKDEpCisgICAgICAgIFNpbXVsYXRlZERldmljZU1hbmFnZXIuX3dhaXRfdW50aWxfZGV2aWNl X2lzX3VzYWJsZShkZXZpY2UsIG1heCgwLCBkZWFkbGluZSAtIHRpbWUudGltZSgpKSkKIAogICAg IEBzdGF0aWNtZXRob2QKICAgICBkZWYgdGVhcl9kb3duKGhvc3Q9U3lzdGVtSG9zdCgpLCB0aW1l b3V0PTYwKToKQEAgLTQ5OCw2ICs0OTQsMjMgQEAgY2xhc3MgU2ltdWxhdGVkRGV2aWNlKG9iamVj dCk6CiAgICAgICAgICAgICByZXR1cm4gVHJ1ZQogICAgICAgICByZXR1cm4gRmFsc2UKIAorICAg IGRlZiBpc191c2FibGUoc2VsZiwgZm9yY2VfdXBkYXRlPUZhbHNlKToKKyAgICAgICAgaWYgc2Vs Zi5zdGF0ZShmb3JjZV91cGRhdGU9Zm9yY2VfdXBkYXRlKSAhPSBTaW11bGF0ZWREZXZpY2UuRGV2 aWNlU3RhdGUuQk9PVEVEOgorICAgICAgICAgICAgcmV0dXJuIEZhbHNlCisKKyAgICAgICAgaWYg c2VsZi5kZXZpY2VfdHlwZS5zb2Z0d2FyZV92YXJpYW50ID09ICdpT1MnOgorICAgICAgICAgICAg aG9tZV9zY3JlZW5fc2VydmljZSA9ICdjb20uYXBwbGUuc3ByaW5nYm9hcmQuc2VydmljZXMnCisg ICAgICAgIGVsaWYgc2VsZi5kZXZpY2VfdHlwZS5zb2Z0d2FyZV92ZXJzaW9uID09ICd3YXRjaE9T JzoKKyAgICAgICAgICAgIGhvbWVfc2NyZWVuX3NlcnZpY2UgPSAnY29tLmFwcGxlLmNhcm91c2Vs LnNlc3Npb25zZXJ2aWNlJworICAgICAgICBlbHNlOgorICAgICAgICAgICAgX2xvZy5kZWJ1Zygn e30gaGFzIG5vIHNlcnZpY2UgdG8gY2hlY2sgaWYgdGhlIGRldmljZSBpcyB1c2FibGUnLmZvcm1h dChzZWxmLmRldmljZV90eXBlLnNvZnR3YXJlX3ZhcmlhbnQpKQorICAgICAgICAgICAgcmV0dXJu IFRydWUKKworICAgICAgICBmb3IgbGluZSBpbiBzZWxmLmV4ZWN1dGl2ZS5ydW5fY29tbWFuZChb U2ltdWxhdGVkRGV2aWNlTWFuYWdlci54Y3J1biwgJ3NpbWN0bCcsICdzcGF3bicsIHNlbGYudWRp ZCwgJ2xhdW5jaGN0bCcsICdwcmludCcsICdzeXN0ZW0nXSkuc3BsaXRsaW5lcygpOgorICAgICAg ICAgICAgaWYgaG9tZV9zY3JlZW5fc2VydmljZSBpbiBsaW5lOgorICAgICAgICAgICAgICAgIHJl dHVybiBUcnVlCisgICAgICAgIHJldHVybiBGYWxzZQorCiAgICAgZGVmIF9zaHV0X2Rvd24oc2Vs ZiwgdGltZW91dD0xMC4wKToKICAgICAgICAgZGVhZGxpbmUgPSB0aW1lLnRpbWUoKSArIHRpbWVv dXQKIApJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0ZWRfZGV2aWNl X3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUv c2ltdWxhdGVkX2RldmljZV91bml0dGVzdC5weQkocmV2aXNpb24gMjM4MDg3KQorKysgVG9vbHMv U2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0ZWRfZGV2aWNlX3VuaXR0ZXN0LnB5CSh3b3Jr aW5nIGNvcHkpCkBAIC00ODcsNyArNDg3LDEyIEBAIHNpbWN0bF9qc29uX291dHB1dCA9ICIiInsK ICAgICAgfSwKICAgICAgInN0YXRlIiA6ICIoYWN0aXZlLCBkaXNjb25uZWN0ZWQpIgogICAgfQot IH0KKyB9LAorICJzZXJ2aWNlcyIgOiBbCisgICAiVGhpcyB0cmlnZ2VycyB0aGUgYmFpbC1vdXQg bG9naWMgaW4gU2ltdWxhdGVkRGV2aWNlLmlzX3VzYWJsZSgpIiwKKyAgICJjb20uYXBwbGUuc3By aW5nYm9hcmQuc2VydmljZXMiLAorICAgImNvbS5hcHBsZS5jYXJvdXNlbC5zZXNzaW9uc2Vydmlj ZSIKKyBdCiB9IiIiCiAKIGltcG9ydCBqc29uCg== 354960 2018-11-15 11:37:28 -0800 2018-11-15 11:43:44 -0800 Patch bug-191551-20181115113728.patch text/plain 1491 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzODIzNSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE4LTExLTE1ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogQ2hlY2sgZm9yIHNwZWNpZmljIHByb2Nlc3MgaW5zdGVh ZCBvZiB1c2luZyBkYXRhIG1pZ3JhdG9yIChGb2xsb3ctdXAgZml4KQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkxNTUxCisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS80NTk5MzE1Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdGVkX2RldmljZS5weToK KyAgICAgICAgKFNpbXVsYXRlZERldmljZS5pc191c2FibGUpOiBVc2Ugc29mdHdhcmVfdmFyaWFu dCBpbnN0ZWFkIG9mIHNvZnR3YXJlX3ZlcnNpb24gZm9yIHdhdGNoT1MuCisKIDIwMTgtMTEtMTUg IERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIFNoaWZ0 ICsgVGFiIGRvZXMgbm90IGZvY3VzIHByZXZpb3VzIGZpZWxkCkluZGV4OiBUb29scy9TY3JpcHRz L3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRlZF9kZXZpY2UucHkKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv U2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0ZWRfZGV2aWNlLnB5CShyZXZpc2lvbiAyMzgy MzUpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRlZF9kZXZpY2UucHkJ KHdvcmtpbmcgY29weSkKQEAgLTUwMCw3ICs1MDAsNyBAQCBjbGFzcyBTaW11bGF0ZWREZXZpY2Uo b2JqZWN0KToKIAogICAgICAgICBpZiBzZWxmLmRldmljZV90eXBlLnNvZnR3YXJlX3ZhcmlhbnQg PT0gJ2lPUyc6CiAgICAgICAgICAgICBob21lX3NjcmVlbl9zZXJ2aWNlID0gJ2NvbS5hcHBsZS5z cHJpbmdib2FyZC5zZXJ2aWNlcycKLSAgICAgICAgZWxpZiBzZWxmLmRldmljZV90eXBlLnNvZnR3 YXJlX3ZlcnNpb24gPT0gJ3dhdGNoT1MnOgorICAgICAgICBlbGlmIHNlbGYuZGV2aWNlX3R5cGUu c29mdHdhcmVfdmFyaWFudCA9PSAnd2F0Y2hPUyc6CiAgICAgICAgICAgICBob21lX3NjcmVlbl9z ZXJ2aWNlID0gJ2NvbS5hcHBsZS5jYXJvdXNlbC5zZXNzaW9uc2VydmljZScKICAgICAgICAgZWxz ZToKICAgICAgICAgICAgIF9sb2cuZGVidWcoJ3t9IGhhcyBubyBzZXJ2aWNlIHRvIGNoZWNrIGlm IHRoZSBkZXZpY2UgaXMgdXNhYmxlJy5mb3JtYXQoc2VsZi5kZXZpY2VfdHlwZS5zb2Z0d2FyZV92 YXJpYW50KSkK