191545 2018-11-12 07:30:59 -0800 [GTK][WPE] Incorrect tile coverage when resizing a layer out of the visible area 2018-11-13 00:58:18 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 magomez magomez bugs-noreply cmarcelo commit-queue ews-watchlist kondapallykalyan luiz noam psaavedra zan oldest_to_newest 1477565 0 magomez 2018-11-12 07:30:59 -0800 I wasn't able to reproduce this on the desktop but I was able to see it when working on some low end devices. The problem happens when resizing a layer that has a backingStore, and that layer is at that point out of the visible area. Inside TiledBackingStore, it exactly happens when the coverRect (the rect that we keep tiles for) and the visible rect don't overlap (empty intersection). When the layer size changes, inside TiledBackingStore::createTiles, a call to resizeEdgeTiles() is required in order to resize the tiles on the edges to the new size. But as the code is now, that doesn't happen if the coverRect is empty (and in the scenario I mentioned it's emptied). As the size change is only detected inside the scope of that function and then forgotten, it's not performed when the layer comes into the visible area again, causing a glitch. The fix would mean remembering that there was a size change so when the layer comes into the visible area again, the edge tiles are properly resized. 1477571 1 354560 magomez 2018-11-12 08:15:18 -0800 Created attachment 354560 Patch 1477942 2 354560 commit-queue 2018-11-13 00:58:17 -0800 Comment on attachment 354560 Patch Clearing flags on attachment: 354560 Committed r238126: <https://trac.webkit.org/changeset/238126> 1477943 3 commit-queue 2018-11-13 00:58:18 -0800 All reviewed patches have been landed. Closing bug. 354560 2018-11-12 08:15:18 -0800 2018-11-13 00:58:17 -0800 Patch bug-191545-20181112171517.patch text/plain 3001 magomez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4MDgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjUwNTEzNjI3NDc2YWNl MWM0OWY2NDdkMTU4NzhjNDViMmJmZmMyMC4uMzZhMzhmMzZkZDlhYjVjN2JiOTQ4YTZmNTg5ZGIz YzhkZjgxMmU4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTExLTEyICBNaWd1 ZWwgR29tZXogIDxtYWdvbWV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bV1BFXSBJbmNv cnJlY3QgdGlsZSBjb3ZlcmFnZSB3aGVuIHJlc2l6aW5nIGEgbGF5ZXIgb3V0IG9mIHRoZSB2aXNp YmxlIGFyZWEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE5MTU0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEtlZXAgdHJhY2sgb2YgbGF5ZXIgc2l6ZSBjaGFuZ2VzIGV2ZW4gaWYgdGhleSBoYXBwZW4gd2hl biB0aGUgbGF5ZXIgaXMgbm90IGluIHRoZSB2aXNpYmxlCisgICAgICAgIGFyZWEsIHNvIHdlIGNh biB1cGRhdGUgZWRnZSB0aWxlcyB3aGVuIHRoZSBsYXllciBnZXRzIHZpc2libGUuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvY29vcmRpbmF0ZWQvVGlsZWRCYWNraW5nU3Rv cmUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGlsZWRCYWNraW5nU3RvcmU6OmNyZWF0ZVRpbGVz KToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvY29vcmRpbmF0ZWQvVGlsZWRC YWNraW5nU3RvcmUuaDoKKwogMjAxOC0xMS0xMiAgWGFiaWVyIFJvZHJpZ3VleiBDYWx2YXIgIDxj YWx2YXJpc0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHU3RyZWFtZXJdW0VNRV0gd2FpdGluZ2Zv cmtleSBldmVudCBzaG91bGQgY29uc2lkZXIgZGVjcnlwdG9ycycgd2FpdGluZyBzdGF0dXMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGlu YXRlZC9UaWxlZEJhY2tpbmdTdG9yZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy90ZXhtYXAvY29vcmRpbmF0ZWQvVGlsZWRCYWNraW5nU3RvcmUuY3BwCmluZGV4IGUwYjAx MDIwMzU4YWJmNjQ2ODc0NGVhNTBiYTI1ZGJhZmRiYjhjMDguLjNiZTQzMTFkZWFhMDI0OTdjN2Vk MWNkY2ExMzQ1YmE1YTY4MDMxMDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9UaWxlZEJhY2tpbmdTdG9yZS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL1RpbGVk QmFja2luZ1N0b3JlLmNwcApAQCAtMTM5LDcgKzEzOSw2IEBAIGJvb2wgVGlsZWRCYWNraW5nU3Rv cmU6OnZpc2libGVBcmVhSXNDb3ZlcmVkKCkgY29uc3QKIHZvaWQgVGlsZWRCYWNraW5nU3RvcmU6 OmNyZWF0ZVRpbGVzKGNvbnN0IEludFJlY3QmIHZpc2libGVSZWN0LCBjb25zdCBJbnRSZWN0JiBz Y2FsZWRDb250ZW50c1JlY3QsIGZsb2F0IGNvdmVyQXJlYU11bHRpcGxpZXIpCiB7CiAgICAgLy8g VXBkYXRlIG91ciBiYWNraW5nIHN0b3JlIGdlb21ldHJ5LgotICAgIGNvbnN0IEludFJlY3QgcHJl dmlvdXNSZWN0ID0gbV9yZWN0OwogICAgIG1fcmVjdCA9IHNjYWxlZENvbnRlbnRzUmVjdDsKICAg ICBtX3RyYWplY3RvcnlWZWN0b3IgPSBtX3BlbmRpbmdUcmFqZWN0b3J5VmVjdG9yOwogICAgIG1f dmlzaWJsZVJlY3QgPSB2aXNpYmxlUmVjdDsKQEAgLTE4NCw4ICsxODMsMTAgQEAgdm9pZCBUaWxl ZEJhY2tpbmdTdG9yZTo6Y3JlYXRlVGlsZXMoY29uc3QgSW50UmVjdCYgdmlzaWJsZVJlY3QsIGNv bnN0IEludFJlY3QmIHMKIAogICAgIC8vIFJlc2l6ZSB0aWxlcyBhdCB0aGUgZWRnZSBpbiBjYXNl IHRoZSBjb250ZW50cyBzaXplIGhhcyBjaGFuZ2VkLCBidXQgb25seSBkbyBzbwogICAgIC8vIGFm dGVyIGhhdmluZyBkcm9wcGVkIHRpbGVzIG91dHNpZGUgdGhlIGtlZXAgcmVjdC4KLSAgICBpZiAo cHJldmlvdXNSZWN0ICE9IG1fcmVjdCkKKyAgICBpZiAobV9wcmV2aW91c1JlY3QgIT0gbV9yZWN0 KSB7CisgICAgICAgIG1fcHJldmlvdXNSZWN0ID0gbV9yZWN0OwogICAgICAgICByZXNpemVFZGdl VGlsZXMoKTsKKyAgICB9CiAKICAgICAvLyBTZWFyY2ggZm9yIHRoZSB0aWxlIHBvc2l0aW9uIGNs b3Nlc3QgdG8gdGhlIHZpZXdwb3J0IGNlbnRlciB0aGF0IGRvZXMgbm90IHlldCBjb250YWluIGEg dGlsZS4KICAgICAvLyBXaGljaCBwb3NpdGlvbiBpcyBjb25zaWRlcmVkIHRoZSBjbG9zZXN0IGRl cGVuZHMgb24gdGhlIHRpbGVEaXN0YW5jZSBmdW5jdGlvbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9UaWxlZEJhY2tpbmdT dG9yZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5h dGVkL1RpbGVkQmFja2luZ1N0b3JlLmgKaW5kZXggNzVmYWVlNjUyOGYwNzFjOGE0MmQ5YjlmZmE4 ZGNkYzhjODdkNDQ5My4uZjcwYTJkMGM4MGE4MmY4ODM2YTIyNmZlMjIzOGM5NWExMDIwYzcwMiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3Jk aW5hdGVkL1RpbGVkQmFja2luZ1N0b3JlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL1RpbGVkQmFja2luZ1N0b3JlLmgKQEAgLTkxLDYg KzkxLDcgQEAgcHJpdmF0ZToKICAgICBJbnRSZWN0IG1fY292ZXJSZWN0OwogICAgIEludFJlY3Qg bV9rZWVwUmVjdDsKICAgICBJbnRSZWN0IG1fcmVjdDsKKyAgICBJbnRSZWN0IG1fcHJldmlvdXNS ZWN0OwogCiAgICAgZmxvYXQgbV9jb250ZW50c1NjYWxlOwogCg==