191504 2018-11-10 10:04:29 -0800 [GTK] Silence ATK_XY_PARENT warnings 2018-11-12 01:05:58 -0800 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro aboxhall apinheiro bugs-noreply cfleizach cgarcia commit-queue dmazzoni ews-watchlist jcraig jdiggs mcatanzaro samuel_white webkit-bug-importer oldest_to_newest 1477277 0 mcatanzaro 2018-11-10 10:04:29 -0800 Who knows how ATX_XY_PARENT is supposed to be handled. For now, let's crash rather than risk mystery surprises. [2003/2862] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/unified-sources/UnifiedSource151.cpp.o In file included from DerivedSources/WebCore/unified-sources/UnifiedSource151.cpp:6: /home/mcatanzaro/Projects/WebKit/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceComponent.cpp: In function ‘WebCore::IntPoint atkToContents(WebCore::AccessibilityObject*, AtkCoordType, gint, gint)’: /home/mcatanzaro/Projects/WebKit/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceComponent.cpp:58:16: warning: enumeration value ‘ATK_XY_PARENT’ not handled in switch [-Wswitch] switch (coordType) { ^ [2003/2862] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/unifie[2004/2862] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/unified-sources/UnifiedSource152.cpp.o In file included from DerivedSources/WebCore/unified-sources/UnifiedSource152.cpp:7: /home/mcatanzaro/Projects/WebKit/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp: In function ‘WebCore::IntRect textExtents(AtkText*, gint, gint, AtkCoordType)’: /home/mcatanzaro/Projects/WebKit/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp:320:12: warning: enumeration value ‘ATK_XY_PARENT’ not handled in switch [-Wswitch] switch (coords) { ^ [2004/2862] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/unifie[2005/2862] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/unifie[2005/2862] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/unifie[2006/2862] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/unifie[2006/2862] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/unifie[2007/2862] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/unified-sources/UnifiedSource153.cpp.o In file included from DerivedSources/WebCore/unified-sources/UnifiedSource153.cpp:1: /home/mcatanzaro/Projects/WebKit/Source/WebCore/accessibility/atk/WebKitAccessibleUtil.cpp: In function ‘void contentsRelativeToAtkCoordinateType(WebCore::AccessibilityObject*, AtkCoordType, WebCore::IntRect, gint*, gint*, gint*, gint*)’: /home/mcatanzaro/Projects/WebKit/Source/WebCore/accessibility/atk/WebKitAccessibleUtil.cpp:62:16: warning: enumeration value ‘ATK_XY_PARENT’ not handled in switch [-Wswitch] switch (coordType) { ^ 1477278 1 webkit-bug-importer 2018-11-10 10:05:20 -0800 <rdar://problem/45968543> 1477293 2 354464 mcatanzaro 2018-11-10 11:06:58 -0800 Created attachment 354464 Patch 1477502 3 354464 commit-queue 2018-11-12 01:05:56 -0800 Comment on attachment 354464 Patch Clearing flags on attachment: 354464 Committed r238082: <https://trac.webkit.org/changeset/238082> 1477503 4 commit-queue 2018-11-12 01:05:58 -0800 All reviewed patches have been landed. Closing bug. 354464 2018-11-10 11:06:58 -0800 2018-11-12 01:05:56 -0800 Patch bug-191504-20181110130657.patch text/plain 3019 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4MDY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2U0ZDlhMTgxNzQ2ZTVm YWIyMTVkYjU3YTc0NDI5ZTUyYWRhMDc3Mi4uYzY5OTRmN2RiMjIyYWEwMzdiNjA1ZGJlNWYyZWJm NmFkMzkyYTc2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTExLTEwICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBT aWxlbmNlIEFUS19YWV9QQVJFTlQgd2FybmluZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTUwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJs ZUludGVyZmFjZUNvbXBvbmVudC5jcHA6CisgICAgICAgIChhdGtUb0NvbnRlbnRzKToKKyAgICAg ICAgKiBhY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlSW50ZXJmYWNlVGV4dC5jcHA6 CisgICAgICAgICh0ZXh0RXh0ZW50cyk6CisgICAgICAgICogYWNjZXNzaWJpbGl0eS9hdGsvV2Vi S2l0QWNjZXNzaWJsZVV0aWwuY3BwOgorICAgICAgICAoY29udGVudHNSZWxhdGl2ZVRvQXRrQ29v cmRpbmF0ZVR5cGUpOgorCiAyMDE4LTExLTEwICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25A YXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgaXQgcG9zc2libGUgdG8gZWRpdCBpbWFnZXMgaW5s aW5lCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRB Y2Nlc3NpYmxlSW50ZXJmYWNlQ29tcG9uZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2li aWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVJbnRlcmZhY2VDb21wb25lbnQuY3BwCmluZGV4IGU4 NmYyMzA5ODRiZWNiNDg5NjVkNjRlMTA5MzhkOTIxOTI1ODFiNDkuLjQzOWZlOTZjMjk1ZjIzMThk MGI5ZDU5YzI5NzY5MTIwY2U0M2RkYmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vz c2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVJbnRlcmZhY2VDb21wb25lbnQuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVJbnRlcmZh Y2VDb21wb25lbnQuY3BwCkBAIC02MCw2ICs2MCwxMCBAQCBzdGF0aWMgSW50UG9pbnQgYXRrVG9D b250ZW50cyhBY2Nlc3NpYmlsaXR5T2JqZWN0KiBjb3JlT2JqZWN0LCBBdGtDb29yZFR5cGUgY29v cgogICAgICAgICAgICAgcmV0dXJuIGZyYW1lVmlldy0+c2NyZWVuVG9Db250ZW50cyhwb3MpOwog ICAgICAgICBjYXNlIEFUS19YWV9XSU5ET1c6CiAgICAgICAgICAgICByZXR1cm4gZnJhbWVWaWV3 LT53aW5kb3dUb0NvbnRlbnRzKHBvcyk7CisjaWYgQVRLX0NIRUNLX1ZFUlNJT04oMiwgMzAsIDAp CisgICAgICAgIGNhc2UgQVRLX1hZX1BBUkVOVDoKKyAgICAgICAgICAgIFJFTEVBU0VfQVNTRVJU X05PVF9SRUFDSEVEKCk7CisjZW5kaWYKICAgICAgICAgfQogICAgIH0KIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZUludGVyZmFj ZVRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNz aWJsZUludGVyZmFjZVRleHQuY3BwCmluZGV4IGEzYTRmN2FkMjRjOTdiZjJmYjIwYjAxN2IwOTAx MGRjMzM3M2Y1OGIuLjE4YzllOWI1Nzk3Yzk5MTZkMjYyNWE5ZmI0MGM2N2ZmNjMxMDM3ZGUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2li bGVJbnRlcmZhY2VUZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0 ay9XZWJLaXRBY2Nlc3NpYmxlSW50ZXJmYWNlVGV4dC5jcHAKQEAgLTMyNSw2ICszMjUsMTAgQEAg c3RhdGljIEludFJlY3QgdGV4dEV4dGVudHMoQXRrVGV4dCogdGV4dCwgZ2ludCBzdGFydE9mZnNl dCwgZ2ludCBsZW5ndGgsIEF0a0Nvb3IKICAgICBjYXNlIEFUS19YWV9XSU5ET1c6CiAgICAgICAg IC8vIE5vLW9wCiAgICAgICAgIGJyZWFrOworI2lmIEFUS19DSEVDS19WRVJTSU9OKDIsIDMwLCAw KQorICAgIGNhc2UgQVRLX1hZX1BBUkVOVDoKKyAgICAgICAgUkVMRUFTRV9BU1NFUlRfTk9UX1JF QUNIRUQoKTsKKyNlbmRpZgogICAgIH0KIAogICAgIHJldHVybiBleHRlbnRzOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZVV0aWwu Y3BwIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZVV0 aWwuY3BwCmluZGV4IDhmOTkzZDFlODJhMWU3NWE3YjI1NmY4ZTdlMTEwNWRmYzgxMDg2MTMuLmEy NmY3MGEyMjA3MmRlNTFlZDkyYzJkOWIxODAxOTIxODUzMzg1YTQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVVdGlsLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlVXRpbC5j cHAKQEAgLTY2LDYgKzY2LDEwIEBAIHZvaWQgY29udGVudHNSZWxhdGl2ZVRvQXRrQ29vcmRpbmF0 ZVR5cGUoQWNjZXNzaWJpbGl0eU9iamVjdCogY29yZU9iamVjdCwgQXRrQ29vCiAgICAgICAgIGNh c2UgQVRLX1hZX1NDUkVFTjoKICAgICAgICAgICAgIHJlY3QgPSBmcmFtZVZpZXctPmNvbnRlbnRz VG9TY3JlZW4ocmVjdCk7CiAgICAgICAgICAgICBicmVhazsKKyNpZiBBVEtfQ0hFQ0tfVkVSU0lP TigyLCAzMCwgMCkKKyAgICAgICAgY2FzZSBBVEtfWFlfUEFSRU5UOgorICAgICAgICAgICAgUkVM RUFTRV9BU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyNlbmRpZgogICAgICAgICB9CiAgICAgfQogCg==