191479 2018-11-09 12:12:08 -0800 [MediaStream] AVVideoCaptureSource reports incorrect size when frames are scaled 2018-11-09 13:26:25 -0800 1 1 1 Unclassified WebKit WebRTC Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue jer.noble webkit-bug-importer youennf oldest_to_newest 1477036 0 eric.carlson 2018-11-09 12:12:08 -0800 AVVideoCaptureSource reports incorrect size when frames are scaled 1477038 1 webkit-bug-importer 2018-11-09 12:13:15 -0800 <rdar://problem/45952201> 1477047 2 354371 eric.carlson 2018-11-09 12:25:00 -0800 Created attachment 354371 Patch 1477073 3 youennf 2018-11-09 13:18:46 -0800 View in context: https://bugs.webkit.org/attachment.cgi?id=354371&action=review > Source/WebCore/platform/mediastream/RealtimeVideoSource.cpp:307 > + continue; exactSizePreset seems to be set above and there is a continue just after it. Maybe we could just have a continue in case we set aspectRatioPreset 4 lines above? > Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:523 > m_buffer = &sample.get(); Do we need m_buffer/shutdownCaptureSession anymore? 1477076 4 354371 commit-queue 2018-11-09 13:26:23 -0800 Comment on attachment 354371 Patch Clearing flags on attachment: 354371 Committed r238053: <https://trac.webkit.org/changeset/238053> 1477077 5 commit-queue 2018-11-09 13:26:25 -0800 All reviewed patches have been landed. Closing bug. 354371 2018-11-09 12:25:00 -0800 2018-11-09 13:26:23 -0800 Patch bug-191479-20181109122459.patch text/plain 6602 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3OTI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjY3OGM5ZWNkNGIzZGM2 ZDcxMGMyOTFlMDE1YTZjZmYzYzY0ZDZiZS4uYTVlNTJlNGJmZGJkOTQzN2FkYWFhMThjZWZjNDMy YzZjZjY0YTcyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE4LTExLTA5ICBFcmlj IENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtNZWRpYVN0cmVh bV0gQVZWaWRlb0NhcHR1cmVTb3VyY2UgcmVwb3J0cyBpbmNvcnJlY3Qgc2l6ZSB3aGVuIGZyYW1l cyBhcmUgc2NhbGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xOTE0NzkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ1OTUyMjAxPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgdGVz dGVkIG1hbnVhbGx5LgorCisgICAgICAgICogcGxhdGZvcm0vbWVkaWFzdHJlYW0vUmVhbHRpbWVW aWRlb1NvdXJjZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZWFsdGltZVZpZGVvU291cmNlOjpz dGFuZGFyZFZpZGVvU2l6ZXMpOiBEcml2ZS1ieSBmaXg6IGFkZCBhIGZldyBtb3JlIHN0YW5kYXJk CisgICAgICAgIHZpZGVvIGZyYW1lIHNpemVzLCBjb3JyZWN0IGEgdHlwby4KKyAgICAgICAgKFdl YkNvcmU6OlJlYWx0aW1lVmlkZW9Tb3VyY2U6OmJlc3RTdXBwb3J0ZWRTaXplQW5kRnJhbWVSYXRl KTogRHJpdmUtYnkgZml4OiBkb24ndCBjb25zaWRlcgorICAgICAgICByZXNjYWxlZCBzaXplZCB3 aGVuIHdlIGFscmVhZHkgaGF2ZSBhbiBleGFjdCBvciBhc3BlY3QgcmF0aW8gbWF0Y2ggYmVjYXVz ZSBpdCB3b24ndCBiZSB1c2VkLgorCisgICAgICAgICogcGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFj L0FWVmlkZW9DYXB0dXJlU291cmNlLmg6CisgICAgICAgIChXZWJDb3JlOjpBVlZpZGVvQ2FwdHVy ZVNvdXJjZTo6d2lkdGggY29uc3QpOiBEZWxldGVkLgorICAgICAgICAoV2ViQ29yZTo6QVZWaWRl b0NhcHR1cmVTb3VyY2U6OmhlaWdodCBjb25zdCk6IERlbGV0ZWQuCisgICAgICAgICogcGxhdGZv cm0vbWVkaWFzdHJlYW0vbWFjL0FWVmlkZW9DYXB0dXJlU291cmNlLm1tOgorICAgICAgICAoV2Vi Q29yZTo6QVZWaWRlb0NhcHR1cmVTb3VyY2U6OnNldFNpemVBbmRGcmFtZVJhdGVXaXRoUHJlc2V0 KTogRGVsZXRlIG1fcmVxdWVzdGVkU2l6ZS4KKyAgICAgICAgKFdlYkNvcmU6OkFWVmlkZW9DYXB0 dXJlU291cmNlOjpzaHV0ZG93bkNhcHR1cmVTZXNzaW9uKTogRGVsZXRlIG1fd2lkdGggYW5kIG1f aGVpZ2h0LgorICAgICAgICAoV2ViQ29yZTo6QVZWaWRlb0NhcHR1cmVTb3VyY2U6OnByb2Nlc3NO ZXdGcmFtZSk6IERvbid0IGNhbGwgc2V0U2l6ZSB3aXRoIGNhcHR1cmVkIHNpemUsCisgICAgICAg IHRoZSBmcmFtZSBtYXkgYmUgcmVzaXplZCBiZWZvcmUgZGVsaXZlci4KKwogMjAxOC0xMS0wNyAg U2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBUaWxlQ29u dHJvbGxlcjo6dGlsZVNpemUoKSBzaG91bGQgbm90IGhhdmUgc2lkZSBlZmZlY3RzCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9SZWFsdGltZVZpZGVvU291 cmNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL1JlYWx0aW1lVmlk ZW9Tb3VyY2UuY3BwCmluZGV4IDBiNGE2ZWQxYzhlMTU1N2E4NDFlMjQxZGRiN2UzZWEyNjczNTcz MDEuLjRmNTlhNjBjYzRkZmMyMzgxMzg0OTI2YzFiZGI1ZmZkOGU1ZWYzOTcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL1JlYWx0aW1lVmlkZW9Tb3VyY2Uu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL1JlYWx0aW1lVmlk ZW9Tb3VyY2UuY3BwCkBAIC0xMDMsMjAgKzEwMywyMSBAQCBjb25zdCBWZWN0b3I8SW50U2l6ZT4m IFJlYWx0aW1lVmlkZW9Tb3VyY2U6OnN0YW5kYXJkVmlkZW9TaXplcygpCiAgICAgICAgICAgICB7 IDExMiwgMTEyIH0sCiAgICAgICAgICAgICB7IDE2MCwgMTYwIH0sCiAgICAgICAgICAgICB7IDE2 MCwgMTIwIH0sIC8vIDQ6MywgUVFWR0EKKyAgICAgICAgICAgIHsgMTc2LCAxNDQgfSwgLy8gNDoz LCBRQ0lGCiAgICAgICAgICAgICB7IDE5MiwgMTkyIH0sCiAgICAgICAgICAgICB7IDE5MiwgMTEy IH0sIC8vIDE2OjkKICAgICAgICAgICAgIHsgMTkyLCAxNDQgfSwgLy8gMzo0CiAgICAgICAgICAg ICB7IDI0MCwgMjQwIH0sCiAgICAgICAgICAgICB7IDI0MCwgMTYwIH0sIC8vIDM6MiwgSFFWR0EK ICAgICAgICAgICAgIHsgMzIwLCAzMjAgfSwKLSAgICAgICAgICAgIHsgMzIwLCAxNzYgfSwgLy8g MTY6OQorICAgICAgICAgICAgeyAzMjAsIDE4MCB9LCAvLyAxNjo5CiAgICAgICAgICAgICB7IDMy MCwgMjQwIH0sIC8vIDQ6MywgUVZHQQogICAgICAgICAgICAgeyAzNTIsIDI4OCB9LCAvLyBDSUYK ICAgICAgICAgICAgIHsgNDgwLCAyNzIgfSwgLy8gMTY6OQogICAgICAgICAgICAgeyA0ODAsIDM2 MCB9LCAvLyA0OjMKICAgICAgICAgICAgIHsgNDgwLCA0ODAgfSwKICAgICAgICAgICAgIHsgNjQw LCA2NDAgfSwKLSAgICAgICAgICAgIHsgNjQwLCAzNjggfSwgLy8gMTY6OQorICAgICAgICAgICAg eyA2NDAsIDM2MCB9LCAvLyAxNjo5LCAzNjBwIG5IRAogICAgICAgICAgICAgeyA2NDAsIDQ4MCB9 LCAvLyA0OjMKICAgICAgICAgICAgIHsgNzIwLCA3MjAgfSwKICAgICAgICAgICAgIHsgODAwLCA2 MDAgfSwgLy8gNDozLCBTVkdBCkBAIC0xMjcsNyArMTI4LDggQEAgY29uc3QgVmVjdG9yPEludFNp emU+JiBSZWFsdGltZVZpZGVvU291cmNlOjpzdGFuZGFyZFZpZGVvU2l6ZXMoKQogICAgICAgICAg ICAgeyAxMjgwLCAxMDI0IH0sIC8vIDU6NCwgU1hHQQogICAgICAgICAgICAgeyAxMjgwLCA3MjAg fSwgLy8gMTY6OSwgV1hHQQogICAgICAgICAgICAgeyAxMzY2LCA3NjggfSwgLy8gMTY6OSwgSEQK LSAgICAgICAgICAgIHsgMTkyMCwgMTA4MCB9LCAvLyAxNjo5LCBGSEQKKyAgICAgICAgICAgIHsg MTYwMCwgMTIwMH0sIC8vIDQ6MywgVVhHQQorICAgICAgICAgICAgeyAxOTIwLCAxMDgwIH0sIC8v IDE2OjksIDEwODBwIEZIRAogICAgICAgICAgICAgeyAyNTYwLCAxNDQwIH0sIC8vIDE2OjksIFFI RAogICAgICAgICAgICAgeyAyNTkyLCAxOTM2IH0sCiAgICAgICAgICAgICB7IDMyNjQsIDI0NDgg fSwgLy8gMzo0CkBAIC0zMDEsNiArMzAzLDkgQEAgc3RkOjpvcHRpb25hbDxSZWFsdGltZVZpZGVv U291cmNlOjpDYXB0dXJlU2l6ZUFuZEZyYW1lUmF0ZT4gUmVhbHRpbWVWaWRlb1NvdXJjZToKICAg ICAgICAgICAgIH0KICAgICAgICAgfQogCisgICAgICAgIGlmIChleGFjdFNpemVQcmVzZXQgfHwg YXNwZWN0UmF0aW9QcmVzZXQpCisgICAgICAgICAgICBjb250aW51ZTsKKwogICAgICAgICBpZiAo cmVxdWVzdGVkV2lkdGggJiYgcmVxdWVzdGVkSGVpZ2h0KSB7CiAgICAgICAgICAgICBjb25zdCBh dXRvJiBtaW5TdGFuZGFyZFNpemUgPSBzdGFuZGFyZFZpZGVvU2l6ZXMoKVswXTsKICAgICAgICAg ICAgIGlmIChyZXF1ZXN0ZWRXaWR0aC52YWx1ZSgpID49IG1pblN0YW5kYXJkU2l6ZS53aWR0aCgp ICYmIHJlcXVlc3RlZEhlaWdodC52YWx1ZSgpID49IG1pblN0YW5kYXJkU2l6ZS5oZWlnaHQoKSkg ewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFjL0FW VmlkZW9DYXB0dXJlU291cmNlLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVh bS9tYWMvQVZWaWRlb0NhcHR1cmVTb3VyY2UuaAppbmRleCAzYzFiMDJjZGFiZDRjNTgzMmIyNDQx NzgxMDVkMzZiYTQ5OTk3NzE4Li42NTNjOGRlZTNkZDI3MjVkNzUyZmE3NGFkOTY4ZDIwYTNiNTQ1 N2ZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMv QVZWaWRlb0NhcHR1cmVTb3VyY2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRp YXN0cmVhbS9tYWMvQVZWaWRlb0NhcHR1cmVTb3VyY2UuaApAQCAtNTcsOSArNTcsNiBAQCBwdWJs aWM6CiAKICAgICBXRUJDT1JFX0VYUE9SVCBzdGF0aWMgVmlkZW9DYXB0dXJlRmFjdG9yeSYgZmFj dG9yeSgpOwogCi0gICAgaW50MzJfdCB3aWR0aCgpIGNvbnN0IHsgcmV0dXJuIG1fd2lkdGg7IH0K LSAgICBpbnQzMl90IGhlaWdodCgpIGNvbnN0IHsgcmV0dXJuIG1faGVpZ2h0OyB9Ci0KICAgICBl bnVtIGNsYXNzIEludGVycnVwdGlvblJlYXNvbiB7IE5vbmUsIFZpZGVvTm90QWxsb3dlZEluQmFj a2dyb3VuZCwgQXVkaW9JblVzZSwgVmlkZW9JblVzZSwgVmlkZW9Ob3RBbGxvd2VkSW5TaWRlQnlT aWRlIH07CiAgICAgdm9pZCBjYXB0dXJlU2Vzc2lvbkJlZ2luSW50ZXJydXB0aW9uKFJldGFpblB0 cjxOU05vdGlmaWNhdGlvbj4pOwogICAgIHZvaWQgY2FwdHVyZVNlc3Npb25FbmRJbnRlcnJ1cHRp b24oUmV0YWluUHRyPE5TTm90aWZpY2F0aW9uPik7CkBAIC0xMTIsOSArMTA5LDYgQEAgcHJpdmF0 ZToKICAgICBSZXRhaW5QdHI8QVZDYXB0dXJlVmlkZW9EYXRhT3V0cHV0PiBtX3ZpZGVvT3V0cHV0 OwogICAgIHN0ZDo6dW5pcXVlX3B0cjxJbWFnZVRyYW5zZmVyU2Vzc2lvblZUPiBtX2ltYWdlVHJh bnNmZXJTZXNzaW9uOwogCi0gICAgSW50U2l6ZSBtX3JlcXVlc3RlZFNpemU7Ci0gICAgaW50MzJf dCBtX3dpZHRoIHsgMCB9OwotICAgIGludDMyX3QgbV9oZWlnaHQgeyAwIH07CiAgICAgaW50IG1f c2Vuc29yT3JpZW50YXRpb24geyAwIH07CiAgICAgaW50IG1fZGV2aWNlT3JpZW50YXRpb24geyAw IH07CiAgICAgTWVkaWFTYW1wbGU6OlZpZGVvUm90YXRpb24gbV9zYW1wbGVSb3RhdGlvbiB7IE1l ZGlhU2FtcGxlOjpWaWRlb1JvdGF0aW9uOjpOb25lIH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvQVZWaWRlb0NhcHR1cmVTb3VyY2UubW0gYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvQVZWaWRlb0NhcHR1cmVTb3Vy Y2UubW0KaW5kZXggODNhZmVkNzYyZmM2MTJlNDMxMmExMTU2YzI5NWRkMzhhOGNjNDA4MC4uMTk4 MTQ4YzY4NWM4OTllNWQzMmFjY2IxMzhkZTU0MmY1MzM1M2FkMSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFjL0FWVmlkZW9DYXB0dXJlU291cmNlLm1t CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL21hYy9BVlZpZGVvQ2Fw dHVyZVNvdXJjZS5tbQpAQCAtMzMxLDggKzMzMSw2IEBAIHZvaWQgQVZWaWRlb0NhcHR1cmVTb3Vy Y2U6OnNldFNpemVBbmRGcmFtZVJhdGVXaXRoUHJlc2V0KEludFNpemUgcmVxdWVzdGVkU2l6ZSwK IAogICAgIEFTU0VSVChhdlByZXNldC0+Zm9ybWF0KTsKIAotICAgIG1fcmVxdWVzdGVkU2l6ZSA9 IHJlcXVlc3RlZFNpemU7Ci0KICAgICBOU0Vycm9yICplcnJvciA9IG5pbDsKICAgICBbbV9zZXNz aW9uIGJlZ2luQ29uZmlndXJhdGlvbl07CiAgICAgQHRyeSB7CkBAIC00NzQsOCArNDcyLDYgQEAg Ym9vbCBBVlZpZGVvQ2FwdHVyZVNvdXJjZTo6c2V0dXBDYXB0dXJlU2Vzc2lvbigpCiB2b2lkIEFW VmlkZW9DYXB0dXJlU291cmNlOjpzaHV0ZG93bkNhcHR1cmVTZXNzaW9uKCkKIHsKICAgICBtX2J1 ZmZlciA9IG51bGxwdHI7Ci0gICAgbV93aWR0aCA9IDA7Ci0gICAgbV9oZWlnaHQgPSAwOwogfQog CiB2b2lkIEFWVmlkZW9DYXB0dXJlU291cmNlOjptb25pdG9yT3JpZW50YXRpb24oT3JpZW50YXRp b25Ob3RpZmllciYgbm90aWZpZXIpCkBAIC01MjUsMTYgKzUyMSw2IEBAIHZvaWQgQVZWaWRlb0Nh cHR1cmVTb3VyY2U6OnByb2Nlc3NOZXdGcmFtZShSZWY8TWVkaWFTYW1wbGU+JiYgc2FtcGxlKQog ICAgICAgICByZXR1cm47CiAKICAgICBtX2J1ZmZlciA9ICZzYW1wbGUuZ2V0KCk7Ci0gICAgYXV0 byBkaW1lbnNpb25zID0gcm91bmRlZEludFNpemUoc2FtcGxlLT5wcmVzZW50YXRpb25TaXplKCkp OwotICAgIGlmIChtX3NhbXBsZVJvdGF0aW9uID09IE1lZGlhU2FtcGxlOjpWaWRlb1JvdGF0aW9u OjpMZWZ0IHx8IG1fc2FtcGxlUm90YXRpb24gPT0gTWVkaWFTYW1wbGU6OlZpZGVvUm90YXRpb246 OlJpZ2h0KQotICAgICAgICBkaW1lbnNpb25zID0geyBkaW1lbnNpb25zLmhlaWdodCgpLCBkaW1l bnNpb25zLndpZHRoKCkgfTsKLQotICAgIGlmIChkaW1lbnNpb25zLndpZHRoKCkgIT0gbV93aWR0 aCB8fCBkaW1lbnNpb25zLmhlaWdodCgpICE9IG1faGVpZ2h0KSB7Ci0gICAgICAgIG1fd2lkdGgg PSBkaW1lbnNpb25zLndpZHRoKCk7Ci0gICAgICAgIG1faGVpZ2h0ID0gZGltZW5zaW9ucy5oZWln aHQoKTsKLSAgICAgICAgc2V0U2l6ZShkaW1lbnNpb25zKTsKLSAgICB9Ci0KICAgICBkaXNwYXRj aE1lZGlhU2FtcGxlVG9PYnNlcnZlcnMoV1RGTW92ZShzYW1wbGUpKTsKIH0KIAo=