191466 2018-11-09 05:25:20 -0800 CSS @imports in HTML missing quote marks are mistakenly hidden from the Preload Scanner 2023-03-05 21:50:29 -0800 1 1 1 Unclassified WebKit Page Loading Safari 12 Unspecified Unspecified RESOLVED FIXED InRadar, WPTImpact P2 Normal --- 1 csswizardry webkit-unassigned ahmad.saleem792 beidson colin koivisto simon.fraser webkit-bug-importer yoav oldest_to_newest 1476861 0 csswizardry 2018-11-09 05:25:20 -0800 **Example URL:** https://csswizardry.com/demos/2018/11/import/blocked-by-css.html OR https://csswizardry.com/demos/2018/11/import/blocked-by-js.html **Steps to reproduce the problem:** 1. Have a page with a synchronous `<link rel="stylesheet" />` and/or synchronous `<script src="">` BEFORE an in-page `@import url(style.css)` that omits the optional quote marks. 2. Reload page with Network panel open 3. Note lack of parallelisation: files are serialised 4. Edit `@import url(style.css)` to be `@import url("style.css")` (note addition of quote marks) 5. Refresh and observe waterfall 6. Parallelisation! **What is the expected behaviour?** I would expect the Preload Scanner to identify the IMPORT regardless of the presence of quote marks **What went wrong?** The Preload Scanner isn’t noticing @import URLs that omit OPTIONAL quotes 1478030 1 webkit-bug-importer 2018-11-13 09:34:06 -0800 <rdar://problem/46031271> 1480199 2 yoav 2018-11-19 04:44:35 -0800 I'm currently fixing a similar (identical?) issue in Chromium's CSSPreloadScanner. Patch is up at https://chromium-review.googlesource.com/c/chromium/src/+/1331042/3 At the very least, the tests can be reused here. 1934143 3 ahmad.saleem792 2023-02-16 05:41:19 -0800 Changes here - https://searchfox.org/wubkat/source/Source/WebCore/html/parser/CSSPreloadScanner.cpp#110 & Comments here - https://searchfox.org/wubkat/source/Source/WebCore/html/parser/CSSPreloadScanner.cpp#166 (No need to add {} here) Comment here - https://chromium-review.googlesource.com/c/chromium/src/+/1331042/3/third_party/blink/renderer/core/html/parser/css_preload_scanner.cc#188 and then from here onward - change and just return String(): https://searchfox.org/wubkat/source/Source/WebCore/html/parser/CSSPreloadScanner.cpp#183-193 Add here remaining - https://searchfox.org/wubkat/source/Source/WebCore/html/parser/CSSPreloadScanner.cpp#201 1934145 4 ahmad.saleem792 2023-02-16 05:44:23 -0800 https://wpt.fyi/results/loading?label=master&label=experimental&aligned&view=subtest&q=preloader-css-import 1934967 5 ahmad.saleem792 2023-02-19 07:41:04 -0800 PR - https://github.com/WebKit/WebKit/pull/10346 1939027 6 ews-feeder 2023-03-05 21:50:26 -0800 Committed 261254@main (6851ca14bf62): <https://commits.webkit.org/261254@main> Reviewed commits have been landed. Closing PR #10346 and removing active labels.