191463 2018-11-09 04:02:43 -0800 [css-grid][css-flex] <table> grid item should fill the grid area for 'stretch'/'normal' self alignment 2021-02-03 06:05:45 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.chromium.org/p/chromium/issues/detail?id=667785 InRadar P2 Normal --- 1 jfernandez webkit-unassigned bfulgham changseok esprehn+autocc ews-watchlist glenn jfernandez kondapallykalyan pdr rego simon.fraser svillar webkit-bug-importer zalan zsun oldest_to_newest 1476849 0 354326 jfernandez 2018-11-09 04:02:43 -0800 Created attachment 354326 Test case to reproduce the issue What steps will reproduce the problem? (1) load the attached testcase (2) (3) What is the expected result? The <table> grid items should fill their grid area. There should be no red areas visible. Fwiw, the testcase works correctly in Firefox: https://nightly.mozilla.org/ 1721496 1 418110 zsun 2021-01-21 23:52:48 -0800 Created attachment 418110 Patch 1721995 2 418110 svillar 2021-01-25 01:50:02 -0800 Comment on attachment 418110 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418110&action=review > Source/WebCore/ChangeLog:15 > + grid are imported. In the Blink patch the author was also unskipping some other tests that are not imported in WebKit tree yet, we should probably do that before landing this change or even as part of this change. > Source/WebCore/rendering/RenderTable.cpp:243 > + // needed and that we're not skipping anything essential due to the early return here. WebKit uses FIXME instead of TODO(name). In any case I think we can completely remove it at this point. In any case I am not sure about the change itself because this is skipping the table width calculation for all the cases when the table is a grid item, but if the grid item is not stretched then we do need this computation because we need the table intrinsic size. > LayoutTests/ChangeLog:8 > + * TestExpectations: You should fill in this ChangeLog as well. Something like "Unskipped a test that is now passing" 1722009 3 svillar 2021-01-25 03:15:13 -0800 (In reply to Sergio Villar Senin from comment #2) > Comment on attachment 418110 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=418110&action=review > > > Source/WebCore/ChangeLog:15 > > + grid are imported. > > In the Blink patch the author was also unskipping some other tests that are > not imported in WebKit tree yet, we should probably do that before landing > this change or even as part of this change. I think I messed it up, the other tests are for flexbox, sorry about the noise. > > > Source/WebCore/rendering/RenderTable.cpp:243 > > + // needed and that we're not skipping anything essential due to the early return here. > > WebKit uses FIXME instead of TODO(name). In any case I think we can > completely remove it at this point. > > In any case I am not sure about the change itself because this is skipping > the table width calculation for all the cases when the table is a grid item, > but if the grid item is not stretched then we do need this computation > because we need the table intrinsic size. Looks like RenderBox ends up calling the preferred logical widths computation in any case so I guess this should indeed work. Let me just review again the test in order to fully understand what's going on. 1722010 4 418110 jfernandez 2021-01-25 03:25:53 -0800 Comment on attachment 418110 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418110&action=review >> Source/WebCore/rendering/RenderTable.cpp:243 >> + // needed and that we're not skipping anything essential due to the early return here. > > WebKit uses FIXME instead of TODO(name). In any case I think we can completely remove it at this point. > > In any case I am not sure about the change itself because this is skipping the table width calculation for all the cases when the table is a grid item, but if the grid item is not stretched then we do need this computation because we need the table intrinsic size. I think the change is correct, at least for the cases we were testing in blink. The idea is that in case the table has justify-self different from auto/stretch, we use the LayoutBox logic, which will eventually run the PreferredLogicalWidth call. However, as the table is a grid item, it should use its corresponding grid area as "container" when computing the available size. The FIXME still stands, because while I think the current RenderGrid logic deals with this correctly for regular boxes as grid item, I'm not completely sure it covers all the peculiarities a table could have (eg. margins, padding, ...) 1723377 5 418649 zsun 2021-01-28 08:49:23 -0800 Created attachment 418649 Patch 1724225 6 zsun 2021-02-01 07:09:52 -0800 (In reply to Sergio Villar Senin from comment #2) > Comment on attachment 418110 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=418110&action=review > > > Source/WebCore/ChangeLog:15 > > + grid are imported. > > In the Blink patch the author was also unskipping some other tests that are > not imported in WebKit tree yet, we should probably do that before landing > this change or even as part of this change. > > > Source/WebCore/rendering/RenderTable.cpp:243 > > + // needed and that we're not skipping anything essential due to the early return here. > > WebKit uses FIXME instead of TODO(name). In any case I think we can > completely remove it at this point. > > In any case I am not sure about the change itself because this is skipping > the table width calculation for all the cases when the table is a grid item, > but if the grid item is not stretched then we do need this computation > because we need the table intrinsic size. > > > LayoutTests/ChangeLog:8 > > + * TestExpectations: > > You should fill in this ChangeLog as well. Something like "Unskipped a test > that is now passing" Updated. Thank you! 1725099 7 ews-feeder 2021-02-03 05:56:35 -0800 zsun@igalia.com does not have committer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/Tools/Scripts/webkitpy/common/config/contributors.json. Rejecting attachment 418649 from commit queue. 1725101 8 ews-feeder 2021-02-03 06:04:00 -0800 Committed r272308: <https://trac.webkit.org/changeset/272308> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418649. 1725103 9 webkit-bug-importer 2021-02-03 06:05:45 -0800 <rdar://problem/73929027> 354326 2018-11-09 04:02:43 -0800 2018-11-09 04:02:43 -0800 Test case to reproduce the issue grid-item-table.html text/html 642 jfernandez PCFET0NUWVBFIEhUTUw+CjxodG1sPjxoZWFkPgogICAgPG1ldGEgY2hhcnNldD0idXRmLTgiPgog ICAgPHRpdGxlPjwvdGl0bGU+CiAgICA8c3R5bGUgdHlwZT0idGV4dC9jc3MiPgoKLmdyaWQgewog IGRpc3BsYXk6IGdyaWQ7CiAgd2lkdGg6IDQwMHB4OwogIGhlaWdodDogNDAwcHg7CiAgYm9yZGVy OiAxcHggc29saWQgYmxhY2s7CiAgYmFja2dyb3VuZDogcmVkOwp9CgouaXRlbSB7CiAgZGlzcGxh eTogdGFibGU7CiAgYmFja2dyb3VuZDogbGltZTsKfQoKY2FwdGlvbiB7CiAgYmFja2dyb3VuZDog Z3JleTsKfQoKICAgIDwvc3R5bGU+CjwvaGVhZD4KPGJvZHk+Cgo8cHJlPlRoZXJlIHNob3VsZCBi ZSBubyByZWQgYXJlYXM6PC9wcmU+Cgo8ZGl2IGNsYXNzPSJncmlkIj4KPGRpdiBjbGFzcz0iaXRl bSI+CnRhYmxlIGNlbGwKPC9kaXY+CjwvZGl2PgoKPGRpdiBjbGFzcz0iZ3JpZCI+Cjx0YWJsZSBj bGFzcz0iaXRlbSI+CjxjYXB0aW9uPmNhcHRpb248L2NhcHRpb24+CjwvdGFibGU+CjwvZGl2PgoK PGRpdiBjbGFzcz0iZ3JpZCI+Cjx0YWJsZSBjbGFzcz0iaXRlbSI+CjxjYXB0aW9uPmNhcHRpb248 L2NhcHRpb24+Cjx0cj48dGQ+dGFibGUgY2VsbDwvdGQ+PC90cj4KPC90YWJsZT4KPC9kaXY+Cgo8 L2JvZHk+CjwvaHRtbD4K 418110 2021-01-21 23:52:48 -0800 2021-01-28 08:49:17 -0800 Patch bug-191463-20210122075246.patch text/plain 4041 zsun U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxNzAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWNkMzdkMWJhYzZkMDI3 NDBhNjIyM2EwMGJlOGNmYzRhNTg3NDQ1Yi4uNDgyOWI0NTdkZGQyYTdmM2UwNmZkMDBkOWE4MjY3 YWNmOWU5MjI3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIxLTAxLTIxICBaaXJh biBTdW4gIDx6c3VuQGlnYWxpYS5jb20+CisKKyAgICAgICAgW2Nzcy1ncmlkXVtjc3MtZmxleF0g PHRhYmxlPiBncmlkIGl0ZW0gc2hvdWxkIGZpbGwgdGhlIGdyaWQgYXJlYSBmb3IgJ3N0cmV0Y2gn Lydub3JtYWwnIHNlbGYgYWxpZ25tZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTE0NjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBdm9pZCB0YWJsZSBzaXppbmcgcGVjdWxpYXJpdGllcyBmb3IgZ3Jp ZCBpdGVtcy4gTGV0IHRoZSBncmlkIHJlbmRlciBhbGdvcml0aG0gZGV0ZXJtaW5lCisgICAgICAg IHRoZSBzaXplIG9mIHRhYmxlcyB0aGF0IGFyZSBncmlkIGl0ZW1zLiBEb24ndCBsZXQgdGhlIGlu dHJpbnNpYyB3aWR0aCBvZiB0YWJsZSBjb2x1bW5zCisgICAgICAgIGFmZmVjdCB0aGUgd2lkdGgg b2YgdGhlIGl0ZW0uIFRoaXMgY2hhbmdlIG9ubHkgZGVhbHMgd2l0aCB3aWR0aHMuCisKKyAgICAg ICAgVGhpcyBpcyBhbiBpbXBvcnQgb2YgQ2hyb21pdW0gY2hhbmdlcyBhdAorICAgICAgICBodHRw czovL2Nocm9taXVtLXJldmlldy5nb29nbGVzb3VyY2UuY29tL2MvY2hyb21pdW0vc3JjLysvNzgx ODU5LworICAgICAgICBUaGlzIGlzc3VlIHNlZW1zIG9ubHkgYWZmZWN0IGdyaWQtaXRlbXMgYW5k IG5vdCBmbGV4Ym94IGFueSBtb3JlIGhlbmNlIG9ubHkgY2hhbmdlcyBmcm9tCisgICAgICAgIGdy aWQgYXJlIGltcG9ydGVkLgorCisgICAgICAgIFRlc3QgZm9yIHRoaXMgY2hhbmdlIGhhcyBhbHJl YWR5IGJlZW4gaW1wb3J0ZWQgZnJvbSBXUFQKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJU YWJsZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUYWJsZTo6dXBkYXRlTG9naWNhbFdp ZHRoKToKKwogMjAyMS0wMS0yMSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNv bT4KIAogICAgICAgICBSRUdSRVNTSU9OIChBc3luYyBvdmVyZmxvdyk6IFNjcm9sbCBzdHV0dGVy cy9ibG9ja2VkIHdpdGggbmVzdGVkIHNjcm9sbGluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJUYWJsZS5jcHAKaW5kZXggYTAxOGYzZmE3NmEwMWVmMWI0MjdjMmEzOGQ1MWIxN2UyZGM3 ZGRmNi4uYmM1NWM4ZDQxZjhhNTJmY2U2NTRiN2ZjMzZmNzg1MTVhYWU1MjA0NSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGUuY3BwCkBAIC0yMzgsNiArMjM4LDEzIEBAIHZv aWQgUmVuZGVyVGFibGU6OnVwZGF0ZUxvZ2ljYWxXaWR0aCgpCiB7CiAgICAgcmVjYWxjU2VjdGlv bnNJZk5lZWRlZCgpOwogCisgICAgaWYgKGlzR3JpZEl0ZW0oKSkgeworICAgICAgICAvLyBUT0RP KGpmZXJuYW5kZXopOiBJbnZlc3RpZ2F0ZSB3aGV0aGVyIHRoZSBncmlkIGxheW91dCBhbGdvcml0 aG0gcHJvdmlkZXMgYWxsIHRoZSBsb2dpYworICAgICAgICAvLyBuZWVkZWQgYW5kIHRoYXQgd2Un cmUgbm90IHNraXBwaW5nIGFueXRoaW5nIGVzc2VudGlhbCBkdWUgdG8gdGhlIGVhcmx5IHJldHVy biBoZXJlLgorICAgICAgICBSZW5kZXJCbG9jazo6dXBkYXRlTG9naWNhbFdpZHRoKCk7CisgICAg ICAgIHJldHVybjsKKyAgICB9CisKICAgICBpZiAoaXNPdXRPZkZsb3dQb3NpdGlvbmVkKCkpIHsK ICAgICAgICAgTG9naWNhbEV4dGVudENvbXB1dGVkVmFsdWVzIGNvbXB1dGVkVmFsdWVzOwogICAg ICAgICBjb21wdXRlUG9zaXRpb25lZExvZ2ljYWxXaWR0aChjb21wdXRlZFZhbHVlcyk7CmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5k ZXggYzdjNDQwMTY0MDA3MTQxNDg4ZWIxNDEyYTY2ZWQzNGI1MDZkOTFlOC4uOWRlMTcyN2I1ODVh OTUyNzI5MGUxYmFhYmE2ZDZlMzNmNTNmYmQxZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIx LTAxLTIxICBaaXJhbiBTdW4gIDx6c3VuQGlnYWxpYS5jb20+CisKKyAgICAgICAgW2Nzcy1ncmlk XVtjc3MtZmxleF0gPHRhYmxlPiBncmlkIGl0ZW0gc2hvdWxkIGZpbGwgdGhlIGdyaWQgYXJlYSBm b3IgJ3N0cmV0Y2gnLydub3JtYWwnIHNlbGYgYWxpZ25tZW50CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTE0NjMKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFRlc3RFeHBlY3RhdGlvbnM6CisKIDIwMjEt MDEtMjEgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAg UkVHUkVTU0lPTiAoPyk6IFNjcm9sbCBzdHV0dGVycy9ibG9ja2VkIHdpdGggbmVzdGVkIHNjcm9s bGluZwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRl c3RzL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggNzliMWQ2NDA4NzA5Yzk4YzQ2N2NhNGI3ZWNjNWU5 MjVkOTBiMzVlNC4uZDQ0MjgwMDBlMTc1MjQwN2UxMmNiYmFjNDMyOWIyMjE4ZTJkYzU5YyAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9U ZXN0RXhwZWN0YXRpb25zCkBAIC0xMjA2LDcgKzEyMDYsNiBAQCB3ZWJraXQub3JnL2IvMjE2MTQ1 IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1ncmlkL2FsaWdubWVudC9n cmlkLQogd2Via2l0Lm9yZy9iLzIxNjE0NSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3Rz L2Nzcy9jc3MtZ3JpZC9hbGlnbm1lbnQvZ3JpZC1pdGVtLW5vLWFzcGVjdC1yYXRpby1zdHJldGNo LTguaHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzIxNjE0NSBpbXBvcnRl ZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtZ3JpZC9hbGlnbm1lbnQvZ3JpZC1pdGVt LW5vLWFzcGVjdC1yYXRpby1zdHJldGNoLTkuaHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQogd2Vi a2l0Lm9yZy9iLzIxNjE0NSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3Mt Z3JpZC9hbGlnbm1lbnQvZ3JpZC1pdGVtLW5vLWFzcGVjdC1yYXRpby1zdHJldGNoLTEwLmh0bWwg WyBJbWFnZU9ubHlGYWlsdXJlIF0KLXdlYmtpdC5vcmcvYi8xOTE0NjMgaW1wb3J0ZWQvdzNjL3dl Yi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLWdyaWQvZ3JpZC1pdGVtcy9leHBsaWNpdGx5LXNpemVk LWdyaWQtaXRlbS1hcy10YWJsZS5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiB3ZWJraXQub3Jn L2IvMTkxNjI3IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1ncmlkL2Fs aWdubWVudC9ncmlkLXNlbGYtYmFzZWxpbmUtbm90LWFwcGxpZWQtaWYtc2l6aW5nLWN5Y2xpYy1k ZXBlbmRlbmN5LTAwMS5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTQ5ODkwIGZhc3Qv Y3NzLWdyaWQtbGF5b3V0L2dyaWQtc2hvcnRoYW5kcy1zdHlsZS1mb3JtYXQuaHRtbCBbIEZhaWx1 cmUgXQogd2Via2l0Lm9yZy9iLzE5MTUwNyBmYXN0L2Nzcy1ncmlkLWxheW91dC9wb3NpdGlvbmVk LWdyaWQtY29udGFpbmVyLXBlcmNlbnRhZ2UtdHJhY2tzLmh0bWwgWyBGYWlsdXJlIF0K 418649 2021-01-28 08:49:23 -0800 2021-02-03 06:04:01 -0800 Patch bug-191463-20210128164921.patch text/plain 4074 zsun U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxNzAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWNkMzdkMWJhYzZkMDI3 NDBhNjIyM2EwMGJlOGNmYzRhNTg3NDQ1Yi4uNDgyOWI0NTdkZGQyYTdmM2UwNmZkMDBkOWE4MjY3 YWNmOWU5MjI3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIxLTAxLTIxICBaaXJh biBTdW4gIDx6c3VuQGlnYWxpYS5jb20+CisKKyAgICAgICAgW2Nzcy1ncmlkXVtjc3MtZmxleF0g PHRhYmxlPiBncmlkIGl0ZW0gc2hvdWxkIGZpbGwgdGhlIGdyaWQgYXJlYSBmb3IgJ3N0cmV0Y2gn Lydub3JtYWwnIHNlbGYgYWxpZ25tZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTE0NjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBdm9pZCB0YWJsZSBzaXppbmcgcGVjdWxpYXJpdGllcyBmb3IgZ3Jp ZCBpdGVtcy4gTGV0IHRoZSBncmlkIHJlbmRlciBhbGdvcml0aG0gZGV0ZXJtaW5lCisgICAgICAg IHRoZSBzaXplIG9mIHRhYmxlcyB0aGF0IGFyZSBncmlkIGl0ZW1zLiBEb24ndCBsZXQgdGhlIGlu dHJpbnNpYyB3aWR0aCBvZiB0YWJsZSBjb2x1bW5zCisgICAgICAgIGFmZmVjdCB0aGUgd2lkdGgg b2YgdGhlIGl0ZW0uIFRoaXMgY2hhbmdlIG9ubHkgZGVhbHMgd2l0aCB3aWR0aHMuCisKKyAgICAg ICAgVGhpcyBpcyBhbiBpbXBvcnQgb2YgQ2hyb21pdW0gY2hhbmdlcyBhdAorICAgICAgICBodHRw czovL2Nocm9taXVtLXJldmlldy5nb29nbGVzb3VyY2UuY29tL2MvY2hyb21pdW0vc3JjLysvNzgx ODU5LworICAgICAgICBUaGlzIGlzc3VlIHNlZW1zIG9ubHkgYWZmZWN0IGdyaWQtaXRlbXMgYW5k IG5vdCBmbGV4Ym94IGFueSBtb3JlIGhlbmNlIG9ubHkgY2hhbmdlcyBmcm9tCisgICAgICAgIGdy aWQgYXJlIGltcG9ydGVkLgorCisgICAgICAgIFRlc3QgZm9yIHRoaXMgY2hhbmdlIGhhcyBhbHJl YWR5IGJlZW4gaW1wb3J0ZWQgZnJvbSBXUFQKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJU YWJsZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUYWJsZTo6dXBkYXRlTG9naWNhbFdp ZHRoKToKKwogMjAyMS0wMS0yMSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNv bT4KIAogICAgICAgICBSRUdSRVNTSU9OIChBc3luYyBvdmVyZmxvdyk6IFNjcm9sbCBzdHV0dGVy cy9ibG9ja2VkIHdpdGggbmVzdGVkIHNjcm9sbGluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJUYWJsZS5jcHAKaW5kZXggYTAxOGYzZmE3NmEwMWVmMWI0MjdjMmEzOGQ1MWIxN2UyZGM3 ZGRmNi4uMDI1YTQzMjRiOTBlNDc0OGVjMThmY2I3MmQ4M2UwZmFiNzE4Y2ZlOSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGUuY3BwCkBAIC0yMzgsNiArMjM4LDEzIEBAIHZv aWQgUmVuZGVyVGFibGU6OnVwZGF0ZUxvZ2ljYWxXaWR0aCgpCiB7CiAgICAgcmVjYWxjU2VjdGlv bnNJZk5lZWRlZCgpOwogCisgICAgaWYgKGlzR3JpZEl0ZW0oKSkgeworICAgICAgICAvLyBGSVhN RTogSW52ZXN0aWdhdGUgd2hldGhlciB0aGUgZ3JpZCBsYXlvdXQgYWxnb3JpdGhtIHByb3ZpZGVz IGFsbCB0aGUgbG9naWMKKyAgICAgICAgLy8gbmVlZGVkIGFuZCB0aGF0IHdlJ3JlIG5vdCBza2lw cGluZyBhbnl0aGluZyBlc3NlbnRpYWwgZHVlIHRvIHRoZSBlYXJseSByZXR1cm4gaGVyZS4KKyAg ICAgICAgUmVuZGVyQmxvY2s6OnVwZGF0ZUxvZ2ljYWxXaWR0aCgpOworICAgICAgICByZXR1cm47 CisgICAgfQorCiAgICAgaWYgKGlzT3V0T2ZGbG93UG9zaXRpb25lZCgpKSB7CiAgICAgICAgIExv Z2ljYWxFeHRlbnRDb21wdXRlZFZhbHVlcyBjb21wdXRlZFZhbHVlczsKICAgICAgICAgY29tcHV0 ZVBvc2l0aW9uZWRMb2dpY2FsV2lkdGgoY29tcHV0ZWRWYWx1ZXMpOwpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGM3YzQ0MDE2 NDAwNzE0MTQ4OGViMTQxMmE2NmVkMzRiNTA2ZDkxZTguLjNkYjM2NTk4Y2YzMDE5ZmU2MzNlMWFm NWZlMTZhNzBlMDMxMzE2OTAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAyMS0wMS0yMSAgWmly YW4gU3VuICA8enN1bkBpZ2FsaWEuY29tPgorCisgICAgICAgIFtjc3MtZ3JpZF1bY3NzLWZsZXhd IDx0YWJsZT4gZ3JpZCBpdGVtIHNob3VsZCBmaWxsIHRoZSBncmlkIGFyZWEgZm9yICdzdHJldGNo Jy8nbm9ybWFsJyBzZWxmIGFsaWdubWVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTkxNDYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBUZXN0RXhwZWN0YXRpb25zOiBVbnNraXAgYSB0ZXN0cyB0aGF0 IGlzIG5vdCBmYWlsaW5nIGFueW1vcmUuCisKIDIwMjEtMDEtMjEgIFNpbW9uIEZyYXNlciAgPHNp bW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAoPyk6IFNjcm9sbCBz dHV0dGVycy9ibG9ja2VkIHdpdGggbmVzdGVkIHNjcm9sbGluZwpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKaW5k ZXggNzliMWQ2NDA4NzA5Yzk4YzQ2N2NhNGI3ZWNjNWU5MjVkOTBiMzVlNC4uZDQ0MjgwMDBlMTc1 MjQwN2UxMmNiYmFjNDMyOWIyMjE4ZTJkYzU5YyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvVGVz dEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCkBAIC0xMjA2 LDcgKzEyMDYsNiBAQCB3ZWJraXQub3JnL2IvMjE2MTQ1IGltcG9ydGVkL3czYy93ZWItcGxhdGZv cm0tdGVzdHMvY3NzL2Nzcy1ncmlkL2FsaWdubWVudC9ncmlkLQogd2Via2l0Lm9yZy9iLzIxNjE0 NSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtZ3JpZC9hbGlnbm1lbnQv Z3JpZC1pdGVtLW5vLWFzcGVjdC1yYXRpby1zdHJldGNoLTguaHRtbCBbIEltYWdlT25seUZhaWx1 cmUgXQogd2Via2l0Lm9yZy9iLzIxNjE0NSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3Rz L2Nzcy9jc3MtZ3JpZC9hbGlnbm1lbnQvZ3JpZC1pdGVtLW5vLWFzcGVjdC1yYXRpby1zdHJldGNo LTkuaHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzIxNjE0NSBpbXBvcnRl ZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtZ3JpZC9hbGlnbm1lbnQvZ3JpZC1pdGVt LW5vLWFzcGVjdC1yYXRpby1zdHJldGNoLTEwLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KLXdl YmtpdC5vcmcvYi8xOTE0NjMgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3Nz LWdyaWQvZ3JpZC1pdGVtcy9leHBsaWNpdGx5LXNpemVkLWdyaWQtaXRlbS1hcy10YWJsZS5odG1s IFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTkxNjI3IGltcG9ydGVkL3czYy93 ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1ncmlkL2FsaWdubWVudC9ncmlkLXNlbGYtYmFzZWxp bmUtbm90LWFwcGxpZWQtaWYtc2l6aW5nLWN5Y2xpYy1kZXBlbmRlbmN5LTAwMS5odG1sIFsgRmFp bHVyZSBdCiB3ZWJraXQub3JnL2IvMTQ5ODkwIGZhc3QvY3NzLWdyaWQtbGF5b3V0L2dyaWQtc2hv cnRoYW5kcy1zdHlsZS1mb3JtYXQuaHRtbCBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzE5MTUw NyBmYXN0L2Nzcy1ncmlkLWxheW91dC9wb3NpdGlvbmVkLWdyaWQtY29udGFpbmVyLXBlcmNlbnRh Z2UtdHJhY2tzLmh0bWwgWyBGYWlsdXJlIF0K