191462 2018-11-09 03:54:00 -0800 [css-grid] Percentage height on replaced item with scrollbar 2020-11-11 22:27:16 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.chromium.org/p/chromium/issues/detail?id=837141 InRadar P2 Normal --- 1 jfernandez webkit-unassigned bfulgham changseok esprehn+autocc ews-watchlist glenn jfernandez kondapallykalyan pdr rego simon.fraser webkit-bug-importer zalan zsun oldest_to_newest 1476847 0 354325 jfernandez 2018-11-09 03:54:00 -0800 Created attachment 354325 Test case to reproduce the issue If you have a replaced item that has scrollbar and a 100% height, the height is wrongly computed as it doesn't get subtracted the scrollbar. In the attached example you shouldn't see any overflow (so you cannot actually scroll). 1706406 1 413803 zsun 2020-11-11 02:51:14 -0800 Created attachment 413803 Patch 1706419 2 413803 rego 2020-11-11 04:09:27 -0800 Comment on attachment 413803 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413803&action=review Thanks for the patch, it looks good, but you need to fix some stuff before landing. > Source/WebCore/ChangeLog:9 > + https://github.com/web-platform-tests/wpt/commit/538eedafb15733c6113b44998170a6bbdae7518b It's good to refer to the original patch in the ChangeLog, but we also should explain and describe the change in this file. How the changes are fixing the issue. Apart from that, as we're now passing the test css/css-grid/grid-items/percentage-size-replaced-subitems-001.html, we should remove the line for that test in TestExpectations. So the test is actually run by the bots. > Source/WebCore/ChangeLog:11 > + Reviewed by NOBODY (OOPS!). This line should be moved above, just after the URL bug line with an empty line in the middle. > Source/WebCore/rendering/RenderBox.cpp:3202 > + stretchedHeight = block->overridingLogicalHeight() - block->borderAndPaddingLogicalHeight() - block->scrollbarLogicalHeight(); I guess you can use block->overridingContentLogicalHeight() directly here. 1706431 3 413813 zsun 2020-11-11 05:53:52 -0800 Created attachment 413813 Patch 1706443 4 413817 zsun 2020-11-11 06:46:00 -0800 Created attachment 413817 Patch 1706466 5 413817 rego 2020-11-11 08:38:49 -0800 Comment on attachment 413817 Patch r=me 1706768 6 ews-feeder 2020-11-11 22:26:32 -0800 Committed r269717: <https://trac.webkit.org/changeset/269717> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413817. 1706769 7 webkit-bug-importer 2020-11-11 22:27:16 -0800 <rdar://problem/71314152> 354325 2018-11-09 03:54:00 -0800 2018-11-09 03:54:00 -0800 Test case to reproduce the issue bug-replaced.html text/html 352 jfernandez PCFET0NUWVBFIGh0bWw+Cgo8c3R5bGU+CiAgLmdyaWQgewogICAgYm9yZGVyOiBzb2xpZCB0aGlj azsKICAgIGRpc3BsYXk6IGlubGluZS1ncmlkOwogICAgZ3JpZDogMTAwcHggLyAxMDBweDsKICB9 CgogIC5pdGVtIHsKICAgIGJhY2tncm91bmQ6IGN5YW47CiAgICBvdmVyZmxvdzogc2Nyb2xsOwog IH0KCiAgaW1nIHsKICAgIGRpc3BsYXk6IGJsb2NrOwogICAgd2lkdGg6IDEwMCU7CiAgICBoZWln aHQ6IDEwMCU7CiAgfQo8L3N0eWxlPgoKPGRpdiBjbGFzcz0iZ3JpZCI+CiAgPGRpdiBjbGFzcz0i aXRlbSI+CiAgICA8aW1nIHNyYz0iaHR0cDovL3BsYWNlaG9sZC5pdC8xMDB4MTAwIj4KICA8L2Rp dj4KPC9kaXY+Cg== 413803 2020-11-11 02:51:14 -0800 2020-11-11 05:53:47 -0800 Patch bug-191462-20201111105113.patch text/plain 3348 zsun U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5NTgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWEyZDMxZGI5OTAxZTcw NjU4N2Y0YzRkNzA4NjQ3Njk5NzhjMGIzOC4uNTg4YTdiMTI2MDdkNjk5ODU5ZWI2OTZjNWRkYWQy OTM2NTg2ZDlhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTExLTExICBaaXJh biBTdW4gIDx6c3VuQGlnYWxpYS5jb20+CisKKyAgICAgICAgW2Nzcy1ncmlkXSBQZXJjZW50YWdl IGhlaWdodCBvbiByZXBsYWNlZCBpdGVtIHdpdGggc2Nyb2xsYmFyCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTE0NjIKKyAgICAgICAgCisgICAgICAg IFRoaXMgQ0wgcG9ydHMgdGhlIGNoYW5nZXMgZnJvbSB0aGUgZm9sbG93aW5nIHBhdGNoIGF0IENo cm9taXVtOgorICAgICAgICBodHRwczovL2J1Z3MuY2hyb21pdW0ub3JnL3AvY2hyb21pdW0vaXNz dWVzL2RldGFpbD9pZD04MzcxNDEKKyAgICAgICAgVGVzdCBmaWxlcyB3ZXJlIGFscmVhZHkgcG9y dGVkIGluIFdQVCBhdAorICAgICAgICBodHRwczovL2dpdGh1Yi5jb20vd2ViLXBsYXRmb3JtLXRl c3RzL3dwdC9jb21taXQvNTM4ZWVkYWZiMTU3MzNjNjExM2I0NDk5ODE3MGE2YmJkYWU3NTE4Ygor ICAgICAgICAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiByZW5kZXJpbmcvUmVuZGVyQm94LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJveDo6 Y29tcHV0ZVJlcGxhY2VkTG9naWNhbEhlaWdodFVzaW5nIGNvbnN0KToKKwogMjAyMC0xMS0wOSAg Q2hyaXMgTG9yZCAgPGNsb3JkQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS11bV1BFXSBTY3Jv bGxpbmcgd2l0aCBtb3VzZSB3aGVlbCBkb2Vzbid0IHdvcmsgb24gaWZyYW1lcyB3aXRoIGFzeW5j IHNjcm9sbGluZyBlbmFibGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyQm94LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guY3BwCmlu ZGV4IDg1YTRjNTYyYjIxYTNiNzZmMjkyNzAwM2YxODEzNTlmYzE5NTdlOGEuLmFmNjZjNDE3MDFh NzgzZTEzNTE2ZjgyNzMzZDNmNWUzNTQ5OTc1YjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJCb3guY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJCb3guY3BwCkBAIC0zMTkxLDE0ICszMTkxLDE1IEBAIExheW91dFVuaXQgUmVuZGVyQm94 Ojpjb21wdXRlUmVwbGFjZWRMb2dpY2FsSGVpZ2h0VXNpbmcoU2l6ZVR5cGUgaGVpZ2h0VHlwZSwg TGVuCiAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgICAgIGNvbnRhaW5l ciA9IGNvbnRhaW5lci0+Y29udGFpbmluZ0Jsb2NrKCk7CiAgICAgICAgICAgICB9CisgICAgICAg ICAgICBib29sIGhhc1BlcnBlbmRpY3VsYXJDb250YWluaW5nQmxvY2sgPSBjb250YWluZXItPmlz SG9yaXpvbnRhbFdyaXRpbmdNb2RlKCkgIT0gaXNIb3Jpem9udGFsV3JpdGluZ01vZGUoKTsKICAg ICAgICAgICAgIE9wdGlvbmFsPExheW91dFVuaXQ+IHN0cmV0Y2hlZEhlaWdodDsKICAgICAgICAg ICAgIGlmIChpczxSZW5kZXJCbG9jaz4oY29udGFpbmVyKSkgewogICAgICAgICAgICAgICAgIGF1 dG8qIGJsb2NrID0gZG93bmNhc3Q8UmVuZGVyQmxvY2s+KGNvbnRhaW5lcik7CiAgICAgICAgICAg ICAgICAgYmxvY2stPmFkZFBlcmNlbnRIZWlnaHREZXNjZW5kYW50KCpjb25zdF9jYXN0PFJlbmRl ckJveCo+KHRoaXMpKTsKICAgICAgICAgICAgICAgICBpZiAoYmxvY2stPmlzRmxleEl0ZW0oKSkK ICAgICAgICAgICAgICAgICAgICAgc3RyZXRjaGVkSGVpZ2h0ID0gZG93bmNhc3Q8UmVuZGVyRmxl eGlibGVCb3g+KGJsb2NrLT5wYXJlbnQoKSktPmNoaWxkTG9naWNhbEhlaWdodEZvclBlcmNlbnRh Z2VSZXNvbHV0aW9uKCpibG9jayk7Ci0gICAgICAgICAgICAgICAgZWxzZSBpZiAoYmxvY2stPmlz R3JpZEl0ZW0oKSAmJiBibG9jay0+aGFzT3ZlcnJpZGluZ0xvZ2ljYWxIZWlnaHQoKSkKLSAgICAg ICAgICAgICAgICAgICAgc3RyZXRjaGVkSGVpZ2h0ID0gYmxvY2stPm92ZXJyaWRpbmdMb2dpY2Fs SGVpZ2h0KCkgLSBibG9jay0+Ym9yZGVyQW5kUGFkZGluZ0xvZ2ljYWxIZWlnaHQoKTsKKyAgICAg ICAgICAgICAgICBlbHNlIGlmIChibG9jay0+aXNHcmlkSXRlbSgpICYmIGJsb2NrLT5oYXNPdmVy cmlkaW5nTG9naWNhbEhlaWdodCgpICYmICFoYXNQZXJwZW5kaWN1bGFyQ29udGFpbmluZ0Jsb2Nr KQorICAgICAgICAgICAgICAgICAgICBzdHJldGNoZWRIZWlnaHQgPSBibG9jay0+b3ZlcnJpZGlu Z0xvZ2ljYWxIZWlnaHQoKSAtIGJsb2NrLT5ib3JkZXJBbmRQYWRkaW5nTG9naWNhbEhlaWdodCgp IC0gYmxvY2stPnNjcm9sbGJhckxvZ2ljYWxIZWlnaHQoKTsKICAgICAgICAgICAgIH0KIAogICAg ICAgICAgICAgLy8gRklYTUU6IFRoaXMgY2FsY3VsYXRpb24gaXMgbm90IHBhdGNoZWQgZm9yIGJs b2NrLWZsb3cgeWV0LgpAQCAtMzIyMiw3ICszMjIzLDcgQEAgTGF5b3V0VW5pdCBSZW5kZXJCb3g6 OmNvbXB1dGVSZXBsYWNlZExvZ2ljYWxIZWlnaHRVc2luZyhTaXplVHlwZSBoZWlnaHRUeXBlLCBM ZW4KICAgICAgICAgICAgIGVsc2UgaWYgKHN0cmV0Y2hlZEhlaWdodCkKICAgICAgICAgICAgICAg ICBhdmFpbGFibGVIZWlnaHQgPSBzdHJldGNoZWRIZWlnaHQudmFsdWUoKTsKICAgICAgICAgICAg IGVsc2UgewotICAgICAgICAgICAgICAgIGF2YWlsYWJsZUhlaWdodCA9IGNvbnRhaW5pbmdCbG9j a0xvZ2ljYWxIZWlnaHRGb3JDb250ZW50KEluY2x1ZGVNYXJnaW5Cb3JkZXJQYWRkaW5nKTsKKyAg ICAgICAgICAgICAgICBhdmFpbGFibGVIZWlnaHQgPSBoYXNQZXJwZW5kaWN1bGFyQ29udGFpbmlu Z0Jsb2NrID8gY29udGFpbmluZ0Jsb2NrTG9naWNhbFdpZHRoRm9yQ29udGVudCgpIDogY29udGFp bmluZ0Jsb2NrTG9naWNhbEhlaWdodEZvckNvbnRlbnQoSW5jbHVkZU1hcmdpbkJvcmRlclBhZGRp bmcpOwogICAgICAgICAgICAgICAgIC8vIEl0IGlzIG5lY2Vzc2FyeSB0byB1c2UgdGhlIGJvcmRl ci1ib3ggdG8gbWF0Y2ggV2luSUUncyBicm9rZW4KICAgICAgICAgICAgICAgICAvLyBib3ggbW9k ZWwuICBUaGlzIGlzIGVzc2VudGlhbCBmb3Igc2l6aW5nIGluc2lkZQogICAgICAgICAgICAgICAg IC8vIHRhYmxlIGNlbGxzIHVzaW5nIHBlcmNlbnRhZ2UgaGVpZ2h0cy4K 413813 2020-11-11 05:53:52 -0800 2020-11-11 06:45:55 -0800 Patch bug-191462-20201111135351.patch text/plain 4986 zsun U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5NTgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWEyZDMxZGI5OTAxZTcw NjU4N2Y0YzRkNzA4NjQ3Njk5NzhjMGIzOC4uY2ZjMjY4M2E4YmQ2MGE2MjFmOTA5NThkOTM1YjQ5 MzlmMWJmMmFiMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIwLTExLTExICBaaXJh biBTdW4gIDx6c3VuQGlnYWxpYS5jb20+CisKKyAgICAgICAgW2Nzcy1ncmlkXSBQZXJjZW50YWdl IGhlaWdodCBvbiByZXBsYWNlZCBpdGVtIHdpdGggc2Nyb2xsYmFyCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTE0NjIKKyAgICAgICAgCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgQ0wgaXMgdG8gc3Vi dHJhY3Qgc2Nyb2xsYmFyIGluIGNvbXB1dGVSZXBsYWNlZExvZ2ljYWxIZWlnaHRVc2luZygpLgor ICAgICAgICBJbiBSZW5kZXJCb3g6OmNvbXB1dGVSZXBsYWNlZExvZ2ljYWxIZWlnaHRVc2luZygp IHdlIHNob3VsZCBhbHNvIHN1YnRyYWN0CisgICAgICAgIHNjcm9sbGJhckxvZ2ljYWxIZWlnaHQo KSB3aGVuIGNhbGN1bGF0aW5nIHN0cmV0Y2hIZWlnaHQuIFdpdGhvdXQgdGhpcyBzdWJ0cmFjdGlv biwKKyAgICAgICAgaXQgY2F1c2VkIGlzc3VlcyB0byByZXNvbHZlIHRoZSBwZXJjZW50YWdlIGhl aWdodHMgb24gZ3JpZCBpdGVtIHJlcGxhY2VkIGNoaWxkcmVuLAorICAgICAgICBpZiB0aGUgZ3Jp ZCBpdGVtIGhhcyBhIHNjcm9sbGJhci4KKyAgICAgICAgCisgICAgICAgIEl0IHBvcnRzIHRoZSBj aGFuZ2VzIGZyb20gdGhlIGZvbGxvd2luZyBwYXRjaCBhdCBDaHJvbWl1bToKKyAgICAgICAgaHR0 cHM6Ly9idWdzLmNocm9taXVtLm9yZy9wL2Nocm9taXVtL2lzc3Vlcy9kZXRhaWw/aWQ9ODM3MTQx CisgICAgICAgIFRlc3QgZmlsZXMgd2VyZSBhbHJlYWR5IHBvcnRlZCBpbiBXUFQgYXQKKyAgICAg ICAgaHR0cHM6Ly9naXRodWIuY29tL3dlYi1wbGF0Zm9ybS10ZXN0cy93cHQvY29tbWl0LzUzOGVl ZGFmYjE1NzMzYzYxMTNiNDQ5OTgxNzBhNmJiZGFlNzUxOGIKKyAgICAgICAgCisgICAgICAgICog cmVuZGVyaW5nL1JlbmRlckJveC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCb3g6OmNv bXB1dGVSZXBsYWNlZExvZ2ljYWxIZWlnaHRVc2luZyBjb25zdCk6CisKIDIwMjAtMTEtMDkgIENo cmlzIExvcmQgIDxjbG9yZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdW1dQRV0gU2Nyb2xs aW5nIHdpdGggbW91c2Ugd2hlZWwgZG9lc24ndCB3b3JrIG9uIGlmcmFtZXMgd2l0aCBhc3luYyBz Y3JvbGxpbmcgZW5hYmxlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckJveC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcAppbmRl eCA4NWE0YzU2MmIyMWEzYjc2ZjI5MjcwMDNmMTgxMzU5ZmMxOTU3ZThhLi5iOTRiYWI4MWY5NTg5 ZGY0ZjAyZDQ4MWMxYzc5ZmVkZDY5ZDE4YjY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyQm94LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyQm94LmNwcApAQCAtMzE5MSwxNCArMzE5MSwxNSBAQCBMYXlvdXRVbml0IFJlbmRlckJveDo6 Y29tcHV0ZVJlcGxhY2VkTG9naWNhbEhlaWdodFVzaW5nKFNpemVUeXBlIGhlaWdodFR5cGUsIExl bgogICAgICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgICAgICBjb250YWluZXIg PSBjb250YWluZXItPmNvbnRhaW5pbmdCbG9jaygpOwogICAgICAgICAgICAgfQorICAgICAgICAg ICAgYm9vbCBoYXNQZXJwZW5kaWN1bGFyQ29udGFpbmluZ0Jsb2NrID0gY29udGFpbmVyLT5pc0hv cml6b250YWxXcml0aW5nTW9kZSgpICE9IGlzSG9yaXpvbnRhbFdyaXRpbmdNb2RlKCk7CiAgICAg ICAgICAgICBPcHRpb25hbDxMYXlvdXRVbml0PiBzdHJldGNoZWRIZWlnaHQ7CiAgICAgICAgICAg ICBpZiAoaXM8UmVuZGVyQmxvY2s+KGNvbnRhaW5lcikpIHsKICAgICAgICAgICAgICAgICBhdXRv KiBibG9jayA9IGRvd25jYXN0PFJlbmRlckJsb2NrPihjb250YWluZXIpOwogICAgICAgICAgICAg ICAgIGJsb2NrLT5hZGRQZXJjZW50SGVpZ2h0RGVzY2VuZGFudCgqY29uc3RfY2FzdDxSZW5kZXJC b3gqPih0aGlzKSk7CiAgICAgICAgICAgICAgICAgaWYgKGJsb2NrLT5pc0ZsZXhJdGVtKCkpCiAg ICAgICAgICAgICAgICAgICAgIHN0cmV0Y2hlZEhlaWdodCA9IGRvd25jYXN0PFJlbmRlckZsZXhp YmxlQm94PihibG9jay0+cGFyZW50KCkpLT5jaGlsZExvZ2ljYWxIZWlnaHRGb3JQZXJjZW50YWdl UmVzb2x1dGlvbigqYmxvY2spOwotICAgICAgICAgICAgICAgIGVsc2UgaWYgKGJsb2NrLT5pc0dy aWRJdGVtKCkgJiYgYmxvY2stPmhhc092ZXJyaWRpbmdMb2dpY2FsSGVpZ2h0KCkpCi0gICAgICAg ICAgICAgICAgICAgIHN0cmV0Y2hlZEhlaWdodCA9IGJsb2NrLT5vdmVycmlkaW5nTG9naWNhbEhl aWdodCgpIC0gYmxvY2stPmJvcmRlckFuZFBhZGRpbmdMb2dpY2FsSGVpZ2h0KCk7CisgICAgICAg ICAgICAgICAgZWxzZSBpZiAoYmxvY2stPmlzR3JpZEl0ZW0oKSAmJiBibG9jay0+aGFzT3ZlcnJp ZGluZ0xvZ2ljYWxIZWlnaHQoKSAmJiAhaGFzUGVycGVuZGljdWxhckNvbnRhaW5pbmdCbG9jaykK KyAgICAgICAgICAgICAgICAgICAgc3RyZXRjaGVkSGVpZ2h0ID0gYmxvY2stPm92ZXJyaWRpbmdD b250ZW50TG9naWNhbEhlaWdodCgpIC0gYmxvY2stPnNjcm9sbGJhckxvZ2ljYWxIZWlnaHQoKTsK ICAgICAgICAgICAgIH0KIAogICAgICAgICAgICAgLy8gRklYTUU6IFRoaXMgY2FsY3VsYXRpb24g aXMgbm90IHBhdGNoZWQgZm9yIGJsb2NrLWZsb3cgeWV0LgpAQCAtMzIyMiw3ICszMjIzLDcgQEAg TGF5b3V0VW5pdCBSZW5kZXJCb3g6OmNvbXB1dGVSZXBsYWNlZExvZ2ljYWxIZWlnaHRVc2luZyhT aXplVHlwZSBoZWlnaHRUeXBlLCBMZW4KICAgICAgICAgICAgIGVsc2UgaWYgKHN0cmV0Y2hlZEhl aWdodCkKICAgICAgICAgICAgICAgICBhdmFpbGFibGVIZWlnaHQgPSBzdHJldGNoZWRIZWlnaHQu dmFsdWUoKTsKICAgICAgICAgICAgIGVsc2UgewotICAgICAgICAgICAgICAgIGF2YWlsYWJsZUhl aWdodCA9IGNvbnRhaW5pbmdCbG9ja0xvZ2ljYWxIZWlnaHRGb3JDb250ZW50KEluY2x1ZGVNYXJn aW5Cb3JkZXJQYWRkaW5nKTsKKyAgICAgICAgICAgICAgICBhdmFpbGFibGVIZWlnaHQgPSBoYXNQ ZXJwZW5kaWN1bGFyQ29udGFpbmluZ0Jsb2NrID8gY29udGFpbmluZ0Jsb2NrTG9naWNhbFdpZHRo Rm9yQ29udGVudCgpIDogY29udGFpbmluZ0Jsb2NrTG9naWNhbEhlaWdodEZvckNvbnRlbnQoSW5j bHVkZU1hcmdpbkJvcmRlclBhZGRpbmcpOwogICAgICAgICAgICAgICAgIC8vIEl0IGlzIG5lY2Vz c2FyeSB0byB1c2UgdGhlIGJvcmRlci1ib3ggdG8gbWF0Y2ggV2luSUUncyBicm9rZW4KICAgICAg ICAgICAgICAgICAvLyBib3ggbW9kZWwuICBUaGlzIGlzIGVzc2VudGlhbCBmb3Igc2l6aW5nIGlu c2lkZQogICAgICAgICAgICAgICAgIC8vIHRhYmxlIGNlbGxzIHVzaW5nIHBlcmNlbnRhZ2UgaGVp Z2h0cy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRU ZXN0cy9UZXN0RXhwZWN0YXRpb25zCmluZGV4IGY3N2ZlZTliNDA3YWJkM2Y1NTI1ZDhlYTJkZTgw MTdhNzMzMjRjYjYuLjZlYTJhYzQ0NzQ1MTk2MzhjZWM1ZTFiNWNlMDNiN2E4YjZkN2YzZTUgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMv VGVzdEV4cGVjdGF0aW9ucwpAQCAtMTE4NCw3ICsxMTg0LDYgQEAgd2Via2l0Lm9yZy9iLzIxNjE0 NSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtZ3JpZC9hbGlnbm1lbnQv Z3JpZC0KIHdlYmtpdC5vcmcvYi8yMTYxNDUgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0 cy9jc3MvY3NzLWdyaWQvYWxpZ25tZW50L2dyaWQtaXRlbS1uby1hc3BlY3QtcmF0aW8tc3RyZXRj aC05Lmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8yMTYxNDUgaW1wb3J0 ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLWdyaWQvYWxpZ25tZW50L2dyaWQtaXRl bS1uby1hc3BlY3QtcmF0aW8tc3RyZXRjaC0xMC5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiB3 ZWJraXQub3JnL2IvMTkxNDYxIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nz cy1ncmlkL2dyaWQtaXRlbXMvcGVyY2VudGFnZS1zaXplLXN1Yml0ZW1zLTAwMS5odG1sIFsgSW1h Z2VPbmx5RmFpbHVyZSBdCi13ZWJraXQub3JnL2IvMTkxNDYyIGltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvY3NzL2Nzcy1ncmlkL2dyaWQtaXRlbXMvcGVyY2VudGFnZS1zaXplLXJlcGxh Y2VkLXN1Yml0ZW1zLTAwMS5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiB3ZWJraXQub3JnL2Iv MTkxNDYzIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1ncmlkL2dyaWQt aXRlbXMvZXhwbGljaXRseS1zaXplZC1ncmlkLWl0ZW0tYXMtdGFibGUuaHRtbCBbIEltYWdlT25s eUZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzE5MTYyNyBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3Jt LXRlc3RzL2Nzcy9jc3MtZ3JpZC9hbGlnbm1lbnQvZ3JpZC1zZWxmLWJhc2VsaW5lLW5vdC1hcHBs aWVkLWlmLXNpemluZy1jeWNsaWMtZGVwZW5kZW5jeS0wMDEuaHRtbCBbIEZhaWx1cmUgXQogd2Vi a2l0Lm9yZy9iLzE0OTg5MCBmYXN0L2Nzcy1ncmlkLWxheW91dC9ncmlkLXNob3J0aGFuZHMtc3R5 bGUtZm9ybWF0Lmh0bWwgWyBGYWlsdXJlIF0K 413817 2020-11-11 06:46:00 -0800 2020-11-11 22:26:33 -0800 Patch bug-191462-20201111144559.patch text/plain 4952 zsun U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5NTgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWEyZDMxZGI5OTAxZTcw NjU4N2Y0YzRkNzA4NjQ3Njk5NzhjMGIzOC4uY2ZjMjY4M2E4YmQ2MGE2MjFmOTA5NThkOTM1YjQ5 MzlmMWJmMmFiMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIwLTExLTExICBaaXJh biBTdW4gIDx6c3VuQGlnYWxpYS5jb20+CisKKyAgICAgICAgW2Nzcy1ncmlkXSBQZXJjZW50YWdl IGhlaWdodCBvbiByZXBsYWNlZCBpdGVtIHdpdGggc2Nyb2xsYmFyCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTE0NjIKKyAgICAgICAgCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgQ0wgaXMgdG8gc3Vi dHJhY3Qgc2Nyb2xsYmFyIGluIGNvbXB1dGVSZXBsYWNlZExvZ2ljYWxIZWlnaHRVc2luZygpLgor ICAgICAgICBJbiBSZW5kZXJCb3g6OmNvbXB1dGVSZXBsYWNlZExvZ2ljYWxIZWlnaHRVc2luZygp IHdlIHNob3VsZCBhbHNvIHN1YnRyYWN0CisgICAgICAgIHNjcm9sbGJhckxvZ2ljYWxIZWlnaHQo KSB3aGVuIGNhbGN1bGF0aW5nIHN0cmV0Y2hIZWlnaHQuIFdpdGhvdXQgdGhpcyBzdWJ0cmFjdGlv biwKKyAgICAgICAgaXQgY2F1c2VkIGlzc3VlcyB0byByZXNvbHZlIHRoZSBwZXJjZW50YWdlIGhl aWdodHMgb24gZ3JpZCBpdGVtIHJlcGxhY2VkIGNoaWxkcmVuLAorICAgICAgICBpZiB0aGUgZ3Jp ZCBpdGVtIGhhcyBhIHNjcm9sbGJhci4KKyAgICAgICAgCisgICAgICAgIEl0IHBvcnRzIHRoZSBj aGFuZ2VzIGZyb20gdGhlIGZvbGxvd2luZyBwYXRjaCBhdCBDaHJvbWl1bToKKyAgICAgICAgaHR0 cHM6Ly9idWdzLmNocm9taXVtLm9yZy9wL2Nocm9taXVtL2lzc3Vlcy9kZXRhaWw/aWQ9ODM3MTQx CisgICAgICAgIFRlc3QgZmlsZXMgd2VyZSBhbHJlYWR5IHBvcnRlZCBpbiBXUFQgYXQKKyAgICAg ICAgaHR0cHM6Ly9naXRodWIuY29tL3dlYi1wbGF0Zm9ybS10ZXN0cy93cHQvY29tbWl0LzUzOGVl ZGFmYjE1NzMzYzYxMTNiNDQ5OTgxNzBhNmJiZGFlNzUxOGIKKyAgICAgICAgCisgICAgICAgICog cmVuZGVyaW5nL1JlbmRlckJveC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCb3g6OmNv bXB1dGVSZXBsYWNlZExvZ2ljYWxIZWlnaHRVc2luZyBjb25zdCk6CisKIDIwMjAtMTEtMDkgIENo cmlzIExvcmQgIDxjbG9yZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdW1dQRV0gU2Nyb2xs aW5nIHdpdGggbW91c2Ugd2hlZWwgZG9lc24ndCB3b3JrIG9uIGlmcmFtZXMgd2l0aCBhc3luYyBz Y3JvbGxpbmcgZW5hYmxlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckJveC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcAppbmRl eCA4NWE0YzU2MmIyMWEzYjc2ZjI5MjcwMDNmMTgxMzU5ZmMxOTU3ZThhLi5jNzY1YzFkMGQ4MzZm ZGI4Yjg2YjhhM2RlMTAwNDlhYmViNzc3YmQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyQm94LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyQm94LmNwcApAQCAtMzE5MSwxNCArMzE5MSwxNSBAQCBMYXlvdXRVbml0IFJlbmRlckJveDo6 Y29tcHV0ZVJlcGxhY2VkTG9naWNhbEhlaWdodFVzaW5nKFNpemVUeXBlIGhlaWdodFR5cGUsIExl bgogICAgICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgICAgICBjb250YWluZXIg PSBjb250YWluZXItPmNvbnRhaW5pbmdCbG9jaygpOwogICAgICAgICAgICAgfQorICAgICAgICAg ICAgYm9vbCBoYXNQZXJwZW5kaWN1bGFyQ29udGFpbmluZ0Jsb2NrID0gY29udGFpbmVyLT5pc0hv cml6b250YWxXcml0aW5nTW9kZSgpICE9IGlzSG9yaXpvbnRhbFdyaXRpbmdNb2RlKCk7CiAgICAg ICAgICAgICBPcHRpb25hbDxMYXlvdXRVbml0PiBzdHJldGNoZWRIZWlnaHQ7CiAgICAgICAgICAg ICBpZiAoaXM8UmVuZGVyQmxvY2s+KGNvbnRhaW5lcikpIHsKICAgICAgICAgICAgICAgICBhdXRv KiBibG9jayA9IGRvd25jYXN0PFJlbmRlckJsb2NrPihjb250YWluZXIpOwogICAgICAgICAgICAg ICAgIGJsb2NrLT5hZGRQZXJjZW50SGVpZ2h0RGVzY2VuZGFudCgqY29uc3RfY2FzdDxSZW5kZXJC b3gqPih0aGlzKSk7CiAgICAgICAgICAgICAgICAgaWYgKGJsb2NrLT5pc0ZsZXhJdGVtKCkpCiAg ICAgICAgICAgICAgICAgICAgIHN0cmV0Y2hlZEhlaWdodCA9IGRvd25jYXN0PFJlbmRlckZsZXhp YmxlQm94PihibG9jay0+cGFyZW50KCkpLT5jaGlsZExvZ2ljYWxIZWlnaHRGb3JQZXJjZW50YWdl UmVzb2x1dGlvbigqYmxvY2spOwotICAgICAgICAgICAgICAgIGVsc2UgaWYgKGJsb2NrLT5pc0dy aWRJdGVtKCkgJiYgYmxvY2stPmhhc092ZXJyaWRpbmdMb2dpY2FsSGVpZ2h0KCkpCi0gICAgICAg ICAgICAgICAgICAgIHN0cmV0Y2hlZEhlaWdodCA9IGJsb2NrLT5vdmVycmlkaW5nTG9naWNhbEhl aWdodCgpIC0gYmxvY2stPmJvcmRlckFuZFBhZGRpbmdMb2dpY2FsSGVpZ2h0KCk7CisgICAgICAg ICAgICAgICAgZWxzZSBpZiAoYmxvY2stPmlzR3JpZEl0ZW0oKSAmJiBibG9jay0+aGFzT3ZlcnJp ZGluZ0xvZ2ljYWxIZWlnaHQoKSAmJiAhaGFzUGVycGVuZGljdWxhckNvbnRhaW5pbmdCbG9jaykK KyAgICAgICAgICAgICAgICAgICAgc3RyZXRjaGVkSGVpZ2h0ID0gYmxvY2stPm92ZXJyaWRpbmdD b250ZW50TG9naWNhbEhlaWdodCgpOwogICAgICAgICAgICAgfQogCiAgICAgICAgICAgICAvLyBG SVhNRTogVGhpcyBjYWxjdWxhdGlvbiBpcyBub3QgcGF0Y2hlZCBmb3IgYmxvY2stZmxvdyB5ZXQu CkBAIC0zMjIyLDcgKzMyMjMsNyBAQCBMYXlvdXRVbml0IFJlbmRlckJveDo6Y29tcHV0ZVJlcGxh Y2VkTG9naWNhbEhlaWdodFVzaW5nKFNpemVUeXBlIGhlaWdodFR5cGUsIExlbgogICAgICAgICAg ICAgZWxzZSBpZiAoc3RyZXRjaGVkSGVpZ2h0KQogICAgICAgICAgICAgICAgIGF2YWlsYWJsZUhl aWdodCA9IHN0cmV0Y2hlZEhlaWdodC52YWx1ZSgpOwogICAgICAgICAgICAgZWxzZSB7Ci0gICAg ICAgICAgICAgICAgYXZhaWxhYmxlSGVpZ2h0ID0gY29udGFpbmluZ0Jsb2NrTG9naWNhbEhlaWdo dEZvckNvbnRlbnQoSW5jbHVkZU1hcmdpbkJvcmRlclBhZGRpbmcpOworICAgICAgICAgICAgICAg IGF2YWlsYWJsZUhlaWdodCA9IGhhc1BlcnBlbmRpY3VsYXJDb250YWluaW5nQmxvY2sgPyBjb250 YWluaW5nQmxvY2tMb2dpY2FsV2lkdGhGb3JDb250ZW50KCkgOiBjb250YWluaW5nQmxvY2tMb2dp Y2FsSGVpZ2h0Rm9yQ29udGVudChJbmNsdWRlTWFyZ2luQm9yZGVyUGFkZGluZyk7CiAgICAgICAg ICAgICAgICAgLy8gSXQgaXMgbmVjZXNzYXJ5IHRvIHVzZSB0aGUgYm9yZGVyLWJveCB0byBtYXRj aCBXaW5JRSdzIGJyb2tlbgogICAgICAgICAgICAgICAgIC8vIGJveCBtb2RlbC4gIFRoaXMgaXMg ZXNzZW50aWFsIGZvciBzaXppbmcgaW5zaWRlCiAgICAgICAgICAgICAgICAgLy8gdGFibGUgY2Vs bHMgdXNpbmcgcGVyY2VudGFnZSBoZWlnaHRzLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvVGVz dEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggZjc3ZmVl OWI0MDdhYmQzZjU1MjVkOGVhMmRlODAxN2E3MzMyNGNiNi4uNmVhMmFjNDQ3NDUxOTYzOGNlYzVl MWI1Y2UwM2I3YThiNmQ3ZjNlNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0 aW9ucworKysgYi9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCkBAIC0xMTg0LDcgKzExODQs NiBAQCB3ZWJraXQub3JnL2IvMjE2MTQ1IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMv Y3NzL2Nzcy1ncmlkL2FsaWdubWVudC9ncmlkLQogd2Via2l0Lm9yZy9iLzIxNjE0NSBpbXBvcnRl ZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtZ3JpZC9hbGlnbm1lbnQvZ3JpZC1pdGVt LW5vLWFzcGVjdC1yYXRpby1zdHJldGNoLTkuaHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQogd2Vi a2l0Lm9yZy9iLzIxNjE0NSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3Mt Z3JpZC9hbGlnbm1lbnQvZ3JpZC1pdGVtLW5vLWFzcGVjdC1yYXRpby1zdHJldGNoLTEwLmh0bWwg WyBJbWFnZU9ubHlGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xOTE0NjEgaW1wb3J0ZWQvdzNjL3dl Yi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLWdyaWQvZ3JpZC1pdGVtcy9wZXJjZW50YWdlLXNpemUt c3ViaXRlbXMtMDAxLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KLXdlYmtpdC5vcmcvYi8xOTE0 NjIgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLWdyaWQvZ3JpZC1pdGVt cy9wZXJjZW50YWdlLXNpemUtcmVwbGFjZWQtc3ViaXRlbXMtMDAxLmh0bWwgWyBJbWFnZU9ubHlG YWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xOTE0NjMgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10 ZXN0cy9jc3MvY3NzLWdyaWQvZ3JpZC1pdGVtcy9leHBsaWNpdGx5LXNpemVkLWdyaWQtaXRlbS1h cy10YWJsZS5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTkxNjI3IGlt cG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1ncmlkL2FsaWdubWVudC9ncmlk LXNlbGYtYmFzZWxpbmUtbm90LWFwcGxpZWQtaWYtc2l6aW5nLWN5Y2xpYy1kZXBlbmRlbmN5LTAw MS5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTQ5ODkwIGZhc3QvY3NzLWdyaWQtbGF5 b3V0L2dyaWQtc2hvcnRoYW5kcy1zdHlsZS1mb3JtYXQuaHRtbCBbIEZhaWx1cmUgXQo=