191455 2018-11-08 21:17:33 -0800 WebHistory.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] 2018-11-09 08:44:09 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii achristensen bfulgham commit-queue don.olmstead pvollan webkit-bug-importer oldest_to_newest 1476791 0 fujii 2018-11-08 21:17:33 -0800 WebHistory.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] Clang-cl reports following compilation warnings while building WinCairo port: > [5754/6223] Building CXX object Source\WebKitLegacy\CMakeFiles\WebKitLegacy.dir\win\WebHistory.cpp.obj > In file included from ..\..\Source\WebKitLegacy\win\WebHistory.cpp:27: > ..\..\Source\WebKitLegacy\win/WebHistory.h(54,39): warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] > virtual HRESULT STDMETHODCALLTYPE QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppvObject); > ^ > C:\Program Files (x86)\Windows Kits\10\include\10.0.17134.0\um\unknwnbase.h(113,47): note: overridden virtual function is here > virtual HRESULT STDMETHODCALLTYPE QueryInterface( > ^ > In file included from ..\..\Source\WebKitLegacy\win\WebHistory.cpp:27: > ..\..\Source\WebKitLegacy\win/WebHistory.h(55,37): warning: 'AddRef' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] > virtual ULONG STDMETHODCALLTYPE AddRef(); > ^ > C:\Program Files (x86)\Windows Kits\10\include\10.0.17134.0\um\unknwnbase.h(117,45): note: overridden virtual function is here > virtual ULONG STDMETHODCALLTYPE AddRef( void) = 0; > ^ > In file included from ..\..\Source\WebKitLegacy\win\WebHistory.cpp:27: > ..\..\Source\WebKitLegacy\win/WebHistory.h(56,37): warning: 'Release' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] > virtual ULONG STDMETHODCALLTYPE Release(); > ^ > C:\Program Files (x86)\Windows Kits\10\include\10.0.17134.0\um\unknwnbase.h(119,45): note: overridden virtual function is here > virtual ULONG STDMETHODCALLTYPE Release( void) = 0; > ^ 1476794 1 354312 fujii 2018-11-08 21:23:12 -0800 Created attachment 354312 Patch 1476796 2 don.olmstead 2018-11-08 21:26:47 -0800 LGTM 1476911 3 354312 bfulgham 2018-11-09 08:18:09 -0800 Comment on attachment 354312 Patch Nice! It's great to see more of this code getting good attention. Thank you! 1476920 4 354312 commit-queue 2018-11-09 08:42:59 -0800 Comment on attachment 354312 Patch Clearing flags on attachment: 354312 Committed r238032: <https://trac.webkit.org/changeset/238032> 1476921 5 commit-queue 2018-11-09 08:43:01 -0800 All reviewed patches have been landed. Closing bug. 1476922 6 webkit-bug-importer 2018-11-09 08:44:09 -0800 <rdar://problem/45944979> 354312 2018-11-08 21:23:12 -0800 2018-11-09 08:42:59 -0800 Patch bug-191455-20181109142311.patch text/plain 4443 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4MDE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L3dpbi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L3dpbi9DaGFuZ2VMb2cKaW5k ZXggZTNiNmM4ZGVhNTFkZjVlMjQ5MTU2YzE1ODA1NWQ1YjExMTIzZDMzNi4uZDQ2ZjdjZmVjZjRl ZDlmMmNmMDNkZjZlMWI4MjBiMGYwOGRkZGY1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl Z2FjeS93aW4vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvd2luL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDEyIEBACisyMDE4LTExLTA4ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3Jp LkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFdlYkhpc3RvcnkuaDogd2FybmluZzogJ1F1ZXJ5 SW50ZXJmYWNlJyBvdmVycmlkZXMgYSBtZW1iZXIgZnVuY3Rpb24gYnV0IGlzIG5vdCBtYXJrZWQg J292ZXJyaWRlJyBbLVdpbmNvbnNpc3RlbnQtbWlzc2luZy1vdmVycmlkZV0KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTQ1NQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViSGlzdG9yeS5oOiBNYXJr ZWQgd2l0aCAnb3ZlcnJpZGUnIGFuZCByZW1vdmVkICd2aXJ0dWFsJy4KKwogMjAxOC0xMS0wMSAg U2lodWkgTGl1ICA8c2lodWlfbGl1QGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgYSBzdG9yYWdl IGxpbWl0IGZvciBJbmRleGVkREIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvd2lu L1dlYkhpc3RvcnkuaCBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvd2luL1dlYkhpc3RvcnkuaAppbmRl eCAxN2FmZjkyODI3ZDFkMTA5YjUzZTljZGNjNmNlNDljOGJlM2U3MGU1Li5hNTJjNTFmMmJiZGMz YjAyYzhmYmNiODM3MWU2ZmRlYjA0YzE4NzBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L3dpbi9XZWJIaXN0b3J5LmgKKysrIGIvU291cmNlL1dlYktpdExlZ2FjeS93aW4vV2ViSGlz dG9yeS5oCkBAIC01MSwzMCArNTEsMzAgQEAgcHJpdmF0ZToKIAogcHVibGljOgogICAgIC8vIElV bmtub3duCi0gICAgdmlydHVhbCBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIFF1ZXJ5SW50ZXJm YWNlKF9Jbl8gUkVGSUlEIHJpaWQsIF9DT01fT3V0cHRyXyB2b2lkKiogcHB2T2JqZWN0KTsKLSAg ICB2aXJ0dWFsIFVMT05HIFNURE1FVEhPRENBTExUWVBFIEFkZFJlZigpOwotICAgIHZpcnR1YWwg VUxPTkcgU1RETUVUSE9EQ0FMTFRZUEUgUmVsZWFzZSgpOworICAgIEhSRVNVTFQgU1RETUVUSE9E Q0FMTFRZUEUgUXVlcnlJbnRlcmZhY2UoX0luXyBSRUZJSUQgcmlpZCwgX0NPTV9PdXRwdHJfIHZv aWQqKiBwcHZPYmplY3QpIG92ZXJyaWRlOworICAgIFVMT05HIFNURE1FVEhPRENBTExUWVBFIEFk ZFJlZigpIG92ZXJyaWRlOworICAgIFVMT05HIFNURE1FVEhPRENBTExUWVBFIFJlbGVhc2UoKSBv dmVycmlkZTsKIAogICAgIC8vIElXZWJIaXN0b3J5Ci0gICAgdmlydHVhbCBIUkVTVUxUIFNURE1F VEhPRENBTExUWVBFIG9wdGlvbmFsU2hhcmVkSGlzdG9yeShfQ09NX091dHB0cl9vcHRfIElXZWJI aXN0b3J5KiopOwotICAgIHZpcnR1YWwgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBzZXRPcHRp b25hbFNoYXJlZEhpc3RvcnkoX0luX29wdF8gSVdlYkhpc3RvcnkqKTsKKyAgICBIUkVTVUxUIFNU RE1FVEhPRENBTExUWVBFIG9wdGlvbmFsU2hhcmVkSGlzdG9yeShfQ09NX091dHB0cl9vcHRfIElX ZWJIaXN0b3J5KiopIG92ZXJyaWRlOworICAgIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgc2V0 T3B0aW9uYWxTaGFyZWRIaXN0b3J5KF9Jbl9vcHRfIElXZWJIaXN0b3J5Kikgb3ZlcnJpZGU7CiAg ICAgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSB1bnVzZWQxKCkgb3ZlcnJpZGU7CiAgICAgSFJF U1VMVCBTVERNRVRIT0RDQUxMVFlQRSB1bnVzZWQyKCkgb3ZlcnJpZGU7Ci0gICAgdmlydHVhbCBI UkVTVUxUIFNURE1FVEhPRENBTExUWVBFIGFkZEl0ZW1zKGludCBpdGVtQ291bnQsIF9fZGVyZWZf aW5fZWNvdW50X29wdChpdGVtQ291bnQpIElXZWJIaXN0b3J5SXRlbSoqKTsKLSAgICB2aXJ0dWFs IEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgcmVtb3ZlSXRlbXMoaW50IGl0ZW1Db3VudCwgX19k ZXJlZl9pbl9lY291bnRfb3B0KGl0ZW1Db3VudCkgSVdlYkhpc3RvcnlJdGVtKiopOwotICAgIHZp cnR1YWwgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSByZW1vdmVBbGxJdGVtcygpOwotICAgIHZp cnR1YWwgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBvcmRlcmVkTGFzdFZpc2l0ZWREYXlzKF9J bm91dF8gaW50KiBjb3VudCwgX0luXyBEQVRFKiBjYWxlbmRhckRhdGVzKTsKLSAgICB2aXJ0dWFs IEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgb3JkZXJlZEl0ZW1zTGFzdFZpc2l0ZWRPbkRheShf SW5vdXRfIGludCogY291bnQsIF9fZGVyZWZfaW5fb3B0IElXZWJIaXN0b3J5SXRlbSoqIGl0ZW1z LCBEQVRFIGNhbGVuZGFyRGF0ZSk7Ci0gICAgdmlydHVhbCBIUkVTVUxUIFNURE1FVEhPRENBTExU WVBFIGl0ZW1Gb3JVUkwoX0luXyBCU1RSIHVybCwgX0NPTV9PdXRwdHJfb3B0XyBJV2ViSGlzdG9y eUl0ZW0qKik7Ci0gICAgdmlydHVhbCBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIHNldEhpc3Rv cnlJdGVtTGltaXQoaW50KTsKLSAgICB2aXJ0dWFsIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUg aGlzdG9yeUl0ZW1MaW1pdChfT3V0XyBpbnQqKTsKLSAgICB2aXJ0dWFsIEhSRVNVTFQgU1RETUVU SE9EQ0FMTFRZUEUgc2V0SGlzdG9yeUFnZUluRGF5c0xpbWl0KGludCk7Ci0gICAgdmlydHVhbCBI UkVTVUxUIFNURE1FVEhPRENBTExUWVBFIGhpc3RvcnlBZ2VJbkRheXNMaW1pdChfT3V0XyBpbnQq KTsKKyAgICBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIGFkZEl0ZW1zKGludCBpdGVtQ291bnQs IF9fZGVyZWZfaW5fZWNvdW50X29wdChpdGVtQ291bnQpIElXZWJIaXN0b3J5SXRlbSoqKSBvdmVy cmlkZTsKKyAgICBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIHJlbW92ZUl0ZW1zKGludCBpdGVt Q291bnQsIF9fZGVyZWZfaW5fZWNvdW50X29wdChpdGVtQ291bnQpIElXZWJIaXN0b3J5SXRlbSoq KSBvdmVycmlkZTsKKyAgICBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIHJlbW92ZUFsbEl0ZW1z KCkgb3ZlcnJpZGU7CisgICAgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBvcmRlcmVkTGFzdFZp c2l0ZWREYXlzKF9Jbm91dF8gaW50KiBjb3VudCwgX0luXyBEQVRFKiBjYWxlbmRhckRhdGVzKSBv dmVycmlkZTsKKyAgICBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIG9yZGVyZWRJdGVtc0xhc3RW aXNpdGVkT25EYXkoX0lub3V0XyBpbnQqIGNvdW50LCBfX2RlcmVmX2luX29wdCBJV2ViSGlzdG9y eUl0ZW0qKiBpdGVtcywgREFURSBjYWxlbmRhckRhdGUpIG92ZXJyaWRlOworICAgIEhSRVNVTFQg U1RETUVUSE9EQ0FMTFRZUEUgaXRlbUZvclVSTChfSW5fIEJTVFIgdXJsLCBfQ09NX091dHB0cl9v cHRfIElXZWJIaXN0b3J5SXRlbSoqKSBvdmVycmlkZTsKKyAgICBIUkVTVUxUIFNURE1FVEhPRENB TExUWVBFIHNldEhpc3RvcnlJdGVtTGltaXQoaW50KSBvdmVycmlkZTsKKyAgICBIUkVTVUxUIFNU RE1FVEhPRENBTExUWVBFIGhpc3RvcnlJdGVtTGltaXQoX091dF8gaW50Kikgb3ZlcnJpZGU7Cisg ICAgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBzZXRIaXN0b3J5QWdlSW5EYXlzTGltaXQoaW50 KSBvdmVycmlkZTsKKyAgICBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIGhpc3RvcnlBZ2VJbkRh eXNMaW1pdChfT3V0XyBpbnQqKSBvdmVycmlkZTsKIAogICAgIC8vIElXZWJIaXN0b3J5UHJpdmF0 ZQotICAgIHZpcnR1YWwgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBhbGxJdGVtcyhfSW5vdXRf IGludCogY291bnQsIF9fZGVyZWZfb3B0X291dCBJV2ViSGlzdG9yeUl0ZW0qKiBpdGVtcyk7Ci0g ICAgdmlydHVhbCBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIHNldFZpc2l0ZWRMaW5rVHJhY2tp bmdFbmFibGVkKEJPT0wpOwotICAgIHZpcnR1YWwgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBy ZW1vdmVBbGxWaXNpdGVkTGlua3MoKTsKKyAgICBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIGFs bEl0ZW1zKF9Jbm91dF8gaW50KiBjb3VudCwgX19kZXJlZl9vcHRfb3V0IElXZWJIaXN0b3J5SXRl bSoqIGl0ZW1zKSBvdmVycmlkZTsKKyAgICBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIHNldFZp c2l0ZWRMaW5rVHJhY2tpbmdFbmFibGVkKEJPT0wpIG92ZXJyaWRlOworICAgIEhSRVNVTFQgU1RE TUVUSE9EQ0FMTFRZUEUgcmVtb3ZlQWxsVmlzaXRlZExpbmtzKCkgb3ZlcnJpZGU7CiAKICAgICAv LyBXZWJIaXN0b3J5CiAgICAgc3RhdGljIFdlYkhpc3RvcnkqIHNoYXJlZEhpc3RvcnkoKTsK