191451 2018-11-08 19:26:46 -0800 Extensions3DOpenGLES.h: warning: 'blitFramebuffer' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] 2018-11-09 10:43:30 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii bfulgham commit-queue dino don.olmstead ews-watchlist graouts kondapallykalyan noam webkit-bug-importer zan oldest_to_newest 1476775 0 fujii 2018-11-08 19:26:46 -0800 Clang-cl 7.0 reports following compilation warnings while building WebKit WinCairo port. > [4903/6223] Building CXX object Source\WebCore\CMakeFiles\WebCore.dir\platform\graphics\opengl\Extensions3DOpenGLES.cpp.obj > In file included from ..\..\Source\WebCore\platform\graphics\opengl\Extensions3DOpenGLES.cpp:31: > ..\..\Source\WebCore\platform\graphics\opengl/Extensions3DOpenGLES.h(80,18): warning: 'blitFramebuffer' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] > virtual void blitFramebuffer(long srcX0, long srcY0, long srcX1, long srcY1, long dstX0, long dstY0, long dstX1, long dstY1, unsigned long mask, unsigned long filter); > ^ > ..\..\Source\WebCore\platform\graphics\Extensions3D.h(254,18): note: overridden virtual function is here > virtual void blitFramebuffer(long srcX0, long srcY0, long srcX1, long srcY1, long dstX0, long dstY0, long dstX1, long dstY1, unsigned long mask, unsigned long filter) = 0; > ^ > In file included from ..\..\Source\WebCore\platform\graphics\opengl\Extensions3DOpenGLES.cpp:31: > ..\..\Source\WebCore\platform\graphics\opengl/Extensions3DOpenGLES.h(81,18): warning: 'renderbufferStorageMultisample' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] > virtual void renderbufferStorageMultisample(unsigned long target, unsigned long samples, unsigned long internalformat, unsigned long width, unsigned long height); > ^ > ..\..\Source\WebCore\platform\graphics\Extensions3D.h(257,18): note: overridden virtual function is here > virtual void renderbufferStorageMultisample(unsigned long target, unsigned long samples, unsigned long internalformat, unsigned long width, unsigned long height) = 0; > ^ > In file included from ..\..\Source\WebCore\platform\graphics\opengl\Extensions3DOpenGLES.cpp:31: > ..\..\Source\WebCore\platform\graphics\opengl/Extensions3DOpenGLES.h(82,18): warning: 'insertEventMarkerEXT' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] > virtual void insertEventMarkerEXT(const String&); > ^ > ..\..\Source\WebCore\platform\graphics\Extensions3D.h(274,18): note: overridden virtual function is here > virtual void insertEventMarkerEXT(const String&) = 0; > ^ > In file included from ..\..\Source\WebCore\platform\graphics\opengl\Extensions3DOpenGLES.cpp:31: > ..\..\Source\WebCore\platform\graphics\opengl/Extensions3DOpenGLES.h(83,18): warning: 'pushGroupMarkerEXT' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] > virtual void pushGroupMarkerEXT(const String&); > ^ > ..\..\Source\WebCore\platform\graphics\Extensions3D.h(275,18): note: overridden virtual function is here > virtual void pushGroupMarkerEXT(const String&) = 0; > ^ > In file included from ..\..\Source\WebCore\platform\graphics\opengl\Extensions3DOpenGLES.cpp:31: > ..\..\Source\WebCore\platform\graphics\opengl/Extensions3DOpenGLES.h(84,18): warning: 'popGroupMarkerEXT' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] > virtual void popGroupMarkerEXT(void); > ^ > ..\..\Source\WebCore\platform\graphics\Extensions3D.h(276,18): note: overridden virtual function is here > virtual void popGroupMarkerEXT(void) = 0; > ^ > In file included from ..\..\Source\WebCore\platform\graphics\opengl\Extensions3DOpenGLES.cpp:31: 1476778 1 354305 fujii 2018-11-08 19:40:23 -0800 Created attachment 354305 Patch 1476958 2 don.olmstead 2018-11-09 09:54:56 -0800 LGTM! 1476984 3 354305 commit-queue 2018-11-09 10:42:34 -0800 Comment on attachment 354305 Patch Clearing flags on attachment: 354305 Committed r238044: <https://trac.webkit.org/changeset/238044> 1476985 4 commit-queue 2018-11-09 10:42:35 -0800 All reviewed patches have been landed. Closing bug. 1476986 5 webkit-bug-importer 2018-11-09 10:43:30 -0800 <rdar://problem/45948603> 354305 2018-11-08 19:40:23 -0800 2018-11-09 10:42:34 -0800 Patch bug-191451-20181109124022.patch text/plain 6200 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4MDE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGFjMGViNTliYWIzYmZj YTk1ZDc3Yzg5NjFhOGViMWU1MTA5MWEyYS4uNjA4NjI3YTg0Nzg3MmQxYWU5ZmM5NzAzZGRhODE4 YzMxYzI5NjE5YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTExLTA4ICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIEV4dGVuc2lv bnMzRE9wZW5HTEVTLmg6ICB3YXJuaW5nOiAnYmxpdEZyYW1lYnVmZmVyJyBvdmVycmlkZXMgYSBt ZW1iZXIgZnVuY3Rpb24gYnV0IGlzIG5vdCBtYXJrZWQgJ292ZXJyaWRlJyBbLVdpbmNvbnNpc3Rl bnQtbWlzc2luZy1vdmVycmlkZV0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE5MTQ1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBiZWNhdXNlIHRoZXJlIGlzIG5vIGJlaGF2aW9yIGNo YW5nZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9FeHRlbnNpb25zM0RP cGVuR0xFUy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFeHRlbnNpb25zM0RPcGVuR0xFUzo6c2V0 RVhUQ29udGV4dExvc3RDYWxsYmFjayk6IERlbGV0ZWQgdW51c2VkIG1ldGhvZC4KKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvRXh0ZW5zaW9uczNET3BlbkdMRVMuaDogTWFya2Vk ICdvdmVycmlkZScuCisKIDIwMTgtMTEtMDggIE1lZ2FuIEdhcmRuZXIgIDxtZWdhbl9nYXJkbmVy QGFwcGxlLmNvbT4KIAogICAgICAgICBBZG9wdCBSZXZlYWwgRnJhbWV3b3JrIHRvIHJlcGxhY2Ug TG9va3VwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVu Z2wvRXh0ZW5zaW9uczNET3BlbkdMRVMuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3Mvb3BlbmdsL0V4dGVuc2lvbnMzRE9wZW5HTEVTLmNwcAppbmRleCAxNDlkNjFlZDlkYTYy NGIzOGVlY2ZlYzcyYmU1ZTU5MDcwZjY2NGRjLi5iMDMyZWQ3ZmMyZjQwOTVmMzhlZWNiZGJlZGU5 NzVjNmE5OGU4ZTExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9vcGVuZ2wvRXh0ZW5zaW9uczNET3BlbkdMRVMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL29wZW5nbC9FeHRlbnNpb25zM0RPcGVuR0xFUy5jcHAKQEAgLTIwNiwx MSArMjA2LDYgQEAgaW50IEV4dGVuc2lvbnMzRE9wZW5HTEVTOjpnZXRHcmFwaGljc1Jlc2V0U3Rh dHVzQVJCKCkKICAgICByZXR1cm4gZmFsc2U7CiB9CiAKLXZvaWQgRXh0ZW5zaW9uczNET3BlbkdM RVM6OnNldEVYVENvbnRleHRMb3N0Q2FsbGJhY2soc3RkOjp1bmlxdWVfcHRyPEdyYXBoaWNzQ29u dGV4dDNEOjpDb250ZXh0TG9zdENhbGxiYWNrPiBjYWxsYmFjaykKLXsKLSAgICBtX2NvbnRleHRM b3N0Q2FsbGJhY2sgPSBXVEZNb3ZlKGNhbGxiYWNrKTsKLX0KLQogdm9pZCBFeHRlbnNpb25zM0RP cGVuR0xFUzo6cmVhZG5QaXhlbHNFWFQoaW50IHgsIGludCB5LCBHQzNEc2l6ZWkgd2lkdGgsIEdD M0RzaXplaSBoZWlnaHQsIEdDM0RlbnVtIGZvcm1hdCwgR0MzRGVudW0gdHlwZSwgR0MzRHNpemVp IGJ1ZlNpemUsIHZvaWQgKmRhdGEpCiB7CiAgICAgaWYgKG1fZ2xSZWFkblBpeGVsc0VYVCkgewpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0V4dGVu c2lvbnMzRE9wZW5HTEVTLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVu Z2wvRXh0ZW5zaW9uczNET3BlbkdMRVMuaAppbmRleCBlOWNlNmFhOTQ3NjE0ZGJlOWMxZTczYTAx ZmZmYWI3NWRiNWUyMjBkLi5kMDFlM2IyOTMwZjY2YTM1OGIxNTIzNmJmMTg1ZjlmNTY0NzEyNjky IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvRXh0 ZW5zaW9uczNET3BlbkdMRVMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9vcGVuZ2wvRXh0ZW5zaW9uczNET3BlbkdMRVMuaApAQCAtNzEsNDAgKzcxLDM4IEBAIHB1Ymxp YzoKICAgICBFeHRlbnNpb25zM0RPcGVuR0xFUyhHcmFwaGljc0NvbnRleHQzRCosIGJvb2wgdXNl SW5kZXhlZEdldFN0cmluZyk7CiAgICAgdmlydHVhbCB+RXh0ZW5zaW9uczNET3BlbkdMRVMoKTsK IAotICAgIGJvb2wgaXNFbmFibGVkKGNvbnN0IFN0cmluZyYpIG92ZXJyaWRlOwotCiAgICAgdmly dHVhbCB2b2lkIGZyYW1lYnVmZmVyVGV4dHVyZTJETXVsdGlzYW1wbGVJTUcodW5zaWduZWQgbG9u ZyB0YXJnZXQsIHVuc2lnbmVkIGxvbmcgYXR0YWNobWVudCwgdW5zaWduZWQgbG9uZyB0ZXh0YXJn ZXQsIHVuc2lnbmVkIGludCB0ZXh0dXJlLCBpbnQgbGV2ZWwsIHVuc2lnbmVkIGxvbmcgc2FtcGxl cyk7CiAgICAgdmlydHVhbCB2b2lkIHJlbmRlcmJ1ZmZlclN0b3JhZ2VNdWx0aXNhbXBsZUlNRyh1 bnNpZ25lZCBsb25nIHRhcmdldCwgdW5zaWduZWQgbG9uZyBzYW1wbGVzLCB1bnNpZ25lZCBsb25n IGludGVybmFsZm9ybWF0LCB1bnNpZ25lZCBsb25nIHdpZHRoLCB1bnNpZ25lZCBsb25nIGhlaWdo dCk7CiAKICAgICAvLyBFeHRlbnNpb24zRCBtZXRob2RzCi0gICAgdmlydHVhbCB2b2lkIGJsaXRG cmFtZWJ1ZmZlcihsb25nIHNyY1gwLCBsb25nIHNyY1kwLCBsb25nIHNyY1gxLCBsb25nIHNyY1kx LCBsb25nIGRzdFgwLCBsb25nIGRzdFkwLCBsb25nIGRzdFgxLCBsb25nIGRzdFkxLCB1bnNpZ25l ZCBsb25nIG1hc2ssIHVuc2lnbmVkIGxvbmcgZmlsdGVyKTsKLSAgICB2aXJ0dWFsIHZvaWQgcmVu ZGVyYnVmZmVyU3RvcmFnZU11bHRpc2FtcGxlKHVuc2lnbmVkIGxvbmcgdGFyZ2V0LCB1bnNpZ25l ZCBsb25nIHNhbXBsZXMsIHVuc2lnbmVkIGxvbmcgaW50ZXJuYWxmb3JtYXQsIHVuc2lnbmVkIGxv bmcgd2lkdGgsIHVuc2lnbmVkIGxvbmcgaGVpZ2h0KTsKLSAgICB2aXJ0dWFsIHZvaWQgaW5zZXJ0 RXZlbnRNYXJrZXJFWFQoY29uc3QgU3RyaW5nJik7Ci0gICAgdmlydHVhbCB2b2lkIHB1c2hHcm91 cE1hcmtlckVYVChjb25zdCBTdHJpbmcmKTsKLSAgICB2aXJ0dWFsIHZvaWQgcG9wR3JvdXBNYXJr ZXJFWFQodm9pZCk7Ci0KLSAgICB2aXJ0dWFsIFBsYXRmb3JtM0RPYmplY3QgY3JlYXRlVmVydGV4 QXJyYXlPRVMoKTsKLSAgICB2aXJ0dWFsIHZvaWQgZGVsZXRlVmVydGV4QXJyYXlPRVMoUGxhdGZv cm0zRE9iamVjdCk7Ci0gICAgdmlydHVhbCBHQzNEYm9vbGVhbiBpc1ZlcnRleEFycmF5T0VTKFBs YXRmb3JtM0RPYmplY3QpOwotICAgIHZpcnR1YWwgdm9pZCBiaW5kVmVydGV4QXJyYXlPRVMoUGxh dGZvcm0zRE9iamVjdCk7Ci0gICAgdmlydHVhbCB2b2lkIGRyYXdCdWZmZXJzRVhUKEdDM0RzaXpl aSwgY29uc3QgR0MzRGVudW0qKTsKLQotICAgIHZpcnR1YWwgdm9pZCBkcmF3QXJyYXlzSW5zdGFu Y2VkKEdDM0RlbnVtIG1vZGUsIEdDM0RpbnQgZmlyc3QsIEdDM0RzaXplaSBjb3VudCwgR0MzRHNp emVpIHByaW1jb3VudCk7Ci0gICAgdmlydHVhbCB2b2lkIGRyYXdFbGVtZW50c0luc3RhbmNlZChH QzNEZW51bSBtb2RlLCBHQzNEc2l6ZWkgY291bnQsIEdDM0RlbnVtIHR5cGUsIGxvbmcgbG9uZyBv ZmZzZXQsIEdDM0RzaXplaSBwcmltY291bnQpOwotICAgIHZpcnR1YWwgdm9pZCB2ZXJ0ZXhBdHRy aWJEaXZpc29yKEdDM0R1aW50IGluZGV4LCBHQzNEdWludCBkaXZpc29yKTsKKyAgICBib29sIGlz RW5hYmxlZChjb25zdCBTdHJpbmcmKSBvdmVycmlkZTsKKyAgICB2b2lkIGJsaXRGcmFtZWJ1ZmZl cihsb25nIHNyY1gwLCBsb25nIHNyY1kwLCBsb25nIHNyY1gxLCBsb25nIHNyY1kxLCBsb25nIGRz dFgwLCBsb25nIGRzdFkwLCBsb25nIGRzdFgxLCBsb25nIGRzdFkxLCB1bnNpZ25lZCBsb25nIG1h c2ssIHVuc2lnbmVkIGxvbmcgZmlsdGVyKSBvdmVycmlkZTsKKyAgICB2b2lkIHJlbmRlcmJ1ZmZl clN0b3JhZ2VNdWx0aXNhbXBsZSh1bnNpZ25lZCBsb25nIHRhcmdldCwgdW5zaWduZWQgbG9uZyBz YW1wbGVzLCB1bnNpZ25lZCBsb25nIGludGVybmFsZm9ybWF0LCB1bnNpZ25lZCBsb25nIHdpZHRo LCB1bnNpZ25lZCBsb25nIGhlaWdodCkgb3ZlcnJpZGU7CisgICAgdm9pZCBpbnNlcnRFdmVudE1h cmtlckVYVChjb25zdCBTdHJpbmcmKSBvdmVycmlkZTsKKyAgICB2b2lkIHB1c2hHcm91cE1hcmtl ckVYVChjb25zdCBTdHJpbmcmKSBvdmVycmlkZTsKKyAgICB2b2lkIHBvcEdyb3VwTWFya2VyRVhU KHZvaWQpIG92ZXJyaWRlOworCisgICAgUGxhdGZvcm0zRE9iamVjdCBjcmVhdGVWZXJ0ZXhBcnJh eU9FUygpIG92ZXJyaWRlOworICAgIHZvaWQgZGVsZXRlVmVydGV4QXJyYXlPRVMoUGxhdGZvcm0z RE9iamVjdCkgb3ZlcnJpZGU7CisgICAgR0MzRGJvb2xlYW4gaXNWZXJ0ZXhBcnJheU9FUyhQbGF0 Zm9ybTNET2JqZWN0KSBvdmVycmlkZTsKKyAgICB2b2lkIGJpbmRWZXJ0ZXhBcnJheU9FUyhQbGF0 Zm9ybTNET2JqZWN0KSBvdmVycmlkZTsKKyAgICB2b2lkIGRyYXdCdWZmZXJzRVhUKEdDM0RzaXpl aSwgY29uc3QgR0MzRGVudW0qKSBvdmVycmlkZTsKKworICAgIHZvaWQgZHJhd0FycmF5c0luc3Rh bmNlZChHQzNEZW51bSBtb2RlLCBHQzNEaW50IGZpcnN0LCBHQzNEc2l6ZWkgY291bnQsIEdDM0Rz aXplaSBwcmltY291bnQpIG92ZXJyaWRlOworICAgIHZvaWQgZHJhd0VsZW1lbnRzSW5zdGFuY2Vk KEdDM0RlbnVtIG1vZGUsIEdDM0RzaXplaSBjb3VudCwgR0MzRGVudW0gdHlwZSwgbG9uZyBsb25n IG9mZnNldCwgR0MzRHNpemVpIHByaW1jb3VudCkgb3ZlcnJpZGU7CisgICAgdm9pZCB2ZXJ0ZXhB dHRyaWJEaXZpc29yKEdDM0R1aW50IGluZGV4LCBHQzNEdWludCBkaXZpc29yKSBvdmVycmlkZTsK IAogICAgIC8vIEVYVCBSb2J1c3RuZXNzIC0gcmVzZXQKLSAgICB2aXJ0dWFsIGludCBnZXRHcmFw aGljc1Jlc2V0U3RhdHVzQVJCKCk7Ci0gICAgdm9pZCBzZXRFWFRDb250ZXh0TG9zdENhbGxiYWNr KHN0ZDo6dW5pcXVlX3B0cjxHcmFwaGljc0NvbnRleHQzRDo6Q29udGV4dExvc3RDYWxsYmFjaz4p OworICAgIGludCBnZXRHcmFwaGljc1Jlc2V0U3RhdHVzQVJCKCkgb3ZlcnJpZGU7CiAKICAgICAv LyBFWFQgUm9idXN0bmVzcyAtIGV0YwotICAgIHZpcnR1YWwgdm9pZCByZWFkblBpeGVsc0VYVChp bnQgeCwgaW50IHksIEdDM0RzaXplaSB3aWR0aCwgR0MzRHNpemVpIGhlaWdodCwgR0MzRGVudW0g Zm9ybWF0LCBHQzNEZW51bSB0eXBlLCBHQzNEc2l6ZWkgYnVmU2l6ZSwgdm9pZCAqZGF0YSk7Ci0g ICAgdmlydHVhbCB2b2lkIGdldG5Vbmlmb3JtZnZFWFQoR0MzRHVpbnQgcHJvZ3JhbSwgaW50IGxv Y2F0aW9uLCBHQzNEc2l6ZWkgYnVmU2l6ZSwgZmxvYXQgKnBhcmFtcyk7Ci0gICAgdmlydHVhbCB2 b2lkIGdldG5Vbmlmb3JtaXZFWFQoR0MzRHVpbnQgcHJvZ3JhbSwgaW50IGxvY2F0aW9uLCBHQzNE c2l6ZWkgYnVmU2l6ZSwgaW50ICpwYXJhbXMpOworICAgIHZvaWQgcmVhZG5QaXhlbHNFWFQoaW50 IHgsIGludCB5LCBHQzNEc2l6ZWkgd2lkdGgsIEdDM0RzaXplaSBoZWlnaHQsIEdDM0RlbnVtIGZv cm1hdCwgR0MzRGVudW0gdHlwZSwgR0MzRHNpemVpIGJ1ZlNpemUsIHZvaWQgKmRhdGEpIG92ZXJy aWRlOworICAgIHZvaWQgZ2V0blVuaWZvcm1mdkVYVChHQzNEdWludCBwcm9ncmFtLCBpbnQgbG9j YXRpb24sIEdDM0RzaXplaSBidWZTaXplLCBmbG9hdCAqcGFyYW1zKSBvdmVycmlkZTsKKyAgICB2 b2lkIGdldG5Vbmlmb3JtaXZFWFQoR0MzRHVpbnQgcHJvZ3JhbSwgaW50IGxvY2F0aW9uLCBHQzNE c2l6ZWkgYnVmU2l6ZSwgaW50ICpwYXJhbXMpIG92ZXJyaWRlOwogCiBwcm90ZWN0ZWQ6Ci0gICAg dmlydHVhbCBib29sIHN1cHBvcnRzRXh0ZW5zaW9uKGNvbnN0IFN0cmluZyYpOwotICAgIHZpcnR1 YWwgU3RyaW5nIGdldEV4dGVuc2lvbnMoKTsKKyAgICBib29sIHN1cHBvcnRzRXh0ZW5zaW9uKGNv bnN0IFN0cmluZyYpIG92ZXJyaWRlOworICAgIFN0cmluZyBnZXRFeHRlbnNpb25zKCkgb3ZlcnJp ZGU7CiAKICAgICBHQzNEZW51bSBtX2NvbnRleHRSZXNldFN0YXR1czsKIAo=