191449 2018-11-08 18:11:06 -0800 Make use of _UIRemoteView instead of CALayerHost if possible for WKRemoteView 2018-11-09 10:59:04 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton bdakin eric.carlson jer.noble jonlee megan_gardner simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1476762 0 thorton 2018-11-08 18:11:06 -0800 Make use of _UIRemoteView instead of CALayerHost if possible for WKRemoteView 1476763 1 354299 thorton 2018-11-08 18:16:03 -0800 Created attachment 354299 Patch 1476764 2 thorton 2018-11-08 18:16:05 -0800 <rdar://problem/45884977> 1476926 3 354299 eric.carlson 2018-11-09 09:00:11 -0800 Comment on attachment 354299 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354299&action=review > Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:189 > + std::call_once(initializeCanUseUIRemoteView, [] { > + canUseUIRemoteView = [_UIRemoteView instancesRespondToSelector:@selector(initWithFrame:pid:contextID:)]; > + }); Nit: this indentation is odd, although the style-bot didn't complain and it is usually much more picky than I am. 1476993 4 354299 thorton 2018-11-09 10:55:33 -0800 Comment on attachment 354299 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354299&action=review >> Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:189 >> + }); > > Nit: this indentation is odd, although the style-bot didn't complain and it is usually much more picky than I am. That is really weird. Also not sure how it happened. Thank you for your review! 1476995 5 thorton 2018-11-09 10:58:56 -0800 https://trac.webkit.org/changeset/238045/webkit 354299 2018-11-08 18:16:03 -0800 2018-11-09 09:00:11 -0800 Patch bug-191449-20181108181603.patch text/plain 5329 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4MDAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc3ZDcxNWZhZjE0MGU5M2I4 ZmJmNzEwN2I5NmZhNjYwNTE5NWI0MDUuLjUxOGZkNTA0NzNiM2NhODUzY2ZhZGNiZTUwYTQ3MDZk YjQ3MzAxZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTgtMTEtMDggIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgTWFrZSB1c2Ugb2YgX1VJ UmVtb3RlVmlldyBpbnN0ZWFkIG9mIENBTGF5ZXJIb3N0IGlmIHBvc3NpYmxlIGZvciBXS1JlbW90 ZVZpZXcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5 MTQ0OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDU4ODQ5Nzc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVUlSZW1vdGVWaWV3IGhhcyBzb21lIG5p Y2UgcHJvY2VzcyBhc3NlcnRpb24gbWFuYWdlbWVudCB0aGF0IGl0IHdvdWxkCisgICAgICAgIGJl IG5pY2UgdG8gbm90IGR1cGxpY2F0ZS4gU28sIHdlIGNhbiBqdXN0IHVzZSBpdCBpbnN0ZWFkIG9m IENBTGF5ZXJIb3N0IQorCisgICAgICAgICogUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5oOgor ICAgICAgICAqIFVJUHJvY2Vzcy9EcmF3aW5nQXJlYVByb3h5Lmg6CisgICAgICAgIChXZWJLaXQ6 OkRyYXdpbmdBcmVhUHJveHk6OnBhZ2UgY29uc3QpOgorICAgICAgICAqIFVJUHJvY2Vzcy9SZW1v dGVMYXllclRyZWUvaW9zL1JlbW90ZUxheWVyVHJlZUhvc3RJT1MubW06CisgICAgICAgICgtW1dL VUlSZW1vdGVWaWV3IGhpdFRlc3Q6d2l0aEV2ZW50Ol0pOgorICAgICAgICAoLVtXS1VJUmVtb3Rl VmlldyBkZXNjcmlwdGlvbl0pOgorICAgICAgICAoY3JlYXRlUmVtb3RlVmlldyk6CisgICAgICAg IChXZWJLaXQ6OlJlbW90ZUxheWVyVHJlZUhvc3Q6OmNyZWF0ZUxheWVyKToKKwogMjAxOC0xMS0w OCAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGV4 cGVyaW1lbnRhbCBzdXBwb3J0IGZvciBhIGBzdXBwb3J0ZWQtY29sb3Itc2NoZW1lc2AgQ1NTIHBy b3BlcnR5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9zcGkvaW9zL1VJS2l0 U1BJLmggYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL3NwaS9pb3MvVUlLaXRTUEkuaAppbmRleCAz MGIyODM2ODMyYWU2MDk5MzdjNDM3MzAzN2Y0ZjA3MTNmZTRlOTU1Li4wMTkyZmZiY2NlYzI5YzRi ZWE3NmI5OTY2Y2RmOTYyZjcyZGJmYWM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1BsYXRm b3JtL3NwaS9pb3MvVUlLaXRTUEkuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL3NwaS9p b3MvVUlLaXRTUEkuaApAQCAtMTA0Myw2ICsxMDQzLDEzIEBAIHR5cGVkZWYgTlNJbnRlZ2VyIFVJ Q29tcG9zaXRpbmdNb2RlOwogLSAoQ0dGbG9hdClnZXRWZXJ0aWNhbE92ZXJsYXBGb3JWaWV3OihV SVZpZXcgKil2aWV3IHVzaW5nS2V5Ym9hcmRJbmZvOihOU0RpY3Rpb25hcnkgKilpbmZvOwogQGVu ZAogCitAaW50ZXJmYWNlIF9VSUxheWVySG9zdFZpZXcgOiBVSVZpZXcKK0BlbmQKKworQGludGVy ZmFjZSBfVUlSZW1vdGVWaWV3IDogX1VJTGF5ZXJIb3N0VmlldworLSAoaW5zdGFuY2V0eXBlKWlu aXRXaXRoRnJhbWU6KENHUmVjdClmcmFtZSBwaWQ6KHBpZF90KXBpZCBjb250ZXh0SUQ6KHVpbnQz Ml90KWNvbnRleHRJRDsKK0BlbmQKKwogI2lmIF9faGFzX2luY2x1ZGUoPFVJS2l0L1VJVGV4dElu cHV0TXVsdGlEb2N1bWVudC5oPikKICNpbXBvcnQgPFVJS2l0L1VJVGV4dElucHV0TXVsdGlEb2N1 bWVudC5oPgogI2Vsc2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0RyYXdp bmdBcmVhUHJveHkuaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0RyYXdpbmdBcmVhUHJveHku aAppbmRleCAyMTQ3MGJmZGFkMmM0YjRiMWE1MDFkYThjYzY5YjlhZjM0OWQ2ZTI0Li5hMWEyZGFh ODJhNGMxMTc4ZGUwNjdkYzJjNjBjMDMwNmNjMTIyODIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9EcmF3aW5nQXJlYVByb3h5LmgKKysrIGIvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvRHJhd2luZ0FyZWFQcm94eS5oCkBAIC0xMDYsNiArMTA2LDggQEAgcHVibGljOgogCiAg ICAgdmlydHVhbCB2b2lkIGRpc3BhdGNoUHJlc2VudGF0aW9uQ2FsbGJhY2tzQWZ0ZXJGbHVzaGlu Z0xheWVycyhjb25zdCBWZWN0b3I8Q2FsbGJhY2tJRD4mKSB7IH0KIAorICAgIFdlYlBhZ2VQcm94 eSYgcGFnZSgpIGNvbnN0IHsgcmV0dXJuIG1fd2ViUGFnZVByb3h5OyB9CisKIHByb3RlY3RlZDoK ICAgICBleHBsaWNpdCBEcmF3aW5nQXJlYVByb3h5KERyYXdpbmdBcmVhVHlwZSwgV2ViUGFnZVBy b3h5Jik7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1JlbW90ZUxheWVy VHJlZS9pb3MvUmVtb3RlTGF5ZXJUcmVlSG9zdElPUy5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL1JlbW90ZUxheWVyVHJlZS9pb3MvUmVtb3RlTGF5ZXJUcmVlSG9zdElPUy5tbQppbmRleCA3 ZWE0MzUxMDBkMDc3MDc4NWFlNzFmYmFlMTY1ODBkZTNmNGYwNzc0Li40NWQyYmU3NDM0MDBkZmE2 ZGZkN2M5NjExODc2NDM1MThkY2FlYWNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9SZW1vdGVMYXllclRyZWUvaW9zL1JlbW90ZUxheWVyVHJlZUhvc3RJT1MubW0KKysrIGIv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvUmVtb3RlTGF5ZXJUcmVlL2lvcy9SZW1vdGVMYXllclRy ZWVIb3N0SU9TLm1tCkBAIC0yOCw3ICsyOCw5IEBACiAKICNpZiBQTEFURk9STShJT1NfRkFNSUxZ KQogCisjaW1wb3J0ICJSZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYVByb3h5LmgiCiAjaW1wb3J0 ICJVSUtpdFNQSS5oIgorI2ltcG9ydCAiV2ViUGFnZVByb3h5LmgiCiAjaW1wb3J0IDxVSUtpdC9V SVNjcm9sbFZpZXcuaD4KICNpbXBvcnQgPHBhbC9zcGkvY29jb2EvUXVhcnR6Q29yZVNQSS5oPgog CkBAIC0xNTUsNiArMTU3LDQ0IEBAICsgKENsYXNzKWxheWVyQ2xhc3MKIAogQGVuZAogCisjaWYg VVNFKFVJUkVNT1RFVklFV19DT05URVhUX0hPU1RJTkcpCitAaW50ZXJmYWNlIFdLVUlSZW1vdGVW aWV3IDogX1VJUmVtb3RlVmlldworQGVuZAorCitAaW1wbGVtZW50YXRpb24gV0tVSVJlbW90ZVZp ZXcKKworLSAoVUlWaWV3ICopaGl0VGVzdDooQ0dQb2ludClwb2ludCB3aXRoRXZlbnQ6KFVJRXZl bnQgKilldmVudAoreworICAgIHJldHVybiBbc2VsZiBfZmluZERlc2NlbmRhbnRWaWV3QXRQb2lu dDpwb2ludCB3aXRoRXZlbnQ6ZXZlbnRdOworfQorCistIChOU1N0cmluZyAqKWRlc2NyaXB0aW9u Cit7CisgICAgTlNTdHJpbmcgKnZpZXdEZXNjcmlwdGlvbiA9IFtzdXBlciBkZXNjcmlwdGlvbl07 CisgICAgTlNTdHJpbmcgKndlYktpdERldGFpbHMgPSBbTlNTdHJpbmcgc3RyaW5nV2l0aEZvcm1h dDpAIiBsYXllcklEID0gJWxsdSBcIiVAXCIiLCBXZWJLaXQ6OlJlbW90ZUxheWVyVHJlZUhvc3Q6 OmxheWVySUQoc2VsZi5sYXllciksIHNlbGYubGF5ZXIubmFtZSA/IHNlbGYubGF5ZXIubmFtZSA6 IEAiIl07CisgICAgcmV0dXJuIFt2aWV3RGVzY3JpcHRpb24gc3RyaW5nQnlBcHBlbmRpbmdTdHJp bmc6d2ViS2l0RGV0YWlsc107Cit9CisKK0BlbmQKKyNlbmRpZgorCitzdGF0aWMgUmV0YWluUHRy PFVJVmlldz4gY3JlYXRlUmVtb3RlVmlldyhwaWRfdCBwaWQsIHVpbnQzMl90IGNvbnRleHRJRCkK K3sKKyNpZiBVU0UoVUlSRU1PVEVWSUVXX0NPTlRFWFRfSE9TVElORykKKyAgICAvLyBGSVhNRTog UmVtb3ZlIHRoaXMgcmVzcG9uZHNUb1NlbGVjdG9yIGNoZWNrIHdoZW4gcG9zc2libGUuCisgICAg c3RhdGljIEJPT0wgY2FuVXNlVUlSZW1vdGVWaWV3OworICAgIHN0YXRpYyBzdGQ6Om9uY2VfZmxh ZyBpbml0aWFsaXplQ2FuVXNlVUlSZW1vdGVWaWV3OworICAgICAgICBzdGQ6OmNhbGxfb25jZShp bml0aWFsaXplQ2FuVXNlVUlSZW1vdGVWaWV3LCBbXSB7CisgICAgICAgICAgICBjYW5Vc2VVSVJl bW90ZVZpZXcgPSBbX1VJUmVtb3RlVmlldyBpbnN0YW5jZXNSZXNwb25kVG9TZWxlY3RvcjpAc2Vs ZWN0b3IoaW5pdFdpdGhGcmFtZTpwaWQ6Y29udGV4dElEOildOworICAgICAgICB9KTsKKyAgICBp ZiAoY2FuVXNlVUlSZW1vdGVWaWV3KQorICAgICAgICByZXR1cm4gYWRvcHROUyhbW1dLVUlSZW1v dGVWaWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOkNHUmVjdFplcm8gcGlkOnBpZCBjb250ZXh0SUQ6 Y29udGV4dElEXSk7CisjZWxzZQorICAgIFVOVVNFRF9QQVJBTShwaWQpOworI2VuZGlmCisgICAg cmV0dXJuIGFkb3B0TlMoW1tXS1JlbW90ZVZpZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6Q0dSZWN0 WmVybyBjb250ZXh0SUQ6Y29udGV4dElEXSk7Cit9CisKIEBpbnRlcmZhY2UgV0tCYWNrZHJvcFZp ZXcgOiBfVUlCYWNrZHJvcFZpZXcKIEBlbmQKIApAQCAtMjA4LDcgKzI0OCw3IEBAIExheWVyT3JW aWV3ICpSZW1vdGVMYXllclRyZWVIb3N0OjpjcmVhdGVMYXllcihjb25zdCBSZW1vdGVMYXllclRy ZWVUcmFuc2FjdGlvbjo6CiAgICAgY2FzZSBQbGF0Zm9ybUNBTGF5ZXI6OkxheWVyVHlwZUFWUGxh eWVyTGF5ZXI6CiAgICAgY2FzZSBQbGF0Zm9ybUNBTGF5ZXI6OkxheWVyVHlwZUNvbnRlbnRzUHJv dmlkZWRMYXllcjoKICAgICAgICAgaWYgKCFtX2lzRGVidWdMYXllclRyZWVIb3N0KSB7Ci0gICAg ICAgICAgICB2aWV3ID0gYWRvcHROUyhbW1dLUmVtb3RlVmlldyBhbGxvY10gaW5pdFdpdGhGcmFt ZTpDR1JlY3RaZXJvIGNvbnRleHRJRDpwcm9wZXJ0aWVzLmhvc3RpbmdDb250ZXh0SURdKTsKKyAg ICAgICAgICAgIHZpZXcgPSBjcmVhdGVSZW1vdGVWaWV3KG1fZHJhd2luZ0FyZWEtPnBhZ2UoKS5w cm9jZXNzSWRlbnRpZmllcigpLCBwcm9wZXJ0aWVzLmhvc3RpbmdDb250ZXh0SUQpOwogICAgICAg ICAgICAgaWYgKHByb3BlcnRpZXMudHlwZSA9PSBQbGF0Zm9ybUNBTGF5ZXI6OkxheWVyVHlwZUFW UGxheWVyTGF5ZXIpIHsKICAgICAgICAgICAgICAgICAvLyBJbnZlcnQgdGhlIHNjYWxlIHRyYW5z Zm9ybSBhZGRlZCBpbiB0aGUgV2ViUHJvY2VzcyB0byBmaXggPHJkYXI6Ly9wcm9ibGVtLzE4MzE2 NTQyPi4KICAgICAgICAgICAgICAgICBmbG9hdCBpbnZlcnNlU2NhbGUgPSAxIC8gcHJvcGVydGll cy5ob3N0aW5nRGV2aWNlU2NhbGVGYWN0b3I7Cg==