191439 2018-11-08 15:14:15 -0800 [JSC] isStrWhiteSpace seems redundant with Lexer<UChar>::isWhiteSpace 2018-11-08 21:31:28 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ross.kirsling ross.kirsling commit-queue ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1476678 0 ross.kirsling 2018-11-08 15:14:15 -0800 isStrWhiteSpace in ParseInt.h seems redundant with Lexer<UChar>::isWhiteSpace and could probably be done away with. Note that while Lexer<UChar>::isWhiteSpace matches the current ES spec (https://tc39.github.io/ecma262/#sec-white-space), isStrWhiteSpace additionally looks for 0x000A, 0x000D, 0x2028, and 0x2029. Not sure whether it's supposed to be doing so or not though. 1476724 1 ross.kirsling 2018-11-08 16:48:29 -0800 (In reply to Ross Kirsling from comment #0) > Note that while Lexer<UChar>::isWhiteSpace matches the current ES spec > (https://tc39.github.io/ecma262/#sec-white-space), isStrWhiteSpace > additionally looks for 0x000A, 0x000D, 0x2028, and 0x2029. Not sure whether > it's supposed to be doing so or not though. Oops, apparently those four are covered in the very next section (https://tc39.github.io/ecma262/#sec-line-terminators). So isStrWhiteSpace (whose name originates here: https://tc39.github.io/ecma262/#prod-StrWhiteSpace) includes line terminators and isWhiteSpace does not. I guess we still need two functions, but we can at least have one depend on the other. 1476738 2 354294 ross.kirsling 2018-11-08 17:13:39 -0800 Created attachment 354294 Patch 1476740 3 ross.kirsling 2018-11-08 17:16:11 -0800 (In reply to Ross Kirsling from comment #2) > Created attachment 354294 [details] > Patch I thought about making isStrWhiteSpace a static Lexer method, but since the spec uses it exclusively for numeric parsing, it's probably best left where it is. 1476742 4 354294 saam 2018-11-08 17:17:36 -0800 Comment on attachment 354294 Patch nice. r=me 1476781 5 354307 ross.kirsling 2018-11-08 20:16:37 -0800 Created attachment 354307 Patch for landing 1476797 6 354307 commit-queue 2018-11-08 21:30:56 -0800 Comment on attachment 354307 Patch for landing Clearing flags on attachment: 354307 Committed r238016: <https://trac.webkit.org/changeset/238016> 1476798 7 commit-queue 2018-11-08 21:30:57 -0800 All reviewed patches have been landed. Closing bug. 1476799 8 webkit-bug-importer 2018-11-08 21:31:28 -0800 <rdar://problem/45934608> 354294 2018-11-08 17:13:39 -0800 2018-11-08 20:16:35 -0800 Patch bug-191439-20181108171338.patch text/plain 1846 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4MDA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 MDgxOGM4YmRlMTRkM2U0Nzk0OTA0NDU2ZTU2MjM5MDFiZDgzOTRkLi44ZDNjODM0YjI4ZTI2NGJl YTIzMTExYmFkNmI3M2JiZDJhODQxZTVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxOC0xMS0wOCAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29u eS5jb20+CisKKyAgICAgICAgW0pTQ10gaXNTdHJXaGl0ZVNwYWNlIHNlZW1zIHJlZHVuZGFudCB3 aXRoIExleGVyPFVDaGFyPjo6aXNXaGl0ZVNwYWNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTE0MzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHJ1bnRpbWUvUGFyc2VJbnQuaDoKKyAgICAgICAgKEpT Qzo6aXNTdHJXaGl0ZVNwYWNlKToKKyAgICAgICAgRGVmaW5lIGlzU3RyV2hpdGVTcGFjZSBpbiB0 ZXJtcyBvZiBpc1doaXRlU3BhY2UgYW5kIGlzTGluZVRlcm1pbmF0b3IuCisKIDIwMTgtMTEtMDgg IFJvc3MgS2lyc2xpbmcgIDxyb3NzLmtpcnNsaW5nQHNvbnkuY29tPgogCiAgICAgICAgIFUrMTgw RSBpcyBubyBsb25nZXIgYSB3aGl0ZXNwYWNlIGNoYXJhY3RlcgpkaWZmIC0tZ2l0IGEvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUGFyc2VJbnQuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL1BhcnNlSW50LmgKaW5kZXggMThkNTAwZDc5NTk4OGQzZmJhNmVkMzZlYTFhOGUw OTE0ZTU1ZDA2MC4uZGU4NjFhNmY0ZjA3YzQyMTBmMzlkOWU1ZDc4MzYzMmQ4NTYxZmIwMiAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUGFyc2VJbnQuaAorKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9QYXJzZUludC5oCkBAIC0yNiw2ICsyNiw3IEBA CiAjcHJhZ21hIG9uY2UKIAogI2luY2x1ZGUgIkpTQ0pTVmFsdWUuaCIKKyNpbmNsdWRlICJMZXhl ci5oIgogI2luY2x1ZGUgPHd0Zi9kdG9hLmg+CiAKIG5hbWVzcGFjZSBKU0MgewpAQCAtMTAxLDIy ICsxMDIsOCBAQCBzdGF0aWMgZG91YmxlIHBhcnNlSW50T3ZlcmZsb3coU3RyaW5nVmlldyBzdHJp bmcsIGludCByYWRpeCkKIAogQUxXQVlTX0lOTElORSBzdGF0aWMgYm9vbCBpc1N0cldoaXRlU3Bh Y2UoVUNoYXIgYykKIHsKLSAgICBzd2l0Y2ggKGMpIHsKLSAgICAvLyBFQ01BLTI2Mi01dGggNy4y ICYgNy4zCi0gICAgY2FzZSAweDAwMDk6Ci0gICAgY2FzZSAweDAwMEE6Ci0gICAgY2FzZSAweDAw MEI6Ci0gICAgY2FzZSAweDAwMEM6Ci0gICAgY2FzZSAweDAwMEQ6Ci0gICAgY2FzZSAweDAwMjA6 Ci0gICAgY2FzZSAweDAwQTA6Ci0gICAgY2FzZSAweDIwMjg6Ci0gICAgY2FzZSAweDIwMjk6Ci0g ICAgY2FzZSAweEZFRkY6Ci0gICAgICAgIHJldHVybiB0cnVlOwotICAgIGRlZmF1bHQ6Ci0gICAg ICAgIHJldHVybiBjID4gMHhGRiAmJiB1X2NoYXJUeXBlKGMpID09IFVfU1BBQ0VfU0VQQVJBVE9S OwotICAgIH0KKyAgICAvLyBodHRwczovL3RjMzkuZ2l0aHViLmlvL2VjbWEyNjIvI3NlYy10b251 bWJlci1hcHBsaWVkLXRvLXRoZS1zdHJpbmctdHlwZQorICAgIHJldHVybiBMZXhlcjxVQ2hhcj46 OmlzV2hpdGVTcGFjZShjKSB8fCBMZXhlcjxVQ2hhcj46OmlzTGluZVRlcm1pbmF0b3IoYyk7CiB9 CiAKIC8vIEVTNS4xIDE1LjEuMi4yCg== 354307 2018-11-08 20:16:37 -0800 2018-11-08 21:30:56 -0800 Patch for landing bug-191439-20181108201636.patch text/plain 2389 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4MDE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 YWUzYTlkZmY5MGZjMDVjM2ZkMDRlZWE2MDMyN2FmYzk4NDZjY2ZhLi42ZDc0YjRmOGQwYzExNGNj NTNlOWIxNWFhNWRkNjhmNDE5YTkzYjNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxOC0xMS0wOCAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29u eS5jb20+CisKKyAgICAgICAgW0pTQ10gaXNTdHJXaGl0ZVNwYWNlIHNlZW1zIHJlZHVuZGFudCB3 aXRoIExleGVyPFVDaGFyPjo6aXNXaGl0ZVNwYWNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTE0MzkKKworICAgICAgICBSZXZpZXdlZCBieSBTYWFt IEJhcmF0aS4KKworICAgICAgICAqIENNYWtlTGlzdHMudHh0OgorICAgICAgICAqIHJ1bnRpbWUv UGFyc2VJbnQuaDoKKyAgICAgICAgKEpTQzo6aXNTdHJXaGl0ZVNwYWNlKToKKyAgICAgICAgRGVm aW5lIGlzU3RyV2hpdGVTcGFjZSBpbiB0ZXJtcyBvZiBpc1doaXRlU3BhY2UgYW5kIGlzTGluZVRl cm1pbmF0b3IuCisKIDIwMTgtMTEtMDggIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5j b20+CiAKICAgICAgICAgT3B0aW9uczo6dXNlUmVnRXhwSklUKCkgc2hvdWxkIHVzZSBqaXRFbmFi bGVkQnlEZWZhdWx0KCkganVzdCBsaWtlIHVzZUpJVCgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VM aXN0cy50eHQKaW5kZXggYjQxZGNlOTBlMWYyMzdmNjIxZDFkYzM5NzM5ZmU1NWFlYTg0YzFiNS4u MjYxNzAwN2FlY2NkNWJhY2VmZjdlNTQ3MGJmOTQ1NGE2OTNkOTMwMiAxMDA2NDQKLS0tIGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DTWFrZUxpc3RzLnR4dApAQCAtNjkyLDYgKzY5Miw4IEBAIHNldChKYXZhU2NyaXB0Q29y ZV9QUklWQVRFX0ZSQU1FV09SS19IRUFERVJTCiAKICAgICBsbGludC9MTEludE9wY29kZS5oCiAK KyAgICBwYXJzZXIvTGV4ZXIuaAorICAgIHBhcnNlci9QYXJzZXJBcmVuYS5oCiAgICAgcGFyc2Vy L1BhcnNlckVycm9yLmgKICAgICBwYXJzZXIvUGFyc2VyTW9kZXMuaAogICAgIHBhcnNlci9QYXJz ZXJUb2tlbnMuaApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUGFy c2VJbnQuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1BhcnNlSW50LmgKaW5kZXgg MThkNTAwZDc5NTk4OGQzZmJhNmVkMzZlYTFhOGUwOTE0ZTU1ZDA2MC4uZGU4NjFhNmY0ZjA3YzQy MTBmMzlkOWU1ZDc4MzYzMmQ4NTYxZmIwMiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvUGFyc2VJbnQuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9QYXJzZUludC5oCkBAIC0yNiw2ICsyNiw3IEBACiAjcHJhZ21hIG9uY2UKIAogI2luY2x1ZGUg IkpTQ0pTVmFsdWUuaCIKKyNpbmNsdWRlICJMZXhlci5oIgogI2luY2x1ZGUgPHd0Zi9kdG9hLmg+ CiAKIG5hbWVzcGFjZSBKU0MgewpAQCAtMTAxLDIyICsxMDIsOCBAQCBzdGF0aWMgZG91YmxlIHBh cnNlSW50T3ZlcmZsb3coU3RyaW5nVmlldyBzdHJpbmcsIGludCByYWRpeCkKIAogQUxXQVlTX0lO TElORSBzdGF0aWMgYm9vbCBpc1N0cldoaXRlU3BhY2UoVUNoYXIgYykKIHsKLSAgICBzd2l0Y2gg KGMpIHsKLSAgICAvLyBFQ01BLTI2Mi01dGggNy4yICYgNy4zCi0gICAgY2FzZSAweDAwMDk6Ci0g ICAgY2FzZSAweDAwMEE6Ci0gICAgY2FzZSAweDAwMEI6Ci0gICAgY2FzZSAweDAwMEM6Ci0gICAg Y2FzZSAweDAwMEQ6Ci0gICAgY2FzZSAweDAwMjA6Ci0gICAgY2FzZSAweDAwQTA6Ci0gICAgY2Fz ZSAweDIwMjg6Ci0gICAgY2FzZSAweDIwMjk6Ci0gICAgY2FzZSAweEZFRkY6Ci0gICAgICAgIHJl dHVybiB0cnVlOwotICAgIGRlZmF1bHQ6Ci0gICAgICAgIHJldHVybiBjID4gMHhGRiAmJiB1X2No YXJUeXBlKGMpID09IFVfU1BBQ0VfU0VQQVJBVE9SOwotICAgIH0KKyAgICAvLyBodHRwczovL3Rj MzkuZ2l0aHViLmlvL2VjbWEyNjIvI3NlYy10b251bWJlci1hcHBsaWVkLXRvLXRoZS1zdHJpbmct dHlwZQorICAgIHJldHVybiBMZXhlcjxVQ2hhcj46OmlzV2hpdGVTcGFjZShjKSB8fCBMZXhlcjxV Q2hhcj46OmlzTGluZVRlcm1pbmF0b3IoYyk7CiB9CiAKIC8vIEVTNS4xIDE1LjEuMi4yCg==