191438 2018-11-08 15:06:20 -0800 Web Inspector: Potential for watch expressions to never show results 2018-11-08 16:51:47 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue hi inspector-bugzilla-changes joepeck mattbaker webkit-bug-importer oldest_to_newest 1476674 0 joepeck 2018-11-08 15:06:20 -0800 Potential for watch expressions to never show results I'm not sure how this would be possible, but watch expressions might not be resolving a Promise. It should always resolve the Promise here. 1476675 1 354280 joepeck 2018-11-08 15:08:05 -0800 Created attachment 354280 [PATCH] Proposed Fix 1476682 2 354280 mattbaker 2018-11-08 15:19:20 -0800 Comment on attachment 354280 [PATCH] Proposed Fix r=me 1476701 3 354280 commit-queue 2018-11-08 15:44:32 -0800 Comment on attachment 354280 [PATCH] Proposed Fix Clearing flags on attachment: 354280 Committed r238005: <https://trac.webkit.org/changeset/238005> 1476702 4 commit-queue 2018-11-08 15:44:33 -0800 All reviewed patches have been landed. Closing bug. 1476705 5 webkit-bug-importer 2018-11-08 15:45:24 -0800 <rdar://problem/45926682> 1476726 6 354280 hi 2018-11-08 16:51:47 -0800 Comment on attachment 354280 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=354280&action=review > Source/WebInspectorUI/UserInterface/Views/ScopeChainDetailsSidebarPanel.js:-313 > - resolve(propertyDescriptor); If `evaluateInWindow` becomes `async`, this could cause the order of properties to be different (depending on the order that each promise resolves). This isn't an issue right now, especially considering that `WI.ObjectTreeView.comparePropertyDescriptors` sorts the list after the fact. Just something to consider :) 354280 2018-11-08 15:08:05 -0800 2018-11-08 15:44:32 -0800 [PATCH] Proposed Fix watch-1.patch text/plain 2335 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGY2NDFhMmEwMzkwLi45MjI2NzIxOTJiZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMTEtMDggIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBQb3RlbnRpYWwgZm9yIHdhdGNoIGV4cHJlc3Npb25zIHRvIG5ldmVyIHNob3cgcmVzdWx0cwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkxNDM4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50 ZXJmYWNlL1ZpZXdzL1Njb3BlQ2hhaW5EZXRhaWxzU2lkZWJhclBhbmVsLmpzOgorICAgICAgICAo V0kuU2NvcGVDaGFpbkRldGFpbHNTaWRlYmFyUGFuZWwucHJvdG90eXBlLl9nZW5lcmF0ZVdhdGNo RXhwcmVzc2lvbnNTZWN0aW9uKToKKyAgICAgICAgSWYgdGhlcmUgd2FzIG5vIG9iamVjdCBkb24n dCBiYWlsLCBjb250aW51ZSBhbmQgcmVzb2x2ZSB0aGUgUHJvbWlzZS4KKyAgICAgICAgSW4gdGhp cyBjYXNlIHdlIGNhbiBmYWxsYmFjayB0byBzaG93IGB1bmRlZmluZWRgLiBUaGlzIGNvZGUgbWln aHQgbm90IGJlCisgICAgICAgIHJlYWNoYWJsZSByaWdodCBub3csIGJ1dCBpcyB3cm9uZyBhcyBp cy4KKwogMjAxOC0xMS0wOCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgog CiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFN0YXJ0IG1vdmluZyB0b3dhcmQgYmV0dGVyIG11bHRp LXRhcmdldCBzdXBwb3J0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9TY29wZUNoYWluRGV0YWlsc1NpZGViYXJQYW5lbC5qcyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Njb3BlQ2hhaW5EZXRhaWxzU2lkZWJh clBhbmVsLmpzCmluZGV4IGVjNTRmNmFiM2U2Li5iYjRmMGQ2Mzg5MCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2NvcGVDaGFpbkRldGFpbHNT aWRlYmFyUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvU2NvcGVDaGFpbkRldGFpbHNTaWRlYmFyUGFuZWwuanMKQEAgLTMwNiwxMSArMzA2LDEw IEBAIFdJLlNjb3BlQ2hhaW5EZXRhaWxzU2lkZWJhclBhbmVsID0gY2xhc3MgU2NvcGVDaGFpbkRl dGFpbHNTaWRlYmFyUGFuZWwgZXh0ZW5kcyBXCiAgICAgICAgICAgICBwcm9taXNlcy5wdXNoKG5l dyBQcm9taXNlKGZ1bmN0aW9uKHJlc29sdmUsIHJlamVjdCkgewogICAgICAgICAgICAgICAgIGxl dCBvcHRpb25zID0ge29iamVjdEdyb3VwOiBXSS5TY29wZUNoYWluRGV0YWlsc1NpZGViYXJQYW5l bC5XYXRjaEV4cHJlc3Npb25zT2JqZWN0R3JvdXBOYW1lLCBpbmNsdWRlQ29tbWFuZExpbmVBUEk6 IGZhbHNlLCBkb05vdFBhdXNlT25FeGNlcHRpb25zQW5kTXV0ZUNvbnNvbGU6IHRydWUsIHJldHVy bkJ5VmFsdWU6IGZhbHNlLCBnZW5lcmF0ZVByZXZpZXc6IHRydWUsIHNhdmVSZXN1bHQ6IGZhbHNl fTsKICAgICAgICAgICAgICAgICBXSS5ydW50aW1lTWFuYWdlci5ldmFsdWF0ZUluSW5zcGVjdGVk V2luZG93KGV4cHJlc3Npb24sIG9wdGlvbnMsIGZ1bmN0aW9uKG9iamVjdCwgd2FzVGhyb3duKSB7 Ci0gICAgICAgICAgICAgICAgICAgIGlmICghb2JqZWN0KQotICAgICAgICAgICAgICAgICAgICAg ICAgcmV0dXJuOworICAgICAgICAgICAgICAgICAgICBvYmplY3QgPSBvYmplY3QgfHwgV0kuUmVt b3RlT2JqZWN0LmZyb21QcmltaXRpdmVWYWx1ZSh1bmRlZmluZWQpOwogICAgICAgICAgICAgICAg ICAgICBsZXQgcHJvcGVydHlEZXNjcmlwdG9yID0gbmV3IFdJLlByb3BlcnR5RGVzY3JpcHRvcih7 bmFtZTogZXhwcmVzc2lvbiwgdmFsdWU6IG9iamVjdH0sIHVuZGVmaW5lZCwgdW5kZWZpbmVkLCB3 YXNUaHJvd24pOwogICAgICAgICAgICAgICAgICAgICBvYmplY3RUcmVlLmFwcGVuZEV4dHJhUHJv cGVydHlEZXNjcmlwdG9yKHByb3BlcnR5RGVzY3JpcHRvcik7Ci0gICAgICAgICAgICAgICAgICAg IHJlc29sdmUocHJvcGVydHlEZXNjcmlwdG9yKTsKKyAgICAgICAgICAgICAgICAgICAgcmVzb2x2 ZSgpOwogICAgICAgICAgICAgICAgIH0pOwogICAgICAgICAgICAgfSkpOwogICAgICAgICB9Cg==