191423 2018-11-08 09:25:05 -0800 Remove legacy storage tracker database file after r237330 2018-11-09 09:29:05 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sihui_liu sihui_liu cdumez commit-queue ggaren webkit-bug-importer oldest_to_newest 1476546 0 sihui_liu 2018-11-08 09:25:05 -0800 r237330 changed name of the storage tracker database file in WebKitLegacy, but I didn't remove the file with old name before using the new file. 1476548 1 354245 sihui_liu 2018-11-08 09:39:47 -0800 Created attachment 354245 Patch 1476641 2 354245 ggaren 2018-11-08 13:36:06 -0800 Comment on attachment 354245 Patch r=me 1476936 3 354245 cdumez 2018-11-09 09:27:26 -0800 Comment on attachment 354245 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354245&action=review > Source/WebKitLegacy/Storage/StorageTracker.cpp:84 > + FileSystem::deleteFile(FileSystem::pathByAppendingComponent(m_storageDirectoryPath, "StorageTracker.db")); A comment explaining why we do did would have been nice. It does not seem obvious to me. 1476937 4 354245 commit-queue 2018-11-09 09:27:42 -0800 Comment on attachment 354245 Patch Clearing flags on attachment: 354245 Committed r238036: <https://trac.webkit.org/changeset/238036> 1476938 5 commit-queue 2018-11-09 09:27:44 -0800 All reviewed patches have been landed. Closing bug. 1476939 6 webkit-bug-importer 2018-11-09 09:28:20 -0800 <rdar://problem/45946046> 1476940 7 354245 cdumez 2018-11-09 09:29:05 -0800 Comment on attachment 354245 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354245&action=review >> Source/WebKitLegacy/Storage/StorageTracker.cpp:84 >> + FileSystem::deleteFile(FileSystem::pathByAppendingComponent(m_storageDirectoryPath, "StorageTracker.db")); > > A comment explaining why we do did would have been nice. It does not seem obvious to me. Also, since the second parameter constructs a String, "StorageTracker.db"_s would be better than "StorageTracker.db". 354245 2018-11-08 09:39:47 -0800 2018-11-09 09:27:42 -0800 Patch bug-191423-20181108093946.patch text/plain 1538 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3OTg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvQ2hhbmdlTG9nCmluZGV4IDkwN2U0 M2NiNTUyYzgzNDk2MjU2M2E3NjE5MWI1MzdlNmQ3NjAzMzkuLmI1ZDEzZTdjNTYzNGJkNWI4YTgy N2U0MWNkYWViZGZkNWRhMmU2NzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvQ2hh bmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTgtMTEtMDggIFNpaHVpIExpdSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CisKKyAgICAg ICAgUmVtb3ZlIGxlZ2FjeSBzdG9yYWdlIHRyYWNrZXIgZGF0YWJhc2UgZmlsZSBhZnRlciByMjM3 MzMwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTE0 MjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICByMjM3 MzMwIGNoYW5nZWQgdGhlIGZpbGUgbmFtZSBvZiBzdG9yYWdlIHRyYWNrZXIgZGF0YWJhc2UsIGJ1 dCBpdCBkaWQgbm90IHJlbW92ZSB0aGUgb2xkIAorICAgICAgICBmaWxlIGJlZm9yZSB1c2luZyB0 aGUgbmV3IG9uZS4KKworICAgICAgICAqIFN0b3JhZ2UvU3RvcmFnZVRyYWNrZXIuY3BwOgorICAg ICAgICAoV2ViS2l0OjpTdG9yYWdlVHJhY2tlcjo6aW50ZXJuYWxJbml0aWFsaXplKToKKwogMjAx OC0xMS0wMSAgU2lodWkgTGl1ICA8c2lodWlfbGl1QGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQg YSBzdG9yYWdlIGxpbWl0IGZvciBJbmRleGVkREIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXRM ZWdhY3kvU3RvcmFnZS9TdG9yYWdlVHJhY2tlci5jcHAgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L1N0 b3JhZ2UvU3RvcmFnZVRyYWNrZXIuY3BwCmluZGV4IDgxZDJhNDM1NTJiNTdhMzIwZjdjZDE4MzA1 ODZhOWQ0YWQ5YmYzNDguLjcxMDE0MGIxYjEzM2EyZWI1OTM5NmQ3Njc0ODZkMjE4M2VjOTA0ODQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvU3RvcmFnZS9TdG9yYWdlVHJhY2tlci5j cHAKKysrIGIvU291cmNlL1dlYktpdExlZ2FjeS9TdG9yYWdlL1N0b3JhZ2VUcmFja2VyLmNwcApA QCAtNzksNiArNzksMTAgQEAgdm9pZCBTdG9yYWdlVHJhY2tlcjo6aW50ZXJuYWxJbml0aWFsaXpl KCkKICAgICBzdG9yYWdlVHJhY2tlci0+c2V0SXNBY3RpdmUodHJ1ZSk7CiAgICAgc3RvcmFnZVRy YWNrZXItPm1fdGhyZWFkLT5zdGFydCgpOyAgCiAgICAgc3RvcmFnZVRyYWNrZXItPmltcG9ydE9y aWdpbklkZW50aWZpZXJzKCk7CisKKyAgICBtX3RocmVhZC0+ZGlzcGF0Y2goW3RoaXNdIHsKKyAg ICAgICAgRmlsZVN5c3RlbTo6ZGVsZXRlRmlsZShGaWxlU3lzdGVtOjpwYXRoQnlBcHBlbmRpbmdD b21wb25lbnQobV9zdG9yYWdlRGlyZWN0b3J5UGF0aCwgIlN0b3JhZ2VUcmFja2VyLmRiIikpOwor ICAgIH0pOwogfQogCiBTdG9yYWdlVHJhY2tlciYgU3RvcmFnZVRyYWNrZXI6OnRyYWNrZXIoKQo=