191416 2018-11-08 00:24:02 -0800 [Win] UDis86Disassembler.cpp: warning: format specifies type 'unsigned long' but the argument has type 'uintptr_t' (aka 'unsigned long long') 2018-11-08 17:31:38 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1476445 0 fujii 2018-11-08 00:24:02 -0800 [Win] UDis86Disassembler.cpp: warning: format specifies type 'unsigned long' but the argument has type 'uintptr_t' (aka 'unsigned long long') MSVC reports following compilation warning: > c:\webkit\ga\source\javascriptcore\disassembler\udis86disassembler.cpp(52): warning C4477: 'snprintf' : format string '%lx' requires an argument of type 'unsigned long', but variadic argument 1 has type 'uintptr_t' (compiling source file C:\webkit\ga\WebKitBuild\Debug\DerivedSources\JavaScriptCore\unified-sources\UnifiedSource55.cpp) > c:\webkit\ga\source\javascriptcore\disassembler\udis86disassembler.cpp(52): note: consider using '%llx' in the format string (compiling source file C:\webkit\ga\WebKitBuild\Debug\DerivedSources\JavaScriptCore\unified-sources\UnifiedSource55.cpp) > c:\webkit\ga\source\javascriptcore\disassembler\udis86disassembler.cpp(52): note: consider using '%Ix' in the format string (compiling source file C:\webkit\ga\WebKitBuild\Debug\DerivedSources\JavaScriptCore\unified-sources\UnifiedSource55.cpp) > c:\webkit\ga\source\javascriptcore\disassembler\udis86disassembler.cpp(52): note: consider using '%I64x' in the format string (compiling source file C:\webkit\ga\WebKitBuild\Debug\DerivedSources\JavaScriptCore\unified-sources\UnifiedSource55.cpp) Clang-cl reports following compilation warning: > In file included from DerivedSources\JavaScriptCore\unified-sources\UnifiedSource55.cpp:4: > ..\..\Source\JavaScriptCore\disassembler/UDis86Disassembler.cpp(52,55): warning: format specifies type 'unsigned long' but the argument has type 'uintptr_t' (aka 'unsigned long long') [-Wformat] > snprintf(pcString, sizeof(pcString), "0x%lx", static_cast<uintptr_t>(currentPC)); > ~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > %llx > 1 warning generated. This code has been introduced in Bug 190273. 1476459 1 354218 fujii 2018-11-08 01:18:02 -0800 Created attachment 354218 Patch 1476746 2 354218 fujii 2018-11-08 17:30:43 -0800 Comment on attachment 354218 Patch Clearing flags on attachment: 354218 Committed r238011: <https://trac.webkit.org/changeset/238011> 1476747 3 fujii 2018-11-08 17:30:46 -0800 All reviewed patches have been landed. Closing bug. 1476748 4 webkit-bug-importer 2018-11-08 17:31:38 -0800 <rdar://problem/45930615> 354218 2018-11-08 01:18:02 -0800 2018-11-08 17:30:43 -0800 Patch bug-191416-20181108181801.patch text/plain 1716 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3OTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw NGI5ZTNjMmRmYzY5YzRjYzhkOTA4ZDk0ZDE1NzE3ZWUxZjU3Y2E5Li5iMWYyZDNhZmQ1NTk5YTJk YmE2N2IyYTEyOGFjNGY2MGRmNGM3ZDcxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxOC0xMS0wOCAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBz b255LmNvbT4KKworICAgICAgICBbV2luXSBVRGlzODZEaXNhc3NlbWJsZXIuY3BwOiB3YXJuaW5n OiBmb3JtYXQgc3BlY2lmaWVzIHR5cGUgJ3Vuc2lnbmVkIGxvbmcnIGJ1dCB0aGUgYXJndW1lbnQg aGFzIHR5cGUgJ3VpbnRwdHJfdCcgKGFrYSAndW5zaWduZWQgbG9uZyBsb25nJykKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTQxNgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZGlzYXNzZW1ibGVyL1VE aXM4NkRpc2Fzc2VtYmxlci5jcHA6CisgICAgICAgIChKU0M6OnRyeVRvRGlzYXNzZW1ibGVXaXRo VURpczg2KTogVXNlIFBSSXhQVFIgZm9yIHVpbnRwdHJfdC4KKwogMjAxOC0xMS0wNiAgS2VpdGgg Um9sbGluICA8a3JvbGxpbkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRqdXN0IGhhbmRsaW5nIG9m IEluY2x1ZGUgcGF0aHMgdGhhdCBuZWVkIHF1b3RpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9kaXNhc3NlbWJsZXIvVURpczg2RGlzYXNzZW1ibGVyLmNwcCBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9kaXNhc3NlbWJsZXIvVURpczg2RGlzYXNzZW1ibGVyLmNwcAppbmRleCAy YzE2N2YyNjA2NTA0NGVkZDQyZmRhMTViZTZjNjBiNDI2MWViMmU0Li4xNWRiMWJkZmU3ZmU3OGUy MWQ0ZGE3ZWZkNTRhNGE3OWEyZTU1NDJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvZGlzYXNzZW1ibGVyL1VEaXM4NkRpc2Fzc2VtYmxlci5jcHAKKysrIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL2Rpc2Fzc2VtYmxlci9VRGlzODZEaXNhc3NlbWJsZXIuY3BwCkBAIC00OSw3ICs0 OSw3IEBAIGJvb2wgdHJ5VG9EaXNhc3NlbWJsZVdpdGhVRGlzODYoY29uc3QgTWFjcm9Bc3NlbWJs ZXJDb2RlUHRyPERpc2Fzc2VtYmx5UHRyVGFnPiYKICAgICB1aW50NjRfdCBjdXJyZW50UEMgPSBk aXNhc3NlbWJsZXIucGM7CiAgICAgd2hpbGUgKHVkX2Rpc2Fzc2VtYmxlKCZkaXNhc3NlbWJsZXIp KSB7CiAgICAgICAgIGNoYXIgcGNTdHJpbmdbMjBdOwotICAgICAgICBzbnByaW50ZihwY1N0cmlu Zywgc2l6ZW9mKHBjU3RyaW5nKSwgIjB4JWx4Iiwgc3RhdGljX2Nhc3Q8dWludHB0cl90PihjdXJy ZW50UEMpKTsKKyAgICAgICAgc25wcmludGYocGNTdHJpbmcsIHNpemVvZihwY1N0cmluZyksICIw eCUiIFBSSXhQVFIsIHN0YXRpY19jYXN0PHVpbnRwdHJfdD4oY3VycmVudFBDKSk7CiAgICAgICAg IG91dC5wcmludGYoIiVzJTE2czogJXNcbiIsIHByZWZpeCwgcGNTdHJpbmcsIHVkX2luc25fYXNt KCZkaXNhc3NlbWJsZXIpKTsKICAgICAgICAgY3VycmVudFBDID0gZGlzYXNzZW1ibGVyLnBjOwog ICAgIH0K