191414 2018-11-07 21:45:08 -0800 [BFC][IFC] InlineFormattingContext::Line::alignRuns() should take care of all the alignments. 2018-11-08 07:21:23 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1476427 0 zalan 2018-11-07 21:45:08 -0800 ssia. 1476428 1 354208 zalan 2018-11-07 21:46:30 -0800 Created attachment 354208 Patch 1476497 2 354208 koivisto 2018-11-08 04:22:37 -0800 Comment on attachment 354208 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354208&action=review > Source/WebCore/layout/inlineformatting/Line.cpp:238 > + auto alignRuns = [&]() { No need for () 1476520 3 zalan 2018-11-08 07:20:37 -0800 Committed r237985: <https://trac.webkit.org/changeset/237985> 1476521 4 webkit-bug-importer 2018-11-08 07:21:23 -0800 <rdar://problem/45909781> 354208 2018-11-07 21:46:30 -0800 2018-11-08 04:22:37 -0800 Patch bug-191414-20181107214627.patch text/plain 2427 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3Nzg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjAxYjZmMDcwNWM5ZWNk ZDFhNTY2YjA2MTdjYWQ3ZWFjNWE0ZDg3NS4uNjY2NWZiNjhlOTM2MzA5NmM5YzNjOWM5NzM5MmE2 M2M1ZGU0NTc4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE4LTExLTA3ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0JGQ11bSUZDXSBJbmxpbmVG b3JtYXR0aW5nQ29udGV4dDo6TGluZTo6YWxpZ25SdW5zKCkgc2hvdWxkIHRha2UgY2FyZSBvZiBh bGwgdGhlIGFsaWdubWVudHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xOTE0MTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIGxheW91dC9pbmxpbmVmb3JtYXR0aW5nL0xpbmUuY3BwOgorICAgICAgICAo V2ViQ29yZTo6TGF5b3V0OjpJbmxpbmVGb3JtYXR0aW5nQ29udGV4dDo6TGluZTo6Y2xvc2UpOgor CiAyMDE4LTExLTA0ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAg W2lPU10gSXNzdWUgaW5pdGlhbCBwYWludCBzb29uIGFmdGVyIHRoZSB2aXN1YWxseU5vbkVtcHR5 IG1pbGVzdG9uZSBpcyBmaXJlZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9p bmxpbmVmb3JtYXR0aW5nL0xpbmUuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZv cm1hdHRpbmcvTGluZS5jcHAKaW5kZXggZjFhZGY3YTkxMzIyMmVjNzRmMTcyYzk3ZDAyYmM2NWU4 YzljM2Y4ZS4uNDEyYTVmMjNiNzQxYTgxY2E0YmFmNmVhMDZlZjE5MGY5ZDQwYWQwMiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvTGluZS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvTGluZS5jcHAKQEAgLTIz NSwxMiArMjM1LDE4IEBAIHZvaWQgSW5saW5lRm9ybWF0dGluZ0NvbnRleHQ6OkxpbmU6OmNsb3Nl KExhc3RMaW5lIGlzTGFzdExpbmUpCiAgICAgICAgIG1fdHJhaWxpbmdUcmltbWFibGVDb250ZW50 ID0geyB9OwogICAgIH07CiAKLSAgICBhdXRvIGFsaWduUnVucyA9IFsmXShhdXRvIGFsaWdubWVu dCkgeworICAgIGF1dG8gYWxpZ25SdW5zID0gWyZdKCkgewogCiAgICAgICAgIGlmICghaGFzQ29u dGVudCgpKQogICAgICAgICAgICAgcmV0dXJuOwogCi0gICAgICAgIGF1dG8gYWRqdXN0ZWRMb2dp Y2FsTGVmdCA9IGFkanVzdGVkTGluZUxvZ2ljYWxMZWZ0KGFsaWdubWVudCwgbV9sb2dpY2FsUmVj dC5sZWZ0KCksIG1fYXZhaWxhYmxlV2lkdGgpOworICAgICAgICBhdXRvIHRleHRBbGlnbm1lbnQg PSAhbV9hbGlnbm1lbnRJc0p1c3RpZnkgPyBtX2Zvcm1hdHRpbmdSb290LnN0eWxlKCkudGV4dEFs aWduKCkgOiBpc0xhc3RMaW5lID09IExhc3RMaW5lOjpObyA/IFRleHRBbGlnbk1vZGU6Okp1c3Rp ZnkgOiBUZXh0QWxpZ25Nb2RlOjpMZWZ0OworICAgICAgICBpZiAodGV4dEFsaWdubWVudCA9PSBU ZXh0QWxpZ25Nb2RlOjpKdXN0aWZ5KSB7CisgICAgICAgICAgICBqdXN0aWZ5UnVucygpOworICAg ICAgICAgICAgcmV0dXJuOworICAgICAgICB9CisKKyAgICAgICAgYXV0byBhZGp1c3RlZExvZ2lj YWxMZWZ0ID0gYWRqdXN0ZWRMaW5lTG9naWNhbExlZnQodGV4dEFsaWdubWVudCwgbV9sb2dpY2Fs UmVjdC5sZWZ0KCksIG1fYXZhaWxhYmxlV2lkdGgpOwogICAgICAgICBpZiAobV9sb2dpY2FsUmVj dC5sZWZ0KCkgPT0gYWRqdXN0ZWRMb2dpY2FsTGVmdCkKICAgICAgICAgICAgIHJldHVybjsKIApA QCAtMjU0LDE3ICsyNjAsOCBAQCB2b2lkIElubGluZUZvcm1hdHRpbmdDb250ZXh0OjpMaW5lOjpj bG9zZShMYXN0TGluZSBpc0xhc3RMaW5lKQogICAgICAgICByZXR1cm47CiAKICAgICB0cmltVHJh aWxpbmdDb250ZW50KCk7CisgICAgYWxpZ25SdW5zKCk7CiAKLSAgICBhdXRvIHRleHRBbGlnbm1l bnQgPSBtX2Zvcm1hdHRpbmdSb290LnN0eWxlKCkudGV4dEFsaWduKCk7Ci0gICAgaWYgKG1fYWxp Z25tZW50SXNKdXN0aWZ5KSB7Ci0gICAgICAgIGlmIChpc0xhc3RMaW5lID09IExhc3RMaW5lOjpO bykgewotICAgICAgICAgICAganVzdGlmeVJ1bnMoKTsKLSAgICAgICAgICAgIHJldHVybjsKLSAg ICAgICAgfQotICAgICAgICB0ZXh0QWxpZ25tZW50ID0gVGV4dEFsaWduTW9kZTo6TGVmdDsKLSAg ICB9Ci0KLSAgICBhbGlnblJ1bnModGV4dEFsaWdubWVudCk7CiAgICAgbV9pc0ZpcnN0TGluZSA9 IGZhbHNlOwogICAgIG1fY2xvc2VkID0gdHJ1ZTsKIH0K