191409 2018-11-07 18:06:16 -0800 [Win] Compile Service Worker support 2018-11-14 13:55:34 -0800 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 don.olmstead webkit-unassigned achristensen basuke commit-queue don.olmstead mcatanzaro stephan.szabo webkit-bug-importer youennf oldest_to_newest 1476371 0 don.olmstead 2018-11-07 18:06:16 -0800 Currently there are compilation errors around ENABLE(SERVICE_WORKER) in Windows. 1478498 1 354827 stephan.szabo 2018-11-14 10:11:03 -0800 Created attachment 354827 Support compiling service workers with clang-cl on windows. 1478511 2 354830 stephan.szabo 2018-11-14 10:33:46 -0800 Created attachment 354830 Support compiling service workers with clang-cl on windows, moving export other way Trying it with making the class exported and not the members (putting this up to try on bots while I test win build). 1478525 3 basuke 2018-11-14 10:52:34 -0800 AFAIK, we don't have http cache implementation so that service worker doesn't work well. 1478573 4 don.olmstead 2018-11-14 12:29:30 -0800 (In reply to Basuke Suzuki from comment #3) > AFAIK, we don't have http cache implementation so that service worker > doesn't work well. Sure but first step is getting it compiled. 1478601 5 354830 commit-queue 2018-11-14 13:54:35 -0800 Comment on attachment 354830 Support compiling service workers with clang-cl on windows, moving export other way Clearing flags on attachment: 354830 Committed r238196: <https://trac.webkit.org/changeset/238196> 1478602 6 commit-queue 2018-11-14 13:54:36 -0800 All reviewed patches have been landed. Closing bug. 1478604 7 webkit-bug-importer 2018-11-14 13:55:34 -0800 <rdar://problem/46074239> 354827 2018-11-14 10:11:03 -0800 2018-11-14 10:33:46 -0800 Support compiling service workers with clang-cl on windows. 191409-1.diff text/plain 2016 stephan.szabo ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyMThjMDkwNzZjNC4uMDg1OWI5Y2IzODcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAxOC0xMS0xNCAgU3RlcGhhbiBTemFibyAgPHN0ZXBoYW4uc3phYm9Ac29u eS5jb20+CisKKyAgICAgICAgW1dpbl0gQ29tcGlsZSBTZXJ2aWNlIFdvcmtlciBzdXBwb3J0Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTE0MDkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggY29tcGls YXRpb24gZXJyb3JzIHdoZW4gRU5BQkxFKFNFUlZJQ0VfV09SS0VSKQorICAgICAgICBvbiBXaW5k b3dzIHdpdGggY2xhbmctY2wuIENsYW5nIG9uIGRsbGV4cG9ydAorICAgICAgICBwbGF0Zm9ybXMg ZG9lcyBub3Qgc3VwcG9ydCBzcGVjaWZ5aW5nIHRoZQorICAgICAgICBkbGxleHBvcnQgb24gYm90 aCBhIGNsYXNzIGFuZCBtZW1iZXJzIG9mIHRoZSBjbGFzcworICAgICAgICBhbmQgdW5pc3RkLmgg aXNuJ3QgcHJvdmlkZWQgYnV0IGFsc28gYXBwZWFyZWQgdG8KKyAgICAgICAgbm90IGJlIHVzZWQu CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBzaG91bGQgYmUgY292ZXJlZCBieSBleGlzdGluZyB0 ZXN0cy4KKworICAgICAgICAqIHdvcmtlcnMvc2VydmljZS9TZXJ2aWNlV29ya2VyUHJvdmlkZXIu aDoKKyAgICAgICAgKiB3b3JrZXJzL3NlcnZpY2UvY29udGV4dC9TV0NvbnRleHRNYW5hZ2VyLmNw cDoKKwogMjAxOC0xMS0wOCAgSm9uYXRoYW4gSGFtbWVyICA8am9uYXRoYW5AZTNzb2Z0d2FyZS5j b20+CiAKICAgICAgICAgUGxhaW4gdGV4dCBkcmFnIGluIGNvbnRlbnRlZGl0YWJsZSBpcyBhbHdh eXMgRHJhZ09wZXJhdGlvbkNvcHksIG5ldmVyIERyYWdPcGVyYXRpb25Nb3ZlCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2UvU2VydmljZVdvcmtlclByb3ZpZGVyLmgg Yi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2UvU2VydmljZVdvcmtlclByb3ZpZGVyLmgK aW5kZXggM2RlNGQwNGYxZjQuLmYwYTc0OWFiNjczIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS93b3JrZXJzL3NlcnZpY2UvU2VydmljZVdvcmtlclByb3ZpZGVyLmgKKysrIGIvU291cmNlL1dl YkNvcmUvd29ya2Vycy9zZXJ2aWNlL1NlcnZpY2VXb3JrZXJQcm92aWRlci5oCkBAIC0zNyw3ICsz Nyw3IEBAIGNsYXNzIFNXQ2xpZW50Q29ubmVjdGlvbjsKIHN0cnVjdCBTZWN1cml0eU9yaWdpbkRh dGE7CiBjbGFzcyBTZXJ2aWNlV29ya2VySm9iOwogCi1jbGFzcyBXRUJDT1JFX0VYUE9SVCBTZXJ2 aWNlV29ya2VyUHJvdmlkZXIgeworY2xhc3MgU2VydmljZVdvcmtlclByb3ZpZGVyIHsKIHB1Ymxp YzoKICAgICB2aXJ0dWFsIH5TZXJ2aWNlV29ya2VyUHJvdmlkZXIoKTsKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvd29ya2Vycy9zZXJ2aWNlL2NvbnRleHQvU1dDb250ZXh0TWFuYWdlci5j cHAgYi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2UvY29udGV4dC9TV0NvbnRleHRNYW5h Z2VyLmNwcAppbmRleCA2NDVlZWIxMjY3ZC4uNjFlZWJlM2QxNjYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9jb250ZXh0L1NXQ29udGV4dE1hbmFnZXIuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9jb250ZXh0L1NXQ29udGV4dE1hbmFn ZXIuY3BwCkBAIC0zMSw3ICszMSw2IEBACiAjaW5jbHVkZSAiTWVzc2FnZVdpdGhNZXNzYWdlUG9y dHMuaCIKICNpbmNsdWRlICJTZXJ2aWNlV29ya2VyQ2xpZW50SWRlbnRpZmllci5oIgogI2luY2x1 ZGUgIlNlcnZpY2VXb3JrZXJHbG9iYWxTY29wZS5oIgotI2luY2x1ZGUgPHVuaXN0ZC5oPgogCiBu YW1lc3BhY2UgV2ViQ29yZSB7CiAK 354830 2018-11-14 10:33:46 -0800 2018-11-14 13:54:35 -0800 Support compiling service workers with clang-cl on windows, moving export other way 191409-2.diff text/plain 2629 stephan.szabo ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyMThjMDkwNzZjNC4uMDg1OWI5Y2IzODcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAxOC0xMS0xNCAgU3RlcGhhbiBTemFibyAgPHN0ZXBoYW4uc3phYm9Ac29u eS5jb20+CisKKyAgICAgICAgW1dpbl0gQ29tcGlsZSBTZXJ2aWNlIFdvcmtlciBzdXBwb3J0Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTE0MDkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggY29tcGls YXRpb24gZXJyb3JzIHdoZW4gRU5BQkxFKFNFUlZJQ0VfV09SS0VSKQorICAgICAgICBvbiBXaW5k b3dzIHdpdGggY2xhbmctY2wuIENsYW5nIG9uIGRsbGV4cG9ydAorICAgICAgICBwbGF0Zm9ybXMg ZG9lcyBub3Qgc3VwcG9ydCBzcGVjaWZ5aW5nIHRoZQorICAgICAgICBkbGxleHBvcnQgb24gYm90 aCBhIGNsYXNzIGFuZCBtZW1iZXJzIG9mIHRoZSBjbGFzcworICAgICAgICBhbmQgdW5pc3RkLmgg aXNuJ3QgcHJvdmlkZWQgYnV0IGFsc28gYXBwZWFyZWQgdG8KKyAgICAgICAgbm90IGJlIHVzZWQu CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBzaG91bGQgYmUgY292ZXJlZCBieSBleGlzdGluZyB0 ZXN0cy4KKworICAgICAgICAqIHdvcmtlcnMvc2VydmljZS9TZXJ2aWNlV29ya2VyUHJvdmlkZXIu aDoKKyAgICAgICAgKiB3b3JrZXJzL3NlcnZpY2UvY29udGV4dC9TV0NvbnRleHRNYW5hZ2VyLmNw cDoKKwogMjAxOC0xMS0wOCAgSm9uYXRoYW4gSGFtbWVyICA8am9uYXRoYW5AZTNzb2Z0d2FyZS5j b20+CiAKICAgICAgICAgUGxhaW4gdGV4dCBkcmFnIGluIGNvbnRlbnRlZGl0YWJsZSBpcyBhbHdh eXMgRHJhZ09wZXJhdGlvbkNvcHksIG5ldmVyIERyYWdPcGVyYXRpb25Nb3ZlCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2UvU2VydmljZVdvcmtlclByb3ZpZGVyLmgg Yi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2UvU2VydmljZVdvcmtlclByb3ZpZGVyLmgK aW5kZXggM2RlNGQwNGYxZjQuLjNlMTQ3NjQzNGNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS93b3JrZXJzL3NlcnZpY2UvU2VydmljZVdvcmtlclByb3ZpZGVyLmgKKysrIGIvU291cmNlL1dl YkNvcmUvd29ya2Vycy9zZXJ2aWNlL1NlcnZpY2VXb3JrZXJQcm92aWRlci5oCkBAIC00MSwxNCAr NDEsMTQgQEAgY2xhc3MgV0VCQ09SRV9FWFBPUlQgU2VydmljZVdvcmtlclByb3ZpZGVyIHsKIHB1 YmxpYzoKICAgICB2aXJ0dWFsIH5TZXJ2aWNlV29ya2VyUHJvdmlkZXIoKTsKIAotICAgIFdFQkNP UkVfRVhQT1JUIHN0YXRpYyBTZXJ2aWNlV29ya2VyUHJvdmlkZXImIHNpbmdsZXRvbigpOwotICAg IFdFQkNPUkVfRVhQT1JUIHN0YXRpYyB2b2lkIHNldFNoYXJlZFByb3ZpZGVyKFNlcnZpY2VXb3Jr ZXJQcm92aWRlciYpOworICAgIHN0YXRpYyBTZXJ2aWNlV29ya2VyUHJvdmlkZXImIHNpbmdsZXRv bigpOworICAgIHN0YXRpYyB2b2lkIHNldFNoYXJlZFByb3ZpZGVyKFNlcnZpY2VXb3JrZXJQcm92 aWRlciYpOwogCiAgICAgYm9vbCBtYXlIYXZlU2VydmljZVdvcmtlclJlZ2lzdGVyZWRGb3JPcmln aW4oUEFMOjpTZXNzaW9uSUQsIGNvbnN0IFNlY3VyaXR5T3JpZ2luRGF0YSYpOwogICAgIHZpcnR1 YWwgU1dDbGllbnRDb25uZWN0aW9uKiBleGlzdGluZ1NlcnZpY2VXb3JrZXJDb25uZWN0aW9uRm9y U2Vzc2lvbihQQUw6OlNlc3Npb25JRCkgPSAwOwogICAgIHZpcnR1YWwgU1dDbGllbnRDb25uZWN0 aW9uJiBzZXJ2aWNlV29ya2VyQ29ubmVjdGlvbkZvclNlc3Npb24oUEFMOjpTZXNzaW9uSUQpID0g MDsKIAotICAgIFdFQkNPUkVfRVhQT1JUIHZvaWQgcmVnaXN0ZXJTZXJ2aWNlV29ya2VyQ2xpZW50 cygpOworICAgIHZvaWQgcmVnaXN0ZXJTZXJ2aWNlV29ya2VyQ2xpZW50cygpOwogCiAgICAgdm9p ZCBzZXRNYXlIYXZlUmVnaXN0ZXJlZFNlcnZpY2VXb3JrZXJzKCkgeyBtX21heUhhdmVSZWdpc3Rl cmVkU2VydmljZVdvcmtlcnMgPSB0cnVlOyB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3dvcmtlcnMvc2VydmljZS9jb250ZXh0L1NXQ29udGV4dE1hbmFnZXIuY3BwIGIvU291cmNlL1dl YkNvcmUvd29ya2Vycy9zZXJ2aWNlL2NvbnRleHQvU1dDb250ZXh0TWFuYWdlci5jcHAKaW5kZXgg NjQ1ZWViMTI2N2QuLjYxZWViZTNkMTY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93b3Jr ZXJzL3NlcnZpY2UvY29udGV4dC9TV0NvbnRleHRNYW5hZ2VyLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS93b3JrZXJzL3NlcnZpY2UvY29udGV4dC9TV0NvbnRleHRNYW5hZ2VyLmNwcApAQCAtMzEs NyArMzEsNiBAQAogI2luY2x1ZGUgIk1lc3NhZ2VXaXRoTWVzc2FnZVBvcnRzLmgiCiAjaW5jbHVk ZSAiU2VydmljZVdvcmtlckNsaWVudElkZW50aWZpZXIuaCIKICNpbmNsdWRlICJTZXJ2aWNlV29y a2VyR2xvYmFsU2NvcGUuaCIKLSNpbmNsdWRlIDx1bmlzdGQuaD4KIAogbmFtZXNwYWNlIFdlYkNv cmUgewogCg==