191387 2018-11-07 11:38:01 -0800 IntersectionObserver GC-dependent tests are flaky 2018-11-07 13:01:30 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ajuma ajuma bfulgham cdumez commit-queue rniwa simon.fraser webkit-bug-importer zalan oldest_to_newest 1476093 0 ajuma 2018-11-07 11:38:01 -0800 intersection-observer/root-element-deleted.html is flaky on Sierra Release WK2 bot. intersection-observer/target-deleted.html is flaky on the GTK bots. These two tests try to trigger GC, but if they happen to do this while the GC thread is already active, the call to GC will early-out in GCController::garbageCollectNow. This is problematic for two reasons: 1) The test will continue before the already-underway GC is finished; 2) Objects whose last reference was only just released might not be freed by the already-underway GC. To make these tests more robust, we need to do something like what intersection-observer/no-document-leak.html does, and repeatedly trigger GC inside a setInterval(). 1476097 1 354117 ajuma 2018-11-07 11:40:56 -0800 Created attachment 354117 Patch 1476147 2 354117 commit-queue 2018-11-07 13:00:44 -0800 Comment on attachment 354117 Patch Clearing flags on attachment: 354117 Committed r237939: <https://trac.webkit.org/changeset/237939> 1476148 3 commit-queue 2018-11-07 13:00:46 -0800 All reviewed patches have been landed. Closing bug. 1476149 4 webkit-bug-importer 2018-11-07 13:01:30 -0800 <rdar://problem/45886176> 354117 2018-11-07 11:40:56 -0800 2018-11-07 13:00:44 -0800 Patch bug-191387-20181107144055.patch text/plain 4180 ajuma U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3ODgwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZDEwODQ3N2FiOTY3OWVkZGMxZDUx OTQ5M2FmY2FhNmNiOWVlNjI5ZS4uN2JlNGUzNzJmYzlkMTc4OWM1OTZlZDJjYTQzMmNlZDM1ZjRm MTUzMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTExLTA3ICBBbGkgSnVtYSAgPGFqdW1h QGNocm9taXVtLm9yZz4KKworICAgICAgICBJbnRlcnNlY3Rpb25PYnNlcnZlciBHQy1kZXBlbmRl bnQgdGVzdHMgYXJlIGZsYWt5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xOTEzODcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBNYWtlIHRoZXNlIHRlc3RzIG1vcmUgcm9idXN0IGJ5IHRyaWdnZXJpbmcgR0Mg cmVwZWF0ZWRseSBpbnNpZGUgYSBzZXRJbnRlcnZhbCgpLiBIYXZpbmcgb25seSBhIHNpbmdsZSBj YWxsIHRvCisgICAgICAgIEdDIGlzIHBvdGVudGlhbGx5IGZsYWt5LCBzaW5jZSB0aGF0IGNhbGwg d2lsbCBlYXJseS1vdXQgYW5kIHJldHVybiBpbW1lZGlhdGVseSBpZiBhIEdDIGlzIGFscmVhZHkg dW5kZXJ3YXkuCisKKyAgICAgICAgKiBpbnRlcnNlY3Rpb24tb2JzZXJ2ZXIvcm9vdC1lbGVtZW50 LWRlbGV0ZWQuaHRtbDoKKyAgICAgICAgKiBpbnRlcnNlY3Rpb24tb2JzZXJ2ZXIvdGFyZ2V0LWRl bGV0ZWQuaHRtbDoKKwogMjAxOC0xMS0wNiAgQWxpIEp1bWEgIDxhanVtYUBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgSW50ZXJzZWN0aW9uT2JzZXJ2ZXIgZG9lc24ndCBrZWVwIHRhcmdldCdzIEpT IHdyYXBwZXIgYWxpdmUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ludGVyc2VjdGlvbi1vYnNl cnZlci9yb290LWVsZW1lbnQtZGVsZXRlZC5odG1sIGIvTGF5b3V0VGVzdHMvaW50ZXJzZWN0aW9u LW9ic2VydmVyL3Jvb3QtZWxlbWVudC1kZWxldGVkLmh0bWwKaW5kZXggNGM0ZGU1ODZmMmQzOWI4 NmY1MjcyNmE4ODFjOWE0MzM3M2RlMWI2NC4uM2E4NTlmMGM4NTM1NWZiNDZiZjMzYzlhNmE3NmM2 YzZmM2U2N2Y5YSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW50ZXJzZWN0aW9uLW9ic2VydmVy L3Jvb3QtZWxlbWVudC1kZWxldGVkLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvaW50ZXJzZWN0aW9u LW9ic2VydmVyL3Jvb3QtZWxlbWVudC1kZWxldGVkLmh0bWwKQEAgLTksNiArOSwxOSBAQAogPC9k aXY+CiAKIDxzY3JpcHQ+CisgICAgZnVuY3Rpb24gb2JzZXJ2ZXJTaG91bGRCZVJlbW92ZWQoKQor ICAgIHsKKyAgICAgICAgcmV0dXJuIG5ldyBQcm9taXNlKGZ1bmN0aW9uKHJlc29sdmUpIHsKKyAg ICAgICAgICAgIGhhbmRsZSA9IHNldEludGVydmFsKGZ1bmN0aW9uKCkgeworICAgICAgICAgICAg ICAgIEdDQ29udHJvbGxlci5jb2xsZWN0KCk7CisgICAgICAgICAgICAgICAgaWYgKGludGVybmFs cyAmJiBpbnRlcm5hbHMubnVtYmVyT2ZJbnRlcnNlY3Rpb25PYnNlcnZlcnMoZG9jdW1lbnQpID09 IDApIHsKKyAgICAgICAgICAgICAgICAgICAgY2xlYXJJbnRlcnZhbChoYW5kbGUpOworICAgICAg ICAgICAgICAgICAgICByZXNvbHZlKCk7CisgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAg fSwgMTApOworICAgICAgICB9KTsKKyAgICB9CisKICAgICBhc3luY190ZXN0KGZ1bmN0aW9uKHQp IHsKICAgICAgICAgdmFyIHJvb3QgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgncm9vdCcpOwog ICAgICAgICB2YXIgb2JzZXJ2ZXIgPSBuZXcgSW50ZXJzZWN0aW9uT2JzZXJ2ZXIoZnVuY3Rpb24o KSB7fSwgeyByb290OiBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgncm9vdCcpIH0pOzsKQEAgLTE5 LDEyICszMiwxMiBAQAogICAgICAgICByb290LnBhcmVudE5vZGUucmVtb3ZlQ2hpbGQocm9vdCk7 CiAgICAgICAgIHJvb3QgPSBudWxsOwogICAgICAgICB0YXJnZXQgPSBudWxsOwotICAgICAgICBy ZXF1ZXN0QW5pbWF0aW9uRnJhbWUodC5zdGVwX2Z1bmNfZG9uZShmdW5jdGlvbigpIHsKKyAgICAg ICAgcmVxdWVzdEFuaW1hdGlvbkZyYW1lKGZ1bmN0aW9uKCkgewogICAgICAgICAgICAgb2JzZXJ2 ZXIudGFrZVJlY29yZHMoKTsKLSAgICAgICAgICAgIEdDQ29udHJvbGxlci5jb2xsZWN0KCk7Ci0g ICAgICAgICAgICBhc3NlcnRfZXF1YWxzKG9ic2VydmVyLnJvb3QsIG51bGwsICdPYnNlcnZlciBo YXMgbnVsbCByb290IGFmdGVyIHJvb3QgZWxlbWVudCBpcyBkZXN0cm95ZWQnKTsKLSAgICAgICAg ICAgIGFzc2VydF9lcXVhbHMoaW50ZXJuYWxzLm51bWJlck9mSW50ZXJzZWN0aW9uT2JzZXJ2ZXJz KGRvY3VtZW50KSwgMCk7Ci0gICAgICAgIH0pKTsKKyAgICAgICAgICAgIG9ic2VydmVyU2hvdWxk QmVSZW1vdmVkKCkudGhlbih0LnN0ZXBfZnVuY19kb25lKGZ1bmN0aW9uKCkgeworICAgICAgICAg ICAgICAgIGFzc2VydF9lcXVhbHMob2JzZXJ2ZXIucm9vdCwgbnVsbCwgJ09ic2VydmVyIGhhcyBu dWxsIHJvb3QgYWZ0ZXIgcm9vdCBlbGVtZW50IGlzIGRlc3Ryb3llZCcpOworICAgICAgICAgICAg fSkpOworICAgICAgICB9KTsKICAgICB9LCAiSW50ZXJzZWN0aW9uT2JzZXJ2ZXIgZG9lc24ndCBr ZWVwIHVucmVhY2hhYmxlIHJvb3QgYWxpdmUiKTsKIDwvc2NyaXB0PgogPC9ib2R5PgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvaW50ZXJzZWN0aW9uLW9ic2VydmVyL3RhcmdldC1kZWxldGVkLmh0 bWwgYi9MYXlvdXRUZXN0cy9pbnRlcnNlY3Rpb24tb2JzZXJ2ZXIvdGFyZ2V0LWRlbGV0ZWQuaHRt bAppbmRleCBjNzAwNjEwNjdmZjQ3Njc3NmYwMjRiMWI0ZTFmYmE1YzU2NzE5MGFjLi5lZmU0MmMz Nzc2YjdiOWJlMjdkMGM0NDc3ZGMzNDBkNWVmNTJiMDg2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9pbnRlcnNlY3Rpb24tb2JzZXJ2ZXIvdGFyZ2V0LWRlbGV0ZWQuaHRtbAorKysgYi9MYXlvdXRU ZXN0cy9pbnRlcnNlY3Rpb24tb2JzZXJ2ZXIvdGFyZ2V0LWRlbGV0ZWQuaHRtbApAQCAtOCwxNCAr OCwyNiBAQAogPGRpdiBpZD0idGFyZ2V0IiBzdHlsZT0id2lkdGg6IDEwMHB4OyBoZWlnaHQ6IDEw MHB4OyBiYWNrZ3JvdW5kLWNvbG9yOiBncmVlbiI+PC9kaXY+CiAKIDxzY3JpcHQ+CisgICAgZnVu Y3Rpb24gb2JzZXJ2ZXJTaG91bGRCZVJlbW92ZWQoKQorICAgIHsKKyAgICAgICAgcmV0dXJuIG5l dyBQcm9taXNlKGZ1bmN0aW9uKHJlc29sdmUpIHsKKyAgICAgICAgICAgIGhhbmRsZSA9IHNldElu dGVydmFsKGZ1bmN0aW9uKCkgeworICAgICAgICAgICAgICAgIGdjKCk7CisgICAgICAgICAgICAg ICAgaWYgKGludGVybmFscyAmJiBpbnRlcm5hbHMubnVtYmVyT2ZJbnRlcnNlY3Rpb25PYnNlcnZl cnMoZG9jdW1lbnQpID09IDApIHsKKyAgICAgICAgICAgICAgICAgICAgY2xlYXJJbnRlcnZhbCho YW5kbGUpOworICAgICAgICAgICAgICAgICAgICByZXNvbHZlKCk7CisgICAgICAgICAgICAgICAg fQorICAgICAgICAgICAgfSwgMTApOworICAgICAgICB9KTsKKyAgICB9CisKICAgICBhc3luY190 ZXN0KGZ1bmN0aW9uKHQpIHsKICAgICAgICAgbGV0IG9ic2VydmVyID0gbmV3IEludGVyc2VjdGlv bk9ic2VydmVyKGZ1bmN0aW9uKGVudHJpZXMpIHsKICAgICAgICAgICAgIGlmIChlbnRyaWVzWzBd LmlzSW50ZXJzZWN0aW5nKSB7CiAgICAgICAgICAgICAgICAgZW50cmllc1swXS50YXJnZXQucmVt b3ZlKCk7Ci0gICAgICAgICAgICAgICAgcmVxdWVzdEFuaW1hdGlvbkZyYW1lKHQuc3RlcF9mdW5j X2RvbmUoZnVuY3Rpb24oKSB7Ci0gICAgICAgICAgICAgICAgICAgIGdjKCk7Ci0gICAgICAgICAg ICAgICAgICAgIGFzc2VydF9lcXVhbHMoaW50ZXJuYWxzLm51bWJlck9mSW50ZXJzZWN0aW9uT2Jz ZXJ2ZXJzKGRvY3VtZW50KSwgMCk7Ci0gICAgICAgICAgICAgICAgfSkpOworICAgICAgICAgICAg ICAgIG9ic2VydmVyU2hvdWxkQmVSZW1vdmVkKCkudGhlbihmdW5jdGlvbigpIHsKKyAgICAgICAg ICAgICAgICAgICAgdC5kb25lKCk7CisgICAgICAgICAgICAgICAgfSk7CiAgICAgICAgICAgICB9 CiAgICAgICAgIH0pOwogICAgICAgICBvYnNlcnZlci5vYnNlcnZlKGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCJ0YXJnZXQiKSk7Cg==