191351 2018-11-07 00:48:31 -0800 "/api/report" does not check commit time correctly. 2018-11-12 15:48:50 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dewei_zhu dewei_zhu dewei_zhu rniwa oldest_to_newest 1475910 0 dewei_zhu 2018-11-07 00:48:31 -0800 "/api/report' does not check commit time correctly. 1475911 1 354070 dewei_zhu 2018-11-07 00:51:49 -0800 Created attachment 354070 Patch 1476330 2 dewei_zhu 2018-11-07 16:43:10 -0800 Landed in r237953. Tracked in <rdar://problem/45894683> 1477774 3 354070 rniwa 2018-11-12 15:48:50 -0800 Comment on attachment 354070 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354070&action=review > Websites/perf.webkit.org/public/include/report-processor.php:175 > + > + if ($commit_data['time'] && abs(strtotime($commit_row['commit_time']) - strtotime($commit_data['time'])) > 1.0) Why don't we just call Database::to_js_time and check that the difference is less than 1000ms? 354070 2018-11-07 00:51:49 -0800 2018-11-07 14:02:39 -0800 Patch bug-191351-20181107005149.patch text/plain 5721 dewei_zhu U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3OTE2CmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndl YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwpp bmRleCBiYzI5MjE3M2NiYzY5YzA3ZTJkYzI4MWFhZWI0NTNkYTc2YTMzOWJiLi42NjM2MzgzNzNm NzM5YmJiZmFjNzFiOGVkOGMwYWE1NzZlOTJjMjIxIDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJm LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxOC0xMS0wNyAgRGV3ZWkgWmh1ICA8ZGV3ZWlfemh1 QGFwcGxlLmNvbT4KKworICAgICAgICAiL2FwaS9yZXBvcnQnIGRvZXMgbm90IGNoZWNrIGNvbW1p dCB0aW1lIGNvcnJlY3RseS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE5MTM1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRlc3QgcmVzdWx0IHJlcG9ydCBBUEkgZG9lcyBub3QgY29udmVydCBmb3JtYXRl ZCB0aW1lIHN0cmluZyB0byB0aW1lc3RhbXAgY29ycmVjdGx5CisgICAgICAgIHdoaWNoIHJlc3Vs dCBpbiBub3QgY2hlY2tpbmcgY29tbWl0IHRpbWUgY29ycmVjdGx5LgorCisgICAgICAgICogcHVi bGljL2luY2x1ZGUvcmVwb3J0LXByb2Nlc3Nvci5waHA6IFVzZSAnc3RydG90aW1lJyBpbnN0ZWFk IG9mICdmbG9hdHZhbCcuCisgICAgICAgIEFjY2VwdHMgdGhlIHRpbWUgZGVsdGEgd2l0aGluIDEg c2Vjb25kcy4KKyAgICAgICAgKiBzZXJ2ZXItdGVzdHMvYXBpLXJlcG9ydC10ZXN0cy5qczogQWRk ZWQgdW5pdCB0ZXN0cy4KKyAgICAgICAgKHJlcG9ydFdpdE1pc21hdGNoaW5nQ29tbWl0VGltZSk6 CisgICAgICAgIChyZXBvcnRXaXRoT25lU2Vjb25kQ29tbWl0VGltZURpZmZlcmVuY2UpOgorCiAy MDE4LTExLTA2ICBEZXdlaSBaaHUgIDxkZXdlaV96aHVAYXBwbGUuY29tPgogCiAgICAgICAgIEN1 c3RvbWl6YWJsZSB0ZXN0IGdyb3VwIGZvcm0gc2hvdWxkIG5vdCByZXNldCBtYW51YWxseSBlZGl0 ZWQgY29tbWl0IHZhbHVlIHNvbWV0aW1lcy4KZGlmZiAtLWdpdCBhL1dlYnNpdGVzL3BlcmYud2Vi a2l0Lm9yZy9wdWJsaWMvaW5jbHVkZS9yZXBvcnQtcHJvY2Vzc29yLnBocCBiL1dlYnNpdGVzL3Bl cmYud2Via2l0Lm9yZy9wdWJsaWMvaW5jbHVkZS9yZXBvcnQtcHJvY2Vzc29yLnBocAppbmRleCAz MGY4NGI5NGJjOTRkZDA3NWJjYWIxN2QxNDllNDlhMmIyZWViNjkxLi5kOWU4MTkwOWMyZjkxYzYz OWYyYjk3ODBiYzU0MjdjODFjOTRhZWNiIDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJmLndlYmtp dC5vcmcvcHVibGljL2luY2x1ZGUvcmVwb3J0LXByb2Nlc3Nvci5waHAKKysrIGIvV2Vic2l0ZXMv cGVyZi53ZWJraXQub3JnL3B1YmxpYy9pbmNsdWRlL3JlcG9ydC1wcm9jZXNzb3IucGhwCkBAIC0x NzEsNyArMTcxLDggQEAgY2xhc3MgUmVwb3J0UHJvY2Vzc29yIHsKICAgICAgICAgICAgICAgICBh cnJheSgncmVwb3NpdG9yeScgPT4gJHJlcG9zaXRvcnlfaWQsICdyZXZpc2lvbicgPT4gJHJldmlz aW9uX2RhdGFbJ3JldmlzaW9uJ10pLCAkY29tbWl0X2RhdGEsICcqJyk7CiAgICAgICAgICAgICBp ZiAoISRjb21taXRfcm93KQogICAgICAgICAgICAgICAgICR0aGlzLT5yb2xsYmFja193aXRoX2Vy cm9yKCdGYWlsZWRUb1JlY29yZENvbW1pdCcsICRjb21taXRfZGF0YSk7Ci0gICAgICAgICAgICBp ZiAoJGNvbW1pdF9kYXRhWyd0aW1lJ10gJiYgYWJzKGZsb2F0dmFsKCRjb21taXRfcm93Wydjb21t aXRfdGltZSddKSAtIGZsb2F0dmFsKCRjb21taXRfZGF0YVsndGltZSddKSkgPiAxLjApCisKKyAg ICAgICAgICAgIGlmICgkY29tbWl0X2RhdGFbJ3RpbWUnXSAmJiBhYnMoc3RydG90aW1lKCRjb21t aXRfcm93Wydjb21taXRfdGltZSddKSAtIHN0cnRvdGltZSgkY29tbWl0X2RhdGFbJ3RpbWUnXSkp ID4gMS4wKQogICAgICAgICAgICAgICAgICR0aGlzLT5yb2xsYmFja193aXRoX2Vycm9yKCdNaXNt YXRjaGluZ0NvbW1pdFRpbWUnLCBhcnJheSgnZXhpc3RpbmcnID0+ICRjb21taXRfcm93LCAnbmV3 JyA9PiAkY29tbWl0X2RhdGEpKTsKIAogICAgICAgICAgICAgaWYgKCEkdGhpcy0+ZGItPnNlbGVj dF9vcl9pbnNlcnRfcm93KCdidWlsZF9jb21taXRzJywgbnVsbCwKZGlmZiAtLWdpdCBhL1dlYnNp dGVzL3BlcmYud2Via2l0Lm9yZy9zZXJ2ZXItdGVzdHMvYXBpLXJlcG9ydC10ZXN0cy5qcyBiL1dl YnNpdGVzL3BlcmYud2Via2l0Lm9yZy9zZXJ2ZXItdGVzdHMvYXBpLXJlcG9ydC10ZXN0cy5qcwpp bmRleCA4ZjJmZjE5YWVkOTM1NDcxZWRiNmFjZTJkMjA2ODlhMzQ1ZjJmZGQxLi42YWRkYmJiNTFh ZmFlZmVmNDJkY2ZlMDgwMzE0MGUxMDBmYWE3NGRlIDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJm LndlYmtpdC5vcmcvc2VydmVyLXRlc3RzL2FwaS1yZXBvcnQtdGVzdHMuanMKKysrIGIvV2Vic2l0 ZXMvcGVyZi53ZWJraXQub3JnL3NlcnZlci10ZXN0cy9hcGktcmVwb3J0LXRlc3RzLmpzCkBAIC0z Myw2ICszMyw1MCBAQCBkZXNjcmliZSgiL2FwaS9yZXBvcnQiLCBmdW5jdGlvbiAoKSB7CiAgICAg ICAgIH07CiAgICAgfQogCisgICAgZnVuY3Rpb24gcmVwb3J0V2l0TWlzbWF0Y2hpbmdDb21taXRU aW1lKCkKKyAgICB7CisgICAgICAgIHJldHVybiB7CisgICAgICAgICAgICAiYnVpbGROdW1iZXIi OiAiMTI0IiwKKyAgICAgICAgICAgICJidWlsZFRpbWUiOiAiMjAxMy0wMi0yOFQxMDoxMjowMy4z ODgzMDQiLAorICAgICAgICAgICAgImJ1aWxkZXJOYW1lIjogInNvbWVCdWlsZGVyIiwKKyAgICAg ICAgICAgICJzbGF2ZU5hbWUiOiAic29tZVNsYXZlIiwKKyAgICAgICAgICAgICJidWlsZGVyUGFz c3dvcmQiOiAic29tZVBhc3N3b3JkIiwKKyAgICAgICAgICAgICJwbGF0Zm9ybSI6ICJNb3VudGFp biBMaW9uIiwKKyAgICAgICAgICAgICJ0ZXN0cyI6IHt9LAorICAgICAgICAgICAgInJldmlzaW9u cyI6IHsKKyAgICAgICAgICAgICAgICAibWFjT1MiOiB7CisgICAgICAgICAgICAgICAgICAgICJy ZXZpc2lvbiI6ICIxMC44LjIgMTJDNjAiCisgICAgICAgICAgICAgICAgfSwKKyAgICAgICAgICAg ICAgICAiV2ViS2l0IjogeworICAgICAgICAgICAgICAgICAgICAicmV2aXNpb24iOiAiMTQxOTc3 IiwKKyAgICAgICAgICAgICAgICAgICAgInRpbWVzdGFtcCI6ICIyMDEzLTAyLTA2VDA4OjU1OjEw LjlaIgorICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgIH0KKyAgICAgICAgfTsKKyAgICB9 CisKKyAgICBmdW5jdGlvbiByZXBvcnRXaXRoT25lU2Vjb25kQ29tbWl0VGltZURpZmZlcmVuY2Uo KQorICAgIHsKKyAgICAgICAgcmV0dXJuIHsKKyAgICAgICAgICAgICJidWlsZE51bWJlciI6ICIx MjUiLAorICAgICAgICAgICAgImJ1aWxkVGltZSI6ICIyMDEzLTAyLTI4VDEwOjEyOjAzLjM4ODMw NCIsCisgICAgICAgICAgICAiYnVpbGRlck5hbWUiOiAic29tZUJ1aWxkZXIiLAorICAgICAgICAg ICAgInNsYXZlTmFtZSI6ICJzb21lU2xhdmUiLAorICAgICAgICAgICAgImJ1aWxkZXJQYXNzd29y ZCI6ICJzb21lUGFzc3dvcmQiLAorICAgICAgICAgICAgInBsYXRmb3JtIjogIk1vdW50YWluIExp b24iLAorICAgICAgICAgICAgInRlc3RzIjoge30sCisgICAgICAgICAgICAicmV2aXNpb25zIjog eworICAgICAgICAgICAgICAgICJtYWNPUyI6IHsKKyAgICAgICAgICAgICAgICAgICAgInJldmlz aW9uIjogIjEwLjguMiAxMkM2MCIKKyAgICAgICAgICAgICAgICB9LAorICAgICAgICAgICAgICAg ICJXZWJLaXQiOiB7CisgICAgICAgICAgICAgICAgICAgICJyZXZpc2lvbiI6ICIxNDE5NzciLAor ICAgICAgICAgICAgICAgICAgICAidGltZXN0YW1wIjogIjIwMTMtMDItMDZUMDg6NTU6MTkuOVoi CisgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgfQorICAgICAgICB9OworICAgIH0KKwog ICAgIGZ1bmN0aW9uIGVtcHR5U2xhdmVSZXBvcnQoKQogICAgIHsKICAgICAgICAgcmV0dXJuIHsK QEAgLTk5LDYgKzE0MywzMiBAQCBkZXNjcmliZSgiL2FwaS9yZXBvcnQiLCBmdW5jdGlvbiAoKSB7 CiAgICAgICAgIH0pOwogICAgIH0pOwogCisgICAgaXQoJ3Nob3VsZCByZWplY3QgcmVwb3J0IHdp dGggIk1pc21hdGNoaW5nQ29tbWl0VGltZSInLCBhc3luYyAoKSA9PiB7CisgICAgICAgIGF3YWl0 IGFkZEJ1aWxkZXJGb3JSZXBvcnQoZW1wdHlSZXBvcnQoKSk7CisgICAgICAgIGxldCByZXNwb25z ZSA9IGF3YWl0IFRlc3RTZXJ2ZXIucmVtb3RlQVBJKCkucG9zdEpTT04oJy9hcGkvcmVwb3J0Lycs IFtyZXBvcnRXaXRNaXNtYXRjaGluZ0NvbW1pdFRpbWUoKV0pOworICAgICAgICBhc3NlcnQuZXF1 YWwocmVzcG9uc2VbJ3N0YXR1cyddLCAnT0snKTsKKyAgICAgICAgYXNzZXJ0LmVxdWFsKHJlc3Bv bnNlWydmYWlsdXJlU3RvcmVkJ10sIGZhbHNlKTsKKyAgICAgICAgYXNzZXJ0LmVxdWFsKHJlc3Bv bnNlWydwcm9jZXNzZWRSdW5zJ10sIDEpOworCisgICAgICAgIHJlc3BvbnNlID0gYXdhaXQgVGVz dFNlcnZlci5yZW1vdGVBUEkoKS5wb3N0SlNPTignL2FwaS9yZXBvcnQvJywgW2VtcHR5UmVwb3J0 KCldKTsKKyAgICAgICAgYXNzZXJ0LmVxdWFsKHJlc3BvbnNlWydzdGF0dXMnXSwgJ01pc21hdGNo aW5nQ29tbWl0VGltZScpOworICAgICAgICBhc3NlcnQuZXF1YWwocmVzcG9uc2VbJ2ZhaWx1cmVT dG9yZWQnXSwgdHJ1ZSk7CisgICAgICAgIGFzc2VydC5lcXVhbChyZXNwb25zZVsncHJvY2Vzc2Vk UnVucyddLCAwKTsKKyAgICB9KTsKKworICAgIGl0KCdzaG91bGQgbm90IHJlamVjdCByZXBvcnQg aWYgdGhlIGNvbW1pdCB0aW1lIGRpZmZlcmVuY2UgaXMgd2l0aGluIDEgc2Vjb25kIicsIGFzeW5j ICgpID0+IHsKKyAgICAgICAgYXdhaXQgYWRkQnVpbGRlckZvclJlcG9ydChlbXB0eVJlcG9ydCgp KTsKKyAgICAgICAgbGV0IHJlc3BvbnNlID0gYXdhaXQgVGVzdFNlcnZlci5yZW1vdGVBUEkoKS5w b3N0SlNPTignL2FwaS9yZXBvcnQvJywgW3JlcG9ydFdpdGhPbmVTZWNvbmRDb21taXRUaW1lRGlm ZmVyZW5jZSgpXSk7CisgICAgICAgIGFzc2VydC5lcXVhbChyZXNwb25zZVsnc3RhdHVzJ10sICdP SycpOworICAgICAgICBhc3NlcnQuZXF1YWwocmVzcG9uc2VbJ2ZhaWx1cmVTdG9yZWQnXSwgZmFs c2UpOworICAgICAgICBhc3NlcnQuZXF1YWwocmVzcG9uc2VbJ3Byb2Nlc3NlZFJ1bnMnXSwgMSk7 CisKKyAgICAgICAgcmVzcG9uc2UgPSBhd2FpdCBUZXN0U2VydmVyLnJlbW90ZUFQSSgpLnBvc3RK U09OKCcvYXBpL3JlcG9ydC8nLCBbZW1wdHlSZXBvcnQoKV0pOworICAgICAgICBhc3NlcnQuZXF1 YWwocmVzcG9uc2VbJ3N0YXR1cyddLCAnT0snKTsKKyAgICAgICAgYXNzZXJ0LmVxdWFsKHJlc3Bv bnNlWydmYWlsdXJlU3RvcmVkJ10sIGZhbHNlKTsKKyAgICAgICAgYXNzZXJ0LmVxdWFsKHJlc3Bv bnNlWydwcm9jZXNzZWRSdW5zJ10sIDEpOworICAgIH0pOworCiAgICAgaXQoInNob3VsZCBzdG9y ZSBhIHJlcG9ydCBmcm9tIGEgdmFsaWQgYnVpbGRlciIsICgpID0+IHsKICAgICAgICAgcmV0dXJu IGFkZEJ1aWxkZXJGb3JSZXBvcnQoZW1wdHlSZXBvcnQoKSkudGhlbigoKSA9PiB7CiAgICAgICAg ICAgICByZXR1cm4gVGVzdFNlcnZlci5yZW1vdGVBUEkoKS5wb3N0SlNPTignL2FwaS9yZXBvcnQv JywgW2VtcHR5UmVwb3J0KCldKTsK