191349 2018-11-07 00:27:55 -0800 TileController::tileSize() should not have side effects 2018-11-07 07:22:23 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser commit-queue simon.fraser webkit-bug-importer zalan oldest_to_newest 1475904 0 simon.fraser 2018-11-07 00:27:55 -0800 TileController::tileSize() should not have side effects 1475905 1 354068 simon.fraser 2018-11-07 00:29:56 -0800 Created attachment 354068 Patch 1475984 2 354068 commit-queue 2018-11-07 07:21:13 -0800 Comment on attachment 354068 Patch Clearing flags on attachment: 354068 Committed r237925: <https://trac.webkit.org/changeset/237925> 1475985 3 commit-queue 2018-11-07 07:21:14 -0800 All reviewed patches have been landed. Closing bug. 1475986 4 webkit-bug-importer 2018-11-07 07:22:23 -0800 <rdar://problem/45875045> 354068 2018-11-07 00:29:56 -0800 2018-11-07 07:21:13 -0800 Patch bug-191349-20181107002955.patch text/plain 3755 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3OTE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODJjZjExM2NiYTI4ZTIy NTc4Mzc2YWU4ZjExNWEyYWYxNTdhYWUwOC4uNzZkMWQ3MTlmYjdlMGVkOTJlNjcyMGJkNTcxOGY4 NDY4NDBjMjc4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE4LTExLTA3ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFRpbGVDb250cm9s bGVyOjp0aWxlU2l6ZSgpIHNob3VsZCBub3QgaGF2ZSBzaWRlIGVmZmVjdHMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTM0OQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENhbGxpbmcgVGlsZUNvbnRyb2xs ZXI6OnRpbGVTaXplKCkgd291bGQgcmVjb21wdXRlIGEgbmV3IHRpbGUgc2l6ZSBhbmQgc2V0IG1f dGlsZVNpemVMb2NrZWQsCisgICAgICAgIHdoaWNoIGNhdXNlZCB0ZXN0IGZhaWx1cmVzIGlmIGxv Z2dpbmcgd2FzIGVuYWJsZWQgd2hlbiBydW5uaW5nIHRlc3RzLgorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvY2EvVGlsZUNvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGls ZUNvbnRyb2xsZXI6OnRpbGVTaXplIGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6OlRpbGVDb250 cm9sbGVyOjpjb21wdXRlVGlsZVNpemUpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nh L1RpbGVDb250cm9sbGVyLmg6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2EvVGlsZUdy aWQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGlsZUdyaWQ6OnJldmFsaWRhdGVUaWxlcyk6CisK IDIwMTgtMTEtMDYgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAg ICAgICBTZXJ2aWNlV29ya2VyIEluc3BlY3RvcjogVW5jYXVnaHQgRXhjZXB0aW9uOiBudWxsIGlz IG5vdCBhbiBvYmplY3QgKGV2YWx1YXRpbmcgJ3Jlc291cmNlLnRhcmdldC5hZGRSZXNvdXJjZScp CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9UaWxlQ29u dHJvbGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9UaWxlQ29u dHJvbGxlci5jcHAKaW5kZXggNjIxYmUxN2IzYTM5MmJlYmRiZDlhMTJlMzhiNWQyOTZlOWUwNzEx Ny4uODBjZmM0ZmFjMzQ1YzkyZWNkNjE3MzdmYzkyNTRkY2Q4Yjc1NWJmOCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvVGlsZUNvbnRyb2xsZXIuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL1RpbGVDb250cm9sbGVyLmNw cApAQCAtNTI3LDYgKzUyNywxMSBAQCB2b2lkIFRpbGVDb250cm9sbGVyOjp0aWxlU2l6ZUNoYW5n ZVRpbWVyRmlyZWQoKQogfQogCiBJbnRTaXplIFRpbGVDb250cm9sbGVyOjp0aWxlU2l6ZSgpIGNv bnN0Cit7CisgICAgcmV0dXJuIHRpbGVHcmlkKCkudGlsZVNpemUoKTsKK30KKworSW50U2l6ZSBU aWxlQ29udHJvbGxlcjo6Y29tcHV0ZVRpbGVTaXplKCkKIHsKICAgICBpZiAobV9pbkxpdmVSZXNp emUgfHwgbV90aWxlU2l6ZUxvY2tlZCkKICAgICAgICAgcmV0dXJuIHRpbGVHcmlkKCkudGlsZVNp emUoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL1Rp bGVDb250cm9sbGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9UaWxl Q29udHJvbGxlci5oCmluZGV4IGNkYzA2NmJhZWNhNjBkMDBlYjQ0Njk4NzBhMjZmMDJlZTE0Nzc3 NWQuLmFlMTliOGM1MTcxZmQ1NzQxYTU1MTVmNzZhNjk4ODY2NjJmYWYwN2MgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL1RpbGVDb250cm9sbGVyLmgKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvVGlsZUNvbnRyb2xsZXIuaApA QCAtMTIzLDYgKzEyMyw4IEBAIHB1YmxpYzoKICAgICB2b2lkIGFkanVzdFRpbGVDb3ZlcmFnZVJl Y3QoRmxvYXRSZWN0JiBjb3ZlcmFnZVJlY3QsIGNvbnN0IEZsb2F0U2l6ZSYgbmV3U2l6ZSwgY29u c3QgRmxvYXRSZWN0JiBwcmV2aW91c1Zpc2libGVSZWN0LCBjb25zdCBGbG9hdFJlY3QmIGN1cnJl bnRWaXNpYmxlUmVjdCwgZmxvYXQgY29udGVudHNTY2FsZSkgY29uc3Qgb3ZlcnJpZGU7CiAgICAg Ym9vbCBzY3JvbGxpbmdQZXJmb3JtYW5jZUxvZ2dpbmdFbmFibGVkKCkgY29uc3Qgb3ZlcnJpZGUg eyByZXR1cm4gbV9zY3JvbGxpbmdQZXJmb3JtYW5jZUxvZ2dpbmdFbmFibGVkOyB9CiAKKyAgICBJ bnRTaXplIGNvbXB1dGVUaWxlU2l6ZSgpOworCiAgICAgSW50UmVjdCBib3VuZHNBdExhc3RSZXZh bGlkYXRlKCkgY29uc3QgeyByZXR1cm4gbV9ib3VuZHNBdExhc3RSZXZhbGlkYXRlOyB9CiAgICAg SW50UmVjdCBib3VuZHNBdExhc3RSZXZhbGlkYXRlV2l0aG91dE1hcmdpbigpIGNvbnN0OwogICAg IHZvaWQgZGlkUmV2YWxpZGF0ZVRpbGVzKCk7CkBAIC0yMjksNyArMjMxLDcgQEAgcHJpdmF0ZToK ICAgICBib29sIG1fdGlsZXNBcmVPcGFxdWUgeyBmYWxzZSB9OwogICAgIGJvb2wgbV9oYXNUaWxl c1dpdGhUZW1wb3JhcnlTY2FsZUZhY3RvciB7IGZhbHNlIH07IC8vIFVzZWQgdG8gbWFrZSBsb3ct cmVzIHRpbGVzIHdoZW4gem9vbWluZy4KICAgICBib29sIG1faW5MaXZlUmVzaXplIHsgZmFsc2Ug fTsKLSAgICBtdXRhYmxlIGJvb2wgbV90aWxlU2l6ZUxvY2tlZCB7IGZhbHNlIH07CisgICAgYm9v bCBtX3RpbGVTaXplTG9ja2VkIHsgZmFsc2UgfTsKICAgICBib29sIG1faXNUaWxlU2l6ZVVwZGF0 ZURlbGF5RGlzYWJsZWRGb3JUZXN0aW5nIHsgZmFsc2UgfTsKIAogICAgIENvbG9yIG1fdGlsZURl YnVnQm9yZGVyQ29sb3I7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jYS9UaWxlR3JpZC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j YS9UaWxlR3JpZC5jcHAKaW5kZXggMTE2M2QxNDRkNjM3Mjk4MTYyZWZjMzM3MTFjNTE3M2IzODJl YzQyOC4uNjg1MWNjM2IxOWJkYmU1MzM5MjFhYTQ4YmVmNzYxZDkwNmQ5MjM3OSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvVGlsZUdyaWQuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL1RpbGVHcmlkLmNwcApAQCAtMzY4 LDcgKzM2OCw3IEBAIHZvaWQgVGlsZUdyaWQ6OnJldmFsaWRhdGVUaWxlcyhUaWxlVmFsaWRhdGlv blBvbGljeSB2YWxpZGF0aW9uUG9saWN5KQogICAgIFNlY29uZHMgbWluaW11bVJldmFsaWRhdGlv blRpbWVyRHVyYXRpb24gPSBTZWNvbmRzOjppbmZpbml0eSgpOwogICAgIGJvb2wgbmVlZHNUaWxl UmV2YWxpZGF0aW9uID0gZmFsc2U7CiAgICAgCi0gICAgYXV0byB0aWxlU2l6ZSA9IG1fY29udHJv bGxlci50aWxlU2l6ZSgpOworICAgIGF1dG8gdGlsZVNpemUgPSBtX2NvbnRyb2xsZXIuY29tcHV0 ZVRpbGVTaXplKCk7CiAgICAgaWYgKHRpbGVTaXplICE9IG1fdGlsZVNpemUpIHsKICAgICAgICAg cmVtb3ZlQWxsVGlsZXMoKTsKICAgICAgICAgbV90aWxlU2l6ZSA9IHRpbGVTaXplOwo=