<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>191348</bug_id>
          
          <creation_ts>2018-11-07 00:17:05 -0800</creation_ts>
          <short_desc>run-bindings-tests is timing out in some WinCairo bots</short_desc>
          <delta_ts>2018-11-11 18:03:28 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Fujii Hironori">fujii</reporter>
          <assigned_to name="Fujii Hironori">fujii</assigned_to>
          <cc>achristensen</cc>
    
    <cc>annulen</cc>
    
    <cc>bfulgham</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>fpizlo</cc>
    
    <cc>ggaren</cc>
    
    <cc>glenn</cc>
    
    <cc>lforschler</cc>
    
    <cc>pvollan</cc>
    
    <cc>ross.kirsling</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1475900</commentid>
    <comment_count>0</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2018-11-07 00:17:05 -0800</bug_when>
    <thetext>[WinCairo] run-bindings-tests is timing out in some bots

This issue is happening on wincairo-wkl-release-tests-02, but on wincairo-wkl-release-tests-01.

For example,

https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Release%20%28Tests%29/builds/2426/steps/bindings-generation-tests/logs/stdio

&gt; command timed out: 1200 seconds without output running [&apos;python&apos;, &apos;./Tools/Scripts/run-bindings-tests&apos;], attempting to kill
&gt; program finished with exit code 1
&gt; elapsedTime=1200.300000


If I set a env var PYTHONUNBUFFERED=1 in wincairo-wkl-release-tests-02, it passed.

https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Release%20%28Tests%29/builds/2430/steps/bindings-generation-tests/logs/stdio

&gt; PYTHONUNBUFFERED=1
(...)
&gt; All tests PASS!
&gt; program finished with exit code 0
&gt; elapsedTime=2069.417000</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1475903</commentid>
    <comment_count>1</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2018-11-07 00:19:51 -0800</bug_when>
    <thetext>BuildBot kills run-bindings-tests if it outputs nothing for 20 minutes.
run-bindings-tests runs very slowly in WinCairo Docker.
It takes more than 30 minutes to complete.
And, Python buffers the progress output.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1475920</commentid>
    <comment_count>2</comment_count>
      <attachid>354073</attachid>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2018-11-07 01:18:59 -0800</bug_when>
    <thetext>Created attachment 354073
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1475998</commentid>
    <comment_count>3</comment_count>
    <who name="Ross Kirsling">ross.kirsling</who>
    <bug_when>2018-11-07 08:47:26 -0800</bug_when>
    <thetext>Seems reasonable to me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1476000</commentid>
    <comment_count>4</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2018-11-07 08:53:22 -0800</bug_when>
    <thetext>Geoff, Filip, any objection to adding this flush? Seems reasonable.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1476824</commentid>
    <comment_count>5</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2018-11-09 00:26:44 -0800</bug_when>
    <thetext>Review, please.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1477445</commentid>
    <comment_count>6</comment_count>
      <attachid>354073</attachid>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2018-11-11 18:01:55 -0800</bug_when>
    <thetext>Comment on attachment 354073
Patch

Clearing flags on attachment: 354073

Committed r238081: &lt;https://trac.webkit.org/changeset/238081&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1477446</commentid>
    <comment_count>7</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2018-11-11 18:01:58 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1477448</commentid>
    <comment_count>8</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-11-11 18:03:28 -0800</bug_when>
    <thetext>&lt;rdar://problem/45977718&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>354073</attachid>
            <date>2018-11-07 01:18:59 -0800</date>
            <delta_ts>2018-11-11 18:01:55 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-191348-20181107181858.patch</filename>
            <type>text/plain</type>
            <size>1604</size>
            <attacher name="Fujii Hironori">fujii</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3OTExCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDg5ZmE5MTMzZTU3OGRiZTlkYjZhY2IzMjdjMWFhYTRi
N2Y2NDFkNS4uMTkwYTk1OTVlZGVkZWUwNWQ0NWEzNDExYmY5YmE2OTZiYWQ0N2EwMyAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5
IEBACisyMDE4LTExLTA3ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t
PgorCisgICAgICAgIHJ1bi1iaW5kaW5ncy10ZXN0cyBpcyB0aW1pbmcgb3V0IGluIHNvbWUgV2lu
Q2Fpcm8gYm90cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9MTkxMzQ4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg
ICAgQnVpbGRCb3Qga2lsbHMgcnVuLWJpbmRpbmdzLXRlc3RzIGlmIGl0IG91dHB1dHMgbm90aGlu
ZyBmb3IgMjAKKyAgICAgICAgbWludXRlcy4gcnVuLWJpbmRpbmdzLXRlc3RzIHJ1bnMgdmVyeSBz
bG93bHkgaW4gV2luQ2Fpcm8gRG9ja2VyLAorICAgICAgICBhbmQgaXQgdGFrZXMgbW9yZSB0aGFu
IDMwIG1pbnV0ZXMgdG8gZmluaXNoLiBBbmQsIFdpbmRvd3MgUHl0aG9uCisgICAgICAgIGJ1ZmZl
cnMgdGhlIHByb2dyZXNzIG91dHB1dC4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvYmlu
ZGluZ3MvbWFpbi5weToKKyAgICAgICAgKEJpbmRpbmdzVGVzdHMuZGV0ZWN0X2NoYW5nZXMpOiBD
YWxsIHN5cy5zdGRvdXQuZmx1c2goKSBhZnRlciB0aGUKKyAgICAgICAgdGVzdCBjYXNlIHJlc3Vs
dCBpcyBvdXRwdXQuCisKIDIwMTgtMTEtMDYgIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBw
bGUuY29tPgogCiAgICAgICAgIFtld3MtYXBwXSBBZGQgVVJMIGNvbmZpZ3VyYXRpb24gZm9yIE9w
ZW5Tb3VyY2UgRVdTIERqYW5nbyBhcHAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0
cHkvYmluZGluZ3MvbWFpbi5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvYmluZGluZ3MvbWFp
bi5weQppbmRleCAyMDkzN2JlZDZkOWQ3YjhhNjIzODAzODhiN2VlYzVlYmFkNGI0OTMxLi42NWE1
ODhlYmU0NTgwMjBjOWY1M2Q1Mjg5OGIxNWQxODk1OGZmNTQwIDEwMDY0NAotLS0gYS9Ub29scy9T
Y3JpcHRzL3dlYmtpdHB5L2JpbmRpbmdzL21haW4ucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJr
aXRweS9iaW5kaW5ncy9tYWluLnB5CkBAIC0xMjcsNiArMTI3LDcgQEAgY2xhc3MgQmluZGluZ3NU
ZXN0czoKICAgICAgICAgICAgICAgICAgICAgc2VsZi5mYWlsdXJlcy5hcHBlbmQoIiglcykgJXMi
ICUgKGdlbmVyYXRvciwgb3V0cHV0X2ZpbGUpKQogICAgICAgICAgICAgZWxpZiBzZWxmLnZlcmJv
c2U6CiAgICAgICAgICAgICAgICAgcHJpbnQoJ1BBU1M6ICglcykgJXMnICUgKGdlbmVyYXRvciwg
b3V0cHV0X2ZpbGUpKQorICAgICAgICAgICAgc3lzLnN0ZG91dC5mbHVzaCgpCiAgICAgICAgIHJl
dHVybiBjaGFuZ2VzX2ZvdW5kCiAKICAgICBkZWYgdGVzdF9tYXRjaGVzX3BhdHRlcm5zKHNlbGYs
IHRlc3QpOgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>