191342 2018-11-06 18:52:09 -0800 Web Inspector: Debugger Popover does not work when paused in Worker 2018-11-08 14:44:29 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1475822 0 joepeck 2018-11-06 18:52:09 -0800 Debugger Popover does not work when paused in Worker Steps to Reproduce: 1. Pause in a worker's onmessage 2. Hover over something like `event` => No popover Notes: • Wrong target seems to be getting used for popover related code. 1475824 1 354045 joepeck 2018-11-06 18:54:02 -0800 Created attachment 354045 [PATCH] Proposed Fix 1475879 2 354045 hi 2018-11-06 22:08:05 -0800 Comment on attachment 354045 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=354045&action=review > Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js:1728 > + let target = WI.debuggerManager.activeCallFrame ? WI.debuggerManager.activeCallFrame.target : this.target; NIT: considering that `WI.debuggerManager.activeCallFrame` is used in a few places in this function, making it into a separate variable seems reasonable (e.g. `activeCallFrame` or even just `callFrame`) 1475880 3 hi 2018-11-06 22:08:25 -0800 (In reply to Devin Rousso from comment #2) Forgot, r=me :P 1476663 4 354045 commit-queue 2018-11-08 14:43:59 -0800 Comment on attachment 354045 [PATCH] Proposed Fix Clearing flags on attachment: 354045 Committed r238003: <https://trac.webkit.org/changeset/238003> 1476664 5 commit-queue 2018-11-08 14:44:01 -0800 All reviewed patches have been landed. Closing bug. 1476665 6 webkit-bug-importer 2018-11-08 14:44:29 -0800 <rdar://problem/45924333> 354045 2018-11-06 18:54:02 -0800 2018-11-08 14:43:59 -0800 [PATCH] Proposed Fix debugger-worker-1.patch text/plain 2916 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDg0YzIxN2FiYzY5Li5jY2IxNTliNDVhYSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMTEtMDYgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBEZWJ1Z2dlciBQb3BvdmVyIGRvZXMgbm90IHdvcmsgd2hlbiBwYXVzZWQgaW4gV29ya2VyCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTEzNDIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRl cmZhY2UvVmlld3MvU291cmNlQ29kZVRleHRFZGl0b3IuanM6CisgICAgICAgIChXSS5Tb3VyY2VD b2RlVGV4dEVkaXRvci5wcm90b3R5cGUuX3Rva2VuVHJhY2tpbmdDb250cm9sbGVySGlnaGxpZ2h0 ZWRKYXZhU2NyaXB0RXhwcmVzc2lvbi5wb3B1bGF0ZSk6CisgICAgICAgIChXSS5Tb3VyY2VDb2Rl VGV4dEVkaXRvci5wcm90b3R5cGUuX3Rva2VuVHJhY2tpbmdDb250cm9sbGVySGlnaGxpZ2h0ZWRK YXZhU2NyaXB0RXhwcmVzc2lvbik6CisgICAgICAgIFdoZW4gcmVjZWl2aW5nIHRoZSByZXN1bHQg b2YgdGhlIHBvcG92ZXIgZXZhbHVhdGlvbiBhc3NvY2lhdGUgdGhlIFJlbW90ZU9iamVjdCB3aXRo CisgICAgICAgIHRoZSB0YXJnZXQgd2UgdXNlZCB0byBldmFsdWF0ZSAoc3VjaCBhcyB0aGUgRGVi dWdnZXIgY2FsbCBmcmFtZSksIG5vdCB0aGUgdGFyZ2V0CisgICAgICAgIGFzc29jaWF0ZWQgd2l0 aCB0aGUgZWRpdG9yLgorCiAyMDE4LTExLTA2ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0Bh cHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogRml4ICJKYXZhc2NyaXB0IiA9PiAi SmF2YVNjcmlwdCIgZW51bSBpbiBwcm90b2NvbCBnZW5lcmF0ZWQgb2JqZWN0cwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU291cmNlQ29kZVRl eHRFZGl0b3IuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9T b3VyY2VDb2RlVGV4dEVkaXRvci5qcwppbmRleCAzZWRiYzFjODZhMC4uODdkZWM5YTIzNjkgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NvdXJj ZUNvZGVUZXh0RWRpdG9yLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL1NvdXJjZUNvZGVUZXh0RWRpdG9yLmpzCkBAIC0xNzI1LDYgKzE3MjUsOSBAQCBX SS5Tb3VyY2VDb2RlVGV4dEVkaXRvciA9IGNsYXNzIFNvdXJjZUNvZGVUZXh0RWRpdG9yIGV4dGVu ZHMgV0kuVGV4dEVkaXRvcgogICAgIHsKICAgICAgICAgY29uc29sZS5hc3NlcnQoY2FuZGlkYXRl LmV4cHJlc3Npb24pOwogCisgICAgICAgIGxldCB0YXJnZXQgPSBXSS5kZWJ1Z2dlck1hbmFnZXIu YWN0aXZlQ2FsbEZyYW1lID8gV0kuZGVidWdnZXJNYW5hZ2VyLmFjdGl2ZUNhbGxGcmFtZS50YXJn ZXQgOiB0aGlzLnRhcmdldDsKKyAgICAgICAgbGV0IGV4cHJlc3Npb24gPSBhcHBlbmRXZWJJbnNw ZWN0b3JTb3VyY2VVUkwoY2FuZGlkYXRlLmV4cHJlc3Npb24pOworCiAgICAgICAgIGZ1bmN0aW9u IHBvcHVsYXRlKGVycm9yLCByZXN1bHQsIHdhc1Rocm93bikKICAgICAgICAgewogICAgICAgICAg ICAgaWYgKGVycm9yIHx8IHdhc1Rocm93bikKQEAgLTE3MzMsNyArMTczNiw3IEBAIFdJLlNvdXJj ZUNvZGVUZXh0RWRpdG9yID0gY2xhc3MgU291cmNlQ29kZVRleHRFZGl0b3IgZXh0ZW5kcyBXSS5U ZXh0RWRpdG9yCiAgICAgICAgICAgICBpZiAoY2FuZGlkYXRlICE9PSB0aGlzLnRva2VuVHJhY2tp bmdDb250cm9sbGVyLmNhbmRpZGF0ZSkKICAgICAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAg ICAgICAgIGxldCBkYXRhID0gV0kuUmVtb3RlT2JqZWN0LmZyb21QYXlsb2FkKHJlc3VsdCwgdGhp cy50YXJnZXQpOworICAgICAgICAgICAgbGV0IGRhdGEgPSBXSS5SZW1vdGVPYmplY3QuZnJvbVBh eWxvYWQocmVzdWx0LCB0YXJnZXQpOwogICAgICAgICAgICAgc3dpdGNoIChkYXRhLnR5cGUpIHsK ICAgICAgICAgICAgIGNhc2UgImZ1bmN0aW9uIjoKICAgICAgICAgICAgICAgICB0aGlzLl9zaG93 UG9wb3ZlckZvckZ1bmN0aW9uKGRhdGEpOwpAQCAtMTc1NCw4ICsxNzU3LDYgQEAgV0kuU291cmNl Q29kZVRleHRFZGl0b3IgPSBjbGFzcyBTb3VyY2VDb2RlVGV4dEVkaXRvciBleHRlbmRzIFdJLlRl eHRFZGl0b3IKICAgICAgICAgICAgIH0KICAgICAgICAgfQogCi0gICAgICAgIGxldCB0YXJnZXQg PSBXSS5kZWJ1Z2dlck1hbmFnZXIuYWN0aXZlQ2FsbEZyYW1lID8gV0kuZGVidWdnZXJNYW5hZ2Vy LmFjdGl2ZUNhbGxGcmFtZS50YXJnZXQgOiB0aGlzLnRhcmdldDsKLSAgICAgICAgbGV0IGV4cHJl c3Npb24gPSBhcHBlbmRXZWJJbnNwZWN0b3JTb3VyY2VVUkwoY2FuZGlkYXRlLmV4cHJlc3Npb24p OwogCiAgICAgICAgIGlmIChXSS5kZWJ1Z2dlck1hbmFnZXIuYWN0aXZlQ2FsbEZyYW1lKSB7CiAg ICAgICAgICAgICB0YXJnZXQuRGVidWdnZXJBZ2VudC5ldmFsdWF0ZU9uQ2FsbEZyYW1lLmludm9r ZSh7Y2FsbEZyYW1lSWQ6IFdJLmRlYnVnZ2VyTWFuYWdlci5hY3RpdmVDYWxsRnJhbWUuaWQsIGV4 cHJlc3Npb24sIG9iamVjdEdyb3VwOiAicG9wb3ZlciIsIGRvTm90UGF1c2VPbkV4Y2VwdGlvbnNB bmRNdXRlQ29uc29sZTogdHJ1ZX0sIHBvcHVsYXRlLmJpbmQodGhpcyksIHRhcmdldC5EZWJ1Z2dl ckFnZW50KTsK