<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>191339</bug_id>
          
          <creation_ts>2018-11-06 16:48:47 -0800</creation_ts>
          <short_desc>ServiceWorker Inspector: Uncaught Exception: null is not an object (evaluating &apos;resource.target.addResource&apos;)</short_desc>
          <delta_ts>2018-11-06 23:33:39 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Inspector</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc>https://airhorner.com/</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Joseph Pecoraro">joepeck</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>inspector-bugzilla-changes</cc>
    
    <cc>joepeck</cc>
    
    <cc>mattbaker</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1475767</commentid>
    <comment_count>0</comment_count>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2018-11-06 16:48:47 -0800</bug_when>
    <thetext>* Steps to Reproduce
1. Inspect ServiceWorker on airhorner.com
2. Reload the airhorner.com page
  =&gt; Exception in inspector for script with `targetId` of &quot;serviceWorkerScriptLoad:&quot; which is unexpected

-------
Inspected URL:        https://airhorner.com/
Loading completed:    true
Dispatch Source:      Protocol Event

Protocol Event:
{&quot;method&quot;:&quot;Network.requestWillBeSent&quot;,&quot;params&quot;:{&quot;requestId&quot;:&quot;0.28&quot;,&quot;frameId&quot;:&quot;&quot;,&quot;loaderId&quot;:&quot;&quot;,&quot;documentURL&quot;:&quot;https://airhorner.com/sw.js&quot;,&quot;request&quot;:{&quot;url&quot;:&quot;https://airhorner.com/sw.js&quot;,&quot;method&quot;:&quot;GET&quot;,&quot;headers&quot;:{&quot;Service-Worker&quot;:&quot;script&quot;}},&quot;timestamp&quot;:3.59948630600411,&quot;walltime&quot;:1541551630.689134,&quot;initiator&quot;:{&quot;type&quot;:&quot;other&quot;},&quot;targetId&quot;:&quot;serviceWorkerScriptLoad:&quot;}}

Uncaught Exceptions:
 - null is not an object (evaluating &apos;resource.target.addResource&apos;) (at NetworkManager.js:619:28)
    _addNewResourceToFrameOrTarget @ NetworkManager.js:619:28
    resourceRequestWillBeSent @ NetworkManager.js:274:55
    requestWillBeSent @ NetworkObserver.js:41:52
    dispatchEvent @ InspectorBackend.js:305:42
    _dispatchEvent @ Connection.js:194:32
    dispatch @ Connection.js:72:32
    dispatch @ InspectorBackend.js:154:49
    dispatchNextQueuedMessageFromBackend @ MessageDispatcher.js:42:34

Additional Details:
    cause --&gt; An uncaught exception was thrown while handling event: Network.requestWillBeSent</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1475768</commentid>
    <comment_count>1</comment_count>
      <attachid>354030</attachid>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2018-11-06 16:49:53 -0800</bug_when>
    <thetext>Created attachment 354030
[PATCH] Proposed Fix</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1475799</commentid>
    <comment_count>2</comment_count>
      <attachid>354030</attachid>
    <who name="Matt Baker">mattbaker</who>
    <bug_when>2018-11-06 17:54:21 -0800</bug_when>
    <thetext>Comment on attachment 354030
[PATCH] Proposed Fix

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1475893</commentid>
    <comment_count>3</comment_count>
      <attachid>354030</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-11-06 23:32:52 -0800</bug_when>
    <thetext>Comment on attachment 354030
[PATCH] Proposed Fix

Clearing flags on attachment: 354030

Committed r237917: &lt;https://trac.webkit.org/changeset/237917&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1475894</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-11-06 23:32:53 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1475895</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-11-06 23:33:39 -0800</bug_when>
    <thetext>&lt;rdar://problem/45867252&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>354030</attachid>
            <date>2018-11-06 16:49:53 -0800</date>
            <delta_ts>2018-11-06 23:32:52 -0800</delta_ts>
            <desc>[PATCH] Proposed Fix</desc>
            <filename>sw-1.patch</filename>
            <type>text/plain</type>
            <size>1510</size>
            <attacher name="Joseph Pecoraro">joepeck</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCAxYjY5NGRhMWJkYi4uODM3MzRkYzZlNzggMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNCBAQAorMjAxOC0xMS0wNiAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUu
Y29tPgorCisgICAgICAgIFNlcnZpY2VXb3JrZXIgSW5zcGVjdG9yOiBVbmNhdWdodCBFeGNlcHRp
b246IG51bGwgaXMgbm90IGFuIG9iamVjdCAoZXZhbHVhdGluZyAncmVzb3VyY2UudGFyZ2V0LmFk
ZFJlc291cmNlJykKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTE5MTMzOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg
ICAgICogd29ya2Vycy9zZXJ2aWNlL1NlcnZpY2VXb3JrZXJKb2IuY3BwOgorICAgICAgICAoV2Vi
Q29yZTo6U2VydmljZVdvcmtlckpvYjo6ZmV0Y2hTY3JpcHRXaXRoQ29udGV4dCk6CisgICAgICAg
IFVzZSB0aGUgU2VydmljZSBXb3JrZXIncyBpZGVudGlmaWVyLCBub3QgdGhpcyBzdGF0aWMgYnV0
IG90aGVyd2lzZSB1bmtub3duIGlkZW50aWZpZXIuCisKIDIwMTgtMTEtMDUgIE15bGVzIEMuIE1h
eGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAogICAgICAgICBQYXJzaW5nIHN1cHBvcnQg
Zm9yIHRleHQtdW5kZXJsaW5lLW9mZnNldCBhbmQgdGV4dC1kZWNvcmF0aW9uLXRoaWNrbmVzcwpk
aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvd29ya2Vycy9zZXJ2aWNlL1NlcnZpY2VXb3JrZXJK
b2IuY3BwIGIvU291cmNlL1dlYkNvcmUvd29ya2Vycy9zZXJ2aWNlL1NlcnZpY2VXb3JrZXJKb2Iu
Y3BwCmluZGV4IDZkMjQ0YTA0ZjczLi40ODhiODU3ZmI2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YkNvcmUvd29ya2Vycy9zZXJ2aWNlL1NlcnZpY2VXb3JrZXJKb2IuY3BwCisrKyBiL1NvdXJjZS9X
ZWJDb3JlL3dvcmtlcnMvc2VydmljZS9TZXJ2aWNlV29ya2VySm9iLmNwcApAQCAtOTUsNyArOTUs
NyBAQCB2b2lkIFNlcnZpY2VXb3JrZXJKb2I6OmZldGNoU2NyaXB0V2l0aENvbnRleHQoU2NyaXB0
RXhlY3V0aW9uQ29udGV4dCYgY29udGV4dCwgRgogICAgIG1fc2NyaXB0TG9hZGVyID0gV29ya2Vy
U2NyaXB0TG9hZGVyOjpjcmVhdGUoKTsKIAogICAgIFJlc291cmNlUmVxdWVzdCByZXF1ZXN0IHsg
bV9qb2JEYXRhLnNjcmlwdFVSTCB9OwotICAgIHJlcXVlc3Quc2V0SW5pdGlhdG9ySWRlbnRpZmll
cigic2VydmljZVdvcmtlclNjcmlwdExvYWQ6Iik7CisgICAgcmVxdWVzdC5zZXRJbml0aWF0b3JJ
ZGVudGlmaWVyKGNvbnRleHQucmVzb3VyY2VSZXF1ZXN0SWRlbnRpZmllcigpKTsKICAgICByZXF1
ZXN0LmFkZEhUVFBIZWFkZXJGaWVsZCgiU2VydmljZS1Xb3JrZXIiX3MsICJzY3JpcHQiX3MpOwog
CiAgICAgRmV0Y2hPcHRpb25zIG9wdGlvbnM7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>