191295 2018-11-05 19:17:37 -0800 RealtimeOutgoingAudioSourceCocoa should unobserve its source at destruction time 2018-11-06 08:15:22 -0800 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf commit-queue eric.carlson webkit-bug-importer youennf oldest_to_newest 1475381 0 youennf 2018-11-05 19:17:37 -0800 Currently it is done at RealtimeOutgoingAudioSource destruction time which might be too late. 1475382 1 353941 youennf 2018-11-05 19:20:01 -0800 Created attachment 353941 Patch 1475542 2 353941 commit-queue 2018-11-06 08:14:36 -0800 Comment on attachment 353941 Patch Clearing flags on attachment: 353941 Committed r237867: <https://trac.webkit.org/changeset/237867> 1475543 3 commit-queue 2018-11-06 08:14:38 -0800 All reviewed patches have been landed. Closing bug. 1475545 4 webkit-bug-importer 2018-11-06 08:15:22 -0800 <rdar://problem/45843542> 353941 2018-11-05 19:20:01 -0800 2018-11-06 08:14:36 -0800 Patch bug-191295-20181106102006.patch text/plain 5271 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3ODM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTVhYWEyZGU3MjM4Yjkw Y2U4OTA0YzczOWEyYTYwZmQ4YTFlOWY5Mi4uMWUyNWEzOWYyMmI5ZWMyYzQwN2I3YWUyNTEyYmM2 MzFiZDc3MDU0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE4LTExLTA1ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBSZWFsdGltZU91dGdvaW5n QXVkaW9Tb3VyY2VDb2NvYSBzaG91bGQgdW5vYnNlcnZlIGl0cyBzb3VyY2UgYXQgZGVzdHJ1Y3Rp b24gdGltZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTkxMjk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg TWFrZSBSZWFsdGltZU91dGdvaW5nQXVkaW9Tb3VyY2Ugc3ViY2xhc3NlcyB1bm9ic2VydmUgdGhl aXIgc291cmNlCisgICAgICAgIGluc2lkZSB0aGVpciBkZXN0cnVjdG9yIGluc3RlYWQgb2YgUmVh bHRpbWVPdXRnb2luZ0F1ZGlvU291cmNlLgorICAgICAgICBUaGlzIGlzIGNvbnNpc3RlbnQgd2l0 aCBob3cgc3RhcnRpbmcgdG8gb2JzZXJ2ZSB3b3Jrcy4KKyAgICAgICAgQ292ZXJlZCBieSBleGlz dGluZyB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL21lZGlhc3RyZWFtL1JlYWx0aW1lT3V0 Z29pbmdBdWRpb1NvdXJjZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZWFsdGltZU91dGdvaW5n QXVkaW9Tb3VyY2U6OnVub2JzZXJ2ZVNvdXJjZSk6CisgICAgICAgICogcGxhdGZvcm0vbWVkaWFz dHJlYW0vUmVhbHRpbWVPdXRnb2luZ0F1ZGlvU291cmNlLmg6CisgICAgICAgICogcGxhdGZvcm0v bWVkaWFzdHJlYW0vZ3N0cmVhbWVyL1JlYWx0aW1lT3V0Z29pbmdBdWRpb1NvdXJjZUxpYldlYlJU Qy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZWFsdGltZU91dGdvaW5nQXVkaW9Tb3VyY2VMaWJX ZWJSVEM6On5SZWFsdGltZU91dGdvaW5nQXVkaW9Tb3VyY2VMaWJXZWJSVEMpOgorICAgICAgICAq IHBsYXRmb3JtL21lZGlhc3RyZWFtL21hYy9SZWFsdGltZU91dGdvaW5nQXVkaW9Tb3VyY2VDb2Nv YS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZWFsdGltZU91dGdvaW5nQXVkaW9Tb3VyY2VDb2Nv YTo6UmVhbHRpbWVPdXRnb2luZ0F1ZGlvU291cmNlQ29jb2EpOgorICAgICAgICAoV2ViQ29yZTo6 UmVhbHRpbWVPdXRnb2luZ0F1ZGlvU291cmNlQ29jb2E6On5SZWFsdGltZU91dGdvaW5nQXVkaW9T b3VyY2VDb2NvYSk6CisgICAgICAgICogcGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFjL1JlYWx0aW1l T3V0Z29pbmdBdWRpb1NvdXJjZUNvY29hLmg6CisKIDIwMTgtMTEtMDUgIEVyaWMgQ2FybHNvbiAg PGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgW01lZGlhU3RyZWFtXSBBbiBhdWRp byB0cmFjayBzaG91bGQgYmUgbXV0ZWQgd2hlbiBjYXB0dXJlIGlzIGludGVycnVwdGVkIGJ5IHRo ZSBPUy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL1Jl YWx0aW1lT3V0Z29pbmdBdWRpb1NvdXJjZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9t ZWRpYXN0cmVhbS9SZWFsdGltZU91dGdvaW5nQXVkaW9Tb3VyY2UuY3BwCmluZGV4IGFmYTEzZTFl YjVmNDU4MmYwZjhjNDJhYzQ3Y2EzOGQ4YjY5Y2QzMDIuLjVlZjc0NDRmNjZmZGZjNmI3ZWJlZDcx ZDg4MWJmOGFjYmExMDAzZTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21l ZGlhc3RyZWFtL1JlYWx0aW1lT3V0Z29pbmdBdWRpb1NvdXJjZS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vUmVhbHRpbWVPdXRnb2luZ0F1ZGlvU291cmNlLmNw cApAQCAtNDcsNiArNDcsMTEgQEAgdm9pZCBSZWFsdGltZU91dGdvaW5nQXVkaW9Tb3VyY2U6Om9i c2VydmVTb3VyY2UoKQogICAgIGluaXRpYWxpemVDb252ZXJ0ZXIoKTsKIH0KIAordm9pZCBSZWFs dGltZU91dGdvaW5nQXVkaW9Tb3VyY2U6OnVub2JzZXJ2ZVNvdXJjZSgpCit7CisgICAgbV9hdWRp b1NvdXJjZS0+cmVtb3ZlT2JzZXJ2ZXIoKnRoaXMpOworfQorCiBib29sIFJlYWx0aW1lT3V0Z29p bmdBdWRpb1NvdXJjZTo6c2V0U291cmNlKFJlZjxNZWRpYVN0cmVhbVRyYWNrUHJpdmF0ZT4mJiBu ZXdTb3VyY2UpCiB7CiAgICAgbV9hdWRpb1NvdXJjZS0+cmVtb3ZlT2JzZXJ2ZXIoKnRoaXMpOwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vUmVhbHRpbWVP dXRnb2luZ0F1ZGlvU291cmNlLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVh bS9SZWFsdGltZU91dGdvaW5nQXVkaW9Tb3VyY2UuaAppbmRleCA4NjUxZWQxMDQ2ZTFiNzRmYjdk YWE4NmExZDc2YTM5ZWU2YWEzNTQ2Li42OTRiZGFlNWQwODkzZjIxOTAyMGZlMzYxOWFkMDE4OTA1 MDc4MWVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9S ZWFsdGltZU91dGdvaW5nQXVkaW9Tb3VyY2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9tZWRpYXN0cmVhbS9SZWFsdGltZU91dGdvaW5nQXVkaW9Tb3VyY2UuaApAQCAtNjUsNiArNjUs NyBAQCBwcm90ZWN0ZWQ6CiAgICAgZXhwbGljaXQgUmVhbHRpbWVPdXRnb2luZ0F1ZGlvU291cmNl KFJlZjxNZWRpYVN0cmVhbVRyYWNrUHJpdmF0ZT4mJik7CiAKICAgICB2b2lkIG9ic2VydmVTb3Vy Y2UoKTsKKyAgICB2b2lkIHVub2JzZXJ2ZVNvdXJjZSgpOwogCiAgICAgdmlydHVhbCB2b2lkIHB1 bGxBdWRpb0RhdGEoKSB7IH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bWVkaWFzdHJlYW0vZ3N0cmVhbWVyL1JlYWx0aW1lT3V0Z29pbmdBdWRpb1NvdXJjZUxpYldlYlJU Qy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9nc3RyZWFtZXIvUmVh bHRpbWVPdXRnb2luZ0F1ZGlvU291cmNlTGliV2ViUlRDLmNwcAppbmRleCAwMTIwYWMwODNkZGNh M2RjYWFmNGU0ZDY2MzUxODk3YjdiNTVlYzRjLi4wNjBmYzEwOTZjZTU0ZjU3MjJkYWI1NjRkNzQ3 NmFjNzBmM2NmY2YyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0 cmVhbS9nc3RyZWFtZXIvUmVhbHRpbWVPdXRnb2luZ0F1ZGlvU291cmNlTGliV2ViUlRDLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9nc3RyZWFtZXIvUmVhbHRp bWVPdXRnb2luZ0F1ZGlvU291cmNlTGliV2ViUlRDLmNwcApAQCAtMzksNiArMzksNyBAQCBSZWFs dGltZU91dGdvaW5nQXVkaW9Tb3VyY2VMaWJXZWJSVEM6OlJlYWx0aW1lT3V0Z29pbmdBdWRpb1Nv dXJjZUxpYldlYlJUQyhSZWY8TQogCiBSZWFsdGltZU91dGdvaW5nQXVkaW9Tb3VyY2VMaWJXZWJS VEM6On5SZWFsdGltZU91dGdvaW5nQXVkaW9Tb3VyY2VMaWJXZWJSVEMoKQogeworICAgIHVub2Jz ZXJ2ZVNvdXJjZSgpOwogICAgIGlmIChtX3NhbXBsZUNvbnZlcnRlcikKICAgICAgICAgZ19jbGVh cl9wb2ludGVyKCZtX3NhbXBsZUNvbnZlcnRlciwgZ3N0X2F1ZGlvX2NvbnZlcnRlcl9mcmVlKTsK IH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL21hYy9S ZWFsdGltZU91dGdvaW5nQXVkaW9Tb3VyY2VDb2NvYS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9tZWRpYXN0cmVhbS9tYWMvUmVhbHRpbWVPdXRnb2luZ0F1ZGlvU291cmNlQ29jb2EuY3Bw CmluZGV4IGMwZWEzMjRkYTgyMzY3MGY0YjQyNGNkMTVjMzMxZmU0OWI1MjI5MWIuLjJmYmUwNjc4 YjBhZmMxNmE3OTZhNDhlYzZlODgzN2FiM2MyMWVjMjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL21hYy9SZWFsdGltZU91dGdvaW5nQXVkaW9Tb3VyY2VD b2NvYS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFjL1Jl YWx0aW1lT3V0Z29pbmdBdWRpb1NvdXJjZUNvY29hLmNwcApAQCAtNTAsNiArNTAsMTEgQEAgUmVh bHRpbWVPdXRnb2luZ0F1ZGlvU291cmNlQ29jb2E6OlJlYWx0aW1lT3V0Z29pbmdBdWRpb1NvdXJj ZUNvY29hKFJlZjxNZWRpYVN0cmUKICAgICBvYnNlcnZlU291cmNlKCk7CiB9CiAKK1JlYWx0aW1l T3V0Z29pbmdBdWRpb1NvdXJjZUNvY29hOjp+UmVhbHRpbWVPdXRnb2luZ0F1ZGlvU291cmNlQ29j b2EoKQoreworICAgIHVub2JzZXJ2ZVNvdXJjZSgpOworfQorCiBSZWY8UmVhbHRpbWVPdXRnb2lu Z0F1ZGlvU291cmNlPiBSZWFsdGltZU91dGdvaW5nQXVkaW9Tb3VyY2U6OmNyZWF0ZShSZWY8TWVk aWFTdHJlYW1UcmFja1ByaXZhdGU+JiYgYXVkaW9Tb3VyY2UpCiB7CiAgICAgcmV0dXJuIFJlYWx0 aW1lT3V0Z29pbmdBdWRpb1NvdXJjZUNvY29hOjpjcmVhdGUoV1RGTW92ZShhdWRpb1NvdXJjZSkp OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFjL1Jl YWx0aW1lT3V0Z29pbmdBdWRpb1NvdXJjZUNvY29hLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9tZWRpYXN0cmVhbS9tYWMvUmVhbHRpbWVPdXRnb2luZ0F1ZGlvU291cmNlQ29jb2EuaAppbmRl eCA4NTAwYzUzZjJmNGIwZmE5OTZkMTdlZDY3YTc3MDhjMTA0MDc2NjE1Li43NGI3NDY5MGMwOWQ0 MTEzMWM1OGM0NDZiNTBiMDZiMzU3Y2FjNTdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvUmVhbHRpbWVPdXRnb2luZ0F1ZGlvU291cmNlQ29jb2Eu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvUmVhbHRpbWVP dXRnb2luZ0F1ZGlvU291cmNlQ29jb2EuaApAQCAtNDMsNiArNDMsNyBAQCBwdWJsaWM6CiAKIHBy aXZhdGU6CiAgICAgZXhwbGljaXQgUmVhbHRpbWVPdXRnb2luZ0F1ZGlvU291cmNlQ29jb2EoUmVm PE1lZGlhU3RyZWFtVHJhY2tQcml2YXRlPiYmKTsKKyAgICB+UmVhbHRpbWVPdXRnb2luZ0F1ZGlv U291cmNlQ29jb2EoKTsKIAogICAgIHZvaWQgYXVkaW9TYW1wbGVzQXZhaWxhYmxlKGNvbnN0IE1l ZGlhVGltZSYsIGNvbnN0IFBsYXRmb3JtQXVkaW9EYXRhJiwgY29uc3QgQXVkaW9TdHJlYW1EZXNj cmlwdGlvbiYsIHNpemVfdCkgZmluYWw7CiAK