191288 2018-11-05 16:49:55 -0800 Feature flags not present for Visual Studio when using build-webkit 2018-11-06 14:12:29 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 don.olmstead don.olmstead annulen bfulgham commit-queue dbates ews-watchlist fujii lforschler mcatanzaro pvollan webkit-bug-importer oldest_to_newest 1475340 0 don.olmstead 2018-11-05 16:49:55 -0800 Currently none of the feature flags selected in build-webkit end up being passed into a Visual Studio based build. 1475341 1 353925 don.olmstead 2018-11-05 16:51:25 -0800 Created attachment 353925 Patch 1475353 2 don.olmstead 2018-11-05 17:18:32 -0800 *** Bug 190935 has been marked as a duplicate of this bug. *** 1475359 3 353925 fujii 2018-11-05 17:40:21 -0800 Comment on attachment 353925 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353925&action=review > Tools/Scripts/build-webkit:303 > + if (exitStatus(generateBuildSystemFromCMakeProject($prefixPath, (cmakeBasedPortArguments(), @featureArgs), @cmakeArgs))) { cmakeBasedPortArguments is not used since Bug 136951. I think you should remove it. 1475502 4 353925 fujii 2018-11-06 05:21:45 -0800 Comment on attachment 353925 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353925&action=review >> Tools/Scripts/build-webkit:303 >> + if (exitStatus(generateBuildSystemFromCMakeProject($prefixPath, (cmakeBasedPortArguments(), @featureArgs), @cmakeArgs))) { > > cmakeBasedPortArguments is not used since Bug 136951. I think you should remove it. This inner parenthesis is useless in Perl because Perl flattens nested lists. generateBuildSystemFromCMakeProject($prefixPath, cmakeBasedPortArguments(), @featureArgs, @cmakeArgs) 1475612 5 353984 don.olmstead 2018-11-06 12:11:29 -0800 Created attachment 353984 Patch Updated based on review comments. Removed the unused cmakeBasedPortArguments. 1475693 6 353984 commit-queue 2018-11-06 14:10:39 -0800 Comment on attachment 353984 Patch Clearing flags on attachment: 353984 Committed r237887: <https://trac.webkit.org/changeset/237887> 1475694 7 commit-queue 2018-11-06 14:10:41 -0800 All reviewed patches have been landed. Closing bug. 1475695 8 webkit-bug-importer 2018-11-06 14:12:29 -0800 <rdar://problem/45855617> 353925 2018-11-05 16:51:25 -0800 2018-11-06 12:11:29 -0800 Patch bug-191288.diff text/plain 1178 don.olmstead ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwNTlj YzdhM2RiOS4uMWM1ODdlYWU0ZWMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxOC0xMS0wNSAgRG9uIE9sbXN0ZWFk ICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29tPgorCisgICAgICAgIEZlYXR1cmUgZmxhZ3Mgbm90IHBy ZXNlbnQgZm9yIFZpc3VhbCBTdHVkaW8gd2hlbiB1c2luZyBidWlsZC13ZWJraXQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTI4OAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy9idWlsZC13 ZWJraXQ6CisKIDIwMTgtMTEtMDUgIFRoaWJhdWx0IFNhdW5pZXIgIDx0c2F1bmllckBpZ2FsaWEu Y29tPgogCiAgICAgICAgIFtGbGF0cGFrXSBCdWlsZCBsaWJ4MjY0IGFzIGl0IGlzIHRoZSBoMjY0 IGVuY29kZXIgd2Ugc3VwcG9ydCBpbiBXZWJSVEMKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMv YnVpbGQtd2Via2l0IGIvVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKaW5kZXggODU2MGMxNjYy ODEuLmI0YzM2YjNlZjQ5IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdAor KysgYi9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdApAQCAtMzAwLDcgKzMwMCw3IEBAIGlmIChp c0FwcGxlV2luV2ViS2l0KCkgfHwgaXNXaW5DYWlybygpIHx8IGlzUGxheVN0YXRpb24oKSkgewog ICAgIHJlbW92ZUNNYWtlQ2FjaGUoQGZlYXR1cmVBcmdzKTsKIAogICAgIGNoZGlyV2ViS2l0KCk7 Ci0gICAgaWYgKGV4aXRTdGF0dXMoZ2VuZXJhdGVCdWlsZFN5c3RlbUZyb21DTWFrZVByb2plY3Qo JHByZWZpeFBhdGgsIEBjbWFrZUFyZ3MpKSkgeworICAgIGlmIChleGl0U3RhdHVzKGdlbmVyYXRl QnVpbGRTeXN0ZW1Gcm9tQ01ha2VQcm9qZWN0KCRwcmVmaXhQYXRoLCAoY21ha2VCYXNlZFBvcnRB cmd1bWVudHMoKSwgQGZlYXR1cmVBcmdzKSwgQGNtYWtlQXJncykpKSB7CiAgICAgICAgIGRpZSAi UnVuIFZpc3VhbCBTdHVkaW8gMjAxNyBpbnN0YWxsYXRpb24gdmN2YXJzLmJhdCBiZWZvcmUgYnVp bGQtd2Via2l0IHdoZW4gdXNpbmcgbmluamEiOwogICAgIH0KIAo= 353984 2018-11-06 12:11:29 -0800 2018-11-06 14:10:39 -0800 Patch bug-191288.diff text/plain 2889 don.olmstead ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxY2Nh NDk1MzNhZC4uNDIwMGM3OGVhYjYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxOC0xMS0wNiAgRG9uIE9sbXN0ZWFk ICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29tPgorCisgICAgICAgIEZlYXR1cmUgZmxhZ3Mgbm90IHBy ZXNlbnQgZm9yIFZpc3VhbCBTdHVkaW8gd2hlbiB1c2luZyBidWlsZC13ZWJraXQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTI4OAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBhc3NlcyBmZWF0dXJlIGZs YWdzIHRvIFZpc3VhbCBzdHVkaW8gYnVpbGRzIHdpdGhpbiBidWlsZC13ZWJraXQuCisgICAgICAg IFJlbW92ZXMgY21ha2VCYXNlZFBvcnRBcmd1bWVudHMgYXMgaXQgaXMgbm8gbG9uZ2VyIGluIHVz ZS4KKworICAgICAgICAqIFNjcmlwdHMvYnVpbGQtanNjOgorICAgICAgICAqIFNjcmlwdHMvYnVp bGQtd2Via2l0OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKGNt YWtlQmFzZWRQb3J0QXJndW1lbnRzKTogRGVsZXRlZC4KKwogMjAxOC0xMS0wNiAgQWxleCBDaHJp c3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIEZpeCB0ZXN0cyBh ZnRlciByMjM3ODYzCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2J1aWxkLWpzYyBiL1Rvb2xz L1NjcmlwdHMvYnVpbGQtanNjCmluZGV4IGZlNjBmMjExYzI0Li41N2E0NDNiOGUyZSAxMDA3NTUK LS0tIGEvVG9vbHMvU2NyaXB0cy9idWlsZC1qc2MKKysrIGIvVG9vbHMvU2NyaXB0cy9idWlsZC1q c2MKQEAgLTE2Miw3ICsxNjIsNyBAQCBpZiAoaXNDTWFrZUJ1aWxkKCkpIHsKICAgICB9CiAKICAg ICAjIFRoaXMgY2FsbCBvbmx5IHJldHVybnMgaWYgbm90aGluZyB3cm9uZyBoYXBwZW5lZAotICAg IGJ1aWxkQ01ha2VQcm9qZWN0T3JFeGl0KDAsIHVuZGVmLCAkYnVpbGRUYXJnZXQsIChjbWFrZUJh c2VkUG9ydEFyZ3VtZW50cygpLCBAZmVhdHVyZUFyZ3MsIEBjbWFrZUFyZ3MpKTsKKyAgICBidWls ZENNYWtlUHJvamVjdE9yRXhpdCgwLCB1bmRlZiwgJGJ1aWxkVGFyZ2V0LCBAZmVhdHVyZUFyZ3Ms IEBjbWFrZUFyZ3MpOwogICAgIHdyaXRlQ29uZ3JhdHMoKTsKICAgICBleGl0IGV4aXRTdGF0dXMo MCk7CiB9CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdCBiL1Rvb2xzL1Nj cmlwdHMvYnVpbGQtd2Via2l0CmluZGV4IDg1NjBjMTY2MjgxLi44MjM5Njc0M2Y3MSAxMDA3NTUK LS0tIGEvVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKKysrIGIvVG9vbHMvU2NyaXB0cy9idWls ZC13ZWJraXQKQEAgLTI5MSw3ICsyOTEsNyBAQCBpZiAoaXNDTWFrZUJ1aWxkKCkgJiYgIWlzQW55 V2luZG93cygpKSB7CiAgICAgbXkgQGZlYXR1cmVBcmdzID0gY21ha2VBcmdzRnJvbUZlYXR1cmVz KEBmZWF0dXJlcywgISRub0V4cGVyaW1lbnRhbEZlYXR1cmVzKTsKICAgICByZW1vdmVDTWFrZUNh Y2hlKEBmZWF0dXJlQXJncyk7CiAKLSAgICBidWlsZENNYWtlUHJvamVjdE9yRXhpdCgkY2xlYW4s ICRwcmVmaXhQYXRoLCAkbWFrZUFyZ3MsIChjbWFrZUJhc2VkUG9ydEFyZ3VtZW50cygpLCBAZmVh dHVyZUFyZ3MpLCBAY21ha2VBcmdzKTsKKyAgICBidWlsZENNYWtlUHJvamVjdE9yRXhpdCgkY2xl YW4sICRwcmVmaXhQYXRoLCAkbWFrZUFyZ3MsIEBmZWF0dXJlQXJncywgQGNtYWtlQXJncyk7CiB9 CiAKIG15ICRiYXNlUHJvZHVjdERpciA9IGJhc2VQcm9kdWN0RGlyKCk7CkBAIC0zMDAsNyArMzAw LDcgQEAgaWYgKGlzQXBwbGVXaW5XZWJLaXQoKSB8fCBpc1dpbkNhaXJvKCkgfHwgaXNQbGF5U3Rh dGlvbigpKSB7CiAgICAgcmVtb3ZlQ01ha2VDYWNoZShAZmVhdHVyZUFyZ3MpOwogCiAgICAgY2hk aXJXZWJLaXQoKTsKLSAgICBpZiAoZXhpdFN0YXR1cyhnZW5lcmF0ZUJ1aWxkU3lzdGVtRnJvbUNN YWtlUHJvamVjdCgkcHJlZml4UGF0aCwgQGNtYWtlQXJncykpKSB7CisgICAgaWYgKGV4aXRTdGF0 dXMoZ2VuZXJhdGVCdWlsZFN5c3RlbUZyb21DTWFrZVByb2plY3QoJHByZWZpeFBhdGgsIEBmZWF0 dXJlQXJncywgQGNtYWtlQXJncykpKSB7CiAgICAgICAgIGRpZSAiUnVuIFZpc3VhbCBTdHVkaW8g MjAxNyBpbnN0YWxsYXRpb24gdmN2YXJzLmJhdCBiZWZvcmUgYnVpbGQtd2Via2l0IHdoZW4gdXNp bmcgbmluamEiOwogICAgIH0KIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJz LnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IDMwYTUzODg4YTY1Li4yMTAy YWRiYjliZSAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCisrKyBiL1Rv b2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQpAQCAtNjYsNyArNjYsNiBAQCBCRUdJTiB7CiAgICAg ICAgJmNoZGlyV2ViS2l0CiAgICAgICAgJmNoZWNrRnJhbWV3b3JrcwogICAgICAgICZjbWFrZUFy Z3NGcm9tRmVhdHVyZXMKLSAgICAgICAmY21ha2VCYXNlZFBvcnRBcmd1bWVudHMKICAgICAgICAm Y3VycmVudFNWTlJldmlzaW9uCiAgICAgICAgJmRlYnVnU2FmYXJpCiAgICAgICAgJmV4ZWN1dGFi bGVQcm9kdWN0RGlyCkBAIC0yMzY3LDEyICsyMzY2LDYgQEAgc3ViIGNtYWtlQXJnc0Zyb21GZWF0 dXJlcyhcQDskKQogICAgIHJldHVybiBAYXJnczsKIH0KIAotCi1zdWIgY21ha2VCYXNlZFBvcnRB cmd1bWVudHMoKQotewotICAgIHJldHVybiAoKTsKLX0KLQogc3ViIGNtYWtlQmFzZWRQb3J0TmFt ZSgpCiB7CiAgICAgcmV0dXJuIHVjZmlyc3QgcG9ydE5hbWUoKTsK