<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>191287</bug_id>
          
          <creation_ts>2018-11-05 16:43:03 -0800</creation_ts>
          <short_desc>[CMake] Fix WebCore/Modules includes</short_desc>
          <delta_ts>2018-11-05 23:01:52 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CMake</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Don Olmstead">don.olmstead</reporter>
          <assigned_to name="Don Olmstead">don.olmstead</assigned_to>
          <cc>achristensen</cc>
    
    <cc>annulen</cc>
    
    <cc>commit-queue</cc>
    
    <cc>fujii</cc>
    
    <cc>mcatanzaro</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1475334</commentid>
    <comment_count>0</comment_count>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2018-11-05 16:43:03 -0800</bug_when>
    <thetext>The includes for WebCore/Modules are missing applicationmanifest and they&apos;re not sorted.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1475337</commentid>
    <comment_count>1</comment_count>
      <attachid>353923</attachid>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2018-11-05 16:46:06 -0800</bug_when>
    <thetext>Created attachment 353923
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1475422</commentid>
    <comment_count>2</comment_count>
      <attachid>353923</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-11-05 23:01:50 -0800</bug_when>
    <thetext>Comment on attachment 353923
Patch

Clearing flags on attachment: 353923

Committed r237846: &lt;https://trac.webkit.org/changeset/237846&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1475423</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-11-05 23:01:52 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>353923</attachid>
            <date>2018-11-05 16:46:06 -0800</date>
            <delta_ts>2018-11-05 23:01:50 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-191287.diff</filename>
            <type>text/plain</type>
            <size>2057</size>
            <attacher name="Don Olmstead">don.olmstead</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1dlYkNv
cmUvQ01ha2VMaXN0cy50eHQKaW5kZXggOWFlYjJkZGNjZDkuLmMyMzIxYWNkMjc1IDEwMDY0NAot
LS0gYS9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvV2ViQ29yZS9D
TWFrZUxpc3RzLnR4dApAQCAtMTksOSArMTksMTAgQEAgc2V0KFdlYkNvcmVfSU5DTFVERV9ESVJF
Q1RPUklFUwogICAgICIke0NNQUtFX0JJTkFSWV9ESVJ9IgogICAgICIke1dFQkNPUkVfRElSfSIK
ICAgICAiJHtXRUJDT1JFX0RJUn0vTW9kdWxlcy9haXJwbGF5IgotICAgICIke1dFQkNPUkVfRElS
fS9Nb2R1bGVzL2JlYWNvbiIKICAgICAiJHtXRUJDT1JFX0RJUn0vTW9kdWxlcy9hcHBsZXBheSIK
ICAgICAiJHtXRUJDT1JFX0RJUn0vTW9kdWxlcy9hcHBsZXBheS9wYXltZW50cmVxdWVzdCIKKyAg
ICAiJHtXRUJDT1JFX0RJUn0vTW9kdWxlcy9hcHBsaWNhdGlvbm1hbmlmZXN0IgorICAgICIke1dF
QkNPUkVfRElSfS9Nb2R1bGVzL2JlYWNvbiIKICAgICAiJHtXRUJDT1JFX0RJUn0vTW9kdWxlcy9j
YWNoZSIKICAgICAiJHtXRUJDT1JFX0RJUn0vTW9kdWxlcy9jcmVkZW50aWFsbWFuYWdlbWVudCIK
ICAgICAiJHtXRUJDT1JFX0RJUn0vTW9kdWxlcy9lbmNyeXB0ZWRtZWRpYSIKQEAgLTM0LDEyICsz
NSwxMiBAQCBzZXQoV2ViQ29yZV9JTkNMVURFX0RJUkVDVE9SSUVTCiAgICAgIiR7V0VCQ09SRV9E
SVJ9L01vZHVsZXMvaW5kZXhlZGRiL3NlcnZlciIKICAgICAiJHtXRUJDT1JFX0RJUn0vTW9kdWxl
cy9pbmRleGVkZGIvc2hhcmVkIgogICAgICIke1dFQkNPUkVfRElSfS9Nb2R1bGVzL21lZGlhY2Fw
YWJpbGl0aWVzIgotICAgICIke1dFQkNPUkVfRElSfS9Nb2R1bGVzL21lZGlhY29udHJvbHMvIgor
ICAgICIke1dFQkNPUkVfRElSfS9Nb2R1bGVzL21lZGlhY29udHJvbHMiCisgICAgIiR7V0VCQ09S
RV9ESVJ9L01vZHVsZXMvbWVkaWFyZWNvcmRlciIKICAgICAiJHtXRUJDT1JFX0RJUn0vTW9kdWxl
cy9tZWRpYXNlc3Npb24iCiAgICAgIiR7V0VCQ09SRV9ESVJ9L01vZHVsZXMvbWVkaWFzb3VyY2Ui
CiAgICAgIiR7V0VCQ09SRV9ESVJ9L01vZHVsZXMvbWVkaWFzdHJlYW0iCiAgICAgIiR7V0VCQ09S
RV9ESVJ9L01vZHVsZXMvbWVkaWFzdHJlYW0vbGlid2VicnRjIgotICAgICIke1dFQkNPUkVfRElS
fS9Nb2R1bGVzL21lZGlhcmVjb3JkZXIiCiAgICAgIiR7V0VCQ09SRV9ESVJ9L01vZHVsZXMvbmF2
aWdhdG9yY29udGVudHV0aWxzIgogICAgICIke1dFQkNPUkVfRElSfS9Nb2R1bGVzL25vdGlmaWNh
dGlvbnMiCiAgICAgIiR7V0VCQ09SRV9ESVJ9L01vZHVsZXMvcGF5bWVudHJlcXVlc3QiCmRpZmYg
LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM
b2cKaW5kZXggZjk1MDU3NzgzMjUuLjRiM2QwOTc3ZjgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs
MTcgQEAKKzIwMTgtMTEtMDUgIERvbiBPbG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBzb255LmNvbT4K
KworICAgICAgICBbQ01ha2VdIEZpeCBXZWJDb3JlL01vZHVsZXMgaW5jbHVkZXMKKyAgICAgICAg
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTI4NworCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gTm8g
Y2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgIEFkZCBpbiBhcHBsaWNhdGlvbm1hbmlmZXN0
IHRvIHRoZSBsaXN0IG9mIGluY2x1ZGVzIGFuZCBzb3J0IHRoZQorICAgICAgICBtb2R1bGVzIGRp
cmVjdG9yeS4KKworICAgICAgICAqIENNYWtlTGlzdHMudHh0OgorCiAyMDE4LTExLTA1ICBUaGli
YXVsdCBTYXVuaWVyICA8dHNhdW5pZXJAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1N0cmVhbWVy
XSBGaXggRW5jb2RlZEltYWdlIHRpbWVzdGFtcHMgdG8gbWF0Y2ggd2hhdCBsaWJXZWJSVEMgZXhw
ZWN0cwo=
</data>

          </attachment>
      

    </bug>

</bugzilla>