<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>191285</bug_id>
          
          <creation_ts>2018-11-05 15:10:39 -0800</creation_ts>
          <short_desc>[Win] run-javascriptcore-tests does not run to completion in Release mode</short_desc>
          <delta_ts>2023-03-28 13:54:05 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Windows 10</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>254566</dup_id>
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=189880</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ross Kirsling">ross.kirsling</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>fujii</cc>
    
    <cc>lforschler</cc>
    
    <cc>pvollan</cc>
    
    <cc>stephan.szabo</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1475295</commentid>
    <comment_count>0</comment_count>
    <who name="Ross Kirsling">ross.kirsling</who>
    <bug_when>2018-11-05 15:10:39 -0800</bug_when>
    <thetext>Remaining work after bug 189880:
WinCairo JSC stress tests are now able to run to completion in Debug mode, but we still end up with hanging subprocesses in Release mode.

Notes:
- Repro rate seems to be 100% when running the full suite, but which tests end up stuck seems random. In particular, these are not failing tests.
- We may well manage to *start* running every test, but then we just sit at the end forever since some number of subprocesses will never terminate.
- Running a subset of tests with --filter is generally stable, and it seems that even --quick usually terminates successfully.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1475330</commentid>
    <comment_count>1</comment_count>
    <who name="Ross Kirsling">ross.kirsling</who>
    <bug_when>2018-11-05 16:28:10 -0800</bug_when>
    <thetext>As mentioned in the previous ticket, the stack trace for all hanging subprocesses is:
&gt; [External Code]
&gt; jscLib.dll!`anonymous namespace&apos;::jscExit(int status)            at Source\JavaScriptCore\jsc.cpp(174)
&gt; jscLib.dll!main(int argc, char * * argv)                         at Source\JavaScriptCore\jsc.cpp(2275)
&gt; jscLib.dll!dllLauncherEntryPoint(int argc, const char * * argv)  at Source\JavaScriptCore\jsc.cpp(2855)
&gt; jsc.exe!main(int argc, const char * * argv)                      at Source\JavaScriptCore\shell\DLLLauncherMain.cpp(222)
&gt; [External Code]

Attaching to process and hitting the Pause button breaks at jsc.cpp:174, and attempting to Step Into has the same effect as hitting Continue, since the call stack above the `exit(0);` call is just &quot;external code&quot;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1475371</commentid>
    <comment_count>2</comment_count>
    <who name="Ross Kirsling">ross.kirsling</who>
    <bug_when>2018-11-05 18:48:51 -0800</bug_when>
    <thetext>Hmm, it seems like if I ensure that we never collect continuously, then none of the subprocesses hang!
(https://github.com/WebKit/webkit/blob/master/Tools/Scripts/run-jsc-stress-tests#L494-L496)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1583243</commentid>
    <comment_count>3</comment_count>
      <attachid>381778</attachid>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2019-10-23 23:29:16 -0700</bug_when>
    <thetext>Created attachment 381778
workaround patch by disabling concurrent GC</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1597082</commentid>
    <comment_count>4</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2019-12-09 19:37:36 -0800</bug_when>
    <thetext>Now, AppleWin port Buildbots are running run-javascriptcore-tests with 64bit JSC JIT.
AppleWin port is also showing the same issue.
Release builds are timing out, while Debug builds are completing.

https://build.webkit.org/builders/Apple%20Win%2010%20Debug%20%28Tests%29/builds/3207
https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Tests%29/builds/4324</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1944733</commentid>
    <comment_count>5</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2023-03-28 13:54:05 -0700</bug_when>
    <thetext>Fixed by 262193@main.

*** This bug has been marked as a duplicate of bug 254566 ***</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>381778</attachid>
            <date>2019-10-23 23:29:16 -0700</date>
            <delta_ts>2019-10-23 23:29:16 -0700</delta_ts>
            <desc>workaround patch by disabling concurrent GC</desc>
            <filename>workaround.patch</filename>
            <type>text/plain</type>
            <size>588</size>
            <attacher name="Fujii Hironori">fujii</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVzdHMgYi9Ub29scy9T
Y3JpcHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3RzCmluZGV4IDg1YzdiY2QzZDJjLi45NDMzOWEwNmUy
OCAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cworKysgYi9U
b29scy9TY3JpcHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3RzCkBAIC01MDQsNyArNTA0LDcgQEAgRk9S
Q0VfTExJTlRfRVhJVF9PUFRJT05TID0gWyItLWZvcmNlT1NSRXhpdFRvTExJbnQ9dHJ1ZSJdCiBy
ZXF1aXJlX3JlbGF0aXZlICJ3ZWJraXRydWJ5L2pzYy1zdHJlc3MtdGVzdC13cml0ZXItI3skdGVz
dFdyaXRlcn0iCiAKIGRlZiBzaG91bGRDb2xsZWN0Q29udGludW91c2x5PwotICAgICRidWlsZFR5
cGUgPT0gInJlbGVhc2UiIG9yICRmb3JjZUNvbGxlY3RDb250aW51b3VzbHkKKyAgICBmYWxzZQog
ZW5kCiAKIENPTExFQ1RfQ09OVElOVU9VU0xZX09QVElPTlMgPSBzaG91bGRDb2xsZWN0Q29udGlu
dW91c2x5PyA/IFsiLS1jb2xsZWN0Q29udGludW91c2x5PXRydWUiLCAiLS11c2VHZW5lcmF0aW9u
YWxHQz1mYWxzZSJdIDogW10K
</data>

          </attachment>
      

    </bug>

</bugzilla>