191275 2018-11-05 12:10:11 -0800 webkitpy: Generalize trailing SDK specifier 2018-11-08 08:16:20 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain commit-queue ews-watchlist glenn lforschler webkit-bug-importer oldest_to_newest 1475230 0 jbedard 2018-11-05 12:10:11 -0800 List all installed SDKs with version numbers stripped out. 1475231 1 jbedard 2018-11-05 12:10:28 -0800 <rdar://problem/45703660> 1475232 2 353899 jbedard 2018-11-05 12:17:25 -0800 Created attachment 353899 Patch 1475323 3 353899 commit-queue 2018-11-05 16:21:44 -0800 Comment on attachment 353899 Patch Clearing flags on attachment: 353899 Committed r237836: <https://trac.webkit.org/changeset/237836> 1475324 4 commit-queue 2018-11-05 16:21:45 -0800 All reviewed patches have been landed. Closing bug. 1475325 5 webkit-bug-importer 2018-11-05 16:22:21 -0800 <rdar://problem/45825307> 1475547 6 jbedard 2018-11-06 08:37:16 -0800 Reopening to attach new patch. 1475548 7 353970 jbedard 2018-11-06 08:37:17 -0800 Created attachment 353970 Patch 1475641 8 353991 jbedard 2018-11-06 12:57:31 -0800 Created attachment 353991 Patch 1475650 9 353991 aakash_jain 2018-11-06 13:07:49 -0800 Comment on attachment 353991 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353991&action=review > Tools/Scripts/webkitpy/port/ios_simulator.py:84 > + return ['--sdk', self.SDK] + (['ARCHS={}'.format(self.architecture())] if self.architecture() else []) Is the architecture change unrelated? If so, it probably needs to be in a separate patch. 1475698 10 354004 jbedard 2018-11-06 14:18:16 -0800 Created attachment 354004 Patch 1475699 11 jbedard 2018-11-06 14:19:02 -0800 (In reply to Aakash Jain from comment #9) > Comment on attachment 353991 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=353991&action=review > > > Tools/Scripts/webkitpy/port/ios_simulator.py:84 > > + return ['--sdk', self.SDK] + (['ARCHS={}'.format(self.architecture())] if self.architecture() else []) > > Is the architecture change unrelated? If so, it probably needs to be in a > separate patch. It was some code clean-up, I removed it. (It wasn't actually a functional change) 1475861 12 354004 commit-queue 2018-11-06 21:01:38 -0800 Comment on attachment 354004 Patch Clearing flags on attachment: 354004 Committed r237913: <https://trac.webkit.org/changeset/237913> 1475862 13 commit-queue 2018-11-06 21:01:40 -0800 All reviewed patches have been landed. Closing bug. 1476083 14 jbedard 2018-11-07 11:25:41 -0800 Reverted r237913 for reason: Breaks running tests on Mac without iOS SDK installed Committed r237931: <https://trac.webkit.org/changeset/237931> 1476297 15 jbedard 2018-11-07 15:50:49 -0800 (In reply to Jonathan Bedard from comment #14) > Reverted r237913 for reason: > > Breaks running tests on Mac without iOS SDK installed > > Committed r237931: <https://trac.webkit.org/changeset/237931> I'll re-land this tonight, this patch was (and is) fine, there is just a specific local configuration problem that causes this patch to fail, I'll reach out to those who might be impacted. 1476430 16 354004 commit-queue 2018-11-07 22:26:31 -0800 Comment on attachment 354004 Patch Rejecting attachment 354004 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 354004, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Tools/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/9904967 1476534 17 jbedard 2018-11-08 08:16:20 -0800 Committed r237989: <https://trac.webkit.org/changeset/237989> 353899 2018-11-05 12:17:25 -0800 2018-11-06 08:37:15 -0800 Patch bug-191275-20181105121724.patch text/plain 3402 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzNzgyNikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE4LTExLTA1ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogR2VuZXJhbGl6ZSB0cmFpbGluZyBTREsgc3BlY2lmaWVy IChQYXJ0IDEpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTEyNzUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ1NzAzNjYwPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9j b21tb24vc3lzdGVtL3BsYXRmb3JtaW5mby5weToKKyAgICAgICAgKFBsYXRmb3JtSW5mby5hdmFp bGFibGVfc2Rrcyk6IExpc3QgYWxsIGluc3RhbGxlZCBTREtzIHdpdGggdmVyc2lvbiBudW1iZXJz IHN0cmlwcGVkIG91dC4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0v cGxhdGZvcm1pbmZvX3VuaXR0ZXN0LnB5OgorICAgICAgICAoVGVzdFBsYXRmb3JtSW5mbyk6Cisg ICAgICAgIChUZXN0UGxhdGZvcm1JbmZvLnRlc3RfYXZhaWxhYmxlX3Nka3MpOgorCiAyMDE4LTEx LTA1ICBCYXN1a2UgU3V6dWtpICA8QmFzdWtlLlN1enVraUBzb255LmNvbT4KIAogICAgICAgICBb c3R5bGVdIEV4Y2x1ZGUgc3R5bGUgY2hlY2sgZm9yIGF1dG8gZ2VuZXJhdGVkIGZpbGVzLgpJbmRl eDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL3BsYXRmb3JtaW5mby5weQo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vcGxhdGZv cm1pbmZvLnB5CShyZXZpc2lvbiAyMzc4MDQpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2Nv bW1vbi9zeXN0ZW0vcGxhdGZvcm1pbmZvLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xNjIsNiArMTYy LDIwIEBAIGNsYXNzIFBsYXRmb3JtSW5mbyhvYmplY3QpOgogICAgICAgICAgICAgcmFpc2UgTm90 SW1wbGVtZW50ZWRFcnJvcgogICAgICAgICByZXR1cm4gVmVyc2lvbi5mcm9tX3N0cmluZyhzZWxm Ll9leGVjdXRpdmUucnVuX2NvbW1hbmQoWyd4Y29kZWJ1aWxkJywgJy12ZXJzaW9uJ10pLnNwbGl0 KClbMV0pCiAKKyAgICBkZWYgYXZhaWxhYmxlX3Nka3Moc2VsZik6CisgICAgICAgIGlmIG5vdCBz ZWxmLmlzX21hYygpOgorICAgICAgICAgICAgcmV0dXJuIFtdCisKKyAgICAgICAgWENPREVfU0RL X1JFR0VYID0gcmUuY29tcGlsZSgnXC1zZGsgKD9QPHNkaz5cRCspXGQrXC5cZCsoP1A8c3BlY2lm aWVyPlxEKiknKQorICAgICAgICBvdXRwdXQgPSBzZWxmLl9leGVjdXRpdmUucnVuX2NvbW1hbmQo Wyd4Y29kZWJ1aWxkJywgJy1zaG93c2RrcyddLCByZXR1cm5fc3RkZXJyPUZhbHNlKQorCisgICAg ICAgIHNka3MgPSBsaXN0KCkKKyAgICAgICAgZm9yIGxpbmUgaW4gb3V0cHV0LnNwbGl0bGluZXMo KToKKyAgICAgICAgICAgIG1hdGNoID0gWENPREVfU0RLX1JFR0VYLnNlYXJjaChsaW5lKQorICAg ICAgICAgICAgaWYgbWF0Y2g6CisgICAgICAgICAgICAgICAgc2Rrcy5hcHBlbmQobWF0Y2guZ3Jv dXAoJ3NkaycpICsgbWF0Y2guZ3JvdXAoJ3NwZWNpZmllcicpKQorICAgICAgICByZXR1cm4gc2Rr cworCiAgICAgZGVmIF9kZXRlcm1pbmVfb3NfbmFtZShzZWxmLCBzeXNfcGxhdGZvcm0pOgogICAg ICAgICBpZiBzeXNfcGxhdGZvcm0gPT0gJ2Rhcndpbic6CiAgICAgICAgICAgICByZXR1cm4gJ21h YycKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9wbGF0Zm9ybWlu Zm9fdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21t b24vc3lzdGVtL3BsYXRmb3JtaW5mb191bml0dGVzdC5weQkocmV2aXNpb24gMjM3ODA0KQorKysg VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL3BsYXRmb3JtaW5mb191bml0dGVz dC5weQkod29ya2luZyBjb3B5KQpAQCAtMTU4LDMgKzE1OCwzMCBAQCBjbGFzcyBUZXN0UGxhdGZv cm1JbmZvKHVuaXR0ZXN0LlRlc3RDYXNlCiAKICAgICAgICAgaW5mbyA9IHNlbGYubWFrZV9pbmZv KGZha2Vfc3lzKCdmcmVlYnNkOScpLCBmYWtlX3BsYXRmb3JtKCcnLCAnOS4wLVJFTEVBU0UnKSkK ICAgICAgICAgc2VsZi5hc3NlcnRJc05vbmUoaW5mby50b3RhbF9ieXRlc19tZW1vcnkoKSkKKwor ICAgIGRlZiB0ZXN0X2F2YWlsYWJsZV9zZGtzKHNlbGYpOgorICAgICAgICBzaG93X3Nka3Nfb3V0 cHV0ID0gIiIiaU9TIFNES3M6CisgICAgaU9TIDEyLjAgICAgICAgICAgICAgICAgICAgICAgICAg IC1zZGsgaXBob25lb3MxMi4wCisKK2lPUyBTaW11bGF0b3IgU0RLczoKKyAgICBTaW11bGF0b3Ig LSBpT1MgMTIuMCAgICAgICAgICAgICAgLXNkayBpcGhvbmVzaW11bGF0b3IxMi4wCisgICAgU2lt dWxhdG9yIC0gaU9TIDEyLjAgSW50ZXJuYWwgICAgIC1zZGsgaXBob25lc2ltdWxhdG9yMTIuMC50 eXBlCisKK21hY09TIFNES3M6CisgICAgbWFjT1MgMTAuMTQgICAgICAgICAgICAgICAgICAgICAg IC1zZGsgbWFjb3N4MTAuMTQKKword2F0Y2hPUyBTREtzOgorICAgIHdhdGNoT1MgNS4wICAgICAg ICAgICAgICAgICAgICAgICAtc2RrIHdhdGNob3M1LjAKKword2F0Y2hPUyBTaW11bGF0b3IgU0RL czoKKyAgICBTaW11bGF0b3IgLSB3YXRjaE9TIDUuMCAgICAgICAgICAgLXNkayB3YXRjaHNpbXVs YXRvcjUuMAorICAgIFNpbXVsYXRvciAtIHdhdGNoT1MgNS4wIEludGVybmFsICAgIC1zZGsgd2F0 Y2hzaW11bGF0b3I1LjAudHlwZQorIiIiCisgICAgICAgIGluZm8gPSBzZWxmLm1ha2VfaW5mbyhm YWtlX3N5cygnZGFyd2luJyksIGZha2VfcGxhdGZvcm0oJzEwLjE0LjAnKSwgZmFrZV9leGVjdXRp dmUoc2hvd19zZGtzX291dHB1dCkpCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoaW5mby5hdmFp bGFibGVfc2RrcygpLCBbCisgICAgICAgICAgICAnaXBob25lb3MnLAorICAgICAgICAgICAgJ2lw aG9uZXNpbXVsYXRvcicsICdpcGhvbmVzaW11bGF0b3IudHlwZScsCisgICAgICAgICAgICAnbWFj b3N4JywKKyAgICAgICAgICAgICd3YXRjaG9zJywKKyAgICAgICAgICAgICd3YXRjaHNpbXVsYXRv cicsICd3YXRjaHNpbXVsYXRvci50eXBlJywKKyAgICAgICAgXSkK 353970 2018-11-06 08:37:17 -0800 2018-11-06 12:57:29 -0800 Patch bug-191275-20181106083716.patch text/plain 3093 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzNzg2NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE4LTExLTA2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogR2VuZXJhbGl6ZSB0cmFpbGluZyBTREsgc3BlY2lmaWVy IChQYXJ0IDIpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTEyNzUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ1NzAzNjYwPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9w b3J0L2lvc19kZXZpY2UucHk6CisgICAgICAgIChJT1NEZXZpY2VQb3J0KTogVXNlIG5vcm1hbGl6 ZWQgU0RLLgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC9pb3Nfc2ltdWxhdG9yLnB5 OgorICAgICAgICAoSU9TU2ltdWxhdG9yUG9ydCk6IFVzZSBub3JtYWxpemVkIFNESy4KKyAgICAg ICAgKElPU1NpbXVsYXRvclBvcnQuX2J1aWxkX2RyaXZlcl9mbGFncyk6IFVzZSBwbGF0Zm9ybSBT REsgaW4gYnVpbGQgZHJpdmVyIGZsYWdzLgorCiAyMDE4LTExLTA1ICBBbGV4IENocmlzdGVuc2Vu ICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW01hY10gSW1wbGVtZW50IHNh ZmUgYnJvd3NpbmcgaW4gV2ViS2l0CkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQv aW9zX2RldmljZS5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQv aW9zX2RldmljZS5weQkocmV2aXNpb24gMjM3ODM2KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9wb3J0L2lvc19kZXZpY2UucHkJKHdvcmtpbmcgY29weSkKQEAgLTM4LDcgKzM4LDcgQEAgY2xh c3MgSU9TRGV2aWNlUG9ydChJT1NQb3J0KToKICAgICBBUkNISVRFQ1RVUkVTID0gWydhcm12Nycs ICdhcm12N3MnLCAnYXJtNjQnXQogICAgIERFRkFVTFRfQVJDSElURUNUVVJFID0gJ2FybTY0Jwog ICAgIFZFUlNJT05fRkFMTEJBQ0tfT1JERVIgPSBbJ2lvcy03JywgJ2lvcy04JywgJ2lvcy05Jywg J2lvcy0xMCddCi0gICAgU0RLID0gYXBwbGVfYWRkaXRpb25zKCkuaW9zX2RldmljZV9TREsoKSBp ZiBhcHBsZV9hZGRpdGlvbnMoKSBlbHNlICdpcGhvbmVvcycKKyAgICBTREsgPSBhcHBsZV9hZGRp dGlvbnMoKS5nZXRfc2RrKCdpcGhvbmVvcycpIGlmIGFwcGxlX2FkZGl0aW9ucygpIGVsc2UgJ2lw aG9uZW9zJwogICAgIE5PX09OX0RFVklDRV9URVNUSU5HID0gJ09uLWRldmljZSB0ZXN0aW5nIGlz IG5vdCBzdXBwb3J0ZWQgb24gdGhpcyBtYWNoaW5lJwogCiAgICAgQG1lbW9pemVkCkluZGV4OiBU b29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvaW9zX3NpbXVsYXRvci5weQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvaW9zX3NpbXVsYXRvci5weQkocmV2aXNpb24g MjM3ODM2KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2lvc19zaW11bGF0b3IucHkJ KHdvcmtpbmcgY29weSkKQEAgLTI0LDYgKzI0LDcgQEAgaW1wb3J0IGxvZ2dpbmcKIAogZnJvbSB3 ZWJraXRweS5jb21tb24ubWVtb2l6ZWQgaW1wb3J0IG1lbW9pemVkCiBmcm9tIHdlYmtpdHB5LmNv bW1vbi52ZXJzaW9uIGltcG9ydCBWZXJzaW9uCitmcm9tIHdlYmtpdHB5LnBvcnQuY29uZmlnIGlt cG9ydCBhcHBsZV9hZGRpdGlvbnMKIGZyb20gd2Via2l0cHkucG9ydC5pb3MgaW1wb3J0IElPU1Bv cnQKIGZyb20gd2Via2l0cHkueGNvZGUuZGV2aWNlX3R5cGUgaW1wb3J0IERldmljZVR5cGUKIGZy b20gd2Via2l0cHkueGNvZGUuc2ltdWxhdGVkX2RldmljZSBpbXBvcnQgRGV2aWNlUmVxdWVzdCwg U2ltdWxhdGVkRGV2aWNlTWFuYWdlcgpAQCAtNDEsNyArNDIsNyBAQCBjbGFzcyBJT1NTaW11bGF0 b3JQb3J0KElPU1BvcnQpOgogCiAgICAgREVGQVVMVF9ERVZJQ0VfQ0xBU1MgPSAnaVBob25lIFNF JwogICAgIENVU1RPTV9ERVZJQ0VfQ0xBU1NFUyA9IFsnaVBhZCcsICdpUGhvbmUgNyddCi0gICAg U0RLID0gJ2lwaG9uZXNpbXVsYXRvcicKKyAgICBTREsgPSBhcHBsZV9hZGRpdGlvbnMoKS5nZXRf c2RrKCdpcGhvbmVzaW11bGF0b3InKSBpZiBhcHBsZV9hZGRpdGlvbnMoKSBlbHNlICdpcGhvbmVz aW11bGF0b3InCiAKICAgICBkZWYgX19pbml0X18oc2VsZiwgaG9zdCwgcG9ydF9uYW1lLCAqKmt3 YXJncyk6CiAgICAgICAgIHN1cGVyKElPU1NpbXVsYXRvclBvcnQsIHNlbGYpLl9faW5pdF9fKGhv c3QsIHBvcnRfbmFtZSwgKiprd2FyZ3MpCkBAIC04MCw5ICs4MSw3IEBAIGNsYXNzIElPU1NpbXVs YXRvclBvcnQoSU9TUG9ydCk6CiAgICAgICAgIHJldHVybiBTaW11bGF0ZWREZXZpY2VNYW5hZ2Vy Lm1heF9zdXBwb3J0ZWRfc2ltdWxhdG9ycyhzZWxmLmhvc3QpCiAKICAgICBkZWYgX2J1aWxkX2Ry aXZlcl9mbGFncyhzZWxmKToKLSAgICAgICAgYXJjaHMgPSBbJ0FSQ0hTPWkzODYnXSBpZiBzZWxm LmFyY2hpdGVjdHVyZSgpID09ICd4ODYnIGVsc2UgW10KLSAgICAgICAgc2RrID0gWyctLXNkaycs ICdpcGhvbmVzaW11bGF0b3InXQotICAgICAgICByZXR1cm4gYXJjaHMgKyBzZGsKKyAgICAgICAg cmV0dXJuIFsnLS1zZGsnLCBzZWxmLlNES10gKyAoWydBUkNIUz17fScuZm9ybWF0KHNlbGYuYXJj aGl0ZWN0dXJlKCkpXSBpZiBzZWxmLmFyY2hpdGVjdHVyZSgpIGVsc2UgW10pCiAKICAgICBkZWYg X3NldF9kZXZpY2VfY2xhc3Moc2VsZiwgZGV2aWNlX2NsYXNzKToKICAgICAgICAgc2VsZi5fZGV2 aWNlX2NsYXNzID0gZGV2aWNlX2NsYXNzIGlmIGRldmljZV9jbGFzcyBlbHNlIHNlbGYuREVGQVVM VF9ERVZJQ0VfQ0xBU1MK 353991 2018-11-06 12:57:31 -0800 2018-11-06 14:18:14 -0800 Patch bug-191275-20181106125730.patch text/plain 4259 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzNzg4MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIwIEBACisyMDE4LTExLTA2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogR2VuZXJhbGl6ZSB0cmFpbGluZyBTREsgc3BlY2lmaWVy IChQYXJ0IDIpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTEyNzUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ1NzAzNjYwPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9w b3J0L2lvc19kZXZpY2UucHk6CisgICAgICAgIChJT1NEZXZpY2VQb3J0KTogVXNlIG5vcm1hbGl6 ZWQgU0RLLgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC9pb3Nfc2ltdWxhdG9yLnB5 OgorICAgICAgICAoSU9TU2ltdWxhdG9yUG9ydCk6IFVzZSBub3JtYWxpemVkIFNESy4KKyAgICAg ICAgKElPU1NpbXVsYXRvclBvcnQuX2J1aWxkX2RyaXZlcl9mbGFncyk6IFVzZSBwbGF0Zm9ybSBT REsgaW4gYnVpbGQgZHJpdmVyIGZsYWdzLgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9y dC9pb3Nfc2ltdWxhdG9yX3VuaXR0ZXN0LnB5OgorICAgICAgICAoSU9TU2ltdWxhdG9yVGVzdC50 ZXN0XzMyYml0KToKKyAgICAgICAgKElPU1NpbXVsYXRvclRlc3QudGVzdF82NGJpdCk6CisKIDIw MTgtMTEtMDYgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAog ICAgICAgICBGaXggdGVzdHMgYWZ0ZXIgcjIzNzg2MwpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9wb3J0L2lvc19kZXZpY2UucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9wb3J0L2lvc19kZXZpY2UucHkJKHJldmlzaW9uIDIzNzg3OSkKKysrIFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvcG9ydC9pb3NfZGV2aWNlLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0zOCw3ICsz OCw3IEBAIGNsYXNzIElPU0RldmljZVBvcnQoSU9TUG9ydCk6CiAgICAgQVJDSElURUNUVVJFUyA9 IFsnYXJtdjcnLCAnYXJtdjdzJywgJ2FybTY0J10KICAgICBERUZBVUxUX0FSQ0hJVEVDVFVSRSA9 ICdhcm02NCcKICAgICBWRVJTSU9OX0ZBTExCQUNLX09SREVSID0gWydpb3MtNycsICdpb3MtOCcs ICdpb3MtOScsICdpb3MtMTAnXQotICAgIFNESyA9IGFwcGxlX2FkZGl0aW9ucygpLmlvc19kZXZp Y2VfU0RLKCkgaWYgYXBwbGVfYWRkaXRpb25zKCkgZWxzZSAnaXBob25lb3MnCisgICAgU0RLID0g YXBwbGVfYWRkaXRpb25zKCkuZ2V0X3NkaygnaXBob25lb3MnKSBpZiBhcHBsZV9hZGRpdGlvbnMo KSBlbHNlICdpcGhvbmVvcycKICAgICBOT19PTl9ERVZJQ0VfVEVTVElORyA9ICdPbi1kZXZpY2Ug dGVzdGluZyBpcyBub3Qgc3VwcG9ydGVkIG9uIHRoaXMgbWFjaGluZScKIAogICAgIEBtZW1vaXpl ZApJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2lvc19zaW11bGF0b3IucHkKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2lvc19zaW11bGF0b3IucHkJ KHJldmlzaW9uIDIzNzg3OSkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9pb3Nfc2lt dWxhdG9yLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yNCw2ICsyNCw3IEBAIGltcG9ydCBsb2dnaW5n CiAKIGZyb20gd2Via2l0cHkuY29tbW9uLm1lbW9pemVkIGltcG9ydCBtZW1vaXplZAogZnJvbSB3 ZWJraXRweS5jb21tb24udmVyc2lvbiBpbXBvcnQgVmVyc2lvbgorZnJvbSB3ZWJraXRweS5wb3J0 LmNvbmZpZyBpbXBvcnQgYXBwbGVfYWRkaXRpb25zCiBmcm9tIHdlYmtpdHB5LnBvcnQuaW9zIGlt cG9ydCBJT1NQb3J0CiBmcm9tIHdlYmtpdHB5Lnhjb2RlLmRldmljZV90eXBlIGltcG9ydCBEZXZp Y2VUeXBlCiBmcm9tIHdlYmtpdHB5Lnhjb2RlLnNpbXVsYXRlZF9kZXZpY2UgaW1wb3J0IERldmlj ZVJlcXVlc3QsIFNpbXVsYXRlZERldmljZU1hbmFnZXIKQEAgLTQxLDcgKzQyLDcgQEAgY2xhc3Mg SU9TU2ltdWxhdG9yUG9ydChJT1NQb3J0KToKIAogICAgIERFRkFVTFRfREVWSUNFX0NMQVNTID0g J2lQaG9uZSBTRScKICAgICBDVVNUT01fREVWSUNFX0NMQVNTRVMgPSBbJ2lQYWQnLCAnaVBob25l IDcnXQotICAgIFNESyA9ICdpcGhvbmVzaW11bGF0b3InCisgICAgU0RLID0gYXBwbGVfYWRkaXRp b25zKCkuZ2V0X3NkaygnaXBob25lc2ltdWxhdG9yJykgaWYgYXBwbGVfYWRkaXRpb25zKCkgZWxz ZSAnaXBob25lc2ltdWxhdG9yJwogCiAgICAgZGVmIF9faW5pdF9fKHNlbGYsIGhvc3QsIHBvcnRf bmFtZSwgKiprd2FyZ3MpOgogICAgICAgICBzdXBlcihJT1NTaW11bGF0b3JQb3J0LCBzZWxmKS5f X2luaXRfXyhob3N0LCBwb3J0X25hbWUsICoqa3dhcmdzKQpAQCAtODAsOSArODEsNyBAQCBjbGFz cyBJT1NTaW11bGF0b3JQb3J0KElPU1BvcnQpOgogICAgICAgICByZXR1cm4gU2ltdWxhdGVkRGV2 aWNlTWFuYWdlci5tYXhfc3VwcG9ydGVkX3NpbXVsYXRvcnMoc2VsZi5ob3N0KQogCiAgICAgZGVm IF9idWlsZF9kcml2ZXJfZmxhZ3Moc2VsZik6Ci0gICAgICAgIGFyY2hzID0gWydBUkNIUz1pMzg2 J10gaWYgc2VsZi5hcmNoaXRlY3R1cmUoKSA9PSAneDg2JyBlbHNlIFtdCi0gICAgICAgIHNkayA9 IFsnLS1zZGsnLCAnaXBob25lc2ltdWxhdG9yJ10KLSAgICAgICAgcmV0dXJuIGFyY2hzICsgc2Rr CisgICAgICAgIHJldHVybiBbJy0tc2RrJywgc2VsZi5TREtdICsgKFsnQVJDSFM9e30nLmZvcm1h dChzZWxmLmFyY2hpdGVjdHVyZSgpKV0gaWYgc2VsZi5hcmNoaXRlY3R1cmUoKSBlbHNlIFtdKQog CiAgICAgZGVmIF9zZXRfZGV2aWNlX2NsYXNzKHNlbGYsIGRldmljZV9jbGFzcyk6CiAgICAgICAg IHNlbGYuX2RldmljZV9jbGFzcyA9IGRldmljZV9jbGFzcyBpZiBkZXZpY2VfY2xhc3MgZWxzZSBz ZWxmLkRFRkFVTFRfREVWSUNFX0NMQVNTCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Bv cnQvaW9zX3NpbXVsYXRvcl91bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRz L3dlYmtpdHB5L3BvcnQvaW9zX3NpbXVsYXRvcl91bml0dGVzdC5weQkocmV2aXNpb24gMjM3ODc5 KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2lvc19zaW11bGF0b3JfdW5pdHRlc3Qu cHkJKHdvcmtpbmcgY29weSkKQEAgLTYwLDcgKzYwLDcgQEAgY2xhc3MgSU9TU2ltdWxhdG9yVGVz dChpb3NfdGVzdGNhc2UuSU9TVAogICAgICAgICBwb3J0Ll9ydW5fc2NyaXB0ID0gcnVuX3Njcmlw dAogICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHBvcnQuYXJjaGl0ZWN0dXJlKCksICd4ODYnKQog ICAgICAgICBwb3J0Ll9idWlsZF9kcml2ZXIoKQotICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHNl bGYuYXJncywgWydBUkNIUz1pMzg2JywgJy0tc2RrJywgJ2lwaG9uZXNpbXVsYXRvciddKQorICAg ICAgICBzZWxmLmFzc2VydEVxdWFsKHNlbGYuYXJncywgWyctLXNkaycsICdpcGhvbmVzaW11bGF0 b3InLCAnQVJDSFM9eDg2J10pCiAKICAgICBkZWYgdGVzdF82NGJpdChzZWxmKToKICAgICAgICAg IyBBcHBsZSBNYWMgcG9ydCBpcyA2NC1iaXQgYnkgZGVmYXVsdApAQCAtNzIsNyArNzIsNyBAQCBj bGFzcyBJT1NTaW11bGF0b3JUZXN0KGlvc190ZXN0Y2FzZS5JT1NUCiAKICAgICAgICAgcG9ydC5f cnVuX3NjcmlwdCA9IHJ1bl9zY3JpcHQKICAgICAgICAgcG9ydC5fYnVpbGRfZHJpdmVyKCkKLSAg ICAgICAgc2VsZi5hc3NlcnRFcXVhbChzZWxmLmFyZ3MsIFsnLS1zZGsnLCAnaXBob25lc2ltdWxh dG9yJ10pCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoc2VsZi5hcmdzLCBbJy0tc2RrJywgJ2lw aG9uZXNpbXVsYXRvcicsICdBUkNIUz14ODZfNjQnXSkKIAogICAgIGRlZiB0ZXN0X3Nka19uYW1l KHNlbGYpOgogICAgICAgICBwb3J0ID0gc2VsZi5tYWtlX3BvcnQoKQo= 354004 2018-11-06 14:18:16 -0800 2018-11-07 22:26:31 -0800 Patch bug-191275-20181106141815.patch text/plain 2835 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzNzg4MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE4LTExLTA2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogR2VuZXJhbGl6ZSB0cmFpbGluZyBTREsgc3BlY2lmaWVy IChQYXJ0IDIpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTEyNzUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ1NzAzNjYwPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9w b3J0L2lvc19kZXZpY2UucHk6CisgICAgICAgIChJT1NEZXZpY2VQb3J0KTogVXNlIG5vcm1hbGl6 ZWQgU0RLLgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC9pb3Nfc2ltdWxhdG9yLnB5 OgorICAgICAgICAoSU9TU2ltdWxhdG9yUG9ydCk6IFVzZSBub3JtYWxpemVkIFNESy4KKyAgICAg ICAgKElPU1NpbXVsYXRvclBvcnQuX2J1aWxkX2RyaXZlcl9mbGFncyk6IFVzZSBwbGF0Zm9ybSBT REsgaW4gYnVpbGQgZHJpdmVyIGZsYWdzLgorCiAyMDE4LTExLTA2ICBBbGV4IENocmlzdGVuc2Vu ICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgRml4IHRlc3RzIGFmdGVyIHIy Mzc4NjMKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9pb3NfZGV2aWNlLnB5Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9pb3NfZGV2aWNlLnB5CShy ZXZpc2lvbiAyMzc4NzkpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvaW9zX2Rldmlj ZS5weQkod29ya2luZyBjb3B5KQpAQCAtMzgsNyArMzgsNyBAQCBjbGFzcyBJT1NEZXZpY2VQb3J0 KElPU1BvcnQpOgogICAgIEFSQ0hJVEVDVFVSRVMgPSBbJ2FybXY3JywgJ2FybXY3cycsICdhcm02 NCddCiAgICAgREVGQVVMVF9BUkNISVRFQ1RVUkUgPSAnYXJtNjQnCiAgICAgVkVSU0lPTl9GQUxM QkFDS19PUkRFUiA9IFsnaW9zLTcnLCAnaW9zLTgnLCAnaW9zLTknLCAnaW9zLTEwJ10KLSAgICBT REsgPSBhcHBsZV9hZGRpdGlvbnMoKS5pb3NfZGV2aWNlX1NESygpIGlmIGFwcGxlX2FkZGl0aW9u cygpIGVsc2UgJ2lwaG9uZW9zJworICAgIFNESyA9IGFwcGxlX2FkZGl0aW9ucygpLmdldF9zZGso J2lwaG9uZW9zJykgaWYgYXBwbGVfYWRkaXRpb25zKCkgZWxzZSAnaXBob25lb3MnCiAgICAgTk9f T05fREVWSUNFX1RFU1RJTkcgPSAnT24tZGV2aWNlIHRlc3RpbmcgaXMgbm90IHN1cHBvcnRlZCBv biB0aGlzIG1hY2hpbmUnCiAKICAgICBAbWVtb2l6ZWQKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvcG9ydC9pb3Nfc2ltdWxhdG9yLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvcG9ydC9pb3Nfc2ltdWxhdG9yLnB5CShyZXZpc2lvbiAyMzc4NzkpCisrKyBUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvaW9zX3NpbXVsYXRvci5weQkod29ya2luZyBjb3B5KQpA QCAtMjQsNiArMjQsNyBAQCBpbXBvcnQgbG9nZ2luZwogCiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5t ZW1vaXplZCBpbXBvcnQgbWVtb2l6ZWQKIGZyb20gd2Via2l0cHkuY29tbW9uLnZlcnNpb24gaW1w b3J0IFZlcnNpb24KK2Zyb20gd2Via2l0cHkucG9ydC5jb25maWcgaW1wb3J0IGFwcGxlX2FkZGl0 aW9ucwogZnJvbSB3ZWJraXRweS5wb3J0LmlvcyBpbXBvcnQgSU9TUG9ydAogZnJvbSB3ZWJraXRw eS54Y29kZS5kZXZpY2VfdHlwZSBpbXBvcnQgRGV2aWNlVHlwZQogZnJvbSB3ZWJraXRweS54Y29k ZS5zaW11bGF0ZWRfZGV2aWNlIGltcG9ydCBEZXZpY2VSZXF1ZXN0LCBTaW11bGF0ZWREZXZpY2VN YW5hZ2VyCkBAIC00MSw3ICs0Miw3IEBAIGNsYXNzIElPU1NpbXVsYXRvclBvcnQoSU9TUG9ydCk6 CiAKICAgICBERUZBVUxUX0RFVklDRV9DTEFTUyA9ICdpUGhvbmUgU0UnCiAgICAgQ1VTVE9NX0RF VklDRV9DTEFTU0VTID0gWydpUGFkJywgJ2lQaG9uZSA3J10KLSAgICBTREsgPSAnaXBob25lc2lt dWxhdG9yJworICAgIFNESyA9IGFwcGxlX2FkZGl0aW9ucygpLmdldF9zZGsoJ2lwaG9uZXNpbXVs YXRvcicpIGlmIGFwcGxlX2FkZGl0aW9ucygpIGVsc2UgJ2lwaG9uZXNpbXVsYXRvcicKIAogICAg IGRlZiBfX2luaXRfXyhzZWxmLCBob3N0LCBwb3J0X25hbWUsICoqa3dhcmdzKToKICAgICAgICAg c3VwZXIoSU9TU2ltdWxhdG9yUG9ydCwgc2VsZikuX19pbml0X18oaG9zdCwgcG9ydF9uYW1lLCAq Kmt3YXJncykKQEAgLTgxLDcgKzgyLDcgQEAgY2xhc3MgSU9TU2ltdWxhdG9yUG9ydChJT1NQb3J0 KToKIAogICAgIGRlZiBfYnVpbGRfZHJpdmVyX2ZsYWdzKHNlbGYpOgogICAgICAgICBhcmNocyA9 IFsnQVJDSFM9aTM4NiddIGlmIHNlbGYuYXJjaGl0ZWN0dXJlKCkgPT0gJ3g4NicgZWxzZSBbXQot ICAgICAgICBzZGsgPSBbJy0tc2RrJywgJ2lwaG9uZXNpbXVsYXRvciddCisgICAgICAgIHNkayA9 IFsnLS1zZGsnLCBzZWxmLlNES10KICAgICAgICAgcmV0dXJuIGFyY2hzICsgc2RrCiAKICAgICBk ZWYgX3NldF9kZXZpY2VfY2xhc3Moc2VsZiwgZGV2aWNlX2NsYXNzKToK