191273 2018-11-05 11:09:32 -0800 Fix typos in closing ENABLE guards 2018-11-05 11:37:24 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 don.olmstead don.olmstead commit-queue ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1475177 0 don.olmstead 2018-11-05 11:09:32 -0800 There are just some typos in there that I found when grepping ENABLE flags. 1475183 1 353891 don.olmstead 2018-11-05 11:15:19 -0800 Created attachment 353891 Patch 1475187 2 353891 keith_miller 2018-11-05 11:17:02 -0800 Comment on attachment 353891 Patch Lol r=me. 1475188 3 keith_miller 2018-11-05 11:17:57 -0800 This is the downside of using the ENABLE macros, where it checks if the value is defined so the compiler doesn't catch these... It's probably not the end of the world though. 1475191 4 don.olmstead 2018-11-05 11:18:48 -0800 (In reply to Keith Miller from comment #3) > This is the downside of using the ENABLE macros, where it checks if the > value is defined so the compiler doesn't catch these... It's probably not > the end of the world though. These are just in the ending comments. I was grepping in there and I saw the typos. 1475204 5 353891 commit-queue 2018-11-05 11:36:02 -0800 Comment on attachment 353891 Patch Clearing flags on attachment: 353891 Committed r237823: <https://trac.webkit.org/changeset/237823> 1475205 6 commit-queue 2018-11-05 11:36:04 -0800 All reviewed patches have been landed. Closing bug. 1475207 7 webkit-bug-importer 2018-11-05 11:37:24 -0800 <rdar://problem/45814243> 353891 2018-11-05 11:15:19 -0800 2018-11-05 11:36:02 -0800 Patch bug-191273.diff text/plain 2744 don.olmstead ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGFjNDkwODVmZWExLi5lNTU5ZmJkNjUxMSAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMTEtMDUgIERvbiBP bG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBzb255LmNvbT4KKworICAgICAgICBGaXggdHlwb3MgaW4g Y2xvc2luZyBFTkFCTEUgZ3VhcmRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xOTEyNzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIGZ0bC9GVExGb3JPU1JFbnRyeUpJVENvZGUuaDoKKyAgICAgICAgKiBm dGwvRlRMSklUQ29kZS5oOgorICAgICAgICAqIGpzYy5jcHA6CisgICAgICAgICogd2FzbS9XYXNt TWVtb3J5SW5mb3JtYXRpb24uaDoKKyAgICAgICAgKiB3YXNtL1dhc21QYWdlQ291bnQuaDoKKwog MjAxOC0xMS0wNSAgRG9taW5payBJbmZ1ZWhyICA8ZGluZnVlaHJAaWdhbGlhLmNvbT4KIAogICAg ICAgICBFbmFibGUgTExJbnQgb24gQVJNdjcvTGludXgKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9mdGwvRlRMRm9yT1NSRW50cnlKSVRDb2RlLmggYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvZnRsL0ZUTEZvck9TUkVudHJ5SklUQ29kZS5oCmluZGV4IDA2ZGIzZGVkYjRmLi5hZjJj ZDExMzM5ZiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExGb3JPU1JF bnRyeUpJVENvZGUuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTEZvck9TUkVu dHJ5SklUQ29kZS5oCkBAIC02NCw0ICs2NCw0IEBAIHByaXZhdGU6CiAKIH0gfSAvLyBuYW1lc3Bh Y2UgSlNDOjpGVEwKIAotI2VuZGlmIC8vIEVOQUJMRShGTFRfSklUKQorI2VuZGlmIC8vIEVOQUJM RShGVExfSklUKQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExKSVRD b2RlLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTEpJVENvZGUuaAppbmRleCAyZjk4 NjZmMjEyZi4uOTgyODAwNTM4MzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9m dGwvRlRMSklUQ29kZS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMSklUQ29k ZS5oCkBAIC04Miw0ICs4Miw0IEBAIHByaXZhdGU6CiAKIH0gfSAvLyBuYW1lc3BhY2UgSlNDOjpG VEwKIAotI2VuZGlmIC8vIEVOQUJMRShGTFRfSklUKQorI2VuZGlmIC8vIEVOQUJMRShGVExfSklU KQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5jcHAgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvanNjLmNwcAppbmRleCA2ZDMzYzFmOTRlOS4uNTg2ODdiZGEyNTYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9qc2MuY3BwCkBAIC0yMTgyLDcgKzIxODIsNyBAQCBzdGF0aWMgRW5jb2RlZEpTVmFs dWUgSlNDX0hPU1RfQ0FMTCBmdW5jdGlvbldlYkFzc2VtYmx5TWVtb3J5TW9kZShFeGVjU3RhdGUq IGV4ZQogICAgIHJldHVybiB0aHJvd1ZNVHlwZUVycm9yKGV4ZWMsIHNjb3BlLCAiV2ViQXNzZW1i bHlNZW1vcnlNb2RlIGV4cGVjdHMgZWl0aGVyIGEgV2ViQXNzZW1ibHkuTWVtb3J5IG9yIFdlYkFz c2VtYmx5Lkluc3RhbmNlIl9zKTsKIH0KIAotI2VuZGlmIC8vIEVOQUJMRShXRUJBU1NFQkxZKQor I2VuZGlmIC8vIEVOQUJMRShXRUJBU1NFTUJMWSkKIAogLy8gVXNlIFNFSCBmb3IgUmVsZWFzZSBi dWlsZHMgb25seSB0byBnZXQgcmlkIG9mIHRoZSBjcmFzaCByZXBvcnQgZGlhbG9nCiAvLyAobHVj a2lseSB0aGUgc2FtZSB0ZXN0cyBmYWlsIGluIFJlbGVhc2UgYW5kIERlYnVnIGJ1aWxkcyBzbyBm YXIpLiBOZWVkIHRvCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNt TWVtb3J5SW5mb3JtYXRpb24uaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21NZW1v cnlJbmZvcm1hdGlvbi5oCmluZGV4IDMwOTIxZGQ2OWEzLi44Y2ViYzVmYTY2OCAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbU1lbW9yeUluZm9ybWF0aW9uLmgKKysr IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbU1lbW9yeUluZm9ybWF0aW9uLmgKQEAg LTkwLDQgKzkwLDQgQEAgcHJpdmF0ZToKIAogfSB9IC8vIG5hbWVzcGFjZSBKU0M6Oldhc20KIAot I2VuZGlmIC8vIEVOQUJMRShXQVNNKQorI2VuZGlmIC8vIEVOQUJMRShXRUJBU1NFTUJMWSkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21QYWdlQ291bnQuaCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21QYWdlQ291bnQuaAppbmRleCBlZjA1ZjMzNDI5 My4uZThkYzFhMzBhZWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dh c21QYWdlQ291bnQuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtUGFnZUNv dW50LmgKQEAgLTEwMyw0ICsxMDMsNCBAQCBwcml2YXRlOgogCiB9IH0gLy8gbmFtZXNwYWNlIEpT Qzo6V2FzbQogCi0jZW5kaWYgLy8gRU5BQkxFKFdBU00pCisjZW5kaWYgLy8gRU5BQkxFKFdFQkFT U0VNQkxZKQo=