<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>191260</bug_id>
          
          <creation_ts>2018-11-05 06:47:08 -0800</creation_ts>
          <short_desc>Setting transceiver.direction = &quot;inactive&quot; is ignored</short_desc>
          <delta_ts>2018-12-06 03:39:57 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebRTC</component>
          <version>Safari Technology Preview</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Iñaki Baz">ibc</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1475060</commentid>
    <comment_count>0</comment_count>
      <attachid>353859</attachid>
    <who name="Iñaki Baz">ibc</who>
    <bug_when>2018-11-05 06:47:08 -0800</bug_when>
    <thetext>Created attachment 353859
Script that reproduces the issue. Just run it in Safari 12.1 console with &quot;Unified-Plan&quot; enabled.

Scenario:

* Have a pc with an audio transceiver for just sending audio (it does not receive audio from the remote), so it has `direction: &quot;sendonly&quot;`.

* Call `transceiver.sender.replaceTrack(null)` and `transceiver.direction = &quot;inactive&quot;` and do a new SDP O/A.

* No matter where `transceiver.direction = &quot;inactive&quot;` is set. The `transceiver.direction` remains &quot;sendonly&quot; and its m=audio section also remains with &quot;a=sendonly&quot;.

This works as expected in Chrome and Firefox.

Script attached.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1478189</commentid>
    <comment_count>1</comment_count>
    <who name="Iñaki Baz">ibc</who>
    <bug_when>2018-11-13 16:05:58 -0800</bug_when>
    <thetext>Hi, any news about this issue?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1478222</commentid>
    <comment_count>2</comment_count>
    <who name="youenn fablet">youennf</who>
    <bug_when>2018-11-13 16:52:09 -0800</bug_when>
    <thetext>(In reply to Iñaki Baz from comment #1)
&gt; Hi, any news about this issue?

Will look at it this week.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1478225</commentid>
    <comment_count>3</comment_count>
    <who name="youenn fablet">youennf</who>
    <bug_when>2018-11-13 16:57:55 -0800</bug_when>
    <thetext>Using WebKit Tot, your test case works as expected.
Let&apos;s mark it as fixed for now.
Please reopen if next STP version is not working as expected.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1480282</commentid>
    <comment_count>4</comment_count>
    <who name="Iñaki Baz">ibc</who>
    <bug_when>2018-11-19 13:02:15 -0800</bug_when>
    <thetext>Hi, I&apos;ve tested in latest STP: Release 70 (Safari 12.1, WebKit 14607.1.13)

The attached still fails (direction remains a=sendonly instead of a=inactive).

Should I wait for next STP?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1485673</commentid>
    <comment_count>5</comment_count>
    <who name="Iñaki Baz">ibc</who>
    <bug_when>2018-12-06 03:39:57 -0800</bug_when>
    <thetext>ok, it works today in latest (Safari 12.1, WebKit 14607.1.15.

Good work :)</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>353859</attachid>
            <date>2018-11-05 06:47:08 -0800</date>
            <delta_ts>2018-11-05 06:47:08 -0800</delta_ts>
            <desc>Script that reproduces the issue. Just run it in Safari 12.1 console with &quot;Unified-Plan&quot; enabled.</desc>
            <filename>transceiver-direction-inactive-is-ignored.js</filename>
            <type>text/javascript</type>
            <size>2690</size>
            <attacher name="Iñaki Baz">ibc</attacher>
            
              <data encoding="base64">bGV0IG1pY1RyYWNrOwpsZXQgd2ViY2FtVHJhY2s7CmxldCBwYzE7CmxldCBwYzI7CmxldCBtaWNU
cmFuc2NlaXZlcjsKCm5hdmlnYXRvci5tZWRpYURldmljZXMuZ2V0VXNlck1lZGlhKHsgYXVkaW86
IHRydWUgfSkKCS50aGVuKChzdHJlYW0pID0+Cgl7CgkJbWljVHJhY2sgPSBzdHJlYW0uZ2V0QXVk
aW9UcmFja3MoKVswXTsKCX0pCgkudGhlbigoKSA9PgoJewoJCXBjMSA9IG5ldyBSVENQZWVyQ29u
bmVjdGlvbigKCQkJewoJCQkJaWNlU2VydmVycyAgICA6IFtdLAoJCQkJYnVuZGxlUG9saWN5ICA6
ICdtYXgtYnVuZGxlJywKCQkJCXJ0Y3BNdXhQb2xpY3kgOiAncmVxdWlyZScsCgkJCQlzZHBTZW1h
bnRpY3MgIDogJ3VuaWZpZWQtcGxhbicKCQkJfSk7CgoJCXBjMiA9IG5ldyBSVENQZWVyQ29ubmVj
dGlvbigKCQkJewoJCQkJaWNlU2VydmVycyAgICA6IFtdLAoJCQkJYnVuZGxlUG9saWN5ICA6ICdt
YXgtYnVuZGxlJywKCQkJCXJ0Y3BNdXhQb2xpY3kgOiAncmVxdWlyZScsCgkJCQlzZHBTZW1hbnRp
Y3MgIDogJ3VuaWZpZWQtcGxhbicKCQkJfSk7CgoJCWNvbnNvbGUud2FybigncGMxOiBhZGRpbmcg
bWljIHRyYWNrJyk7CgoJCW1pY1RyYW5zY2VpdmVyID0KCQkJcGMxLmFkZFRyYW5zY2VpdmVyKG1p
Y1RyYWNrLCB7IGRpcmVjdGlvbjogJ3NlbmRvbmx5JyB9KTsKCX0pCgkudGhlbigoKSA9PiBuZWdv
dGlhdGVTZHBzKCkpCgkudGhlbigoKSA9PgoJewoJCWNvbnNvbGUud2FybigncGMxOiByZW1vdmlu
ZyBtaWMgdHJhY2sgdXNpbmcgcmVwbGFjZVRyYWNrKG51bGwpJyk7CgoJCS8vIE5PVEU6IFRoaXMg
ZG9lcyBub3Qgd29yayBoZXJlLiBhPWRpcmVjdGlvbiByZW1haW5zICJzZW5kb25seSIgaW4KCQkv
LyB0aGUgbmV3IG9mZmVyLgoJCW1pY1RyYW5zY2VpdmVyLmRpcmVjdGlvbiA9ICdpbmFjdGl2ZSc7
CgoJCXJldHVybiBtaWNUcmFuc2NlaXZlci5zZW5kZXIucmVwbGFjZVRyYWNrKG51bGwpOwoJfSkK
CS50aGVuKCgpID0+Cgl7CgkJLy8gTk9URTogVGhpcyBkb2VzIG5vdCB3b3JrIG5laXRoZXIgaGVy
ZS4gYT1kaXJlY3Rpb24gcmVtYWlucyAic2VuZG9ubHkiIGluCgkJLy8gdGhlIG5ldyBvZmZlci4K
CQltaWNUcmFuc2NlaXZlci5kaXJlY3Rpb24gPSAnaW5hY3RpdmUnOwoJfSkKCS50aGVuKCgpID0+
IG5lZ290aWF0ZVNkcHMoKSkKCS5jYXRjaCgoZXJyb3IpID0+Cgl7CgkJY29uc29sZS5lcnJvcihl
cnJvcik7Cgl9KTsKCmZ1bmN0aW9uIG5lZ290aWF0ZVNkcHMoKQp7CglsZXQgZXJyb3JlZCA9IGZh
bHNlOwoKCXJldHVybiBQcm9taXNlLnJlc29sdmUoKQoJCS50aGVuKCgpID0+IHBjMS5jcmVhdGVP
ZmZlcigpKQoJCS5jYXRjaCgoZXJyb3IpID0+CgkJewoJCQljb25zb2xlLmVycm9yKCdwYzEuY3Jl
YXRlT2ZmZXIoKSBmYWlsZWQnKTsKCgkJCWVycm9yZWQgPSB0cnVlOwoJCQl0aHJvdyBlcnJvcjsK
CQl9KQoJCS50aGVuKChvZmZlcikgPT4KCQl7CgkJCWNvbnNvbGUud2FybigncGMxLmNyZWF0ZU9m
ZmVyKCkgc3VjY2VlZGVkOlxuJXMnLCBvZmZlci5zZHApOwoKCQkJcmV0dXJuIHBjMS5zZXRMb2Nh
bERlc2NyaXB0aW9uKG9mZmVyKTsKCQl9KQoJCS5jYXRjaCgoZXJyb3IpID0+CgkJewoJCQlpZiAo
ZXJyb3JlZCkKCQkJCXRocm93IGVycm9yOwoKCQkJY29uc29sZS5lcnJvcigncGMxLnNldExvY2Fs
RGVzY3JpcHRpb24oKSBmYWlsZWQnKTsKCgkJCWVycm9yZWQgPSB0cnVlOwoJCQl0aHJvdyBlcnJv
cjsKCQl9KQoJCS50aGVuKCgpID0+CgkJewoJCQljb25zdCBvZmZlciA9IHBjMS5sb2NhbERlc2Ny
aXB0aW9uOwoKCQkJcmV0dXJuIHBjMi5zZXRSZW1vdGVEZXNjcmlwdGlvbihvZmZlcik7CgkJfSkK
CQkuY2F0Y2goKGVycm9yKSA9PgoJCXsKCQkJaWYgKGVycm9yZWQpCgkJCQl0aHJvdyBlcnJvcjsK
CgkJCWNvbnNvbGUuZXJyb3IoJ3BjMi5zZXRSZW1vdGVEZXNjcmlwdGlvbigpIGZhaWxlZCcpOwoK
CQkJZXJyb3JlZCA9IHRydWU7CgkJCXRocm93IGVycm9yOwoJCX0pCgkJLnRoZW4oKCkgPT4gcGMy
LmNyZWF0ZUFuc3dlcigpKQoJCS5jYXRjaCgoZXJyb3IpID0+CgkJewoJCQlpZiAoZXJyb3JlZCkK
CQkJCXRocm93IGVycm9yOwoKCQkJY29uc29sZS5lcnJvcigncGMyLmNyZWF0ZUFuc3dlcigpIGZh
aWxlZCcpOwoKCQkJZXJyb3JlZCA9IHRydWU7CgkJCXRocm93IGVycm9yOwoJCX0pCgkJLnRoZW4o
KGFuc3dlcikgPT4gcGMyLnNldExvY2FsRGVzY3JpcHRpb24oYW5zd2VyKSkKCQkuY2F0Y2goKGVy
cm9yKSA9PgoJCXsKCQkJaWYgKGVycm9yZWQpCgkJCQl0aHJvdyBlcnJvcjsKCgkJCWNvbnNvbGUu
ZXJyb3IoJ3BjMi5zZXRMb2NhbERlc2NyaXB0aW9uKCkgZmFpbGVkJyk7CgoJCQllcnJvcmVkID0g
dHJ1ZTsKCQkJdGhyb3cgZXJyb3I7CgkJfSkKCQkudGhlbigoKSA9PgoJCXsKCQkJY29uc3QgYW5z
d2VyID0gcGMyLmxvY2FsRGVzY3JpcHRpb247CgoJCQlyZXR1cm4gcGMxLnNldFJlbW90ZURlc2Ny
aXB0aW9uKGFuc3dlcik7CgkJfSkKCQkudGhlbigoKSA9PgoJCXsKCQkJY29uc29sZS53YXJuKCdw
YzEuc2V0UmVtb3RlRGVzY3JpcHRpb24oKSBzdWNjZWVkZWQnKTsKCQl9KQoJCS5jYXRjaCgoZXJy
b3IpID0+CgkJewoJCQlpZiAoZXJyb3JlZCkKCQkJCXRocm93IGVycm9yOwoKCQkJY29uc29sZS5l
cnJvcigncGMyLnNldFJlbW90ZURlc2NyaXB0aW9uKCkgZmFpbGVkJyk7CgoJCQl0aHJvdyBlcnJv
cjsKCQl9KTsKfQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>