191251 2018-11-05 01:25:01 -0800 Remove some virtual methods in CachedRawResource 2018-11-05 05:56:22 -0800 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rbuis rbuis cdumez commit-queue dbates ews-watchlist fred.wang japhet webkit-bug-importer oldest_to_newest 1474988 0 rbuis 2018-11-05 01:25:01 -0800 Remove some virtual methods in CachedRawResource, as CachedRawResource is final no need to introduce new virtual methods in CachedRawResource. 1474990 1 353837 rbuis 2018-11-05 01:27:18 -0800 Created attachment 353837 Patch 1475030 2 353837 fred.wang 2018-11-05 04:50:59 -0800 Comment on attachment 353837 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353837&action=review > Source/WebCore/loader/cache/CachedRawResource.h:-40 > - // This can be fixed by splitting CORS preflighting out of DocumentThreacableLoader. What's this FIXME referring to? Is it just an obsolete comment? Can you mention in the ChangeLog why we remove this? 1475031 3 353837 fred.wang 2018-11-05 04:52:05 -0800 Comment on attachment 353837 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353837&action=review > Source/WebCore/loader/cache/CachedRawResource.h:-32 > -class SubresourceLoader; Can we also briefly mention this change in the ChangeLog too? 1475034 4 353851 rbuis 2018-11-05 04:59:32 -0800 Created attachment 353851 Patch 1475035 5 353851 rbuis 2018-11-05 05:00:22 -0800 Comment on attachment 353851 Patch Updated commit message after Fred's feedback. 1475036 6 353851 commit-queue 2018-11-05 05:02:01 -0800 Comment on attachment 353851 Patch Rejecting attachment 353851 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 353851, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/9863899 1475039 7 353852 rbuis 2018-11-05 05:15:59 -0800 Created attachment 353852 Patch 1475045 8 353852 commit-queue 2018-11-05 05:55:28 -0800 Comment on attachment 353852 Patch Clearing flags on attachment: 353852 Committed r237797: <https://trac.webkit.org/changeset/237797> 1475046 9 commit-queue 2018-11-05 05:55:30 -0800 All reviewed patches have been landed. Closing bug. 1475047 10 webkit-bug-importer 2018-11-05 05:56:22 -0800 <rdar://problem/45805544> 353837 2018-11-05 01:27:18 -0800 2018-11-05 04:59:28 -0800 Patch bug-191251-20181105102716.patch text/plain 2032 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NzkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTgwYTVmMjFlYzZkNGFm NzZjYWU1MzJkZmFhMzJlNTQyNzYxMTdmMy4uMThkMjJjODgzZjg5OTU5MjA4ZWM2M2E2NGIyYmUz NDdkNjg3MjliZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTExLTA1ICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHNvbWUgdmlydHVhbCBt ZXRob2RzIGluIENhY2hlZFJhd1Jlc291cmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTEyNTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBTaW5jZSBDYWNoZWRSYXdSZXNvdXJjZSBpcyBmaW5hbCBubyBu ZWVkIHRvIGludHJvZHVjZSBuZXcgdmlydHVhbCBtZXRob2RzIGluIENhY2hlZFJhd1Jlc291cmNl LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBzaW5jZSBubyBjaGFuZ2UgaW4gZnVuY3Rpb25hbGl0 eS4KKworICAgICAgICAqIGxvYWRlci9jYWNoZS9DYWNoZWRSYXdSZXNvdXJjZS5oOgorCiAyMDE4 LTExLTA0ICBSb2IgQnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CiAKICAgICAgICAgUmVtb3ZlIEVO QUJMRV9PUEVOQ0wgZnVsbHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNo ZS9DYWNoZWRSYXdSZXNvdXJjZS5oIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hl ZFJhd1Jlc291cmNlLmgKaW5kZXggMmQzZGFjOTk2NDMyMjI4Zjk0OGZjYjZmZDRmNjZkNzA2NTQ3 Y2UxZi4uY2YyOWMzMGYyYTkwY2JiYjUyODFiNGFjOTE2N2ViZjU5YzM0YTFjZiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJhd1Jlc291cmNlLmgKKysrIGIv U291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJhd1Jlc291cmNlLmgKQEAgLTI5LDE4 ICsyOSwxNCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiBjbGFzcyBDYWNoZWRSZXNvdXJjZUNsaWVu dDsKIGNsYXNzIFJlc291cmNlVGltaW5nOwogY2xhc3MgU2hhcmVkQnVmZmVyRGF0YVZpZXc7Ci1j bGFzcyBTdWJyZXNvdXJjZUxvYWRlcjsKIAogY2xhc3MgQ2FjaGVkUmF3UmVzb3VyY2UgZmluYWwg OiBwdWJsaWMgQ2FjaGVkUmVzb3VyY2UgewogcHVibGljOgogICAgIENhY2hlZFJhd1Jlc291cmNl KENhY2hlZFJlc291cmNlUmVxdWVzdCYmLCBUeXBlLCBQQUw6OlNlc3Npb25JRCk7CiAKLSAgICAv LyBGSVhNRTogQXNzb2NpYXRlZFVSTExvYWRlciBzaG91bGRuJ3QgYmUgYSBEb2N1bWVudFRocmVh ZGFibGVMb2FkZXIgYW5kIHRoZXJlZm9yZSBzaG91bGRuJ3QKLSAgICAvLyB1c2UgQ2FjaGVkUmF3 UmVzb3VyY2UuIEhvd2V2ZXIsIGl0IGlzLCBhbmQgaXQgbmVlZHMgdG8gYmUgYWJsZSB0byBkZWZl ciBsb2FkaW5nLgotICAgIC8vIFRoaXMgY2FuIGJlIGZpeGVkIGJ5IHNwbGl0dGluZyBDT1JTIHBy ZWZsaWdodGluZyBvdXQgb2YgRG9jdW1lbnRUaHJlYWNhYmxlTG9hZGVyLgotICAgIHZpcnR1YWwg dm9pZCBzZXREZWZlcnNMb2FkaW5nKGJvb2wpOworICAgIHZvaWQgc2V0RGVmZXJzTG9hZGluZyhi b29sKTsKIAotICAgIHZpcnR1YWwgdm9pZCBzZXREYXRhQnVmZmVyaW5nUG9saWN5KERhdGFCdWZm ZXJpbmdQb2xpY3kpOworICAgIHZvaWQgc2V0RGF0YUJ1ZmZlcmluZ1BvbGljeShEYXRhQnVmZmVy aW5nUG9saWN5KTsKIAogICAgIC8vIEZJWE1FOiBUaGlzIGlzIGV4cG9zZWQgZm9yIHRoZSBJbnNw ZWN0b3JJbnN0cnVtZW50YXRpb24gZm9yIHByZWZsaWdodHMgaW4gRG9jdW1lbnRUaHJlYWRhYmxl TG9hZGVyLiBJdCdzIGFsc28gcmVhbGx5IGxhbWUuCiAgICAgdW5zaWduZWQgbG9uZyBpZGVudGlm aWVyKCkgY29uc3QgeyByZXR1cm4gbV9pZGVudGlmaWVyOyB9Cg== 353851 2018-11-05 04:59:32 -0800 2018-11-05 05:15:54 -0800 Patch bug-191251-20181105135931.patch text/plain 2119 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NzkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTgwYTVmMjFlYzZkNGFm NzZjYWU1MzJkZmFhMzJlNTQyNzYxMTdmMy4uZTZkOTFiOTg5OWU4N2FlMzdhZWY1YzUzNzBlYjBi ZGFkMzg4YWYxOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTExLTA1ICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHNvbWUgdmlydHVhbCBt ZXRob2RzIGluIENhY2hlZFJhd1Jlc291cmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTEyNTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBTaW5jZSBDYWNoZWRSYXdSZXNvdXJjZSBpcyBmaW5hbCBubyBu ZWVkIHRvIGludHJvZHVjZSBuZXcgdmlydHVhbAorICAgICAgICBtZXRob2RzIGluIENhY2hlZFJh d1Jlc291cmNlLiBUaGlzIHBhdGNoIGFsc28gcmVtb3ZlcyBhbiBvdXRkYXRlZAorICAgICAgICBj b21tZW50IGFuZCBmb3J3YXJkIGRlY2xhcmF0aW9uLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBz aW5jZSBubyBjaGFuZ2UgaW4gZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIGxvYWRlci9jYWNo ZS9DYWNoZWRSYXdSZXNvdXJjZS5oOgorCiAyMDE4LTExLTA0ICBSb2IgQnVpcyAgPHJidWlzQGln YWxpYS5jb20+CiAKICAgICAgICAgUmVtb3ZlIEVOQUJMRV9PUEVOQ0wgZnVsbHkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSYXdSZXNvdXJjZS5oIGIvU291 cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJhd1Jlc291cmNlLmgKaW5kZXggMmQzZGFj OTk2NDMyMjI4Zjk0OGZjYjZmZDRmNjZkNzA2NTQ3Y2UxZi4uY2YyOWMzMGYyYTkwY2JiYjUyODFi NGFjOTE2N2ViZjU5YzM0YTFjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL2Nh Y2hlL0NhY2hlZFJhd1Jlc291cmNlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hl L0NhY2hlZFJhd1Jlc291cmNlLmgKQEAgLTI5LDE4ICsyOSwxNCBAQCBuYW1lc3BhY2UgV2ViQ29y ZSB7CiBjbGFzcyBDYWNoZWRSZXNvdXJjZUNsaWVudDsKIGNsYXNzIFJlc291cmNlVGltaW5nOwog Y2xhc3MgU2hhcmVkQnVmZmVyRGF0YVZpZXc7Ci1jbGFzcyBTdWJyZXNvdXJjZUxvYWRlcjsKIAog Y2xhc3MgQ2FjaGVkUmF3UmVzb3VyY2UgZmluYWwgOiBwdWJsaWMgQ2FjaGVkUmVzb3VyY2Ugewog cHVibGljOgogICAgIENhY2hlZFJhd1Jlc291cmNlKENhY2hlZFJlc291cmNlUmVxdWVzdCYmLCBU eXBlLCBQQUw6OlNlc3Npb25JRCk7CiAKLSAgICAvLyBGSVhNRTogQXNzb2NpYXRlZFVSTExvYWRl ciBzaG91bGRuJ3QgYmUgYSBEb2N1bWVudFRocmVhZGFibGVMb2FkZXIgYW5kIHRoZXJlZm9yZSBz aG91bGRuJ3QKLSAgICAvLyB1c2UgQ2FjaGVkUmF3UmVzb3VyY2UuIEhvd2V2ZXIsIGl0IGlzLCBh bmQgaXQgbmVlZHMgdG8gYmUgYWJsZSB0byBkZWZlciBsb2FkaW5nLgotICAgIC8vIFRoaXMgY2Fu IGJlIGZpeGVkIGJ5IHNwbGl0dGluZyBDT1JTIHByZWZsaWdodGluZyBvdXQgb2YgRG9jdW1lbnRU aHJlYWNhYmxlTG9hZGVyLgotICAgIHZpcnR1YWwgdm9pZCBzZXREZWZlcnNMb2FkaW5nKGJvb2wp OworICAgIHZvaWQgc2V0RGVmZXJzTG9hZGluZyhib29sKTsKIAotICAgIHZpcnR1YWwgdm9pZCBz ZXREYXRhQnVmZmVyaW5nUG9saWN5KERhdGFCdWZmZXJpbmdQb2xpY3kpOworICAgIHZvaWQgc2V0 RGF0YUJ1ZmZlcmluZ1BvbGljeShEYXRhQnVmZmVyaW5nUG9saWN5KTsKIAogICAgIC8vIEZJWE1F OiBUaGlzIGlzIGV4cG9zZWQgZm9yIHRoZSBJbnNwZWN0b3JJbnN0cnVtZW50YXRpb24gZm9yIHBy ZWZsaWdodHMgaW4gRG9jdW1lbnRUaHJlYWRhYmxlTG9hZGVyLiBJdCdzIGFsc28gcmVhbGx5IGxh bWUuCiAgICAgdW5zaWduZWQgbG9uZyBpZGVudGlmaWVyKCkgY29uc3QgeyByZXR1cm4gbV9pZGVu dGlmaWVyOyB9Cg== 353852 2018-11-05 05:15:59 -0800 2018-11-05 05:55:28 -0800 Patch bug-191251-20181105141559.patch text/plain 2120 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NzkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTgwYTVmMjFlYzZkNGFm NzZjYWU1MzJkZmFhMzJlNTQyNzYxMTdmMy4uZmQxZWMyNjg5YzVhMWE5YzZlOTI2MDk1ZTExY2Q2 ODliYzQwNzkzMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTExLTA1ICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHNvbWUgdmlydHVhbCBt ZXRob2RzIGluIENhY2hlZFJhd1Jlc291cmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTEyNTEKKworICAgICAgICBSZXZpZXdlZCBieSBGcsOpZMOp cmljIFdhbmcuCisKKyAgICAgICAgU2luY2UgQ2FjaGVkUmF3UmVzb3VyY2UgaXMgZmluYWwgbm8g bmVlZCB0byBpbnRyb2R1Y2UgbmV3IHZpcnR1YWwKKyAgICAgICAgbWV0aG9kcyBpbiBDYWNoZWRS YXdSZXNvdXJjZS4gVGhpcyBwYXRjaCBhbHNvIHJlbW92ZXMgYW4gb3V0ZGF0ZWQKKyAgICAgICAg Y29tbWVudCBhbmQgZm9yd2FyZCBkZWNsYXJhdGlvbi4KKworICAgICAgICBObyBuZXcgdGVzdHMg c2luY2Ugbm8gY2hhbmdlIGluIGZ1bmN0aW9uYWxpdHkuCisKKyAgICAgICAgKiBsb2FkZXIvY2Fj aGUvQ2FjaGVkUmF3UmVzb3VyY2UuaDoKKwogMjAxOC0xMS0wNCAgUm9iIEJ1aXMgIDxyYnVpc0Bp Z2FsaWEuY29tPgogCiAgICAgICAgIFJlbW92ZSBFTkFCTEVfT1BFTkNMIGZ1bGx5CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmF3UmVzb3VyY2UuaCBiL1Nv dXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSYXdSZXNvdXJjZS5oCmluZGV4IDJkM2Rh Yzk5NjQzMjIyOGY5NDhmY2I2ZmQ0ZjY2ZDcwNjU0N2NlMWYuLmNmMjljMzBmMmE5MGNiYmI1Mjgx YjRhYzkxNjdlYmY1OWMzNGExY2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9j YWNoZS9DYWNoZWRSYXdSZXNvdXJjZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNo ZS9DYWNoZWRSYXdSZXNvdXJjZS5oCkBAIC0yOSwxOCArMjksMTQgQEAgbmFtZXNwYWNlIFdlYkNv cmUgewogY2xhc3MgQ2FjaGVkUmVzb3VyY2VDbGllbnQ7CiBjbGFzcyBSZXNvdXJjZVRpbWluZzsK IGNsYXNzIFNoYXJlZEJ1ZmZlckRhdGFWaWV3OwotY2xhc3MgU3VicmVzb3VyY2VMb2FkZXI7CiAK IGNsYXNzIENhY2hlZFJhd1Jlc291cmNlIGZpbmFsIDogcHVibGljIENhY2hlZFJlc291cmNlIHsK IHB1YmxpYzoKICAgICBDYWNoZWRSYXdSZXNvdXJjZShDYWNoZWRSZXNvdXJjZVJlcXVlc3QmJiwg VHlwZSwgUEFMOjpTZXNzaW9uSUQpOwogCi0gICAgLy8gRklYTUU6IEFzc29jaWF0ZWRVUkxMb2Fk ZXIgc2hvdWxkbid0IGJlIGEgRG9jdW1lbnRUaHJlYWRhYmxlTG9hZGVyIGFuZCB0aGVyZWZvcmUg c2hvdWxkbid0Ci0gICAgLy8gdXNlIENhY2hlZFJhd1Jlc291cmNlLiBIb3dldmVyLCBpdCBpcywg YW5kIGl0IG5lZWRzIHRvIGJlIGFibGUgdG8gZGVmZXIgbG9hZGluZy4KLSAgICAvLyBUaGlzIGNh biBiZSBmaXhlZCBieSBzcGxpdHRpbmcgQ09SUyBwcmVmbGlnaHRpbmcgb3V0IG9mIERvY3VtZW50 VGhyZWFjYWJsZUxvYWRlci4KLSAgICB2aXJ0dWFsIHZvaWQgc2V0RGVmZXJzTG9hZGluZyhib29s KTsKKyAgICB2b2lkIHNldERlZmVyc0xvYWRpbmcoYm9vbCk7CiAKLSAgICB2aXJ0dWFsIHZvaWQg c2V0RGF0YUJ1ZmZlcmluZ1BvbGljeShEYXRhQnVmZmVyaW5nUG9saWN5KTsKKyAgICB2b2lkIHNl dERhdGFCdWZmZXJpbmdQb2xpY3koRGF0YUJ1ZmZlcmluZ1BvbGljeSk7CiAKICAgICAvLyBGSVhN RTogVGhpcyBpcyBleHBvc2VkIGZvciB0aGUgSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uIGZvciBw cmVmbGlnaHRzIGluIERvY3VtZW50VGhyZWFkYWJsZUxvYWRlci4gSXQncyBhbHNvIHJlYWxseSBs YW1lLgogICAgIHVuc2lnbmVkIGxvbmcgaWRlbnRpZmllcigpIGNvbnN0IHsgcmV0dXJuIG1faWRl bnRpZmllcjsgfQo=