191233 2018-11-04 06:48:37 -0800 [GTK] Cannot make debug builds of JSC using release 2.22.3 2018-11-04 07:08:19 -0800 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez webkit-bug-importer oldest_to_newest 1474871 0 aperez 2018-11-04 06:48:37 -0800 Using -DCMAKE_BUILD_TYPE=Debug results the following build error: ../Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:2923:48: error: no member named 'StructureForInContextType' in JSC::ForInContext' ASSERT(context.type() == ForInContext::StructureForInContextType); ~~~~~~~~~~~~~~^ DerivedSources/ForwardingHeaders/wtf/Assertions.h:318:11: note: expanded from macro 'ASSERT' if (!(assertion)) { \ ^~~~~~~~~ 1 error generated. 1474872 1 aperez 2018-11-04 06:51:17 -0800 Upstream does not have the assertion, and the explicit cast should have been changed to “context.asStructureForInContext()” after r237502 in the stable release branch. I am making a patch for this. 1474873 2 353803 aperez 2018-11-04 07:04:41 -0800 Created attachment 353803 Patch 1474874 3 aperez 2018-11-04 07:07:06 -0800 (In reply to Adrian Perez from comment #2) > Created attachment 353803 [details] > Patch Manually landed as r237780 in the webkit-2.22 branch: https://trac.webkit.org/changeset/237780/webkit/releases/WebKitGTK/webkit-2.22 1474875 4 webkit-bug-importer 2018-11-04 07:08:19 -0800 <rdar://problem/45791531> 353803 2018-11-04 07:04:41 -0800 2018-11-04 07:04:41 -0800 Patch bug-191233-20181104170440.patch text/plain 1818 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NjkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 MWQzODQ0NGM5YjA0NGU3MmE5YzUxYmIxZjVkYTY3OWVjYzllNzZkLi44MWJmZDU4ODVkOTUyNWI4 NGQwYWUyZWI3ZjU5Yzc1MGUzMTk3OTZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOC0xMS0wNCAgQWRyaWFuIFBlcmV6IGRlIENhc3RybyAgPGFwZXJlekBp Z2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIENhbm5vdCBtYWtlIGRlYnVnIGJ1aWxkcyBvZiBK U0MgdXNpbmcgcmVsZWFzZSAyLjIyLjMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5MTIzMworCisgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4Lgor CisgICAgICAgICogYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmNwcDoKKyAgICAgICAg KEpTQzo6Qnl0ZWNvZGVHZW5lcmF0b3I6OmVtaXRHZXRCeVZhbCk6CisgICAgICAgIFVzZSBjb250 ZXh0LmFzU3RydWN0dXJlRm9ySW5Db250ZXh0KCkgaW5zdGVhZCBvZiBleHBsaWNpdCBjYXN0IGFu ZAorICAgICAgICByZW1vdmUgdGhlIHVubmVlZGVkIGFzc2VydGlvbiwgd2hpY2ggaXMgYWxyZWFk eSBkb25lIGluIHRoZSBoZWxwZXIKKyAgICAgICAgZnVuY3Rpb24uCisKIDIwMTgtMTAtMjYgIE1h cmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBtaXNzaW5nIGVkZ2Ug Y2FzZXMgd2l0aCBKU0dsb2JhbE9iamVjdHMgaGF2aW5nIGEgYmFkIHRpbWUuCmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmNw cCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3Iu Y3BwCmluZGV4IDU5ZTMyNGQ2NmFhNWU1YWZlODVkNjJjZWEyY2UxNTRkMzhjMzhiYzIuLjRiODhh MWIyYWJhNzM4YjY0YzcwZGZmOGY0MGVmMmQxMGNiMTEyOTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3BwCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3BwCkBA IC0yOTIwLDggKzI5MjAsNyBAQCBSZWdpc3RlcklEKiBCeXRlY29kZUdlbmVyYXRvcjo6ZW1pdEdl dEJ5VmFsKFJlZ2lzdGVySUQqIGRzdCwgUmVnaXN0ZXJJRCogYmFzZSwgUgogICAgICAgICAgICAg YnJlYWs7CiAgICAgICAgIH0KIAotICAgICAgICBBU1NFUlQoY29udGV4dC50eXBlKCkgPT0gRm9y SW5Db250ZXh0OjpTdHJ1Y3R1cmVGb3JJbkNvbnRleHRUeXBlKTsKLSAgICAgICAgU3RydWN0dXJl Rm9ySW5Db250ZXh0JiBzdHJ1Y3R1cmVDb250ZXh0ID0gc3RhdGljX2Nhc3Q8U3RydWN0dXJlRm9y SW5Db250ZXh0Jj4oY29udGV4dCk7CisgICAgICAgIFN0cnVjdHVyZUZvckluQ29udGV4dCYgc3Ry dWN0dXJlQ29udGV4dCA9IGNvbnRleHQuYXNTdHJ1Y3R1cmVGb3JJbkNvbnRleHQoKTsKICAgICAg ICAgVW5saW5rZWRWYWx1ZVByb2ZpbGUgcHJvZmlsZSA9IGVtaXRQcm9maWxlZE9wY29kZShvcF9n ZXRfZGlyZWN0X3BuYW1lKTsKICAgICAgICAgaW5zdHJ1Y3Rpb25zKCkuYXBwZW5kKGtpbGwoZHN0 KSk7CiAgICAgICAgIGluc3RydWN0aW9ucygpLmFwcGVuZChiYXNlLT5pbmRleCgpKTsK