191225 2018-11-02 21:41:19 -0700 REGRESSION(r237031): [GTK] Test /webkit/WebKitWebView/settings is failing 2018-11-05 02:46:47 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro alex bugs-noreply commit-queue mcatanzaro oldest_to_newest 1474732 0 mcatanzaro 2018-11-02 21:41:19 -0700 r237031 introduced a memory leak breaking /webkit/WebKitWebView/settings: /webkit/WebKitWebView/settings: Leaked objects: WebKitSettings(0x55c6218f3160) FAIL ERROR:/home/slave/webkitgtk/gtk-linux-64-release/build/Tools/TestWebKitAPI/glib/WebKitGLib/TestMain.h:133:Test::~Test(): assertion failed: (m_watchedObjects.isEmpty()) 1474734 1 353762 mcatanzaro 2018-11-02 22:07:52 -0700 Created attachment 353762 Patch 1475010 2 353762 commit-queue 2018-11-05 02:46:45 -0800 Comment on attachment 353762 Patch Clearing flags on attachment: 353762 Committed r237795: <https://trac.webkit.org/changeset/237795> 1475011 3 commit-queue 2018-11-05 02:46:47 -0800 All reviewed patches have been landed. Closing bug. 353762 2018-11-02 22:07:52 -0700 2018-11-05 02:46:45 -0800 Patch bug-191225-20181103000751.patch text/plain 1819 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NzYxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzU1ZWE4NGM2ZDFkY2JkMDFiNjQ3ZWMwOTEzMGQ0ODIx Mzc1NGJjYi4uMzFjYTVhZmFkZjRmNTg0YWI0ZmU3NjFmYWYwZmFhMjZlNGRlMGIzOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE4LTExLTAyICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNv bT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyMzcwMzEpOiBbR1RLXSBUZXN0IC93ZWJraXQvV2Vi S2l0V2ViVmlldy9zZXR0aW5ncyBpcyBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTEyMjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBGaXggYSBtZW1vcnkgbGVhayBjYXVzaW5nIHRoaXMgdGVz dCB0byBmYWlsLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9nbGliL1dlYktpdEdMaWIvV2Vi Vmlld1Rlc3QuY3BwOgorICAgICAgICAoV2ViVmlld1Rlc3Q6OmluaXRpYWxpemVXZWJWaWV3KToK KwogMjAxOC0xMS0wMiAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3Jn PgogCiAgICAgICAgIE1hYyBwcm9kdWN0aW9uIGJ1aWxkcyBzaG91bGQgc2lnbiB0aGUgbmV0d29y ayBwcm9jZXNzIHhwYyBzZXJ2aWNlIHdpdGggZW50aXRsZW1lbnRzCmRpZmYgLS1naXQgYS9Ub29s cy9UZXN0V2ViS2l0QVBJL2dsaWIvV2ViS2l0R0xpYi9XZWJWaWV3VGVzdC5jcHAgYi9Ub29scy9U ZXN0V2ViS2l0QVBJL2dsaWIvV2ViS2l0R0xpYi9XZWJWaWV3VGVzdC5jcHAKaW5kZXggN2UzNTQw Yjc4MWMyOWFkYmJhMzU3YmRmYmFiOGU2NzQ2ZGNhYWY3Yi4uOTk5NDJjMWY0ZDkzNmUxMWRiMmU5 NzJlY2I3YmZkYTBiMjE4NDE3NCAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9nbGli L1dlYktpdEdMaWIvV2ViVmlld1Rlc3QuY3BwCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvZ2xp Yi9XZWJLaXRHTGliL1dlYlZpZXdUZXN0LmNwcApAQCAtNDksMTQgKzQ5LDE0IEBAIHZvaWQgV2Vi Vmlld1Rlc3Q6OmluaXRpYWxpemVXZWJWaWV3KCkKIHsKICAgICBnX2Fzc2VydCghbV93ZWJWaWV3 KTsKIAotICAgIFdlYktpdFNldHRpbmdzKiB3ZWJraXRTZXR0aW5ncyA9IHdlYmtpdF9zZXR0aW5n c19uZXcoKTsKLSAgICB3ZWJraXRfc2V0dGluZ3Nfc2V0X2VuYWJsZV9tZWRpYV9zdHJlYW0od2Vi a2l0U2V0dGluZ3MsIFRSVUUpOworICAgIEdSZWZQdHI8V2ViS2l0U2V0dGluZ3M+IHNldHRpbmdz ID0gYWRvcHRHUmVmKHdlYmtpdF9zZXR0aW5nc19uZXcoKSk7CisgICAgd2Via2l0X3NldHRpbmdz X3NldF9lbmFibGVfbWVkaWFfc3RyZWFtKHNldHRpbmdzLmdldCgpLCBUUlVFKTsKIAogICAgIG1f d2ViVmlldyA9IFdFQktJVF9XRUJfVklFVyhnX29iamVjdF9uZXcoV0VCS0lUX1RZUEVfV0VCX1ZJ RVcsCiAjaWYgUExBVEZPUk0oV1BFKQogICAgICAgICAiYmFja2VuZCIsIFRlc3Q6OmNyZWF0ZVdl YlZpZXdCYWNrZW5kKCksCiAjZW5kaWYKLSAgICAgICAgInNldHRpbmdzIiwgd2Via2l0U2V0dGlu Z3MsCisgICAgICAgICJzZXR0aW5ncyIsIHNldHRpbmdzLmdldCgpLAogICAgICAgICAid2ViLWNv bnRleHQiLCBtX3dlYkNvbnRleHQuZ2V0KCksCiAgICAgICAgICJ1c2VyLWNvbnRlbnQtbWFuYWdl ciIsIG1fdXNlckNvbnRlbnRNYW5hZ2VyLmdldCgpLAogICAgICAgICBudWxscHRyKSk7Cg==